From nobody Sat Apr 27 06:08:58 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1511198346388862.433465112327; Mon, 20 Nov 2017 09:19:06 -0800 (PST) Received: from localhost ([::1]:58504 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eGpij-0000Ie-M3 for importer@patchew.org; Mon, 20 Nov 2017 12:18:57 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59977) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eGphR-00089U-2P for qemu-devel@nongnu.org; Mon, 20 Nov 2017 12:17:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eGphN-0005Nz-RH for qemu-devel@nongnu.org; Mon, 20 Nov 2017 12:17:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46968) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eGphN-0005NP-Kp for qemu-devel@nongnu.org; Mon, 20 Nov 2017 12:17:33 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CBE447EA85; Mon, 20 Nov 2017 17:17:32 +0000 (UTC) Received: from t460.redhat.com (unknown [10.33.36.46]) by smtp.corp.redhat.com (Postfix) with ESMTP id D4DC55FFF1; Mon, 20 Nov 2017 17:17:31 +0000 (UTC) From: "Daniel P. Berrange" To: qemu-devel@nongnu.org Date: Mon, 20 Nov 2017 17:17:28 +0000 Message-Id: <20171120171728.31266-1-berrange@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Mon, 20 Nov 2017 17:17:32 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] build: disarm the TCG unit test trap X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Developers sometimes mistakenly run 'make test' instead of 'make check'. 'make test' triggers the ancient, unmaintained tcg unit tests in tests/tcg/Makefile which have long since ceased compiling. Even if someone fixes the TCG tests, it makes little sense to put them in a 'make test' target, rather they should be 'make check-tcg', possibly wired up as a dependency of 'make check'. In the meantime, this patch disarms the 'make test' trap by turning it into a synonym for 'make check'. Signed-off-by: Daniel P. Berrange --- tests/Makefile.include | 1 + tests/tcg/Makefile | 3 --- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 434a2ce868..55fd99f451 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -919,6 +919,7 @@ check-unit: $(patsubst %,check-%, $(check-unit-y)) check-speed: $(patsubst %,check-%, $(check-speed-y)) check-block: $(patsubst %,check-%, $(check-block-y)) check: check-qapi-schema check-unit check-qtest +test: check check-clean: $(MAKE) -C tests/tcg clean rm -rf $(check-unit-y) tests/*.o $(QEMU_IOTESTS_HELPERS-y) diff --git a/tests/tcg/Makefile b/tests/tcg/Makefile index 89e3342f3d..4b5d196326 100644 --- a/tests/tcg/Makefile +++ b/tests/tcg/Makefile @@ -36,9 +36,6 @@ ifneq ($(call find-in-path, $(CC_I386)),) TESTS +=3D $(I386_TESTS) endif =20 -all: $(patsubst %,run-%,$(TESTS)) -test: all - # rules to run tests =20 .PHONY: $(patsubst %,run-%,$(TESTS)) --=20 2.14.3