1. Patchew
  2. QEMU
  3. View series

[Qemu-devel] [PATCH v1 for-2.11 0/3] s390x: fixes for SIGP and DIAG 308

David Hildenbrand posted 3 patches 6 years, 5 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20171116170526.12643-1-david@redhat.com
Test checkpatch passed
Test docker passed
Test ppc passed
Test s390x passed
target/s390x/diag.c        | 4 ----
target/s390x/helper.c      | 2 +-
target/s390x/misc_helper.c | 2 ++
3 files changed, 3 insertions(+), 5 deletions(-)
[Qemu-devel] [PATCH v1 for-2.11 0/3] s390x: fixes for SIGP and DIAG 308
Posted by David Hildenbrand 6 years, 5 months ago 
First one also applies to KVM SIGP handling. The other two only
apply to TCG (allowing to IPL from disk with more than 1 VCPU- I
never tested that before).

David Hildenbrand (3):
  s390x: fix storing CPU status (again)
  s390x/tcg: fix DIAG 308 with > 1 VCPU (single threaded TCG)
  s390x/tcg: fix DIAG 308 with > 1 VCPU (MTTCG)

 target/s390x/diag.c        | 4 ----
 target/s390x/helper.c      | 2 +-
 target/s390x/misc_helper.c | 2 ++
 3 files changed, 3 insertions(+), 5 deletions(-)

-- 
2.13.6
Re: [Qemu-devel] [PATCH v1 for-2.11 0/3] s390x: fixes for SIGP and DIAG 308
Posted by Cornelia Huck 6 years, 5 months ago 
On Thu, 16 Nov 2017 18:05:23 +0100
David Hildenbrand <david@redhat.com> wrote:

> First one also applies to KVM SIGP handling. The other two only
> apply to TCG (allowing to IPL from disk with more than 1 VCPU- I
> never tested that before).
> 
> David Hildenbrand (3):
>   s390x: fix storing CPU status (again)
>   s390x/tcg: fix DIAG 308 with > 1 VCPU (single threaded TCG)
>   s390x/tcg: fix DIAG 308 with > 1 VCPU (MTTCG)
> 
>  target/s390x/diag.c        | 4 ----
>  target/s390x/helper.c      | 2 +-
>  target/s390x/misc_helper.c | 2 ++
>  3 files changed, 3 insertions(+), 5 deletions(-)
> 

Thanks, queued to s390-fixes.
Re: [Qemu-devel] [PATCH v1 for-2.11 0/3] s390x: fixes for SIGP and DIAG 308
Posted by David Hildenbrand 6 years, 5 months ago 
On 16.11.2017 18:23, Cornelia Huck wrote:
> On Thu, 16 Nov 2017 18:05:23 +0100
> David Hildenbrand <david@redhat.com> wrote:
> 
>> First one also applies to KVM SIGP handling. The other two only
>> apply to TCG (allowing to IPL from disk with more than 1 VCPU- I
>> never tested that before).
>>
>> David Hildenbrand (3):
>>   s390x: fix storing CPU status (again)
>>   s390x/tcg: fix DIAG 308 with > 1 VCPU (single threaded TCG)
>>   s390x/tcg: fix DIAG 308 with > 1 VCPU (MTTCG)
>>
>>  target/s390x/diag.c        | 4 ----
>>  target/s390x/helper.c      | 2 +-
>>  target/s390x/misc_helper.c | 2 ++
>>  3 files changed, 3 insertions(+), 5 deletions(-)
>>
> 
> Thanks, queued to s390-fixes.
> 

Think the second one needs a change, not sure if a CPU can directly run
after the synchronization and before the reset. Will send a comment.

-- 

Thanks,

David / dhildenb
Re: [Qemu-devel] [PATCH v1 for-2.11 0/3] s390x: fixes for SIGP and DIAG 308
Posted by Christian Borntraeger 6 years, 5 months ago 

On 11/16/2017 06:23 PM, Cornelia Huck wrote:
> On Thu, 16 Nov 2017 18:05:23 +0100
> David Hildenbrand <david@redhat.com> wrote:
> 
>> First one also applies to KVM SIGP handling. The other two only
>> apply to TCG (allowing to IPL from disk with more than 1 VCPU- I
>> never tested that before).
>>
>> David Hildenbrand (3):
>>   s390x: fix storing CPU status (again)
>>   s390x/tcg: fix DIAG 308 with > 1 VCPU (single threaded TCG)
>>   s390x/tcg: fix DIAG 308 with > 1 VCPU (MTTCG)
>>
>>  target/s390x/diag.c        | 4 ----
>>  target/s390x/helper.c      | 2 +-
>>  target/s390x/misc_helper.c | 2 ++
>>  3 files changed, 3 insertions(+), 5 deletions(-)
>>
> 
> Thanks, queued to s390-fixes.

Can you please give a chance to review this?
18 minutes is not ok, especially in hard freeze.
Re: [Qemu-devel] [PATCH v1 for-2.11 0/3] s390x: fixes for SIGP and DIAG 308
Posted by Cornelia Huck 6 years, 5 months ago 
On Thu, 16 Nov 2017 21:55:02 +0100
Christian Borntraeger <borntraeger@de.ibm.com> wrote:

> On 11/16/2017 06:23 PM, Cornelia Huck wrote:
> > On Thu, 16 Nov 2017 18:05:23 +0100
> > David Hildenbrand <david@redhat.com> wrote:
> >   
> >> First one also applies to KVM SIGP handling. The other two only
> >> apply to TCG (allowing to IPL from disk with more than 1 VCPU- I
> >> never tested that before).
> >>
> >> David Hildenbrand (3):
> >>   s390x: fix storing CPU status (again)
> >>   s390x/tcg: fix DIAG 308 with > 1 VCPU (single threaded TCG)
> >>   s390x/tcg: fix DIAG 308 with > 1 VCPU (MTTCG)
> >>
> >>  target/s390x/diag.c        | 4 ----
> >>  target/s390x/helper.c      | 2 +-
> >>  target/s390x/misc_helper.c | 2 ++
> >>  3 files changed, 3 insertions(+), 5 deletions(-)
> >>  
> > 
> > Thanks, queued to s390-fixes.  
> 
> Can you please give a chance to review this?
> 18 minutes is not ok, especially in hard freeze.
> 

Just queued, not sent. I'm still rebasing.
Re: [Qemu-devel] [PATCH v1 for-2.11 0/3] s390x: fixes for SIGP and DIAG 308
Posted by Cornelia Huck 6 years, 5 months ago 
On Thu, 16 Nov 2017 18:23:35 +0100
Cornelia Huck <cohuck@redhat.com> wrote:

> On Thu, 16 Nov 2017 18:05:23 +0100
> David Hildenbrand <david@redhat.com> wrote:
> 
> > First one also applies to KVM SIGP handling. The other two only
> > apply to TCG (allowing to IPL from disk with more than 1 VCPU- I
> > never tested that before).
> > 
> > David Hildenbrand (3):
> >   s390x: fix storing CPU status (again)
> >   s390x/tcg: fix DIAG 308 with > 1 VCPU (single threaded TCG)
> >   s390x/tcg: fix DIAG 308 with > 1 VCPU (MTTCG)
> > 
> >  target/s390x/diag.c        | 4 ----
> >  target/s390x/helper.c      | 2 +-
> >  target/s390x/misc_helper.c | 2 ++
> >  3 files changed, 3 insertions(+), 5 deletions(-)
> >   
> 
> Thanks, queued to s390-fixes.

Patch 2 still needs discussion, I think. I'll dequeue it again and
leave 1 + 3.

Comments?
Re: [Qemu-devel] [PATCH v1 for-2.11 0/3] s390x: fixes for SIGP and DIAG 308
Posted by Christian Borntraeger 6 years, 5 months ago 

On 11/17/2017 09:10 AM, Cornelia Huck wrote:
> On Thu, 16 Nov 2017 18:23:35 +0100
> Cornelia Huck <cohuck@redhat.com> wrote:
> 
>> On Thu, 16 Nov 2017 18:05:23 +0100
>> David Hildenbrand <david@redhat.com> wrote:
>>
>>> First one also applies to KVM SIGP handling. The other two only
>>> apply to TCG (allowing to IPL from disk with more than 1 VCPU- I
>>> never tested that before).
>>>
>>> David Hildenbrand (3):
>>>   s390x: fix storing CPU status (again)
>>>   s390x/tcg: fix DIAG 308 with > 1 VCPU (single threaded TCG)
>>>   s390x/tcg: fix DIAG 308 with > 1 VCPU (MTTCG)
>>>
>>>  target/s390x/diag.c        | 4 ----
>>>  target/s390x/helper.c      | 2 +-
>>>  target/s390x/misc_helper.c | 2 ++
>>>  3 files changed, 3 insertions(+), 5 deletions(-)
>>>   
>>
>> Thanks, queued to s390-fixes.
> 
> Patch 2 still needs discussion, I think. I'll dequeue it again and
> leave 1 + 3.

Yes.
Patch1 is certainly good and relevant for 2.11.
Patch2 needs more time as it has potential for adding regression
No opinion on Patch3

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.