From nobody Sun May 5 20:31:39 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1510700462619785.4722036421407; Tue, 14 Nov 2017 15:01:02 -0800 (PST) Received: from localhost ([::1]:33919 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eEkC6-0000xS-7f for importer@patchew.org; Tue, 14 Nov 2017 18:00:38 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53415) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eEkBG-0000Zr-RD for qemu-devel@nongnu.org; Tue, 14 Nov 2017 17:59:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eEkBD-0002Gr-Q6 for qemu-devel@nongnu.org; Tue, 14 Nov 2017 17:59:46 -0500 Received: from zero.eik.bme.hu ([2001:738:2001:2001::2001]:10126) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eEkBD-0002Fl-Jc for qemu-devel@nongnu.org; Tue, 14 Nov 2017 17:59:43 -0500 Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id 909D07456B7; Tue, 14 Nov 2017 23:59:41 +0100 (CET) Received: by zero.eik.bme.hu (Postfix, from userid 432) id 072707456B5; Tue, 14 Nov 2017 23:59:41 +0100 (CET) From: BALATON Zoltan Date: Tue, 14 Nov 2017 23:42:35 +0100 To: qemu-devel@nongnu.org Message-Id: <20171114225941.072707456B5@zero.eik.bme.hu> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:738:2001:2001::2001 Subject: [Qemu-devel] [PATCH] exec: Skip mru section if it's a partial page and not resolving subpage X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Paolo Bonzini , Richard Henderson , Fam Zheng , Peter Crosthwaite Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This fixes a crash caused by picking the wrong memory region in address_space_lookup_region seen with client code accessing a device model that uses alias memory regions. Signed-off-by: BALATON Zoltan --- exec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/exec.c b/exec.c index 97a24a8..e5f2b9a 100644 --- a/exec.c +++ b/exec.c @@ -413,6 +413,7 @@ static MemoryRegionSection *address_space_lookup_region= (AddressSpaceDispatch *d, bool update; =20 if (section && section !=3D &d->map.sections[PHYS_SECTION_UNASSIGNED] = && + (resolve_subpage || !section->offset_within_region) && section_covers_addr(section, addr)) { update =3D false; } else { --=20 2.7.6