From nobody Fri May 3 00:00:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1508254796676234.86770008084125; Tue, 17 Oct 2017 08:39:56 -0700 (PDT) Received: from localhost ([::1]:40096 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4Ty2-0005JV-4Z for importer@patchew.org; Tue, 17 Oct 2017 11:39:42 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55102) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4TwD-0004CB-Ns for qemu-devel@nongnu.org; Tue, 17 Oct 2017 11:37:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e4TwB-0005ja-HM for qemu-devel@nongnu.org; Tue, 17 Oct 2017 11:37:49 -0400 Received: from mail-pf0-x243.google.com ([2607:f8b0:400e:c00::243]:49723) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e4TwB-0005jJ-98 for qemu-devel@nongnu.org; Tue, 17 Oct 2017 11:37:47 -0400 Received: by mail-pf0-x243.google.com with SMTP id i5so1609315pfe.6 for ; Tue, 17 Oct 2017 08:37:47 -0700 (PDT) Received: from cloudburst.twiddle.net (97-126-104-76.tukw.qwest.net. [97.126.104.76]) by smtp.gmail.com with ESMTPSA id y84sm20094415pff.158.2017.10.17.08.37.44 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Oct 2017 08:37:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=iwMm53bCPIaibzK+BrQzHlrVfAW5jrzMH/23z87sg3I=; b=baNrs4TyOKRg0Efa/Bj+Nnf8T2WeOWdpCZLvTetHcfNWi6nbCF5fRyjxlcpL1/Q3MJ VeGPdRAhyXSJOrupavzI6Hh5EJZWbx/NkKlnRdt4BWi2v1rUOaRvMKCC3K8uw3I3e4Ku wAlbMKnnqX9v2mu4tSeYxeR4/SmGwjKJmfvdo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iwMm53bCPIaibzK+BrQzHlrVfAW5jrzMH/23z87sg3I=; b=dTFUXRfXQyicuiYfgGjsm+x+oQN0q0fLvGZQiqoMG0gL0LPt2+tNuG278kuw0R5u45 2a3I3aXIp01tQkau1ejoLZAGUavG7xNhIp+kv3IrIs6Fo7EoN4obVIJ3GTBwEnkGX1D/ wUnmekN/L7oT27Llclb0IVtcy2JILOfzrkhSRk8YH3yuWUJttwf1VTvuBRriUTL0W/di Or1fWidGNFJD20zc6IKtrSYVL+6+rPugQ1sXQZG6Z4h6C3fBBrBppqkrOVKch9nSj+Yb zTtZKvBJ/8QE8UwP3PjVdFxs+MiN91O/qHKT4E9Y0BsxM1OZ4MVmybiqUj/Wp1Iuhqrv oKEQ== X-Gm-Message-State: AMCzsaWqk5Plk5+DtsLVtixpFHVgy2+ucXHBL9+DC4eOFdhRA6/qgfMB CdSB/feBN4brDlNkj879RsKzvpzdYB4= X-Google-Smtp-Source: AOwi7QAU8v+SBKON8YKrGehuDQI9Vr9dHDbu7+MIAVajnRHXe9OFY9lvFWLZnrkkuoYc6ZF2JndOQg== X-Received: by 10.84.248.144 with SMTP id q16mr12646245pll.345.1508254665958; Tue, 17 Oct 2017 08:37:45 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 17 Oct 2017 08:37:34 -0700 Message-Id: <20171017153742.10026-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20171017153742.10026-1-richard.henderson@linaro.org> References: <20171017153742.10026-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::243 Subject: [Qemu-devel] [PATCH v5 1/9] target/i386: Convert to disas_set_info hook X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Tested-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alex Benn=C3=A9e Signed-off-by: Richard Henderson --- disas.c | 22 ++-------------------- monitor.c | 21 --------------------- target/i386/cpu.c | 12 ++++++++++++ target/i386/translate.c | 8 +------- 4 files changed, 15 insertions(+), 48 deletions(-) diff --git a/disas.c b/disas.c index d6a1eb9c8e..2be716fdb2 100644 --- a/disas.c +++ b/disas.c @@ -205,16 +205,7 @@ void target_disas(FILE *out, CPUState *cpu, target_ulo= ng code, cc->disas_set_info(cpu, &s.info); } =20 -#if defined(TARGET_I386) - if (flags =3D=3D 2) { - s.info.mach =3D bfd_mach_x86_64; - } else if (flags =3D=3D 1) { - s.info.mach =3D bfd_mach_i386_i8086; - } else { - s.info.mach =3D bfd_mach_i386_i386; - } - s.info.print_insn =3D print_insn_i386; -#elif defined(TARGET_PPC) +#if defined(TARGET_PPC) if ((flags >> 16) & 1) { s.info.endian =3D BFD_ENDIAN_LITTLE; } @@ -390,16 +381,7 @@ void monitor_disas(Monitor *mon, CPUState *cpu, cc->disas_set_info(cpu, &s.info); } =20 -#if defined(TARGET_I386) - if (flags =3D=3D 2) { - s.info.mach =3D bfd_mach_x86_64; - } else if (flags =3D=3D 1) { - s.info.mach =3D bfd_mach_i386_i8086; - } else { - s.info.mach =3D bfd_mach_i386_i386; - } - s.info.print_insn =3D print_insn_i386; -#elif defined(TARGET_PPC) +#if defined(TARGET_PPC) if (flags & 0xFFFF) { /* If we have a precise definition of the instruction set, use it.= */ s.info.mach =3D flags & 0xFFFF; diff --git a/monitor.c b/monitor.c index fe0d1bdbb4..a736ae9a81 100644 --- a/monitor.c +++ b/monitor.c @@ -1310,27 +1310,6 @@ static void memory_dump(Monitor *mon, int count, int= format, int wsize, =20 if (format =3D=3D 'i') { int flags =3D 0; -#ifdef TARGET_I386 - CPUArchState *env =3D mon_get_cpu_env(); - if (wsize =3D=3D 2) { - flags =3D 1; - } else if (wsize =3D=3D 4) { - flags =3D 0; - } else { - /* as default we use the current CS size */ - flags =3D 0; - if (env) { -#ifdef TARGET_X86_64 - if ((env->efer & MSR_EFER_LMA) && - (env->segs[R_CS].flags & DESC_L_MASK)) - flags =3D 2; - else -#endif - if (!(env->segs[R_CS].flags & DESC_B_MASK)) - flags =3D 1; - } - } -#endif #ifdef TARGET_PPC CPUArchState *env =3D mon_get_cpu_env(); flags =3D msr_le << 16; diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 98732cd65f..13b2f8fbc5 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -4097,6 +4097,17 @@ static bool x86_cpu_has_work(CPUState *cs) !(env->hflags & HF_SMM_MASK)); } =20 +static void x86_disas_set_info(CPUState *cs, disassemble_info *info) +{ + X86CPU *cpu =3D X86_CPU(cs); + CPUX86State *env =3D &cpu->env; + + info->mach =3D (env->hflags & HF_CS64_MASK ? bfd_mach_x86_64 + : env->hflags & HF_CS32_MASK ? bfd_mach_i386_i386 + : bfd_mach_i386_i8086); + info->print_insn =3D print_insn_i386; +} + static Property x86_cpu_properties[] =3D { #ifdef CONFIG_USER_ONLY /* apic_id =3D 0 by default for *-user, see commit 9886e834 */ @@ -4216,6 +4227,7 @@ static void x86_cpu_common_class_init(ObjectClass *oc= , void *data) #endif cc->cpu_exec_enter =3D x86_cpu_exec_enter; cc->cpu_exec_exit =3D x86_cpu_exec_exit; + cc->disas_set_info =3D x86_disas_set_info; =20 dc->user_creatable =3D true; } diff --git a/target/i386/translate.c b/target/i386/translate.c index 5d61fa96ad..046fc5dfe2 100644 --- a/target/i386/translate.c +++ b/target/i386/translate.c @@ -8520,15 +8520,9 @@ static void i386_tr_disas_log(const DisasContextBase= *dcbase, CPUState *cpu) { DisasContext *dc =3D container_of(dcbase, DisasContext, base); - int disas_flags =3D !dc->code32; =20 qemu_log("IN: %s\n", lookup_symbol(dc->base.pc_first)); -#ifdef TARGET_X86_64 - if (dc->code64) { - disas_flags =3D 2; - } -#endif - log_target_disas(cpu, dc->base.pc_first, dc->base.tb->size, disas_flag= s); + log_target_disas(cpu, dc->base.pc_first, dc->base.tb->size, 0); } =20 static const TranslatorOps i386_tr_ops =3D { --=20 2.13.6 From nobody Fri May 3 00:00:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1508254929617554.1977561428238; Tue, 17 Oct 2017 08:42:09 -0700 (PDT) Received: from localhost ([::1]:40107 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4U0J-0007RF-Ta for importer@patchew.org; Tue, 17 Oct 2017 11:42:03 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55106) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4TwE-0004CC-42 for qemu-devel@nongnu.org; Tue, 17 Oct 2017 11:37:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e4TwC-0005kI-UU for qemu-devel@nongnu.org; Tue, 17 Oct 2017 11:37:50 -0400 Received: from mail-pf0-x22a.google.com ([2607:f8b0:400e:c00::22a]:44614) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e4TwC-0005k0-M2 for qemu-devel@nongnu.org; Tue, 17 Oct 2017 11:37:48 -0400 Received: by mail-pf0-x22a.google.com with SMTP id x7so1620398pfa.1 for ; Tue, 17 Oct 2017 08:37:48 -0700 (PDT) Received: from cloudburst.twiddle.net (97-126-104-76.tukw.qwest.net. [97.126.104.76]) by smtp.gmail.com with ESMTPSA id y84sm20094415pff.158.2017.10.17.08.37.46 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Oct 2017 08:37:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=DujOZWDLQXyTmFWZGQ6qNVKoVqZ6fqxl5TfOEJNh3AQ=; b=B6Pdn1Fxz6C4w0DZ9Wtv9vTL90mEWdTChex9w3uiMDAxxaOVKd6TRqv5MxXblewY9s LawLseK7j9x0Pjmqyiwm2R3Yx2JLtSo4uNxL3pQCTBFM0LCMTCN3SyqH/xCij52u+L90 Wqw+yRoW1bBanTWLLaaXEoBVSvejnwrWd51xc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DujOZWDLQXyTmFWZGQ6qNVKoVqZ6fqxl5TfOEJNh3AQ=; b=kwNWo0oBXJLO3DwvFRLBoIwd/sCmY0VK59E1nuIbRrNDwaoBGCFxmSvISfxDs1lIH6 oKdAVetuCD9tq732I66mSoBcc2xrj6xGayLqzZuYWx+AwYTyqqp6oYgJf90z22V6IMxt BJD5cCbnhMAdq7ErBt2fFwJwLQjJtshxldI/dAbfb9gON/VQgu6/+16yVN7AQpmNRiwK jUA3F59TOgws8Mn0IkDwyu8Tx1DVtr7XC/Q2DIlPnOMAokwwjwbRD3MkM5D4DR1v3OZX HDb62GfXpgd4eCbqOH5nmE1W9t0m78efsswEdWf7PtK3bmETvR7PDFtKuFOKYQWNzw1l 0bJQ== X-Gm-Message-State: AMCzsaXXuAWVkVeoFbrCATlVizwsE+4F2tIVS61hyPQoj1esk8PoMaz4 sFD+mw5Bt3IT9WqvfptSXd56FPkTLcg= X-Google-Smtp-Source: ABhQp+R1WTjnGaG0U0cJjwKYo6whmD6AdAtaGxBV3/aSDtgxtO0jNH1O2lro7eEqVd+nA5HhL85/zQ== X-Received: by 10.84.164.104 with SMTP id m37mr4356311plg.242.1508254667351; Tue, 17 Oct 2017 08:37:47 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 17 Oct 2017 08:37:35 -0700 Message-Id: <20171017153742.10026-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20171017153742.10026-1-richard.henderson@linaro.org> References: <20171017153742.10026-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::22a Subject: [Qemu-devel] [PATCH v5 2/9] target/ppc: Convert to disas_set_info hook X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Tested-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alex Benn=C3=A9e Signed-off-by: Richard Henderson --- disas.c | 33 --------------------------------- monitor.c | 5 ----- target/ppc/translate.c | 5 +---- target/ppc/translate_init.c | 21 +++++++++++++++++++++ 4 files changed, 22 insertions(+), 42 deletions(-) diff --git a/disas.c b/disas.c index 2be716fdb2..3a375a3b6c 100644 --- a/disas.c +++ b/disas.c @@ -205,23 +205,6 @@ void target_disas(FILE *out, CPUState *cpu, target_ulo= ng code, cc->disas_set_info(cpu, &s.info); } =20 -#if defined(TARGET_PPC) - if ((flags >> 16) & 1) { - s.info.endian =3D BFD_ENDIAN_LITTLE; - } - if (flags & 0xFFFF) { - /* If we have a precise definition of the instruction set, use it.= */ - s.info.mach =3D flags & 0xFFFF; - } else { -#ifdef TARGET_PPC64 - s.info.mach =3D bfd_mach_ppc64; -#else - s.info.mach =3D bfd_mach_ppc; -#endif - } - s.info.disassembler_options =3D (char *)"any"; - s.info.print_insn =3D print_insn_ppc; -#endif if (s.info.print_insn =3D=3D NULL) { s.info.print_insn =3D print_insn_od_target; } @@ -381,22 +364,6 @@ void monitor_disas(Monitor *mon, CPUState *cpu, cc->disas_set_info(cpu, &s.info); } =20 -#if defined(TARGET_PPC) - if (flags & 0xFFFF) { - /* If we have a precise definition of the instruction set, use it.= */ - s.info.mach =3D flags & 0xFFFF; - } else { -#ifdef TARGET_PPC64 - s.info.mach =3D bfd_mach_ppc64; -#else - s.info.mach =3D bfd_mach_ppc; -#endif - } - if ((flags >> 16) & 1) { - s.info.endian =3D BFD_ENDIAN_LITTLE; - } - s.info.print_insn =3D print_insn_ppc; -#endif if (!s.info.print_insn) { monitor_printf(mon, "0x" TARGET_FMT_lx ": Asm output not supported on this arch\n", pc); diff --git a/monitor.c b/monitor.c index a736ae9a81..2164dfcc3b 100644 --- a/monitor.c +++ b/monitor.c @@ -1310,11 +1310,6 @@ static void memory_dump(Monitor *mon, int count, int= format, int wsize, =20 if (format =3D=3D 'i') { int flags =3D 0; -#ifdef TARGET_PPC - CPUArchState *env =3D mon_get_cpu_env(); - flags =3D msr_le << 16; - flags |=3D env->bfd_mach; -#endif monitor_disas(mon, cs, addr, count, is_physical, flags); return; } diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 606b605ba0..bc155f1036 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -7395,12 +7395,9 @@ void gen_intermediate_code(CPUState *cs, struct Tran= slationBlock *tb) #if defined(DEBUG_DISAS) if (qemu_loglevel_mask(CPU_LOG_TB_IN_ASM) && qemu_log_in_addr_range(pc_start)) { - int flags; - flags =3D env->bfd_mach; - flags |=3D ctx.le_mode << 16; qemu_log_lock(); qemu_log("IN: %s\n", lookup_symbol(pc_start)); - log_target_disas(cs, pc_start, ctx.nip - pc_start, flags); + log_target_disas(cs, pc_start, ctx.nip - pc_start, 0); qemu_log("\n"); qemu_log_unlock(); } diff --git a/target/ppc/translate_init.c b/target/ppc/translate_init.c index c6399a3a0d..2863e2c0b0 100644 --- a/target/ppc/translate_init.c +++ b/target/ppc/translate_init.c @@ -10681,6 +10681,26 @@ static gchar *ppc_gdb_arch_name(CPUState *cs) #endif } =20 +static void ppc_disas_set_info(CPUState *cs, disassemble_info *info) +{ + PowerPCCPU *cpu =3D POWERPC_CPU(cs); + CPUPPCState *env =3D &cpu->env; + + if ((env->hflags >> MSR_LE) & 1) { + info->endian =3D BFD_ENDIAN_LITTLE; + } + info->mach =3D env->bfd_mach; + if (!env->bfd_mach) { +#ifdef TARGET_PPC64 + info->mach =3D bfd_mach_ppc64; +#else + info->mach =3D bfd_mach_ppc; +#endif + } + info->disassembler_options =3D (char *)"any"; + info->print_insn =3D print_insn_ppc; +} + static Property ppc_cpu_properties[] =3D { DEFINE_PROP_BOOL("pre-2.8-migration", PowerPCCPU, pre_2_8_migration, f= alse), DEFINE_PROP_BOOL("pre-2.10-migration", PowerPCCPU, pre_2_10_migration, @@ -10742,6 +10762,7 @@ static void ppc_cpu_class_init(ObjectClass *oc, voi= d *data) #ifndef CONFIG_USER_ONLY cc->virtio_is_big_endian =3D ppc_cpu_is_big_endian; #endif + cc->disas_set_info =3D ppc_disas_set_info; =20 dc->fw_name =3D "PowerPC,UNKNOWN"; } --=20 2.13.6 From nobody Fri May 3 00:00:10 2024 Delivered-To: importer@patchew.org Received-SPF: temperror (zoho.com: Error in retrieving data from DNS) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1508254803993386.80515546763627; Tue, 17 Oct 2017 08:40:03 -0700 (PDT) Received: from localhost ([::1]:40097 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4TyA-0005R1-CC for importer@patchew.org; Tue, 17 Oct 2017 11:39:50 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55135) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4TwG-0004DJ-MN for qemu-devel@nongnu.org; Tue, 17 Oct 2017 11:37:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e4TwE-0005lK-Cx for qemu-devel@nongnu.org; Tue, 17 Oct 2017 11:37:52 -0400 Received: from mail-pg0-x229.google.com ([2607:f8b0:400e:c05::229]:44374) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e4TwE-0005km-45 for qemu-devel@nongnu.org; Tue, 17 Oct 2017 11:37:50 -0400 Received: by mail-pg0-x229.google.com with SMTP id j3so1718567pga.1 for ; Tue, 17 Oct 2017 08:37:50 -0700 (PDT) Received: from cloudburst.twiddle.net (97-126-104-76.tukw.qwest.net. [97.126.104.76]) by smtp.gmail.com with ESMTPSA id y84sm20094415pff.158.2017.10.17.08.37.47 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Oct 2017 08:37:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=hB8AZwvmRCLXN31Jhod9LFpLholMjxL6hx1+1UO+7iM=; b=Qw+BapOKmYFcryWIZrzSJ2iM0JHJ6ve+xRS0F4iVITcEsu5TmxbdUwCsuFItxU4GL2 j+0e2FkaPvnCx6m7+16TmG7MHR+8sbRDpb4Gm8DVPdwDKWaNJ1zKHw/OT/3KdZCyV4Ev SRK5DTOhnx66x3BRhbK+/bAre8ChcO6P1zA9M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hB8AZwvmRCLXN31Jhod9LFpLholMjxL6hx1+1UO+7iM=; b=uZKMd169mcyTQ+wvdQA9pHLZla+D3bGMno+0RsADsqVCwRZVze/SDunsOLvfTMJ/8N B0CoDLtSw3dp/YMlUcCy4snuXR5xHqMmAKi1+q+laULDDMGh01Wf6VS7zw7bLplvk2NV xZDSJOT/omKnveveRjsoYHl6UlbEZj4fzcwzKSt4Du7GSbYKYn52qAb2MQTKJBEY+N2m eXGS8Q/Ypugqq+OFN22VbiWgZG2rmgbI4Ggvs88zRcu+xl6BhFIlMayn4h/lIFA102bl plBBYUsINYYNMi0paz1wJEDxee8GLyGI8/Vs37Ssi980GiZXBWzDsZGh7/pl3v0RLf7r DABw== X-Gm-Message-State: AMCzsaW5mbRLBpRB7dGgBtyNsiyWA2Knc09+jaGcG273h0IIhbxuRvBs JptMUAzQAF85TlPBRJh1IROipyxcdr8= X-Google-Smtp-Source: ABhQp+Ta0HQaCGu6G7Tulr7WuGC+HZ7slW2dLdKAScpdt5xm6UFlH5uuCL1JXRBZpSnPclpdCGXHOA== X-Received: by 10.159.229.203 with SMTP id t11mr4700751plq.190.1508254668629; Tue, 17 Oct 2017 08:37:48 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 17 Oct 2017 08:37:36 -0700 Message-Id: <20171017153742.10026-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20171017153742.10026-1-richard.henderson@linaro.org> References: <20171017153742.10026-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::229 Subject: [Qemu-devel] [PATCH v5 3/9] disas: Remove unused flags arguments X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_6 Z_629925259 SPT_0 Now that every target is using the disas_set_info hook, the flags argument is unused. Remove it. Tested-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alex Benn=C3=A9e Signed-off-by: Richard Henderson --- include/disas/disas.h | 4 ++-- include/exec/log.h | 4 ++-- disas.c | 15 ++++----------- monitor.c | 3 +-- target/alpha/translate.c | 2 +- target/arm/translate-a64.c | 3 +-- target/arm/translate.c | 3 +-- target/cris/translate.c | 3 +-- target/hppa/translate.c | 2 +- target/i386/translate.c | 2 +- target/lm32/translate.c | 2 +- target/m68k/translate.c | 2 +- target/microblaze/translate.c | 2 +- target/mips/translate.c | 2 +- target/nios2/translate.c | 2 +- target/openrisc/translate.c | 2 +- target/ppc/translate.c | 2 +- target/s390x/translate.c | 2 +- target/sh4/translate.c | 2 +- target/sparc/translate.c | 2 +- target/tricore/translate.c | 2 +- target/unicore32/translate.c | 2 +- target/xtensa/translate.c | 2 +- 23 files changed, 28 insertions(+), 39 deletions(-) diff --git a/include/disas/disas.h b/include/disas/disas.h index e549ca24a1..4d48c13c65 100644 --- a/include/disas/disas.h +++ b/include/disas/disas.h @@ -9,10 +9,10 @@ /* Disassemble this for me please... (debugging). */ void disas(FILE *out, void *code, unsigned long size); void target_disas(FILE *out, CPUState *cpu, target_ulong code, - target_ulong size, int flags); + target_ulong size); =20 void monitor_disas(Monitor *mon, CPUState *cpu, - target_ulong pc, int nb_insn, int is_physical, int flag= s); + target_ulong pc, int nb_insn, int is_physical); =20 /* Look up symbol for debugging purpose. Returns "" if unknown. */ const char *lookup_symbol(target_ulong orig_addr); diff --git a/include/exec/log.h b/include/exec/log.h index ba1c9b5682..c249307911 100644 --- a/include/exec/log.h +++ b/include/exec/log.h @@ -38,9 +38,9 @@ static inline void log_cpu_state_mask(int mask, CPUState = *cpu, int flags) #ifdef NEED_CPU_H /* disas() and target_disas() to qemu_logfile: */ static inline void log_target_disas(CPUState *cpu, target_ulong start, - target_ulong len, int flags) + target_ulong len) { - target_disas(qemu_logfile, cpu, start, len, flags); + target_disas(qemu_logfile, cpu, start, len); } =20 static inline void log_disas(void *code, unsigned long size) diff --git a/disas.c b/disas.c index 3a375a3b6c..ad675dc361 100644 --- a/disas.c +++ b/disas.c @@ -171,15 +171,9 @@ static int print_insn_od_target(bfd_vma pc, disassembl= e_info *info) return print_insn_objdump(pc, info, "OBJD-T"); } =20 -/* Disassemble this for me please... (debugging). 'flags' has the following - values: - i386 - 1 means 16 bit code, 2 means 64 bit code - ppc - bits 0:15 specify (optionally) the machine instruction set; - bit 16 indicates little endian. - other targets - unused - */ +/* Disassemble this for me please... (debugging). */ void target_disas(FILE *out, CPUState *cpu, target_ulong code, - target_ulong size, int flags) + target_ulong size) { CPUClass *cc =3D CPU_GET_CLASS(cpu); target_ulong pc; @@ -336,10 +330,9 @@ monitor_read_memory (bfd_vma memaddr, bfd_byte *myaddr= , int length, return 0; } =20 -/* Disassembler for the monitor. - See target_disas for a description of flags. */ +/* Disassembler for the monitor. */ void monitor_disas(Monitor *mon, CPUState *cpu, - target_ulong pc, int nb_insn, int is_physical, int flag= s) + target_ulong pc, int nb_insn, int is_physical) { CPUClass *cc =3D CPU_GET_CLASS(cpu); int count, i; diff --git a/monitor.c b/monitor.c index 2164dfcc3b..7a802a345e 100644 --- a/monitor.c +++ b/monitor.c @@ -1309,8 +1309,7 @@ static void memory_dump(Monitor *mon, int count, int = format, int wsize, } =20 if (format =3D=3D 'i') { - int flags =3D 0; - monitor_disas(mon, cs, addr, count, is_physical, flags); + monitor_disas(mon, cs, addr, count, is_physical); return; } =20 diff --git a/target/alpha/translate.c b/target/alpha/translate.c index f32c95b9a1..3de369b17e 100644 --- a/target/alpha/translate.c +++ b/target/alpha/translate.c @@ -3048,7 +3048,7 @@ static void alpha_tr_tb_stop(DisasContextBase *dcbase= , CPUState *cpu) static void alpha_tr_disas_log(const DisasContextBase *dcbase, CPUState *c= pu) { qemu_log("IN: %s\n", lookup_symbol(dcbase->pc_first)); - log_target_disas(cpu, dcbase->pc_first, dcbase->tb->size, 1); + log_target_disas(cpu, dcbase->pc_first, dcbase->tb->size); } =20 static const TranslatorOps alpha_tr_ops =3D { diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index a39b9d3633..fc5419df7f 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -11403,8 +11403,7 @@ static void aarch64_tr_disas_log(const DisasContext= Base *dcbase, DisasContext *dc =3D container_of(dcbase, DisasContext, base); =20 qemu_log("IN: %s\n", lookup_symbol(dc->base.pc_first)); - log_target_disas(cpu, dc->base.pc_first, dc->base.tb->size, - 4 | (bswap_code(dc->sctlr_b) ? 2 : 0)); + log_target_disas(cpu, dc->base.pc_first, dc->base.tb->size); } =20 const TranslatorOps aarch64_translator_ops =3D { diff --git a/target/arm/translate.c b/target/arm/translate.c index 4da1a4cbc6..9d31769c8d 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -12371,8 +12371,7 @@ static void arm_tr_disas_log(const DisasContextBase= *dcbase, CPUState *cpu) DisasContext *dc =3D container_of(dcbase, DisasContext, base); =20 qemu_log("IN: %s\n", lookup_symbol(dc->base.pc_first)); - log_target_disas(cpu, dc->base.pc_first, dc->base.tb->size, - dc->thumb | (dc->sctlr_b << 1)); + log_target_disas(cpu, dc->base.pc_first, dc->base.tb->size); } =20 static const TranslatorOps arm_translator_ops =3D { diff --git a/target/cris/translate.c b/target/cris/translate.c index 38a999e6f1..b1fda57c74 100644 --- a/target/cris/translate.c +++ b/target/cris/translate.c @@ -3297,8 +3297,7 @@ void gen_intermediate_code(CPUState *cs, struct Trans= lationBlock *tb) qemu_log_lock(); qemu_log("--------------\n"); qemu_log("IN: %s\n", lookup_symbol(pc_start)); - log_target_disas(cs, pc_start, dc->pc - pc_start, - env->pregs[PR_VR]); + log_target_disas(cs, pc_start, dc->pc - pc_start); qemu_log("\nisize=3D%d osize=3D%d\n", dc->pc - pc_start, tcg_op_buf_count()); qemu_log_unlock(); diff --git a/target/hppa/translate.c b/target/hppa/translate.c index 26242f4b3c..ca6a6d3372 100644 --- a/target/hppa/translate.c +++ b/target/hppa/translate.c @@ -3904,7 +3904,7 @@ static void hppa_tr_disas_log(const DisasContextBase = *dcbase, CPUState *cs) break; default: qemu_log("IN: %s\n", lookup_symbol(tb->pc)); - log_target_disas(cs, tb->pc, tb->size, 1); + log_target_disas(cs, tb->pc, tb->size); break; } } diff --git a/target/i386/translate.c b/target/i386/translate.c index 046fc5dfe2..be0a1e9f05 100644 --- a/target/i386/translate.c +++ b/target/i386/translate.c @@ -8522,7 +8522,7 @@ static void i386_tr_disas_log(const DisasContextBase = *dcbase, DisasContext *dc =3D container_of(dcbase, DisasContext, base); =20 qemu_log("IN: %s\n", lookup_symbol(dc->base.pc_first)); - log_target_disas(cpu, dc->base.pc_first, dc->base.tb->size, 0); + log_target_disas(cpu, dc->base.pc_first, dc->base.tb->size); } =20 static const TranslatorOps i386_tr_ops =3D { diff --git a/target/lm32/translate.c b/target/lm32/translate.c index 65bc9c0bf6..a83cbdf729 100644 --- a/target/lm32/translate.c +++ b/target/lm32/translate.c @@ -1156,7 +1156,7 @@ void gen_intermediate_code(CPUState *cs, struct Trans= lationBlock *tb) && qemu_log_in_addr_range(pc_start)) { qemu_log_lock(); qemu_log("\n"); - log_target_disas(cs, pc_start, dc->pc - pc_start, 0); + log_target_disas(cs, pc_start, dc->pc - pc_start); qemu_log("\nisize=3D%d osize=3D%d\n", dc->pc - pc_start, tcg_op_buf_count()); qemu_log_unlock(); diff --git a/target/m68k/translate.c b/target/m68k/translate.c index d738f32f9c..e1e31f622c 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translate.c @@ -5620,7 +5620,7 @@ void gen_intermediate_code(CPUState *cs, TranslationB= lock *tb) qemu_log_lock(); qemu_log("----------------\n"); qemu_log("IN: %s\n", lookup_symbol(pc_start)); - log_target_disas(cs, pc_start, dc->pc - pc_start, 0); + log_target_disas(cs, pc_start, dc->pc - pc_start); qemu_log("\n"); qemu_log_unlock(); } diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index 067b0878d6..fecc61a1ec 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -1810,7 +1810,7 @@ void gen_intermediate_code(CPUState *cs, struct Trans= lationBlock *tb) qemu_log_lock(); qemu_log("--------------\n"); #if DISAS_GNU - log_target_disas(cs, pc_start, dc->pc - pc_start, 0); + log_target_disas(cs, pc_start, dc->pc - pc_start); #endif qemu_log("\nisize=3D%d osize=3D%d\n", dc->pc - pc_start, tcg_op_buf_count()); diff --git a/target/mips/translate.c b/target/mips/translate.c index ac05f3aa09..7c96aff1a0 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -20370,7 +20370,7 @@ done_generating: && qemu_log_in_addr_range(pc_start)) { qemu_log_lock(); qemu_log("IN: %s\n", lookup_symbol(pc_start)); - log_target_disas(cs, pc_start, ctx.pc - pc_start, 0); + log_target_disas(cs, pc_start, ctx.pc - pc_start); qemu_log("\n"); qemu_log_unlock(); } diff --git a/target/nios2/translate.c b/target/nios2/translate.c index 6b0961837d..7a0fa860da 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@ -907,7 +907,7 @@ void gen_intermediate_code(CPUState *cs, TranslationBlo= ck *tb) && qemu_log_in_addr_range(tb->pc)) { qemu_log_lock(); qemu_log("IN: %s\n", lookup_symbol(tb->pc)); - log_target_disas(cs, tb->pc, dc->pc - tb->pc, 0); + log_target_disas(cs, tb->pc, dc->pc - tb->pc); qemu_log("\n"); qemu_log_unlock(); } diff --git a/target/openrisc/translate.c b/target/openrisc/translate.c index 112db1ad0f..99f2b463ce 100644 --- a/target/openrisc/translate.c +++ b/target/openrisc/translate.c @@ -1653,7 +1653,7 @@ void gen_intermediate_code(CPUState *cs, struct Trans= lationBlock *tb) =20 if (qemu_loglevel_mask(CPU_LOG_TB_IN_ASM) && qemu_log_in_addr_range(pc_start)) { - log_target_disas(cs, pc_start, tb->size, 0); + log_target_disas(cs, pc_start, tb->size); qemu_log("\n"); qemu_log_unlock(); } diff --git a/target/ppc/translate.c b/target/ppc/translate.c index bc155f1036..8e92e4579c 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -7397,7 +7397,7 @@ void gen_intermediate_code(CPUState *cs, struct Trans= lationBlock *tb) && qemu_log_in_addr_range(pc_start)) { qemu_log_lock(); qemu_log("IN: %s\n", lookup_symbol(pc_start)); - log_target_disas(cs, pc_start, ctx.nip - pc_start, 0); + log_target_disas(cs, pc_start, ctx.nip - pc_start); qemu_log("\n"); qemu_log_unlock(); } diff --git a/target/s390x/translate.c b/target/s390x/translate.c index 165d2cac3e..4fa7609c64 100644 --- a/target/s390x/translate.c +++ b/target/s390x/translate.c @@ -5970,7 +5970,7 @@ void gen_intermediate_code(CPUState *cs, struct Trans= lationBlock *tb) qemu_log("IN: EXECUTE %016" PRIx64 "\n", dc.ex_value); } else { qemu_log("IN: %s\n", lookup_symbol(pc_start)); - log_target_disas(cs, pc_start, dc.pc - pc_start, 1); + log_target_disas(cs, pc_start, dc.pc - pc_start); qemu_log("\n"); } qemu_log_unlock(); diff --git a/target/sh4/translate.c b/target/sh4/translate.c index 8db9fba26e..27067cbd30 100644 --- a/target/sh4/translate.c +++ b/target/sh4/translate.c @@ -2347,7 +2347,7 @@ void gen_intermediate_code(CPUState *cs, struct Trans= lationBlock *tb) && qemu_log_in_addr_range(pc_start)) { qemu_log_lock(); qemu_log("IN:\n"); /* , lookup_symbol(pc_start)); */ - log_target_disas(cs, pc_start, ctx.pc - pc_start, 0); + log_target_disas(cs, pc_start, ctx.pc - pc_start); qemu_log("\n"); qemu_log_unlock(); } diff --git a/target/sparc/translate.c b/target/sparc/translate.c index 6290705b11..e89b6227f2 100644 --- a/target/sparc/translate.c +++ b/target/sparc/translate.c @@ -5855,7 +5855,7 @@ void gen_intermediate_code(CPUState *cs, TranslationB= lock * tb) qemu_log_lock(); qemu_log("--------------\n"); qemu_log("IN: %s\n", lookup_symbol(pc_start)); - log_target_disas(cs, pc_start, last_pc + 4 - pc_start, 0); + log_target_disas(cs, pc_start, last_pc + 4 - pc_start); qemu_log("\n"); qemu_log_unlock(); } diff --git a/target/tricore/translate.c b/target/tricore/translate.c index 4e4198e887..e807500e26 100644 --- a/target/tricore/translate.c +++ b/target/tricore/translate.c @@ -8839,7 +8839,7 @@ void gen_intermediate_code(CPUState *cs, struct Trans= lationBlock *tb) && qemu_log_in_addr_range(pc_start)) { qemu_log_lock(); qemu_log("IN: %s\n", lookup_symbol(pc_start)); - log_target_disas(cs, pc_start, ctx.pc - pc_start, 0); + log_target_disas(cs, pc_start, ctx.pc - pc_start); qemu_log("\n"); qemu_log_unlock(); } diff --git a/target/unicore32/translate.c b/target/unicore32/translate.c index 6c094d59d7..f9aa248a80 100644 --- a/target/unicore32/translate.c +++ b/target/unicore32/translate.c @@ -2031,7 +2031,7 @@ done_generating: qemu_log_lock(); qemu_log("----------------\n"); qemu_log("IN: %s\n", lookup_symbol(pc_start)); - log_target_disas(cs, pc_start, dc->pc - pc_start, 0); + log_target_disas(cs, pc_start, dc->pc - pc_start); qemu_log("\n"); qemu_log_unlock(); } diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c index d7bf07e8e6..03719ce12b 100644 --- a/target/xtensa/translate.c +++ b/target/xtensa/translate.c @@ -3250,7 +3250,7 @@ done: qemu_log_lock(); qemu_log("----------------\n"); qemu_log("IN: %s\n", lookup_symbol(pc_start)); - log_target_disas(cs, pc_start, dc.pc - pc_start, 0); + log_target_disas(cs, pc_start, dc.pc - pc_start); qemu_log("\n"); qemu_log_unlock(); } --=20 2.13.6 From nobody Fri May 3 00:00:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1508254936330469.4371266654281; Tue, 17 Oct 2017 08:42:16 -0700 (PDT) Received: from localhost ([::1]:40108 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4U0V-0007Zv-IQ for importer@patchew.org; Tue, 17 Oct 2017 11:42:15 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55149) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4TwI-0004Ef-0y for qemu-devel@nongnu.org; Tue, 17 Oct 2017 11:37:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e4TwF-0005m5-Vn for qemu-devel@nongnu.org; Tue, 17 Oct 2017 11:37:54 -0400 Received: from mail-pf0-x229.google.com ([2607:f8b0:400e:c00::229]:57257) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e4TwF-0005li-MT for qemu-devel@nongnu.org; Tue, 17 Oct 2017 11:37:51 -0400 Received: by mail-pf0-x229.google.com with SMTP id b85so1601919pfj.13 for ; Tue, 17 Oct 2017 08:37:51 -0700 (PDT) Received: from cloudburst.twiddle.net (97-126-104-76.tukw.qwest.net. [97.126.104.76]) by smtp.gmail.com with ESMTPSA id y84sm20094415pff.158.2017.10.17.08.37.48 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Oct 2017 08:37:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references; bh=0GnOE3EOiSsS1sBJSxSS3t9vjWYDvztEoyQAy3/VzWA=; b=Ureqv48A41dvImI6aAM8OIeVDGWVqfkdjYlOGFd73nuyDRYaMUMeHOh7pLPPibHMkQ LOtCn/ITTsWyAWgPANG5v+mCwe1NZHPOxGrChZBmn8UdKiw3cqf4atLsa8XySQYtWYzq vkGoAuWvG9FlZqoD9NX1sC2dorVUKW5G1RhwU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=0GnOE3EOiSsS1sBJSxSS3t9vjWYDvztEoyQAy3/VzWA=; b=taJlDwaJ9nw3P3dHllbLYR8QM8dQBbUGV9Z+y2mcCDQoK7yqNYhpfy3Y/Pf0ktTTYp 7iigWVXR4CKcY6HCxlIKcDurEihEOUWc4oEdLt1yJEq3c7FBf2Pe7VT19Wzv9AL6LkkC GHEMXB83m19nCwhns5nqr4NVi6/+GzkQSjQt9LKRPZgm/K00mZBU8ZBsl1kjctQXX6s3 AOfJfQi3xmYwn1JdA5VDd+cHQl/x1ldqqQ31nEE4QO8IPKYUVTEF61qywpVHIeG+/vaN 1aFKfyOj0Z9C4dWey4jSkTREkNkmme0zP62cmQNFjvUII6KUcG9YsOh4n6K5k72IpwpT h7OA== X-Gm-Message-State: AMCzsaVuqRdj73XbIFFKfiJSsjFI+LFOOLQj5EFW1pXjn5tt1XJN5iqT CEq6/vqVqVbZQrB/BngrXAjiu5UDmdQ= X-Google-Smtp-Source: AOwi7QCICSrcslc60XYd/wmhC/uDZ2gIic0p/+hi8FeqTpmcscxlzLnvTFkV3qfPpfuRfp5Y1M/SoQ== X-Received: by 10.98.33.203 with SMTP id o72mr12015066pfj.41.1508254670224; Tue, 17 Oct 2017 08:37:50 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 17 Oct 2017 08:37:37 -0700 Message-Id: <20171017153742.10026-5-richard.henderson@linaro.org> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20171017153742.10026-1-richard.henderson@linaro.org> References: <20171017153742.10026-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::229 Subject: [Qemu-devel] [PATCH v5 4/9] disas: Support the Capstone disassembler library X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" If configured, prefer this over our rather dated copy of the GPLv2-only binutils. This will be especially apparent with the proposed vector extensions to TCG, as disas/i386.c does not handle AVX. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- include/disas/bfd.h | 4 + include/disas/capstone.h | 38 ++++++++ disas.c | 219 +++++++++++++++++++++++++++++++++++++++++++= +--- configure | 26 ++++++ 4 files changed, 274 insertions(+), 13 deletions(-) create mode 100644 include/disas/capstone.h diff --git a/include/disas/bfd.h b/include/disas/bfd.h index b01e002b4c..0f4ecdeb88 100644 --- a/include/disas/bfd.h +++ b/include/disas/bfd.h @@ -377,6 +377,10 @@ typedef struct disassemble_info { /* Command line options specific to the target disassembler. */ char * disassembler_options; =20 + /* Options for Capstone disassembly. */ + int cap_arch; + int cap_mode; + } disassemble_info; =20 =0C diff --git a/include/disas/capstone.h b/include/disas/capstone.h new file mode 100644 index 0000000000..84e214956d --- /dev/null +++ b/include/disas/capstone.h @@ -0,0 +1,38 @@ +#ifndef QEMU_CAPSTONE_H +#define QEMU_CAPSTONE_H 1 + +#ifdef CONFIG_CAPSTONE + +#include + +#else + +/* Just enough to allow backends to init without ifdefs. */ + +#define CS_ARCH_ARM -1 +#define CS_ARCH_ARM64 -1 +#define CS_ARCH_MIPS -1 +#define CS_ARCH_X86 -1 +#define CS_ARCH_PPC -1 +#define CS_ARCH_SPARC -1 +#define CS_ARCH_SYSZ -1 + +#define CS_MODE_LITTLE_ENDIAN 0 +#define CS_MODE_BIG_ENDIAN 0 +#define CS_MODE_ARM 0 +#define CS_MODE_16 0 +#define CS_MODE_32 0 +#define CS_MODE_64 0 +#define CS_MODE_THUMB 0 +#define CS_MODE_MCLASS 0 +#define CS_MODE_V8 0 +#define CS_MODE_MICRO 0 +#define CS_MODE_MIPS3 0 +#define CS_MODE_MIPS32R6 0 +#define CS_MODE_MIPSGP64 0 +#define CS_MODE_V9 0 +#define CS_MODE_MIPS32 0 +#define CS_MODE_MIPS64 0 + +#endif /* CONFIG_CAPSTONE */ +#endif /* QEMU_CAPSTONE_H */ diff --git a/disas.c b/disas.c index ad675dc361..746d76c07d 100644 --- a/disas.c +++ b/disas.c @@ -6,6 +6,7 @@ =20 #include "cpu.h" #include "disas/disas.h" +#include "disas/capstone.h" =20 typedef struct CPUDebug { struct disassemble_info info; @@ -171,6 +172,192 @@ static int print_insn_od_target(bfd_vma pc, disassemb= le_info *info) return print_insn_objdump(pc, info, "OBJD-T"); } =20 +#ifdef CONFIG_CAPSTONE +/* Temporary storage for the capstone library. This will be alloced via + malloc with a size private to the library; thus there's no reason not + to share this across calls and across host vs target disassembly. */ +static __thread cs_insn *cap_insn; + +/* Initialize the Capstone library. */ +/* ??? It would be nice to cache this. We would need one handle for the + host and one for the target. For most targets we can reset specific + parameters via cs_option(CS_OPT_MODE, new_mode), but we cannot change + CS_ARCH_* in this way. Thus we would need to be able to close and + re-open the target handle with a different arch for the target in order + to handle AArch64 vs AArch32 mode switching. */ +static cs_err cap_disas_start(disassemble_info *info, csh *handle) +{ + cs_mode cap_mode =3D info->cap_mode; + cs_err err; + + cap_mode +=3D (info->endian =3D=3D BFD_ENDIAN_BIG ? CS_MODE_BIG_ENDIAN + : CS_MODE_LITTLE_ENDIAN); + + err =3D cs_open(info->cap_arch, cap_mode, handle); + if (err !=3D CS_ERR_OK) { + return err; + } + + /* ??? There probably ought to be a better place to put this. */ + if (info->cap_arch =3D=3D CS_ARCH_X86) { + /* We don't care about errors (if for some reason the library + is compiled without AT&T syntax); the user will just have + to deal with the Intel syntax. */ + cs_option(*handle, CS_OPT_SYNTAX, CS_OPT_SYNTAX_ATT); + } + + /* "Disassemble" unknown insns as ".byte W,X,Y,Z". */ + cs_option(*handle, CS_OPT_SKIPDATA, CS_OPT_ON); + + /* Allocate temp space for cs_disasm_iter. */ + if (cap_insn =3D=3D NULL) { + cap_insn =3D cs_malloc(*handle); + if (cap_insn =3D=3D NULL) { + cs_close(handle); + return CS_ERR_MEM; + } + } + return CS_ERR_OK; +} + +/* Disassemble SIZE bytes at PC for the target. */ +static bool cap_disas_target(disassemble_info *info, uint64_t pc, size_t s= ize) +{ + uint8_t cap_buf[1024]; + csh handle; + cs_insn *insn; + size_t csize =3D 0; + + if (cap_disas_start(info, &handle) !=3D CS_ERR_OK) { + return false; + } + insn =3D cap_insn; + + while (1) { + size_t tsize =3D MIN(sizeof(cap_buf) - csize, size); + const uint8_t *cbuf =3D cap_buf; + + target_read_memory(pc + csize, cap_buf + csize, tsize, info); + csize +=3D tsize; + size -=3D tsize; + + while (cs_disasm_iter(handle, &cbuf, &csize, &pc, insn)) { + (*info->fprintf_func)(info->stream, + "0x%08" PRIx64 ": %-12s %s\n", + insn->address, insn->mnemonic, + insn->op_str); + } + + /* If the target memory is not consumed, go back for more... */ + if (size !=3D 0) { + /* ... taking care to move any remaining fractional insn + to the beginning of the buffer. */ + if (csize !=3D 0) { + memmove(cap_buf, cbuf, csize); + } + continue; + } + + /* Since the target memory is consumed, we should not have + a remaining fractional insn. */ + if (csize !=3D 0) { + (*info->fprintf_func)(info->stream, + "Disassembler disagrees with translator " + "over instruction decoding\n" + "Please report this to qemu-devel@nongnu.org\n"); + } + break; + } + + cs_close(&handle); + return true; +} + +/* Disassemble SIZE bytes at CODE for the host. */ +static bool cap_disas_host(disassemble_info *info, void *code, size_t size) +{ + csh handle; + const uint8_t *cbuf; + cs_insn *insn; + uint64_t pc; + + if (cap_disas_start(info, &handle) !=3D CS_ERR_OK) { + return false; + } + insn =3D cap_insn; + + cbuf =3D code; + pc =3D (uintptr_t)code; + + while (cs_disasm_iter(handle, &cbuf, &size, &pc, insn)) { + (*info->fprintf_func)(info->stream, + "0x%08" PRIx64 ": %-12s %s\n", + insn->address, insn->mnemonic, + insn->op_str); + } + if (size !=3D 0) { + (*info->fprintf_func)(info->stream, + "Disassembler disagrees with TCG over instruction encoding\n" + "Please report this to qemu-devel@nongnu.org\n"); + } + + cs_close(&handle); + return true; +} + +#if !defined(CONFIG_USER_ONLY) +/* Disassemble COUNT insns at PC for the target. */ +static bool cap_disas_monitor(disassemble_info *info, uint64_t pc, int cou= nt) +{ + uint8_t cap_buf[32]; + csh handle; + cs_insn *insn; + size_t csize =3D 0; + + if (cap_disas_start(info, &handle) !=3D CS_ERR_OK) { + return false; + } + insn =3D cap_insn; + + while (1) { + /* We want to read memory for one insn, but generically we do not + know how much memory that is. We have a small buffer which is + known to be sufficient for all supported targets. Try to not + read beyond the page, Just In Case. For even more simplicity, + ignore the actual target page size and use a 1k boundary. If + that turns out to be insufficient, we'll come back around the + loop and read more. */ + uint64_t epc =3D QEMU_ALIGN_UP(pc + csize + 1, 1024); + size_t tsize =3D MIN(sizeof(cap_buf) - csize, epc - pc); + const uint8_t *cbuf =3D cap_buf; + + /* Make certain that we can make progress. */ + assert(tsize !=3D 0); + info->read_memory_func(pc, cap_buf + csize, tsize, info); + csize +=3D tsize; + + if (cs_disasm_iter(handle, &cbuf, &csize, &pc, insn)) { + (*info->fprintf_func)(info->stream, + "0x%08" PRIx64 ": %-12s %s\n", + insn->address, insn->mnemonic, + insn->op_str); + if (--count <=3D 0) { + break; + } + } + memmove(cap_buf, cbuf, csize); + } + + cs_close(&handle); + return true; +} +#endif /* !CONFIG_USER_ONLY */ +#else +# define cap_disas_target(i, p, s) false +# define cap_disas_host(i, p, s) false +# define cap_disas_monitor(i, p, c) false +#endif /* CONFIG_CAPSTONE */ + /* Disassemble this for me please... (debugging). */ void target_disas(FILE *out, CPUState *cpu, target_ulong code, target_ulong size) @@ -188,6 +375,8 @@ void target_disas(FILE *out, CPUState *cpu, target_ulon= g code, s.info.buffer_vma =3D code; s.info.buffer_length =3D size; s.info.print_address_func =3D generic_print_address; + s.info.cap_arch =3D -1; + s.info.cap_mode =3D 0; =20 #ifdef TARGET_WORDS_BIGENDIAN s.info.endian =3D BFD_ENDIAN_BIG; @@ -199,6 +388,10 @@ void target_disas(FILE *out, CPUState *cpu, target_ulo= ng code, cc->disas_set_info(cpu, &s.info); } =20 + if (s.info.cap_arch >=3D 0 && cap_disas_target(&s.info, code, size)) { + return; + } + if (s.info.print_insn =3D=3D NULL) { s.info.print_insn =3D print_insn_od_target; } @@ -206,18 +399,6 @@ void target_disas(FILE *out, CPUState *cpu, target_ulo= ng code, for (pc =3D code; size > 0; pc +=3D count, size -=3D count) { fprintf(out, "0x" TARGET_FMT_lx ": ", pc); count =3D s.info.print_insn(pc, &s.info); -#if 0 - { - int i; - uint8_t b; - fprintf(out, " {"); - for(i =3D 0; i < count; i++) { - target_read_memory(pc + i, &b, 1, &s.info); - fprintf(out, " %02x", b); - } - fprintf(out, " }"); - } -#endif fprintf(out, "\n"); if (count < 0) break; @@ -245,6 +426,8 @@ void disas(FILE *out, void *code, unsigned long size) s.info.buffer =3D code; s.info.buffer_vma =3D (uintptr_t)code; s.info.buffer_length =3D size; + s.info.cap_arch =3D -1; + s.info.cap_mode =3D 0; =20 #ifdef HOST_WORDS_BIGENDIAN s.info.endian =3D BFD_ENDIAN_BIG; @@ -282,6 +465,11 @@ void disas(FILE *out, void *code, unsigned long size) #elif defined(__hppa__) print_insn =3D print_insn_hppa; #endif + + if (s.info.cap_arch >=3D 0 && cap_disas_host(&s.info, code, size)) { + return; + } + if (print_insn =3D=3D NULL) { print_insn =3D print_insn_od_host; } @@ -344,8 +532,9 @@ void monitor_disas(Monitor *mon, CPUState *cpu, monitor_disas_is_physical =3D is_physical; s.info.read_memory_func =3D monitor_read_memory; s.info.print_address_func =3D generic_print_address; - s.info.buffer_vma =3D pc; + s.info.cap_arch =3D -1; + s.info.cap_mode =3D 0; =20 #ifdef TARGET_WORDS_BIGENDIAN s.info.endian =3D BFD_ENDIAN_BIG; @@ -357,6 +546,10 @@ void monitor_disas(Monitor *mon, CPUState *cpu, cc->disas_set_info(cpu, &s.info); } =20 + if (s.info.cap_arch >=3D 0 && cap_disas_monitor(&s.info, pc, nb_insn))= { + return; + } + if (!s.info.print_insn) { monitor_printf(mon, "0x" TARGET_FMT_lx ": Asm output not supported on this arch\n", pc); diff --git a/configure b/configure index 663e9081ea..11e3078936 100755 --- a/configure +++ b/configure @@ -375,6 +375,7 @@ opengl_dmabuf=3D"no" cpuid_h=3D"no" avx2_opt=3D"no" zlib=3D"yes" +capstone=3D"" lzo=3D"" snappy=3D"" bzip2=3D"" @@ -1294,6 +1295,10 @@ for opt do error_exit "vhost-user isn't available on win32" fi ;; + --disable-capstone) capstone=3D"no" + ;; + --enable-capstone) capstone=3D"yes" + ;; *) echo "ERROR: unknown option $opt" echo "Try '$0 --help' for more information" @@ -1541,6 +1546,7 @@ disabled with --disable-FEATURE, default is enabled i= f available: vxhs Veritas HyperScale vDisk backend support crypto-afalg Linux AF_ALG crypto backend driver vhost-user vhost-user support + capstone capstone disassembler support =20 NOTE: The object files are built at the place where configure is launched EOF @@ -4403,6 +4409,22 @@ EOF fi =20 ########################################## +# capstone + +if test "$capstone" !=3D no; then + if $pkg_config capstone; then + capstone=3Dyes + QEMU_CFLAGS=3D"$QEMU_CFLAGS $($pkg_config --cflags capstone)" + LIBS=3D"$($pkg_config --libs capstone) $LIBS" + else + if test "$capstone" =3D yes; then + feature_not_found capstone + fi + capstone=3Dno + fi +fi + +########################################## # check if we have fdatasync =20 fdatasync=3Dno @@ -5460,6 +5482,7 @@ echo "jemalloc support $jemalloc" echo "avx2 optimization $avx2_opt" echo "replication support $replication" echo "VxHS block device $vxhs" +echo "capstone $capstone" =20 if test "$sdl_too_old" =3D "yes"; then echo "-> Your SDL version is too old - please upgrade to have SDL support" @@ -6134,6 +6157,9 @@ fi if test "$ivshmem" =3D "yes" ; then echo "CONFIG_IVSHMEM=3Dy" >> $config_host_mak fi +if test "$capstone" =3D "yes" ; then + echo "CONFIG_CAPSTONE=3Dy" >> $config_host_mak +fi =20 # Hold two types of flag: # CONFIG_THREAD_SETNAME_BYTHREAD - we've got a way of setting the name = on --=20 2.13.6 From nobody Fri May 3 00:00:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1508255033912131.9725071846084; Tue, 17 Oct 2017 08:43:53 -0700 (PDT) Received: from localhost ([::1]:40112 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4U23-0000RU-8Z for importer@patchew.org; Tue, 17 Oct 2017 11:43:51 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55170) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4TwJ-0004HA-Mi for qemu-devel@nongnu.org; Tue, 17 Oct 2017 11:37:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e4TwH-0005nc-CG for qemu-devel@nongnu.org; Tue, 17 Oct 2017 11:37:55 -0400 Received: from mail-pf0-x231.google.com ([2607:f8b0:400e:c00::231]:53806) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e4TwH-0005mS-5g for qemu-devel@nongnu.org; Tue, 17 Oct 2017 11:37:53 -0400 Received: by mail-pf0-x231.google.com with SMTP id t188so1605003pfd.10 for ; Tue, 17 Oct 2017 08:37:53 -0700 (PDT) Received: from cloudburst.twiddle.net (97-126-104-76.tukw.qwest.net. [97.126.104.76]) by smtp.gmail.com with ESMTPSA id y84sm20094415pff.158.2017.10.17.08.37.50 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Oct 2017 08:37:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=GDQ7o8bMA5JYotApUrKVPtviJVZsbS/8pXdXMpY8hDw=; b=d9Kq6KEpiXilScVfWot2KOPWqO9dfpFNSjBZmULt38CF5dp9fK9jcVxCNQQhV1hBla 0j4tVPPuOJXqadkE+gS+ItplmLXm24qOYS+Ds/MVIFoyRmDhQKyqbA8VxbkZAy/Yku4K Jh0BUABkd+TOW6DVsPr9c9sC/tJqNDIsGmLG0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GDQ7o8bMA5JYotApUrKVPtviJVZsbS/8pXdXMpY8hDw=; b=W8k4PBH4CsYZFDviPaQhjXfaOighqyGeyvPfrp9bl1n9vAjW25xFvwsHrhFtvA+ZMa AaCxvrS2q7YiB4jl7rNYiz+GoUzTSz/4f72FE1Jj6pwIsNxuGL0y0CYlztnPPbuu+oTN OXlaLLQyzMpoipZ7HHKIWQIUOuime1PJ+64k9kMf5oaozvcsZWuDJFdCPyNzrJxAikCp jHiESQd/a3MHa6GuSFeH3w1DFaXeFzR7OK7hESKlMDAuVAF1z7kWR74IJ+ZRK9F2J1u1 52T1Z11nsB+GSHeSompW7jUd1R250hY0gY0ne5bYcc1lpWE7Ug2G7aksWVa4mMzY+a8o UtAw== X-Gm-Message-State: AMCzsaWBFwQUsSqWGSdDdSTKCQ39+3dt03W0rHNUGlbTMuxHj9cy6IRl wr13ECytMJu36pw2eJ6hjBxADkeNFOc= X-Google-Smtp-Source: ABhQp+TWbWez1FVPz0sP8aS5ri3R4U4OkwZmPAgdztgIsq4+xBmCcwzdLTaBW+MsC3ohUed0RT8osg== X-Received: by 10.98.33.15 with SMTP id h15mr5244848pfh.319.1508254671774; Tue, 17 Oct 2017 08:37:51 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 17 Oct 2017 08:37:38 -0700 Message-Id: <20171017153742.10026-6-richard.henderson@linaro.org> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20171017153742.10026-1-richard.henderson@linaro.org> References: <20171017153742.10026-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::231 Subject: [Qemu-devel] [PATCH v5 5/9] i386: Support Capstone in disas_set_info X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Tested-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alex Benn=C3=A9e Signed-off-by: Richard Henderson --- disas.c | 4 ++++ target/i386/cpu.c | 7 +++++++ 2 files changed, 11 insertions(+) diff --git a/disas.c b/disas.c index 746d76c07d..1c44514254 100644 --- a/disas.c +++ b/disas.c @@ -439,9 +439,13 @@ void disas(FILE *out, void *code, unsigned long size) #elif defined(__i386__) s.info.mach =3D bfd_mach_i386_i386; print_insn =3D print_insn_i386; + s.info.cap_arch =3D CS_ARCH_X86; + s.info.cap_mode =3D CS_MODE_32; #elif defined(__x86_64__) s.info.mach =3D bfd_mach_x86_64; print_insn =3D print_insn_i386; + s.info.cap_arch =3D CS_ARCH_X86; + s.info.cap_mode =3D CS_MODE_64; #elif defined(_ARCH_PPC) s.info.disassembler_options =3D (char *)"any"; print_insn =3D print_insn_ppc; diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 13b2f8fbc5..cf890b763b 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -51,6 +51,8 @@ #include "hw/i386/apic_internal.h" #endif =20 +#include "disas/capstone.h" + =20 /* Cache topology CPUID constants: */ =20 @@ -4106,6 +4108,11 @@ static void x86_disas_set_info(CPUState *cs, disasse= mble_info *info) : env->hflags & HF_CS32_MASK ? bfd_mach_i386_i386 : bfd_mach_i386_i8086); info->print_insn =3D print_insn_i386; + + info->cap_arch =3D CS_ARCH_X86; + info->cap_mode =3D (env->hflags & HF_CS64_MASK ? CS_MODE_64 + : env->hflags & HF_CS32_MASK ? CS_MODE_32 + : CS_MODE_16); } =20 static Property x86_cpu_properties[] =3D { --=20 2.13.6 From nobody Fri May 3 00:00:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1508255041781823.3611535326968; Tue, 17 Oct 2017 08:44:01 -0700 (PDT) Received: from localhost ([::1]:40113 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4U2D-0000XX-4x for importer@patchew.org; Tue, 17 Oct 2017 11:44:01 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55165) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4TwJ-0004Gx-DQ for qemu-devel@nongnu.org; Tue, 17 Oct 2017 11:37:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e4TwI-0005oh-Dp for qemu-devel@nongnu.org; Tue, 17 Oct 2017 11:37:55 -0400 Received: from mail-pf0-x22d.google.com ([2607:f8b0:400e:c00::22d]:52275) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e4TwI-0005nj-88 for qemu-devel@nongnu.org; Tue, 17 Oct 2017 11:37:54 -0400 Received: by mail-pf0-x22d.google.com with SMTP id e64so1605147pfk.9 for ; Tue, 17 Oct 2017 08:37:54 -0700 (PDT) Received: from cloudburst.twiddle.net (97-126-104-76.tukw.qwest.net. [97.126.104.76]) by smtp.gmail.com with ESMTPSA id y84sm20094415pff.158.2017.10.17.08.37.51 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Oct 2017 08:37:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=3BLOcxnnPg/ZIwB7QEQ1fWCFx1Q2/Js7qiibntMGJnE=; b=PphiX9/gXClcSzdvDqmoSHtqa0U9T26ynFoaWLn4+Z4IidD3/9U5xtGF1gKlcw6Q2C SZvdduXQx4ced+Dj4a4mYVpzLDp0H+Ex0Y8mxdYck+X1D43eR8rS+XYgi4PclClO73IS l+O5/5+aaT3cGPNWP6aN1LMUxK17wzjIj233g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3BLOcxnnPg/ZIwB7QEQ1fWCFx1Q2/Js7qiibntMGJnE=; b=Kf6s3WwSIY2ov+SSSy9+lC4ZhkaO1FR8LAA0XKVHOaANphyXTLt1sJokrBpY9guzCj 42UUvXV1iffluXVzIsLQ4llEd1Kjmh34+UOl12CCnleYMFwWjvsOCpshleu8dw7QI3bK KevJQSl2CMKGAm9Ns+vlR3ohSS1Lc3IQv7N2y0ZrJVBK9gTjd/LsQKt4O9OqF56Az8Q+ qSJa1w9zCs3ZkwMWcoURcJzaq1DBd9UHiF6KgNxxlz24Dtgc3lFRGlp9ZGJNdmyva/mf UZ2XBr1ct6xNC5cKAvoYLxzNCh912MPYeR0KZqw/KGsEeybLuxvQd41LyNOhsix6NIuk foXA== X-Gm-Message-State: AMCzsaVN+Ch5kMOo4TeHbAdiTnfo/ErMon/iQWZG+keVYCp81M6I5J6q uBQ2WvS/nPjhglW97GQy5cLrq+Od0ww= X-Google-Smtp-Source: AOwi7QCvLBaLlhBfA2fkEdGQKEkBF3IwVIvxcgcoHC4hCPOObJlwxxtoHrw6xJt/Qj0bK+Ny4oUPZQ== X-Received: by 10.98.137.156 with SMTP id n28mr12193826pfk.93.1508254672979; Tue, 17 Oct 2017 08:37:52 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 17 Oct 2017 08:37:39 -0700 Message-Id: <20171017153742.10026-7-richard.henderson@linaro.org> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20171017153742.10026-1-richard.henderson@linaro.org> References: <20171017153742.10026-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::22d Subject: [Qemu-devel] [PATCH v5 6/9] arm: Support Capstone in disas_set_info X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Tested-by: Alex Benn=C3=A9e Tested-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alex Benn=C3=A9e Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Richard Henderson --- disas.c | 3 +++ target/arm/cpu.c | 21 ++++++++++++++++++--- 2 files changed, 21 insertions(+), 3 deletions(-) diff --git a/disas.c b/disas.c index 1c44514254..23c4742f8d 100644 --- a/disas.c +++ b/disas.c @@ -451,6 +451,7 @@ void disas(FILE *out, void *code, unsigned long size) print_insn =3D print_insn_ppc; #elif defined(__aarch64__) && defined(CONFIG_ARM_A64_DIS) print_insn =3D print_insn_arm_a64; + s.info.cap_arch =3D CS_ARCH_ARM64; #elif defined(__alpha__) print_insn =3D print_insn_alpha; #elif defined(__sparc__) @@ -458,6 +459,8 @@ void disas(FILE *out, void *code, unsigned long size) s.info.mach =3D bfd_mach_sparc_v9b; #elif defined(__arm__) print_insn =3D print_insn_arm; + s.info.cap_arch =3D CS_ARCH_ARM; + /* TCG only generates code for arm mode. */ #elif defined(__MIPSEB__) print_insn =3D print_insn_big_mips; #elif defined(__MIPSEL__) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index 88578f360e..1576a6d372 100644 --- a/target/arm/cpu.c +++ b/target/arm/cpu.c @@ -33,6 +33,7 @@ #include "sysemu/sysemu.h" #include "sysemu/hw_accel.h" #include "kvm_arm.h" +#include "disas/capstone.h" =20 static void arm_cpu_set_pc(CPUState *cs, vaddr value) { @@ -501,10 +502,24 @@ static void arm_disas_set_info(CPUState *cpu, disasse= mble_info *info) #if defined(CONFIG_ARM_A64_DIS) info->print_insn =3D print_insn_arm_a64; #endif - } else if (env->thumb) { - info->print_insn =3D print_insn_thumb1; + info->cap_arch =3D CS_ARCH_ARM64; } else { - info->print_insn =3D print_insn_arm; + int cap_mode; + if (env->thumb) { + info->print_insn =3D print_insn_thumb1; + cap_mode =3D CS_MODE_THUMB; + } else { + info->print_insn =3D print_insn_arm; + cap_mode =3D CS_MODE_ARM; + } + if (arm_feature(env, ARM_FEATURE_V8)) { + cap_mode |=3D CS_MODE_V8; + } + if (arm_feature(env, ARM_FEATURE_M)) { + cap_mode |=3D CS_MODE_MCLASS; + } + info->cap_arch =3D CS_ARCH_ARM; + info->cap_mode =3D cap_mode; } if (bswap_code(arm_sctlr_b(env))) { #ifdef TARGET_WORDS_BIGENDIAN --=20 2.13.6 From nobody Fri May 3 00:00:10 2024 Delivered-To: importer@patchew.org Received-SPF: temperror (zoho.com: Error in retrieving data from DNS) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 150825483257552.59888948363255; Tue, 17 Oct 2017 08:40:32 -0700 (PDT) Received: from localhost ([::1]:40098 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4Tya-0005mG-ML for importer@patchew.org; Tue, 17 Oct 2017 11:40:16 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55191) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4TwM-0004Jr-Nc for qemu-devel@nongnu.org; Tue, 17 Oct 2017 11:38:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e4TwJ-0005rX-Rb for qemu-devel@nongnu.org; Tue, 17 Oct 2017 11:37:58 -0400 Received: from mail-pg0-x231.google.com ([2607:f8b0:400e:c05::231]:55843) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e4TwJ-0005pZ-Kz for qemu-devel@nongnu.org; Tue, 17 Oct 2017 11:37:55 -0400 Received: by mail-pg0-x231.google.com with SMTP id y184so508981pgd.12 for ; Tue, 17 Oct 2017 08:37:55 -0700 (PDT) Received: from cloudburst.twiddle.net (97-126-104-76.tukw.qwest.net. [97.126.104.76]) by smtp.gmail.com with ESMTPSA id y84sm20094415pff.158.2017.10.17.08.37.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Oct 2017 08:37:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=chfoJBU+nyqcgO2t4lckPD6aYSbxk/BhHT57ZCjJXKc=; b=FPm1df68pbXeSw0DdSErvoKQB4gRSG5TZwaiv9CbeoyYjY7rep4Uk0cuhtNky3NiDk BnnNGYu1CnFQkfDNDshBmrqEsQphml4zrQii1i1d8AFko0MrT0mMe5+dhPIxvtBLNnzq LPOjl9WjOzM+V5eNKA8fYmpNLvFB/VmA5G9kA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=chfoJBU+nyqcgO2t4lckPD6aYSbxk/BhHT57ZCjJXKc=; b=FQP3Cdg5ONf+u9J9xap+YxTBNhICITFW4tumC+XoJYidmNHiISPmXovljQTSibsJDp CeHJ2sFVhrNA2DXTqs4EzAsNDlatm5F3Ta09O1SBaWScsGBAB7MEyFh99x2K9LHz60yr vRM49erEAXWn+ca5CQ4vlhe22qr2P7X7zM+WgIFDy24GwpJSy19t+iAecVUpoCF/G5lu EYze1MTJR9GVIHjzEP0ozNkpP55LCKlLUgX0TpBbUQX4WarybSK1h/oSDUJHMfybKmE3 KKL5QvIT5vw+yf1qePIg27tycvuJqA9mEEzpklfiOzGLwfmDwdw4zQJwHUL0ArWX31Un JqJw== X-Gm-Message-State: AMCzsaW2+Ah0DhYt8l6QJkRrQTetZUwXR7dSzC4bBxs+Lft7SPfAGJdh 4mDDRnhEhGdJLEHgpoOPjO9a+ck/cfk= X-Google-Smtp-Source: ABhQp+Q7zLrhaTrsTK+UsvekYMxEmAvVBAoDuHWtWu7HQVa6c0yXDx0YA3JAymv+5CRoCmBlb7kDag== X-Received: by 10.98.93.136 with SMTP id n8mr4549736pfj.215.1508254674288; Tue, 17 Oct 2017 08:37:54 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 17 Oct 2017 08:37:40 -0700 Message-Id: <20171017153742.10026-8-richard.henderson@linaro.org> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20171017153742.10026-1-richard.henderson@linaro.org> References: <20171017153742.10026-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::231 Subject: [Qemu-devel] [PATCH v5 7/9] ppc: Support Capstone in disas_set_info X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-ppc@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_6 Z_629925259 SPT_0 Cc: qemu-ppc@nongnu.org Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Richard Henderson --- disas.c | 4 ++++ target/ppc/translate_init.c | 6 ++++++ 2 files changed, 10 insertions(+) diff --git a/disas.c b/disas.c index 23c4742f8d..0d212f2ac5 100644 --- a/disas.c +++ b/disas.c @@ -449,6 +449,10 @@ void disas(FILE *out, void *code, unsigned long size) #elif defined(_ARCH_PPC) s.info.disassembler_options =3D (char *)"any"; print_insn =3D print_insn_ppc; + s.info.cap_arch =3D CS_ARCH_PPC; +# ifdef _ARCH_PPC64 + s.info.cap_mode =3D CS_MODE_64; +# endif #elif defined(__aarch64__) && defined(CONFIG_ARM_A64_DIS) print_insn =3D print_insn_arm_a64; s.info.cap_arch =3D CS_ARCH_ARM64; diff --git a/target/ppc/translate_init.c b/target/ppc/translate_init.c index 2863e2c0b0..69a9485f66 100644 --- a/target/ppc/translate_init.c +++ b/target/ppc/translate_init.c @@ -35,6 +35,7 @@ #include "mmu-book3s-v3.h" #include "sysemu/qtest.h" #include "qemu/cutils.h" +#include "disas/capstone.h" =20 //#define PPC_DUMP_CPU //#define PPC_DEBUG_SPR @@ -10699,6 +10700,11 @@ static void ppc_disas_set_info(CPUState *cs, disas= semble_info *info) } info->disassembler_options =3D (char *)"any"; info->print_insn =3D print_insn_ppc; + + info->cap_arch =3D CS_ARCH_PPC; +#ifdef TARGET_PPC64 + info->cap_mode =3D CS_MODE_64; +#endif } =20 static Property ppc_cpu_properties[] =3D { --=20 2.13.6 From nobody Fri May 3 00:00:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1508254927931773.0825286545889; Tue, 17 Oct 2017 08:42:07 -0700 (PDT) Received: from localhost ([::1]:40106 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4U0H-0007Oo-Fs for importer@patchew.org; Tue, 17 Oct 2017 11:42:01 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55221) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4TwQ-0004NG-9Y for qemu-devel@nongnu.org; Tue, 17 Oct 2017 11:38:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e4TwP-00062L-8V for qemu-devel@nongnu.org; Tue, 17 Oct 2017 11:38:02 -0400 Received: from mail-pf0-x233.google.com ([2607:f8b0:400e:c00::233]:57257) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e4TwP-000602-2H for qemu-devel@nongnu.org; Tue, 17 Oct 2017 11:38:01 -0400 Received: by mail-pf0-x233.google.com with SMTP id b85so1602227pfj.13 for ; Tue, 17 Oct 2017 08:38:00 -0700 (PDT) Received: from cloudburst.twiddle.net (97-126-104-76.tukw.qwest.net. [97.126.104.76]) by smtp.gmail.com with ESMTPSA id y84sm20094415pff.158.2017.10.17.08.37.54 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Oct 2017 08:37:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=hka4OKpB1sEXWyM0u9lG2fdZe8a2ld1bOBH1qwvYLsg=; b=QnUjzmiWI0dBlEbxfQxCN/04dHg1smwyFHDkMMzCkTqn/y9Ip71aZe1GxehlwYQlGZ 0DaTpgMX/4TBFaOnXpBtl3tUxJbu6mvIC+neJ3AJXMAPtAyTH62AuqHacmpZdOF5lozf ACOdG+7ffMSe3PANl3+9LtUaNKMuKj1vGunQM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hka4OKpB1sEXWyM0u9lG2fdZe8a2ld1bOBH1qwvYLsg=; b=Q0+CfxOS9kLpZUMHvK0eJ7poFk5GzTkj358+q1J6llLuBoETiYQWhss2sfWiwcp90A YvjPGreJOA6/Uovsp9rI8vmdk4JeqoOc7Wg2UT2SBNREHgyqCQOh8ahX0B0HF0AmUCS+ yTIedy25A2z1AZ7KDXr02Q6zWYEIk2T8m/3KCgIrrtZd8sdS3puvzg+/17koxmDj81VX UCg89giOmeMXd4lNIzgYUXPIji/h7Dpk6uRQLcoKRKk097/mx7PihJuOyMUw5co70yBn zJAnN1ZxY9d3PJvlqnILPjyg4NDYlDTIYRGkK96PQSX051qUHMXRNtok05YWWZS6j0Xm oBpA== X-Gm-Message-State: AMCzsaWzyoAEZG8TPSxEYSxN4ZnqU00V4WNMZBH/ZfNHf6IuffRWLaqj JjVpM84YFeK+7XXCvot+oSDMNEQaOCY= X-Google-Smtp-Source: AOwi7QBMxHL0lgAOGvekyTQxumGk3q3ycovCDCgN/gvTi5Dk3y5fvEWWaVmFKPdRqx03b0HsBcWTYA== X-Received: by 10.99.3.21 with SMTP id 21mr11058460pgd.77.1508254675771; Tue, 17 Oct 2017 08:37:55 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 17 Oct 2017 08:37:41 -0700 Message-Id: <20171017153742.10026-9-richard.henderson@linaro.org> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20171017153742.10026-1-richard.henderson@linaro.org> References: <20171017153742.10026-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::233 Subject: [Qemu-devel] [PATCH v5 8/9] disas: Remove monitor_disas_is_physical X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Even though there is only one monitor, and thus no race on this global data object, there is also no point in having it. We can just as well record the decision in the read_memory_function that we select. Tested-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alex Benn=C3=A9e Signed-off-by: Richard Henderson --- disas.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/disas.c b/disas.c index 0d212f2ac5..194c523885 100644 --- a/disas.c +++ b/disas.c @@ -513,19 +513,11 @@ const char *lookup_symbol(target_ulong orig_addr) =20 #include "monitor/monitor.h" =20 -static int monitor_disas_is_physical; - static int -monitor_read_memory (bfd_vma memaddr, bfd_byte *myaddr, int length, +physical_read_memory(bfd_vma memaddr, bfd_byte *myaddr, int length, struct disassemble_info *info) { - CPUDebug *s =3D container_of(info, CPUDebug, info); - - if (monitor_disas_is_physical) { - cpu_physical_memory_read(memaddr, myaddr, length); - } else { - cpu_memory_rw_debug(s->cpu, memaddr, myaddr, length, 0); - } + cpu_physical_memory_read(memaddr, myaddr, length); return 0; } =20 @@ -540,8 +532,8 @@ void monitor_disas(Monitor *mon, CPUState *cpu, INIT_DISASSEMBLE_INFO(s.info, (FILE *)mon, monitor_fprintf); =20 s.cpu =3D cpu; - monitor_disas_is_physical =3D is_physical; - s.info.read_memory_func =3D monitor_read_memory; + s.info.read_memory_func + =3D (is_physical ? physical_read_memory : target_read_memory); s.info.print_address_func =3D generic_print_address; s.info.buffer_vma =3D pc; s.info.cap_arch =3D -1; --=20 2.13.6 From nobody Fri May 3 00:00:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 150825514505090.87154197777807; Tue, 17 Oct 2017 08:45:45 -0700 (PDT) Received: from localhost ([::1]:40121 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4U3o-0001lD-Cz for importer@patchew.org; Tue, 17 Oct 2017 11:45:40 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55200) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4TwN-0004L4-Vl for qemu-devel@nongnu.org; Tue, 17 Oct 2017 11:38:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e4TwM-0005wx-Tx for qemu-devel@nongnu.org; Tue, 17 Oct 2017 11:37:59 -0400 Received: from mail-pf0-x232.google.com ([2607:f8b0:400e:c00::232]:46979) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e4TwM-0005vK-O3 for qemu-devel@nongnu.org; Tue, 17 Oct 2017 11:37:58 -0400 Received: by mail-pf0-x232.google.com with SMTP id p87so1615909pfj.3 for ; Tue, 17 Oct 2017 08:37:58 -0700 (PDT) Received: from cloudburst.twiddle.net (97-126-104-76.tukw.qwest.net. [97.126.104.76]) by smtp.gmail.com with ESMTPSA id y84sm20094415pff.158.2017.10.17.08.37.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Oct 2017 08:37:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=IhrehGFXNdn1g4MNkKTsmaTJS+p2x52QVd3uxxOAr/A=; b=GeryctdaIeQjtYrnoEAGYAetUoCe2D4gdtTneWQP2RxIwJa5LU0pOeqrkzr4nYEsH2 QW7DG1s5mY5CX9cU2xYoe0/JHkPHFAvovHqT86qrmRWJQVoa1C79GJW1XtP3LgRQR6hC G2PX3qmXvq0e1a9Tti6+vulK/5dziOAYxM1gA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=IhrehGFXNdn1g4MNkKTsmaTJS+p2x52QVd3uxxOAr/A=; b=tIBEbWKTGqWIlH4yk/zkNs5Fe0Z3aJAajIBkOQuQc6ZWN9R3RvNxnkPHd31W/awQPF TBG1JgncDJsQcVQLRAlVuTcwAqEWV2FehDpbzwn6hLZqDHJ9HUtzAEkNxIqxU7iAUEue jsiAu5eLW1rCV4ONrvRL+fjYACzEEvptw/b7eKa4JTdZnLVHaOgz6fEJmaiB5rB4V+Nd bUlf0JPtM4Wxpf4I9Aw+gQnUYCqMx2rHtiO9H5zt6UgK4FzMvpoksrdoieHUwqkie38j IluJtykJbSFx5BEXkwHkYpHQqMk1q7pty/SVLxFSEUbT+xGxuhwxCYUawZCz/K5j/UvX QO8A== X-Gm-Message-State: AMCzsaWmyA2RKOq6kH30V4IivNJwRVxZIj/XpCwMjxZrdVP0wSyeLXfv k3iIzYn1lxK3nFxT3D6nIdAqfN2dswY= X-Google-Smtp-Source: AOwi7QDEcyvkA3RhdVqLze5qC5NXmCGbPzyNlYv/yDg/mEIMkRCasmCLEUbPyLgy9I8LLN3t4X6ExA== X-Received: by 10.99.95.203 with SMTP id t194mr9406426pgb.318.1508254677247; Tue, 17 Oct 2017 08:37:57 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 17 Oct 2017 08:37:42 -0700 Message-Id: <20171017153742.10026-10-richard.henderson@linaro.org> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20171017153742.10026-1-richard.henderson@linaro.org> References: <20171017153742.10026-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::232 Subject: [Qemu-devel] [PATCH v5 9/9] disas: Add capstone as submodule X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Do not require the submodule, but use it if present (in preference even to a system copy). This will allow us to easily use capstone in older systems for which a package is not available, and also easily track bug fixes from upstream. Cc: Gerd Hoffmann Signed-off-by: Richard Henderson --- Makefile | 13 +++++++++++++ .gitmodules | 3 +++ capstone | 1 + configure | 13 ++++++++++++- 4 files changed, 29 insertions(+), 1 deletion(-) create mode 160000 capstone diff --git a/Makefile b/Makefile index 90f91e54eb..ca5eb489b0 100644 --- a/Makefile +++ b/Makefile @@ -383,6 +383,19 @@ subdir-dtc: .git-submodule-status dtc/libfdt dtc/tests dtc/%: mkdir -p $@ =20 +# Overriding CFLAGS causes us to lose defines added in the sub-makefile. +# Not overriding CFLAGS leads to mis-matches between compilation modes. +# Therefore we replicate some of the logic in the sub-makefile. +CAP_CFLAGS =3D $(subst -Werror,,$(CFLAGS) $(QEMU_CFLAGS)) +CAP_CFLAGS +=3D -DCAPSTONE_USE_SYS_DYN_MEM +CAP_CFLAGS +=3D -DCAPSTONE_HAS_ARM +CAP_CFLAGS +=3D -DCAPSTONE_HAS_ARM64 +CAP_CFLAGS +=3D -DCAPSTONE_HAS_POWERPC +CAP_CFLAGS +=3D -DCAPSTONE_HAS_X86 + +subdir-capstone: .git-submodule-status + $(call quiet-command,$(MAKE) -C $(SRC_PATH)/capstone CAPSTONE_SHARED=3Dno= BUILDDIR=3D"$(BUILD_DIR)/capstone" CC=3D"$(CC)" AR=3D"$(AR)" LD=3D"$(LD)" = CFLAGS=3D"$(CAP_CFLAGS)" $(SUBDIR_MAKEFLAGS) $(BUILD_DIR)/capstone/libcapst= one.a) + $(SUBDIR_RULES): libqemuutil.a $(common-obj-y) $(chardev-obj-y) \ $(qom-obj-y) $(crypto-aes-obj-$(CONFIG_USER_ONLY)) =20 diff --git a/.gitmodules b/.gitmodules index 7c981a42b6..1500579638 100644 --- a/.gitmodules +++ b/.gitmodules @@ -37,3 +37,6 @@ [submodule "ui/keycodemapdb"] path =3D ui/keycodemapdb url =3D git://git.qemu.org/keycodemapdb.git +[submodule "capstone"] + path =3D capstone + url =3D git://git.qemu.org/capstone.git diff --git a/capstone b/capstone new file mode 160000 index 0000000000..a279481dbf --- /dev/null +++ b/capstone @@ -0,0 +1 @@ +Subproject commit a279481dbfd54bb1e2336d771e89978cc6d43176 diff --git a/configure b/configure index 11e3078936..5a305c0a69 100755 --- a/configure +++ b/configure @@ -4412,7 +4412,15 @@ fi # capstone =20 if test "$capstone" !=3D no; then - if $pkg_config capstone; then + # have GIT checkout, so activate capstone submodule + if test -e "${source_path}/.git" ; then + git_submodules=3D"${git_submodules} capstone" + capstone=3Dyes + capstone_internal=3Dyes + mkdir -p capstone + QEMU_CFLAGS=3D"$QEMU_CFLAGS -I\$(SRC_PATH)/capstone/include" + LIBS=3D"\$(BUILD_DIR)/capstone/libcapstone.a $LIBS" + elif $pkg_config capstone; then capstone=3Dyes QEMU_CFLAGS=3D"$QEMU_CFLAGS $($pkg_config --cflags capstone)" LIBS=3D"$($pkg_config --libs capstone) $LIBS" @@ -6642,6 +6650,9 @@ done # for target in $targets if [ "$dtc_internal" =3D "yes" ]; then echo "config-host.h: subdir-dtc" >> $config_host_mak fi +if [ "$capstone_internal" =3D "yes" ]; then + echo "config-host.h: subdir-capstone" >> $config_host_mak +fi =20 if test "$numa" =3D "yes"; then echo "CONFIG_NUMA=3Dy" >> $config_host_mak --=20 2.13.6