[Qemu-devel] [PATCH v2] Update James Hogan's email address

james.hogan@imgtec.com posted 1 patch 6 years, 6 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20171017141311.22194-1-james.hogan@imgtec.com
Test checkpatch passed
Test docker passed
Test s390x passed
.mailmap    | 1 +
MAINTAINERS | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
[Qemu-devel] [PATCH v2] Update James Hogan's email address
Posted by james.hogan@imgtec.com 6 years, 6 months ago
From: James Hogan <james.hogan@imgtec.com>

Update my imgtec.com email address to my kernel.org one in MAINTAINERS
as MIPS will soon no longer be part of Imagination Technologies, and add
a mapping in .mailcap so get_maintainer.pl reports the right address.

Signed-off-by: James Hogan <james.hogan@imgtec.com>
Cc: Michael Tokarev <mjt@tls.msk.ru>
Cc: Laurent Vivier <laurent@vivier.eu>
Cc: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
---
Changes in v2:
- Use my imgtec address as the author / SoB (Laurent Vivier)
---
 .mailmap    | 1 +
 MAINTAINERS | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/.mailmap b/.mailmap
index 28defa1b2c57..5aec1bdf9f7d 100644
--- a/.mailmap
+++ b/.mailmap
@@ -8,6 +8,7 @@ Aurelien Jarno <aurelien@aurel32.net> aurel32 <aurel32@c046a42c-6fe2-441c-8c8c-7
 Blue Swirl <blauwirbel@gmail.com> blueswir1 <blueswir1@c046a42c-6fe2-441c-8c8c-71466251a162>
 Edgar E. Iglesias <edgar.iglesias@gmail.com> edgar_igl <edgar_igl@c046a42c-6fe2-441c-8c8c-71466251a162>
 Fabrice Bellard <fabrice@bellard.org> bellard <bellard@c046a42c-6fe2-441c-8c8c-71466251a162>
+James Hogan <jhogan@kernel.org> <james.hogan@imgtec.com>
 Jocelyn Mayer <l_indien@magic.fr> j_mayer <j_mayer@c046a42c-6fe2-441c-8c8c-71466251a162>
 Paul Brook <paul@codesourcery.com> pbrook <pbrook@c046a42c-6fe2-441c-8c8c-71466251a162>
 Thiemo Seufer <ths@networkno.de> ths <ths@c046a42c-6fe2-441c-8c8c-71466251a162>
diff --git a/MAINTAINERS b/MAINTAINERS
index 9522d1b621bd..b01f5c46ef83 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -284,7 +284,7 @@ S: Maintained
 F: target/arm/kvm.c
 
 MIPS
-M: James Hogan <james.hogan@imgtec.com>
+M: James Hogan <jhogan@kernel.org>
 S: Maintained
 F: target/mips/kvm.c
 
-- 
2.14.1


Re: [Qemu-devel] [PATCH v2] Update James Hogan's email address
Posted by Laurent Vivier 6 years, 6 months ago
Le 17/10/2017 à 16:13, james.hogan@imgtec.com a écrit :
> From: James Hogan <james.hogan@imgtec.com>
> 
> Update my imgtec.com email address to my kernel.org one in MAINTAINERS
> as MIPS will soon no longer be part of Imagination Technologies, and add
> a mapping in .mailcap so get_maintainer.pl reports the right address.
> 
> Signed-off-by: James Hogan <james.hogan@imgtec.com>
> Cc: Michael Tokarev <mjt@tls.msk.ru>
> Cc: Laurent Vivier <laurent@vivier.eu>
> Cc: qemu-devel@nongnu.org
> Cc: qemu-trivial@nongnu.org
> ---
> Changes in v2:
> - Use my imgtec address as the author / SoB (Laurent Vivier)
> ---
>  .mailmap    | 1 +
>  MAINTAINERS | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/.mailmap b/.mailmap
> index 28defa1b2c57..5aec1bdf9f7d 100644
> --- a/.mailmap
> +++ b/.mailmap
> @@ -8,6 +8,7 @@ Aurelien Jarno <aurelien@aurel32.net> aurel32 <aurel32@c046a42c-6fe2-441c-8c8c-7
>  Blue Swirl <blauwirbel@gmail.com> blueswir1 <blueswir1@c046a42c-6fe2-441c-8c8c-71466251a162>
>  Edgar E. Iglesias <edgar.iglesias@gmail.com> edgar_igl <edgar_igl@c046a42c-6fe2-441c-8c8c-71466251a162>
>  Fabrice Bellard <fabrice@bellard.org> bellard <bellard@c046a42c-6fe2-441c-8c8c-71466251a162>
> +James Hogan <jhogan@kernel.org> <james.hogan@imgtec.com>
>  Jocelyn Mayer <l_indien@magic.fr> j_mayer <j_mayer@c046a42c-6fe2-441c-8c8c-71466251a162>
>  Paul Brook <paul@codesourcery.com> pbrook <pbrook@c046a42c-6fe2-441c-8c8c-71466251a162>
>  Thiemo Seufer <ths@networkno.de> ths <ths@c046a42c-6fe2-441c-8c8c-71466251a162>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 9522d1b621bd..b01f5c46ef83 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -284,7 +284,7 @@ S: Maintained
>  F: target/arm/kvm.c
>  
>  MIPS
> -M: James Hogan <james.hogan@imgtec.com>
> +M: James Hogan <jhogan@kernel.org>
>  S: Maintained
>  F: target/mips/kvm.c
>  
> 

Thank you.

I don't understand why you need to update the .mailmap: updating the
MAINTAINERS file should be enough to have the correct address with
get_maintainer.pl?

Thanks,
Laurent

Re: [Qemu-devel] [PATCH v2] Update James Hogan's email address
Posted by Peter Maydell 6 years, 6 months ago
On 17 October 2017 at 15:21, Laurent Vivier <laurent@vivier.eu> wrote:
> I don't understand why you need to update the .mailmap: updating the
> MAINTAINERS file should be enough to have the correct address with
> get_maintainer.pl?

A mailmap update is also useful if you care about your ranking
in the 'git shortlog -nse' high score table :-)

thanks
-- PMM

Re: [Qemu-devel] [PATCH v2] Update James Hogan's email address
Posted by James Hogan 6 years, 6 months ago
On Tue, Oct 17, 2017 at 04:21:13PM +0200, Laurent Vivier wrote:
> Le 17/10/2017 à 16:13, james.hogan@imgtec.com a écrit :
> > From: James Hogan <james.hogan@imgtec.com>
> > 
> > Update my imgtec.com email address to my kernel.org one in MAINTAINERS
> > as MIPS will soon no longer be part of Imagination Technologies, and add
> > a mapping in .mailcap so get_maintainer.pl reports the right address.
> > 
> > Signed-off-by: James Hogan <james.hogan@imgtec.com>
> > Cc: Michael Tokarev <mjt@tls.msk.ru>
> > Cc: Laurent Vivier <laurent@vivier.eu>
> > Cc: qemu-devel@nongnu.org
> > Cc: qemu-trivial@nongnu.org
> > ---
> > Changes in v2:
> > - Use my imgtec address as the author / SoB (Laurent Vivier)
> > ---
> >  .mailmap    | 1 +
> >  MAINTAINERS | 2 +-
> >  2 files changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/.mailmap b/.mailmap
> > index 28defa1b2c57..5aec1bdf9f7d 100644
> > --- a/.mailmap
> > +++ b/.mailmap
> > @@ -8,6 +8,7 @@ Aurelien Jarno <aurelien@aurel32.net> aurel32 <aurel32@c046a42c-6fe2-441c-8c8c-7
> >  Blue Swirl <blauwirbel@gmail.com> blueswir1 <blueswir1@c046a42c-6fe2-441c-8c8c-71466251a162>
> >  Edgar E. Iglesias <edgar.iglesias@gmail.com> edgar_igl <edgar_igl@c046a42c-6fe2-441c-8c8c-71466251a162>
> >  Fabrice Bellard <fabrice@bellard.org> bellard <bellard@c046a42c-6fe2-441c-8c8c-71466251a162>
> > +James Hogan <jhogan@kernel.org> <james.hogan@imgtec.com>
> >  Jocelyn Mayer <l_indien@magic.fr> j_mayer <j_mayer@c046a42c-6fe2-441c-8c8c-71466251a162>
> >  Paul Brook <paul@codesourcery.com> pbrook <pbrook@c046a42c-6fe2-441c-8c8c-71466251a162>
> >  Thiemo Seufer <ths@networkno.de> ths <ths@c046a42c-6fe2-441c-8c8c-71466251a162>
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 9522d1b621bd..b01f5c46ef83 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -284,7 +284,7 @@ S: Maintained
> >  F: target/arm/kvm.c
> >  
> >  MIPS
> > -M: James Hogan <james.hogan@imgtec.com>
> > +M: James Hogan <jhogan@kernel.org>
> >  S: Maintained
> >  F: target/mips/kvm.c
> >  
> > 
> 
> Thank you.
> 
> I don't understand why you need to update the .mailmap: updating the
> MAINTAINERS file should be enough to have the correct address with
> get_maintainer.pl?

It allows get_maintainer.pl results based on git history (e.g. git
blame) to show the up to date address. Admitedly I based that on my
equivalent patch for the Linux kernel, so perhaps it is less relevant
with QEMU?

Cheers
James
Re: [Qemu-devel] [PATCH v2] Update James Hogan's email address
Posted by Laurent Vivier 6 years, 6 months ago
Le 17/10/2017 à 16:13, james.hogan@imgtec.com a écrit :
> From: James Hogan <james.hogan@imgtec.com>
> 
> Update my imgtec.com email address to my kernel.org one in MAINTAINERS
> as MIPS will soon no longer be part of Imagination Technologies, and add
> a mapping in .mailcap so get_maintainer.pl reports the right address.
> 
> Signed-off-by: James Hogan <james.hogan@imgtec.com>
> Cc: Michael Tokarev <mjt@tls.msk.ru>
> Cc: Laurent Vivier <laurent@vivier.eu>
> Cc: qemu-devel@nongnu.org
> Cc: qemu-trivial@nongnu.org
> ---
> Changes in v2:
> - Use my imgtec address as the author / SoB (Laurent Vivier)
> ---
>  .mailmap    | 1 +
>  MAINTAINERS | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Laurent Vivier <laurent@vivier.eu>