docker: cleanup temp directory after test

[Qemu-devel] [PATCH] docker: cleanup temp directory after test

Posted by Peter Xu 6 years, 6 months ago

There are temp directories named "docker-src.*" after doing docker
tests.  I don't see much point in keeping that (it only contains the
qemu.tar which is exactly current tree, and the copied "run" file).
Let's remove it after test finished.

CC: "Alex Bennée" <alex.bennee@linaro.org>
CC: Fam Zheng <famz@redhat.com>
CC: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
 tests/docker/Makefile.include | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
index 6f9ea196a7..c8fbd37127 100644
--- a/tests/docker/Makefile.include
+++ b/tests/docker/Makefile.include
@@ -151,6 +151,8 @@ docker-run: docker-qemu-src
 			$(IMAGE) 					\
 			/var/tmp/qemu/run 				\
 			$(TEST), "  RUN $(TEST) in ${IMAGE}")
+	$(call quiet-command, rm -r $(DOCKER_SRC_COPY), \
+		"  CLEANUP $(DOCKER_SRC_COPY)")
 
 # Run targets:
 #
-- 
2.13.5

Re: [Qemu-devel] [PATCH] docker: cleanup temp directory after test

Posted by Fam Zheng 6 years, 6 months ago

On Tue, 10/17 15:12, Peter Xu wrote:
> There are temp directories named "docker-src.*" after doing docker
> tests.  I don't see much point in keeping that (it only contains the
> qemu.tar which is exactly current tree, and the copied "run" file).
> Let's remove it after test finished.
> 
> CC: "Alex Bennée" <alex.bennee@linaro.org>
> CC: Fam Zheng <famz@redhat.com>
> CC: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>  tests/docker/Makefile.include | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
> index 6f9ea196a7..c8fbd37127 100644
> --- a/tests/docker/Makefile.include
> +++ b/tests/docker/Makefile.include
> @@ -151,6 +151,8 @@ docker-run: docker-qemu-src
>  			$(IMAGE) 					\
>  			/var/tmp/qemu/run 				\
>  			$(TEST), "  RUN $(TEST) in ${IMAGE}")
> +	$(call quiet-command, rm -r $(DOCKER_SRC_COPY), \
> +		"  CLEANUP $(DOCKER_SRC_COPY)")
>  
>  # Run targets:
>  #
> -- 
> 2.13.5
> 
> 

Reviewed-by: Fam Zheng <famz@redhat.com>

Re: [Qemu-devel] [PATCH] docker: cleanup temp directory after test

Posted by Fam Zheng 6 years, 6 months ago

On Tue, 10/17 15:12, Peter Xu wrote:
> There are temp directories named "docker-src.*" after doing docker
> tests.  I don't see much point in keeping that (it only contains the
> qemu.tar which is exactly current tree, and the copied "run" file).
> Let's remove it after test finished.
> 
> CC: "Alex Bennée" <alex.bennee@linaro.org>
> CC: Fam Zheng <famz@redhat.com>
> CC: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>  tests/docker/Makefile.include | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
> index 6f9ea196a7..c8fbd37127 100644
> --- a/tests/docker/Makefile.include
> +++ b/tests/docker/Makefile.include
> @@ -151,6 +151,8 @@ docker-run: docker-qemu-src
>  			$(IMAGE) 					\
>  			/var/tmp/qemu/run 				\
>  			$(TEST), "  RUN $(TEST) in ${IMAGE}")
> +	$(call quiet-command, rm -r $(DOCKER_SRC_COPY), \
> +		"  CLEANUP $(DOCKER_SRC_COPY)")
>  
>  # Run targets:
>  #
> -- 
> 2.13.5
> 
> 

Applied, thanks!

Fam