From nobody Thu May 2 12:51:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1508224465333298.78074704711594; Tue, 17 Oct 2017 00:14:25 -0700 (PDT) Received: from localhost ([::1]:36908 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4M4a-0006Lr-Rd for importer@patchew.org; Tue, 17 Oct 2017 03:13:56 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35159) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4M3W-0005ur-JN for qemu-devel@nongnu.org; Tue, 17 Oct 2017 03:12:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e4M3T-0001ah-EH for qemu-devel@nongnu.org; Tue, 17 Oct 2017 03:12:50 -0400 Received: from m15-113.126.com ([220.181.15.113]:55235) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4M3S-0001ZH-Mm for qemu-devel@nongnu.org; Tue, 17 Oct 2017 03:12:47 -0400 Received: from localhost.localdomain (unknown [58.213.111.46]) by smtp3 (Coremail) with SMTP id DcmowAC3ffI0puVZMSzCAg--.13530S2; Tue, 17 Oct 2017 14:42:13 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id; bh=E2dqNauLr3j/nPoQyW 3JMhg+fSKvdGSg3dratK1AhDA=; b=mku62QfwNB3lP6XL+f4XZJN3UaGyxnXiTp DhWsii0bD0UnY2ompsRj22SHMrZjf4E5RVgjYjoVpxJerMmul/98XZx/xZMuanw/ iZajbjVbtwsOe1GtjtCVNpgvY5xXUL1fioA4SM6g1xxodv4XClatQ48oJRmWuy80 nht6GyQ9E= From: Chen Hanxiao To: qemu-devel@nongnu.org Date: Tue, 17 Oct 2017 14:41:42 +0800 Message-Id: <20171017064142.4519-1-chen_han_xiao@126.com> X-Mailer: git-send-email 2.13.5 X-CM-TRANSID: DcmowAC3ffI0puVZMSzCAg--.13530S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7tF4fGFWkXryxuw13ZFyfCrg_yoW8Xr45pF 4xGFsIk3y8tr42yFySga48JF4fA395Cr1Dur1qkw1UZFs3Was8Aws7AF9Y9r4fAr48tw1f uryDtrZa93yjvw7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07j2-eOUUUUU= X-Originating-IP: [58.213.111.46] X-CM-SenderInfo: xfkh0spkdqs5xldrqiyswou0bp/1tbikRF0rlP7L3SBTAAAsk X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 220.181.15.113 Subject: [Qemu-devel] [Resend][PATCH] qga-win: don't hang if vss hold writes timeout X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomoki Sekiyama , Michael Roth , Chen Hanxiao Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Chen Hanxiao When VM is in a heavy IO, if the command "guest-fsfreeze-freeze" is executed, VSS may timeout when trying to hold writes. Inside guest, Event ID 12298(VSS_ERROR_HOLD_WRITES_TIMEOUT) is logged in the Event Viewer. At that time, if we call AbortBackup, qga may hang forever. This patch will solve this issue. Cc: Michael Roth Cc: Tomoki Sekiyama Reviewed-by: Tomoki Sekiyama Signed-off-by: Chen Hanxiao --- qga/vss-win32/requester.cpp | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/qga/vss-win32/requester.cpp b/qga/vss-win32/requester.cpp index 301762d8b1..3d9c9716c0 100644 --- a/qga/vss-win32/requester.cpp +++ b/qga/vss-win32/requester.cpp @@ -419,6 +419,16 @@ void requester_freeze(int *num_vols, ErrorSet *errset) break; } } + + if (wait_status =3D=3D WAIT_TIMEOUT) { + err_set(errset, E_FAIL, + "timeout when try to receive Frozen event from VSS provide= r"); + /* If we are here, VSS had timeout. + * Don't call AbortBackup, just return directly. + */ + goto out1; + } + if (wait_status !=3D WAIT_OBJECT_0) { err_set(errset, E_FAIL, "couldn't receive Frozen event from VSS provider"); @@ -432,6 +442,8 @@ out: if (vss_ctx.pVssbc) { vss_ctx.pVssbc->AbortBackup(); } + +out1: requester_cleanup(); CoUninitialize(); } --=20 2.13.5