1. Patchew
  2. QEMU
  3. View series

[Qemu-devel] [PATCH] docker: Don't allocate tty unless DEBUG=1

Fam Zheng posted 1 patch 6 years, 6 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20171013011954.9975-1-famz@redhat.com
Test checkpatch passed
Test docker passed
Test s390x passed
tests/docker/Makefile.include | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[Qemu-devel] [PATCH] docker: Don't allocate tty unless DEBUG=1
Posted by Fam Zheng 6 years, 6 months ago 
The existence of tty in the container seems to urge gcc into colorize
the output, but the escape chars will clutter the report once turned
into email replies on patchew. Move -t to debug mode.

Reported-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
---
 tests/docker/Makefile.include | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
index 6f9ea196a7..ab939f2bec 100644
--- a/tests/docker/Makefile.include
+++ b/tests/docker/Makefile.include
@@ -134,10 +134,10 @@ docker-run: docker-qemu-src
 			"  COPYING $(EXECUTABLE) to $(IMAGE)"))
 	$(call quiet-command,						\
 		$(SRC_PATH)/tests/docker/docker.py run 			\
-			$(if $(NOUSER),,-u $(shell id -u)) -t 		\
+			$(if $(NOUSER),,-u $(shell id -u)) 		\
 			--security-opt seccomp=unconfined		\
 			$(if $V,,--rm) 					\
-			$(if $(DEBUG),-i,)				\
+			$(if $(DEBUG),-ti,)				\
 			$(if $(NETWORK),$(if $(subst $(NETWORK),,1),--net=$(NETWORK)),--net=none) \
 			-e TARGET_LIST=$(TARGET_LIST) 			\
 			-e EXTRA_CONFIGURE_OPTS="$(EXTRA_CONFIGURE_OPTS)" \
-- 
2.13.5
Re: [Qemu-devel] [PATCH] docker: Don't allocate tty unless DEBUG=1
Posted by Alex Bennée 6 years, 6 months ago 
Fam Zheng <famz@redhat.com> writes:

> The existence of tty in the container seems to urge gcc into colorize
> the output, but the escape chars will clutter the report once turned
> into email replies on patchew. Move -t to debug mode.
>
> Reported-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Fam Zheng <famz@redhat.com>

I certainly improves my Emacs compilation-mode buffer when applied:

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

> ---
>  tests/docker/Makefile.include | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
> index 6f9ea196a7..ab939f2bec 100644
> --- a/tests/docker/Makefile.include
> +++ b/tests/docker/Makefile.include
> @@ -134,10 +134,10 @@ docker-run: docker-qemu-src
>  			"  COPYING $(EXECUTABLE) to $(IMAGE)"))
>  	$(call quiet-command,						\
>  		$(SRC_PATH)/tests/docker/docker.py run 			\
> -			$(if $(NOUSER),,-u $(shell id -u)) -t 		\
> +			$(if $(NOUSER),,-u $(shell id -u)) 		\
>  			--security-opt seccomp=unconfined		\
>  			$(if $V,,--rm) 					\
> -			$(if $(DEBUG),-i,)				\
> +			$(if $(DEBUG),-ti,)				\
>  			$(if $(NETWORK),$(if $(subst $(NETWORK),,1),--net=$(NETWORK)),--net=none) \
>  			-e TARGET_LIST=$(TARGET_LIST) 			\
>  			-e EXTRA_CONFIGURE_OPTS="$(EXTRA_CONFIGURE_OPTS)" \


--
Alex Bennée
Re: [Qemu-devel] [PATCH] docker: Don't allocate tty unless DEBUG=1
Posted by Fam Zheng 6 years, 6 months ago 
On Fri, 10/13 10:35, Alex Bennée wrote:
> 
> Fam Zheng <famz@redhat.com> writes:
> 
> > The existence of tty in the container seems to urge gcc into colorize
> > the output, but the escape chars will clutter the report once turned
> > into email replies on patchew. Move -t to debug mode.
> >
> > Reported-by: Eric Blake <eblake@redhat.com>
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> 
> I certainly improves my Emacs compilation-mode buffer when applied:
> 
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

Nice, thanks! I'll send a pull request soon.

Fam

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.