There are (at least...) two bugs in preallocated truncation, which this
series fixes.

Both would have been apparent if the the related iotest had used the
default cluster size in addition to 512 byte clusters, but alas, it did
not.  This is remedied by patch 3 of this series.


Max Reitz (3):
  qcow2: Fix unaligned preallocated truncation
  qcow2: Always execute preallocate() in a coroutine
  iotests: Add cluster_size=64k to 125

 block/qcow2.c              |  42 +++-
 tests/qemu-iotests/125     |   7 +-
 tests/qemu-iotests/125.out | 480 ++++++++++++++++++++++++++++++++++++++++-----
 3 files changed, 472 insertions(+), 57 deletions(-)

-- 
2.13.6

On 2017-10-09 23:55, Max Reitz wrote:
> There are (at least...) two bugs in preallocated truncation, which this
> series fixes.
> 
> Both would have been apparent if the the related iotest had used the
> default cluster size in addition to 512 byte clusters, but alas, it did
> not.  This is remedied by patch 3 of this series.
> 
> 
> Max Reitz (3):
>   qcow2: Fix unaligned preallocated truncation
>   qcow2: Always execute preallocate() in a coroutine
>   iotests: Add cluster_size=64k to 125
> 
>  block/qcow2.c              |  42 +++-
>  tests/qemu-iotests/125     |   7 +-
>  tests/qemu-iotests/125.out | 480 ++++++++++++++++++++++++++++++++++++++++-----
>  3 files changed, 472 insertions(+), 57 deletions(-)

Thanks for the reviews, changed the reporter name to Ping Li in patch 1,
dropped the superfluous "struct" from patch 2, and applied to my block
branch:

https://github.com/XanClic/qemu/commits/block

Max

On Mon, Oct 09, 2017 at 11:55:30PM +0200, Max Reitz wrote:
> There are (at least...) two bugs in preallocated truncation, which this
> series fixes.
> 
> Both would have been apparent if the the related iotest had used the
> default cluster size in addition to 512 byte clusters, but alas, it did
> not.  This is remedied by patch 3 of this series.
> 
> 
> Max Reitz (3):
>   qcow2: Fix unaligned preallocated truncation
>   qcow2: Always execute preallocate() in a coroutine
>   iotests: Add cluster_size=64k to 125
> 
>  block/qcow2.c              |  42 +++-
>  tests/qemu-iotests/125     |   7 +-
>  tests/qemu-iotests/125.out | 480 ++++++++++++++++++++++++++++++++++++++++-----
>  3 files changed, 472 insertions(+), 57 deletions(-)
> 
> -- 
> 2.13.6
> 

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>