During my quest to switch block status to be byte-based, John
forced me to evaluate whether we have a situation during
copy-on-read where we could exceed BDRV_REQUEST_MAX_BYTES [1].
Sure enough, we have a number of pre-existing bugs in the
copy-on-read code. Fix those, along with adding a test.
Available as a tag at:
git fetch git://repo.or.cz/qemu/ericb.git nbd-copy-on-read-v3
Since v2 (available at [2]):
- add a new patch to fix an iotests wart
- tweak patch 5 (now 6) to skip rather than fail on limited memory [patchew]
- tweak patch 2 condition for legibility [Stefan]
- add R-b
[1] https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg07286.html
[2] https://lists.gnu.org/archive/html/qemu-devel/2017-10/msg00524.html
001/6:[----] [--] 'qemu-io: Add -C for opening with copy-on-read'
002/6:[0008] [FC] 'block: Uniform handling of 0-length bdrv_get_block_status()'
003/6:[down] 'iotests: Restore stty settings on completion'
004/6:[----] [--] 'block: Add blkdebug hook for copy-on-read'
005/6:[----] [--] 'block: Perform copy-on-read in loop'
006/6:[0013] [FC] 'iotests: Add test 197 for covering copy-on-read'
Eric Blake (6):
qemu-io: Add -C for opening with copy-on-read
block: Uniform handling of 0-length bdrv_get_block_status()
iotests: Restore stty settings on completion
block: Add blkdebug hook for copy-on-read
block: Perform copy-on-read in loop
iotests: Add test 197 for covering copy-on-read
qapi/block-core.json | 5 +-
block/io.c | 123 +++++++++++++++++++++++++++------------
qemu-io.c | 15 ++++-
tests/qemu-iotests/common.filter | 1 +
tests/qemu-iotests/197 | 109 ++++++++++++++++++++++++++++++++++
tests/qemu-iotests/197.out | 26 +++++++++
tests/qemu-iotests/check | 10 ++++
tests/qemu-iotests/group | 1 +
8 files changed, 249 insertions(+), 41 deletions(-)
create mode 100755 tests/qemu-iotests/197
create mode 100644 tests/qemu-iotests/197.out
--
2.13.6