[Qemu-devel] [PATCH 0/3] update keymaps

Gerd Hoffmann posted 3 patches 6 years, 6 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20171005153330.19210-1-kraxel@redhat.com
Test checkpatch passed
Test docker passed
Test s390x passed
configure                |   23 +
Makefile                 |    5 +
qemu-keymap.c            |  258 +++++++++++
pc-bios/keymaps/Makefile |   56 +++
pc-bios/keymaps/ar       |  819 ++++++++++++++++++++++++++++++----
pc-bios/keymaps/bepo     | 1108 ++++++++++++++++++++++++++++++++--------------
pc-bios/keymaps/cz       |  861 ++++++++++++++++++++++++++++++++---
pc-bios/keymaps/da       |  732 +++++++++++++++++++++++++++++-
pc-bios/keymaps/de       |  767 +++++++++++++++++++++++++++++++-
pc-bios/keymaps/de-ch    |  915 ++++++++++++++++++++++++++++++++------
pc-bios/keymaps/en-gb    |  724 +++++++++++++++++++++++++++++-
pc-bios/keymaps/en-us    |  718 +++++++++++++++++++++++++++++-
pc-bios/keymaps/es       |  744 ++++++++++++++++++++++++++++++-
pc-bios/keymaps/et       |  818 ++++++++++++++++++++++++++++++----
pc-bios/keymaps/fi       |  814 +++++++++++++++++++++++++++++++---
pc-bios/keymaps/fo       |  881 +++++++++++++++++++++++++++++++++---
pc-bios/keymaps/fr       |  704 ++++++++++++++++++++++++++++-
pc-bios/keymaps/fr-be    |  724 +++++++++++++++++++++++++++++-
pc-bios/keymaps/fr-ca    |  804 +++++++++++++++++++++++++++++++--
pc-bios/keymaps/fr-ch    |  800 +++++++++++++++++++++++++++++++--
pc-bios/keymaps/hr       |  752 ++++++++++++++++++++++++++++++-
pc-bios/keymaps/hu       |  887 +++++++++++++++++++++++++++++++++----
pc-bios/keymaps/is       |  802 ++++++++++++++++++++++++++++++---
pc-bios/keymaps/it       |  757 ++++++++++++++++++++++++++++++-
pc-bios/keymaps/ja       |  792 +++++++++++++++++++++++++++++----
pc-bios/keymaps/lt       |  844 +++++++++++++++++++++++++++++++++--
pc-bios/keymaps/lv       |  766 ++++++++++++++++++++++++++++++--
pc-bios/keymaps/mk       |  814 ++++++++++++++++++++++++++++++----
pc-bios/keymaps/nl       |  794 ++++++++++++++++++++++++++++++++-
pc-bios/keymaps/no       |  758 ++++++++++++++++++++++++++++++-
pc-bios/keymaps/pl       |  789 +++++++++++++++++++++++++++++++--
pc-bios/keymaps/pt       |  737 +++++++++++++++++++++++++++++-
pc-bios/keymaps/pt-br    |  775 +++++++++++++++++++++++++++++++-
pc-bios/keymaps/ru       |  835 ++++++++++++++++++++++++++++++----
pc-bios/keymaps/th       |  878 ++++++++++++++++++++++++++++++------
pc-bios/keymaps/tr       |  819 +++++++++++++++++++++++++++++++---
36 files changed, 24353 insertions(+), 1721 deletions(-)
create mode 100644 qemu-keymap.c
create mode 100644 pc-bios/keymaps/Makefile
[Qemu-devel] [PATCH 0/3] update keymaps
Posted by Gerd Hoffmann 6 years, 6 months ago
  Hi,

This is a major of the qemu reverse keymaps in pc-bios/keymaps.

First patch adds a new qemu-keymap tool which can generate these
maps from xkbcommon data.  That allows to stop the error-prone
manual maintainance of the reverse keymaps, and it allows to easily
update reverse keymaps on keymap changes.

Second patch adds a Makefile to pc-bios/keymaps, with the correct
qemu-keymap arguments for all keymaps where I could figure what they
are supposed to be.  Hints for the remaining ones are very welcome.

Third patch updates all the keymaps.  If you want test the new keymaps
it is enough to apply just that third patch.

If you want play with the new qemu-keymap tool you should apply this
series on top of daniel's keycodemapdb patch series.

cheers,
  Gerd

Gerd Hoffmann (3):
  tools: add qemu-keymap
  Add pc-bios/keymaps/Makefile
  pc-bios/keymaps: keymaps update

 configure                |   23 +
 Makefile                 |    5 +
 qemu-keymap.c            |  258 +++++++++++
 pc-bios/keymaps/Makefile |   56 +++
 pc-bios/keymaps/ar       |  819 ++++++++++++++++++++++++++++++----
 pc-bios/keymaps/bepo     | 1108 ++++++++++++++++++++++++++++++++--------------
 pc-bios/keymaps/cz       |  861 ++++++++++++++++++++++++++++++++---
 pc-bios/keymaps/da       |  732 +++++++++++++++++++++++++++++-
 pc-bios/keymaps/de       |  767 +++++++++++++++++++++++++++++++-
 pc-bios/keymaps/de-ch    |  915 ++++++++++++++++++++++++++++++++------
 pc-bios/keymaps/en-gb    |  724 +++++++++++++++++++++++++++++-
 pc-bios/keymaps/en-us    |  718 +++++++++++++++++++++++++++++-
 pc-bios/keymaps/es       |  744 ++++++++++++++++++++++++++++++-
 pc-bios/keymaps/et       |  818 ++++++++++++++++++++++++++++++----
 pc-bios/keymaps/fi       |  814 +++++++++++++++++++++++++++++++---
 pc-bios/keymaps/fo       |  881 +++++++++++++++++++++++++++++++++---
 pc-bios/keymaps/fr       |  704 ++++++++++++++++++++++++++++-
 pc-bios/keymaps/fr-be    |  724 +++++++++++++++++++++++++++++-
 pc-bios/keymaps/fr-ca    |  804 +++++++++++++++++++++++++++++++--
 pc-bios/keymaps/fr-ch    |  800 +++++++++++++++++++++++++++++++--
 pc-bios/keymaps/hr       |  752 ++++++++++++++++++++++++++++++-
 pc-bios/keymaps/hu       |  887 +++++++++++++++++++++++++++++++++----
 pc-bios/keymaps/is       |  802 ++++++++++++++++++++++++++++++---
 pc-bios/keymaps/it       |  757 ++++++++++++++++++++++++++++++-
 pc-bios/keymaps/ja       |  792 +++++++++++++++++++++++++++++----
 pc-bios/keymaps/lt       |  844 +++++++++++++++++++++++++++++++++--
 pc-bios/keymaps/lv       |  766 ++++++++++++++++++++++++++++++--
 pc-bios/keymaps/mk       |  814 ++++++++++++++++++++++++++++++----
 pc-bios/keymaps/nl       |  794 ++++++++++++++++++++++++++++++++-
 pc-bios/keymaps/no       |  758 ++++++++++++++++++++++++++++++-
 pc-bios/keymaps/pl       |  789 +++++++++++++++++++++++++++++++--
 pc-bios/keymaps/pt       |  737 +++++++++++++++++++++++++++++-
 pc-bios/keymaps/pt-br    |  775 +++++++++++++++++++++++++++++++-
 pc-bios/keymaps/ru       |  835 ++++++++++++++++++++++++++++++----
 pc-bios/keymaps/th       |  878 ++++++++++++++++++++++++++++++------
 pc-bios/keymaps/tr       |  819 +++++++++++++++++++++++++++++++---
 36 files changed, 24353 insertions(+), 1721 deletions(-)
 create mode 100644 qemu-keymap.c
 create mode 100644 pc-bios/keymaps/Makefile

-- 
2.9.3


Re: [Qemu-devel] [PATCH 0/3] update keymaps
Posted by Eric Blake 6 years, 6 months ago
On 10/05/2017 10:33 AM, Gerd Hoffmann wrote:
>   Hi,
> 
> This is a major of the qemu reverse keymaps in pc-bios/keymaps.
> 
> First patch adds a new qemu-keymap tool which can generate these
> maps from xkbcommon data.  That allows to stop the error-prone
> manual maintainance of the reverse keymaps, and it allows to easily
> update reverse keymaps on keymap changes.
> 
> Second patch adds a Makefile to pc-bios/keymaps, with the correct
> qemu-keymap arguments for all keymaps where I could figure what they
> are supposed to be.  Hints for the remaining ones are very welcome.
> 
> Third patch updates all the keymaps.  If you want test the new keymaps
> it is enough to apply just that third patch.
> 
> If you want play with the new qemu-keymap tool you should apply this
> series on top of daniel's keycodemapdb patch series.

Let's tell that to patchew:

Based-on:
https://lists.gnu.org/archive/html/qemu-devel/2017-10/msg00918.html
([PULL 0/6] Ui 20171005 patches)

even if we know that pull request needs a v2 to solve parallel make races.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Re: [Qemu-devel] [PATCH 0/3] update keymaps
Posted by Gerd Hoffmann 6 years, 6 months ago
  Hi,

> > If you want play with the new qemu-keymap tool you should apply
> > this
> > series on top of daniel's keycodemapdb patch series.
> 
> Let's tell that to patchew:
> 
> Based-on:
> https://lists.gnu.org/archive/html/qemu-devel/2017-10/msg00918.html
> ([PULL 0/6] Ui 20171005 patches)

Well, it's not *that* kind of dependency.  It'll apply and build just
fine on master branch.

But qemu-keymap will generate more complete maps because the evdev to
qkeycode mapping has more entries with Dan's series applied.

Could even be that qemu-keymap will throw an assert() when applied on
master due to missing mappings (didn't test that though).

cheers,
  Gerd


Re: [Qemu-devel] [PATCH 0/3] update keymaps
Posted by Gerd Hoffmann 6 years, 6 months ago
  Hi,

> Third patch updates all the keymaps.  If you want test the new
> keymaps
> it is enough to apply just that third patch.

Oops, seems patch #3 was too big for the list.
Try fetching the bits from the git repo then:

https://www.kraxel.org/cgit/qemu/log/?h=work/xkbcommon

cheers,
  Gerd