[v2] s390/z14: extended TOD-clock support

[Qemu-devel] [PATCH v2 0/2] s390/z14: extended TOD-clock support

Christian Borntraeger posted 2 patches 6 years, 6 months ago

Diff against v1
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20171004105751.24655-1-borntraeger@de.ibm.com

Test checkpatch passed

Test docker passed

Test s390x passed

hw/s390x/s390-virtio-ccw.c |  7 ++-----
target/s390x/cpu.c         | 26 +++++++++++++++++++-------
target/s390x/kvm-stub.c    | 10 ++++++++++
target/s390x/kvm.c         | 35 ++++++++++++++++++++++++++++++++++-
target/s390x/kvm_s390x.h   |  2 ++
5 files changed, 67 insertions(+), 13 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH v2 0/2] s390/z14: extended TOD-clock support

Posted by Christian Borntraeger 6 years, 6 months ago

The last last remaining z14 item on my queue.

v1->v2:
- split patches
- fix white spaces (also fixup kvm_s390_set_clock)
- single phrase error message
- use strerror

Collin L. Walling (2):
  s390/kvm: Support for get/set of extended TOD-Clock for guest
  s390/kvm: make TOD setting failures fatal for migration

 hw/s390x/s390-virtio-ccw.c |  7 ++-----
 target/s390x/cpu.c         | 26 +++++++++++++++++++-------
 target/s390x/kvm-stub.c    | 10 ++++++++++
 target/s390x/kvm.c         | 35 ++++++++++++++++++++++++++++++++++-
 target/s390x/kvm_s390x.h   |  2 ++
 5 files changed, 67 insertions(+), 13 deletions(-)

-- 
2.9.4

Re: [Qemu-devel] [PATCH v2 0/2] s390/z14: extended TOD-clock support

Posted by Cornelia Huck 6 years, 6 months ago

On Wed,  4 Oct 2017 12:57:49 +0200
Christian Borntraeger <borntraeger@de.ibm.com> wrote:

> The last last remaining z14 item on my queue.

So the really last one? :)

> 
> v1->v2:
> - split patches
> - fix white spaces (also fixup kvm_s390_set_clock)
> - single phrase error message
> - use strerror
> 
> Collin L. Walling (2):
>   s390/kvm: Support for get/set of extended TOD-Clock for guest
>   s390/kvm: make TOD setting failures fatal for migration
> 
>  hw/s390x/s390-virtio-ccw.c |  7 ++-----
>  target/s390x/cpu.c         | 26 +++++++++++++++++++-------
>  target/s390x/kvm-stub.c    | 10 ++++++++++
>  target/s390x/kvm.c         | 35 ++++++++++++++++++++++++++++++++++-
>  target/s390x/kvm_s390x.h   |  2 ++
>  5 files changed, 67 insertions(+), 13 deletions(-)
> 

Thanks, applied.

Re: [Qemu-devel] [PATCH v2 0/2] s390/z14: extended TOD-clock support

Posted by Christian Borntraeger 6 years, 6 months ago


On 10/04/2017 03:57 PM, Cornelia Huck wrote:
> On Wed,  4 Oct 2017 12:57:49 +0200
> Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> 
>> The last last remaining z14 item on my queue.
> 
> So the really last one? :)

Have a look at the full model of z14 in target/s390x/gen-features.c

There are some things that we could do, for example the test pending
external interruption or the insert reference multiple. Both instructions
do not make much sense for Linux.

Then there is hpma2, which is a host memory management thing and only becomes
relevant if we ever implement it for vsie.

But nothing of that is high priority right now.
> 
>>
>> v1->v2:
>> - split patches
>> - fix white spaces (also fixup kvm_s390_set_clock)
>> - single phrase error message
>> - use strerror
>>
>> Collin L. Walling (2):
>>   s390/kvm: Support for get/set of extended TOD-Clock for guest
>>   s390/kvm: make TOD setting failures fatal for migration
>>
>>  hw/s390x/s390-virtio-ccw.c |  7 ++-----
>>  target/s390x/cpu.c         | 26 +++++++++++++++++++-------
>>  target/s390x/kvm-stub.c    | 10 ++++++++++
>>  target/s390x/kvm.c         | 35 ++++++++++++++++++++++++++++++++++-
>>  target/s390x/kvm_s390x.h   |  2 ++
>>  5 files changed, 67 insertions(+), 13 deletions(-)
>>
> 
> Thanks, applied.
>