[Qemu-devel] [PATCH 0/6] Add make check tests for Migration

Juan Quintela posted 6 patches 6 years, 5 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20171004103933.7898-1-quintela@redhat.com
Test checkpatch failed
Test docker failed
Test s390x passed
There is a newer version of this series
tests/Makefile.include |   3 +
tests/migration-test.c | 707 +++++++++++++++++++++++++++++++++++++++++++++++++
tests/postcopy-test.c  |   8 +-
3 files changed, 714 insertions(+), 4 deletions(-)
create mode 100644 tests/migration-test.c
[Qemu-devel] [PATCH 0/6] Add make check tests for Migration
Posted by Juan Quintela 6 years, 5 months ago
His this series:
- add test for precopy for unix/tcp
  exec and fd to came, don't know how to test rdma without hardware
- add tests using deprecated interfaces
- add test for xbzrle
  Note to myself, there is no way to set the cache size with migraton_set_parameters
- Add test for compress threads
  disabled on the series, right now it appears that compression is not working at all
- Move postcopy to use new results
  Idea is to move it on top of migration-test.c, but first I want some reviews on basic idea

Please, review.

Juan.


Juan Quintela (6):
  tests: Add basic migration precopy test
  tests: Add basic migration precopy tcp test
  tests: Add precopy test using deprecated commands
  tests: Add migration xbzrle test
  tests: Add migration compress threads tests
  tests: Move postcopy migration test to migrate-set-parameters

 tests/Makefile.include |   3 +
 tests/migration-test.c | 707 +++++++++++++++++++++++++++++++++++++++++++++++++
 tests/postcopy-test.c  |   8 +-
 3 files changed, 714 insertions(+), 4 deletions(-)
 create mode 100644 tests/migration-test.c

-- 
2.13.5


Re: [Qemu-devel] [PATCH 0/6] Add make check tests for Migration
Posted by no-reply@patchew.org 6 years, 5 months ago
Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20171004103933.7898-1-quintela@redhat.com
Subject: [Qemu-devel] [PATCH 0/6] Add make check tests for Migration

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
4aeb6111b4 tests: Move postcopy migration test to migrate-set-parameters
1c9b2bdb92 tests: Add migration compress threads tests
56c99c4814 tests: Add migration xbzrle test
576f38004b tests: Add precopy test using deprecated commands
af499b81e9 tests: Add basic migration precopy tcp test
54217d4480 tests: Add basic migration precopy test

=== OUTPUT BEGIN ===
Checking PATCH 1/6: tests: Add basic migration precopy test...
WARNING: architecture specific defines should be avoided
#72: FILE: tests/migration-test.c:30:
+#if defined(__linux__)

total: 0 errors, 1 warnings, 518 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/6: tests: Add basic migration precopy tcp test...
Checking PATCH 3/6: tests: Add precopy test using deprecated commands...
Checking PATCH 4/6: tests: Add migration xbzrle test...
Checking PATCH 5/6: tests: Add migration compress threads tests...
ERROR: trailing whitespace
#36: FILE: tests/migration-test.c:640:
+    migrate_set_parameter(from, "decompress-threads", "3"); $

total: 1 errors, 0 warnings, 63 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 6/6: tests: Move postcopy migration test to migrate-set-parameters...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org