[v1] backup improvements part 1

[Qemu-devel] [PATCH 0/5] backup improvements part 1

Posted by Vladimir Sementsov-Ogievskiy 6 years, 6 months ago

Hi all. Here is a continuation of my "new backup architecture" series,
The very first part, but it is meaningful itself.

01: was previously sent in other my series, but here is more correct
    version, one mistake is fixed.
02: only rebased to new byte-based interfaces (by Eric), r-bs saved
03: changed to use hbitmap_next_zero, also a comment added to
    none-mode (Fam)
04: commit message rewritten. The patch was controversial, but I need
    it for further backup enhancement, so, let's continue the
    discussion.
05: rebased, logic is not changed, r-bs saved


Vladimir Sementsov-Ogievskiy (5):
  hbitmap: add next_zero function
  backup: move from done_bitmap to copy_bitmap
  backup: init copy_bitmap from sync_bitmap for incremental
  backup: simplify non-dirty bits progress processing
  backup: use copy_bitmap in incremental backup

 include/block/dirty-bitmap.h |   1 +
 include/qemu/hbitmap.h       |   8 +++
 block/backup.c               | 117 ++++++++++++++++++++++++-------------------
 block/dirty-bitmap.c         |   5 ++
 util/hbitmap.c               |  29 +++++++++++
 5 files changed, 108 insertions(+), 52 deletions(-)

-- 
2.11.1

Re: [Qemu-devel] [PATCH 0/5] backup improvements part 1

Posted by Eric Blake 6 years, 6 months ago

On 10/02/2017 09:39 AM, Vladimir Sementsov-Ogievskiy wrote:
> Hi all. Here is a continuation of my "new backup architecture" series,
> The very first part, but it is meaningful itself.
> 
> 01: was previously sent in other my series, but here is more correct
>     version, one mistake is fixed.
> 02: only rebased to new byte-based interfaces (by Eric), r-bs saved

Presumably, that means we need to tell patchew:

Based-on:
https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg06848.html
[PATCH v10 00/20] make dirty-bitmap byte-based

> 03: changed to use hbitmap_next_zero, also a comment added to
>     none-mode (Fam)
> 04: commit message rewritten. The patch was controversial, but I need
>     it for further backup enhancement, so, let's continue the
>     discussion.
> 05: rebased, logic is not changed, r-bs saved
> 
> 
> Vladimir Sementsov-Ogievskiy (5):
>   hbitmap: add next_zero function
>   backup: move from done_bitmap to copy_bitmap
>   backup: init copy_bitmap from sync_bitmap for incremental
>   backup: simplify non-dirty bits progress processing
>   backup: use copy_bitmap in incremental backup
> 
>  include/block/dirty-bitmap.h |   1 +
>  include/qemu/hbitmap.h       |   8 +++
>  block/backup.c               | 117 ++++++++++++++++++++++++-------------------
>  block/dirty-bitmap.c         |   5 ++
>  util/hbitmap.c               |  29 +++++++++++
>  5 files changed, 108 insertions(+), 52 deletions(-)
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Re: [Qemu-devel] [PATCH 0/5] backup improvements part 1

Posted by Vladimir Sementsov-Ogievskiy 6 years, 6 months ago

02.10.2017 18:38, Eric Blake wrote:
> On 10/02/2017 09:39 AM, Vladimir Sementsov-Ogievskiy wrote:
>> Hi all. Here is a continuation of my "new backup architecture" series,
>> The very first part, but it is meaningful itself.
>>
>> 01: was previously sent in other my series, but here is more correct
>>      version, one mistake is fixed.
>> 02: only rebased to new byte-based interfaces (by Eric), r-bs saved
> Presumably, that means we need to tell patchew:
>
> Based-on:
> https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg06848.html
> [PATCH v10 00/20] make dirty-bitmap byte-based

Yes, surely, I forgot to note it.

>
>> 03: changed to use hbitmap_next_zero, also a comment added to
>>      none-mode (Fam)
>> 04: commit message rewritten. The patch was controversial, but I need
>>      it for further backup enhancement, so, let's continue the
>>      discussion.
>> 05: rebased, logic is not changed, r-bs saved
>>
>>
>> Vladimir Sementsov-Ogievskiy (5):
>>    hbitmap: add next_zero function
>>    backup: move from done_bitmap to copy_bitmap
>>    backup: init copy_bitmap from sync_bitmap for incremental
>>    backup: simplify non-dirty bits progress processing
>>    backup: use copy_bitmap in incremental backup
>>
>>   include/block/dirty-bitmap.h |   1 +
>>   include/qemu/hbitmap.h       |   8 +++
>>   block/backup.c               | 117 ++++++++++++++++++++++++-------------------
>>   block/dirty-bitmap.c         |   5 ++
>>   util/hbitmap.c               |  29 +++++++++++
>>   5 files changed, 108 insertions(+), 52 deletions(-)
>>


-- 
Best regards,
Vladimir