From nobody Thu May 2 01:57:55 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@gnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@gnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1506950926012203.5987046782235; Mon, 2 Oct 2017 06:28:46 -0700 (PDT) Received: from localhost ([::1]:52280 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dz0lw-0004Nq-8m for importer@patchew.org; Mon, 02 Oct 2017 09:28:36 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33630) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dyvmz-0005Y0-Md for qemu-devel@nongnu.org; Mon, 02 Oct 2017 04:09:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dyvmu-0005jp-MV for qemu-devel@nongnu.org; Mon, 02 Oct 2017 04:09:21 -0400 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:56936) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dyvmu-0005iu-FU; Mon, 02 Oct 2017 04:09:16 -0400 Received: by mail-wm0-x243.google.com with SMTP id e195so5054900wma.5; Mon, 02 Oct 2017 01:09:15 -0700 (PDT) Received: from localhost.localdomain ([178.208.16.32]) by smtp.gmail.com with ESMTPSA id 133sm8687969wmu.4.2017.10.02.01.09.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Oct 2017 01:09:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=m7lUxMQowDA06v2jRVxPP5F8VipmBDG8Bgi9g2IZseE=; b=LKO3Ou61r57XaanzMLtxaB7RnWE2hfTDj6E5KyHkvdk1aDzCy4o7D1n/ehB/+Z2UTa wCxKSfHSNofnEDtMjW9gPXeNmk5/Hg8dQg1Shena9ffj2mjOAtWdY8OoykzUb7m7Qdv5 guSOobcTOOxQrjA3XxYKlv9iLckuYbasBDrJVSvNfzth334LCiDJMqKlAtvXdlAahlFc EmvvFirLvBqg8ogtjVx2NSgIxaJDJBS7Fwx8MB3hZ9jDn6/xkk75aKNtGOxKERpMfpeQ pHg+oCRH9bjLZ1nw0je523lBFFUka5kgtPmDl/GmELH9MiJinkrl7fxknsyo0439MwEH 6CLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=m7lUxMQowDA06v2jRVxPP5F8VipmBDG8Bgi9g2IZseE=; b=VieXFc0PgeWF9tbqzlow+JWFIRMyx9SjpbIgXsT6NfSRLmgL53kSD/E7hxKNulIieb Oe4FMFAGEfVFo2ZVvzRZI1xnFKAJ5XsA/T8Z21EBrjyRG891nVVhBsmffdVMH4W1f2Ou 34KAY9vdSWJJGVn7GLCvtqSBzyL12SY+EuzJe+BNabh/ZAoOiZoHcAsylbIhJfSXFRwg qB59WDw68rrujynNWQC7I1VoTZGAWl/1ugXCddtDJ2YnuCt7ITd+rFEOuRdVC/ZU2Kji 5ddQyo+Zuk8ZxAC29cI579vtCWC6yqtbnFUwb+kxvnp6WkOXi8d5dTtIGqEaNMP5HF1b WS7g== X-Gm-Message-State: AMCzsaV4fRIKV0rxShDuosfNNjnc2aiOK7yjKn2MNu7iIjvPl9AArZ45 fOx59Wjlgia1z9a04PDMemw= X-Google-Smtp-Source: AOwi7QAMElM3O4yT379IjZhuKyvhClNwB137ZuwNKRLSoK9FnAR79nz13doeP/rJPBT5TIa0d1HmXw== X-Received: by 10.28.30.22 with SMTP id e22mr9697139wme.121.1506931754189; Mon, 02 Oct 2017 01:09:14 -0700 (PDT) From: Anthoine Bourgeois To: Gerd Hoffmann , qemu-devel@nongnu.org Date: Mon, 2 Oct 2017 10:09:06 +0200 Message-Id: <20171002080906.4682-1-anthoine.bourgeois@gmail.com> X-Mailer: git-send-email 2.9.3 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::243 X-Mailman-Approved-At: Mon, 02 Oct 2017 09:26:50 -0400 Subject: [Qemu-devel] [PATCH] gtk: fix wrong id between texture and framebuffer X-BeenThere: qemu-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Anthoine Bourgeois , Anthoine Bourgeois Errors-To: qemu-devel-bounces+importer=patchew.org@gnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Anthoine Bourgeois The gd_gl_area_scanout_texture must destroy framebuffer if there is no texture id instead of no framebuffer id. The effect was a black screen with "-vga virtio -display gtk,gl=3Don" options. The bug was introduce by a4f113fd "gtk: use framebuffer helper functions." Signed-off-by: Anthoine Bourgeois --- ui/gtk-gl-area.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ui/gtk-gl-area.c b/ui/gtk-gl-area.c index 18b298f..026b7d7 100644 --- a/ui/gtk-gl-area.c +++ b/ui/gtk-gl-area.c @@ -178,8 +178,7 @@ void gd_gl_area_scanout_texture(DisplayChangeListener *= dcl, =20 gtk_gl_area_make_current(GTK_GL_AREA(vc->gfx.drawing_area)); =20 - if (vc->gfx.guest_fb.framebuffer =3D=3D 0 || - vc->gfx.w =3D=3D 0 || vc->gfx.h =3D=3D 0) { + if (backing_id =3D=3D 0 || vc->gfx.w =3D=3D 0 || vc->gfx.h =3D=3D 0) { gtk_gl_area_set_scanout_mode(vc, false); return; } --=20 2.9.3