docker: test-block: Don't continue if build fails

[Qemu-devel] [PATCH] docker: test-block: Don't continue if build fails

Posted by Fam Zheng 6 years, 6 months ago

Report error and exit upon compiling error, otherwise the iotests output
will be pure noise.

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 tests/docker/test-block | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/docker/test-block b/tests/docker/test-block
index 2ca1ce54f6..5624b81827 100755
--- a/tests/docker/test-block
+++ b/tests/docker/test-block
@@ -14,7 +14,7 @@
 
 cd "$BUILD_DIR"
 
-build_qemu --target-list=x86_64-softmmu
+build_qemu --target-list=x86_64-softmmu || test_fail "Build failed"
 cd tests/qemu-iotests
 for t in raw qcow2 nbd luks; do
     ./check -g quick -$t || test_fail "Test failed: iotests $t"
-- 
2.13.5

Re: [Qemu-devel] [PATCH] docker: test-block: Don't continue if build fails

Posted by Eric Blake 6 years, 6 months ago

On 09/26/2017 06:01 AM, Fam Zheng wrote:
> Report error and exit upon compiling error, otherwise the iotests output
> will be pure noise.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  tests/docker/test-block | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/tests/docker/test-block b/tests/docker/test-block
> index 2ca1ce54f6..5624b81827 100755
> --- a/tests/docker/test-block
> +++ b/tests/docker/test-block
> @@ -14,7 +14,7 @@
>  
>  cd "$BUILD_DIR"
>  
> -build_qemu --target-list=x86_64-softmmu
> +build_qemu --target-list=x86_64-softmmu || test_fail "Build failed"
>  cd tests/qemu-iotests
>  for t in raw qcow2 nbd luks; do
>      ./check -g quick -$t || test_fail "Test failed: iotests $t"
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Re: [Qemu-devel] [PATCH] docker: test-block: Don't continue if build fails

Posted by Fam Zheng 6 years, 6 months ago

On Tue, 09/26 08:48, Eric Blake wrote:
> On 09/26/2017 06:01 AM, Fam Zheng wrote:
> > Report error and exit upon compiling error, otherwise the iotests output
> > will be pure noise.
> > 
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > ---
> >  tests/docker/test-block | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Reviewed-by: Eric Blake <eblake@redhat.com>

Queued, thanks.

Fam