[Qemu-devel] [PATCH 0/5] commit: Support multiple roots above top node

Kevin Wolf posted 5 patches 6 years, 6 months ago
Failed in applying to current master (apply log)
include/block/block.h          |   3 +-
include/block/block_int.h      |   6 +
block.c                        |  91 +++--
block/commit.c                 |  64 +---
tests/qemu-iotests/030         |   4 -
tests/qemu-iotests/191         | 152 ++++++++
tests/qemu-iotests/191.out     | 827 +++++++++++++++++++++++++++++++++++++++++
tests/qemu-iotests/common.qemu |  14 +-
tests/qemu-iotests/group       |   1 +
9 files changed, 1078 insertions(+), 84 deletions(-)
create mode 100755 tests/qemu-iotests/191
create mode 100644 tests/qemu-iotests/191.out
[Qemu-devel] [PATCH 0/5] commit: Support multiple roots above top node
Posted by Kevin Wolf 6 years, 6 months ago
This is a step towards making the commit job flexible enough that it can
work with any kind of block graph. Currently, it requires that not only
the top and base node of the commit operation are specified, but also
the active layer of the backing file chain. Of course, the assumption
that a single active layer exists is invalid.

This series makes the commit job consider other roots as well so that
all parent nodes of the top node get their backing file updated and stay
valid after the commit job completes.

With this, we should have all of the prerequisites for a follow-up
series that adds a new and clean blockdev-commit QMP command which
doesn't require an option for the active layer and which accepts node
names instead of file names for base and top.

Kevin Wolf (5):
  block: Introduce BdrvChildRole.update_filename
  commit: Support multiple roots above top node
  qemu-iotests: Allow QMP pretty printing in common.qemu
  qemu-iotests: Test commit block job where top has two parents
  commit: Remove overlay_bs

 include/block/block.h          |   3 +-
 include/block/block_int.h      |   6 +
 block.c                        |  91 +++--
 block/commit.c                 |  64 +---
 tests/qemu-iotests/030         |   4 -
 tests/qemu-iotests/191         | 152 ++++++++
 tests/qemu-iotests/191.out     | 827 +++++++++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/common.qemu |  14 +-
 tests/qemu-iotests/group       |   1 +
 9 files changed, 1078 insertions(+), 84 deletions(-)
 create mode 100755 tests/qemu-iotests/191
 create mode 100644 tests/qemu-iotests/191.out

-- 
2.13.5

Re: [Qemu-devel] [Qemu-block] [PATCH 0/5] commit: Support multiple roots above top node
Posted by John Snow 6 years, 6 months ago

On 09/25/2017 08:28 AM, Kevin Wolf wrote:
> This is a step towards making the commit job flexible enough that it can
> work with any kind of block graph. Currently, it requires that not only
> the top and base node of the commit operation are specified, but also
> the active layer of the backing file chain. Of course, the assumption
> that a single active layer exists is invalid.
> 
> This series makes the commit job consider other roots as well so that
> all parent nodes of the top node get their backing file updated and stay
> valid after the commit job completes.
> 
> With this, we should have all of the prerequisites for a follow-up
> series that adds a new and clean blockdev-commit QMP command which
> doesn't require an option for the active layer and which accepts node
> names instead of file names for base and top.
> 
> Kevin Wolf (5):
>   block: Introduce BdrvChildRole.update_filename
>   commit: Support multiple roots above top node
>   qemu-iotests: Allow QMP pretty printing in common.qemu
>   qemu-iotests: Test commit block job where top has two parents
>   commit: Remove overlay_bs
> 
>  include/block/block.h          |   3 +-
>  include/block/block_int.h      |   6 +
>  block.c                        |  91 +++--
>  block/commit.c                 |  64 +---
>  tests/qemu-iotests/030         |   4 -
>  tests/qemu-iotests/191         | 152 ++++++++
>  tests/qemu-iotests/191.out     | 827 +++++++++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/common.qemu |  14 +-
>  tests/qemu-iotests/group       |   1 +
>  9 files changed, 1078 insertions(+), 84 deletions(-)
>  create mode 100755 tests/qemu-iotests/191
>  create mode 100644 tests/qemu-iotests/191.out
> 

Does this depend on another series?

Re: [Qemu-devel] [Qemu-block] [PATCH 0/5] commit: Support multiple roots above top node
Posted by Kevin Wolf 6 years, 6 months ago
Am 25.09.2017 um 22:02 hat John Snow geschrieben:
> On 09/25/2017 08:28 AM, Kevin Wolf wrote:
> > This is a step towards making the commit job flexible enough that it can
> > work with any kind of block graph. Currently, it requires that not only
> > the top and base node of the commit operation are specified, but also
> > the active layer of the backing file chain. Of course, the assumption
> > that a single active layer exists is invalid.
> > 
> > This series makes the commit job consider other roots as well so that
> > all parent nodes of the top node get their backing file updated and stay
> > valid after the commit job completes.
> > 
> > With this, we should have all of the prerequisites for a follow-up
> > series that adds a new and clean blockdev-commit QMP command which
> > doesn't require an option for the active layer and which accepts node
> > names instead of file names for base and top.
> > 
> > Kevin Wolf (5):
> >   block: Introduce BdrvChildRole.update_filename
> >   commit: Support multiple roots above top node
> >   qemu-iotests: Allow QMP pretty printing in common.qemu
> >   qemu-iotests: Test commit block job where top has two parents
> >   commit: Remove overlay_bs
> 
> Does this depend on another series?

It is based on my block branch. I think specifically the series "block:
Fix permissions after ro/rw reopen" might be needed for the patches to
work correctly.

Kevin