[Qemu-devel] [PATCH 0/2] s390/z14: extended TOD-clock support

Christian Borntraeger posted 2 patches 6 years, 7 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170925102302.60587-1-borntraeger@de.ibm.com
Test checkpatch failed
Test docker passed
Test s390x passed
There is a newer version of this series
hw/s390x/s390-virtio-ccw.c   |  8 +++-----
linux-headers/asm-s390/kvm.h |  6 ++++++
target/s390x/cpu.c           | 26 +++++++++++++++++++-------
target/s390x/kvm-stub.c      | 10 ++++++++++
target/s390x/kvm.c           | 35 +++++++++++++++++++++++++++++++++++
target/s390x/kvm_s390x.h     |  2 ++
6 files changed, 75 insertions(+), 12 deletions(-)
[Qemu-devel] [PATCH 0/2] s390/z14: extended TOD-clock support
Posted by Christian Borntraeger 6 years, 7 months ago
I still have this patch on my queue as the last remaining z14 item.
Since I have already rebase it several time, its time for some 
additional review.


Collin L. Walling (2):
  linux-headers: Update linux headers for extended TOD-Clock
  s390/kvm: Support for get/set of extended TOD-Clock for guest

 hw/s390x/s390-virtio-ccw.c   |  8 +++-----
 linux-headers/asm-s390/kvm.h |  6 ++++++
 target/s390x/cpu.c           | 26 +++++++++++++++++++-------
 target/s390x/kvm-stub.c      | 10 ++++++++++
 target/s390x/kvm.c           | 35 +++++++++++++++++++++++++++++++++++
 target/s390x/kvm_s390x.h     |  2 ++
 6 files changed, 75 insertions(+), 12 deletions(-)

-- 
2.9.4


Re: [Qemu-devel] [PATCH 0/2] s390/z14: extended TOD-clock support
Posted by no-reply@patchew.org 6 years, 7 months ago
Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20170925102302.60587-1-borntraeger@de.ibm.com
Subject: [Qemu-devel] [PATCH 0/2] s390/z14: extended TOD-clock support

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
96c6906c93 s390/kvm: Support for get/set of extended TOD-Clock for guest
f4ecf143f0 linux-headers: Update linux headers for extended TOD-Clock

=== OUTPUT BEGIN ===
Checking PATCH 1/2: linux-headers: Update linux headers for extended TOD-Clock...
Checking PATCH 2/2: s390/kvm: Support for get/set of extended TOD-Clock for guest...
ERROR: Error messages should not contain newlines
#34: FILE: hw/s390x/s390-virtio-ccw.c:217:
+                     "s390_get_clock returned error %d.\n", r);

total: 1 errors, 0 warnings, 134 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org