scripts/orderfile: keep MAINTAINERS at bottom

[Qemu-devel] [PATCH] scripts/orderfile: keep MAINTAINERS at bottom

Philippe Mathieu-Daudé posted 1 patch 8 years, 4 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170922161345.331-1-f4bug@amsat.org

Test checkpatch passed

Test docker passed

Test s390x passed

scripts/git.orderfile | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[Qemu-devel] [PATCH] scripts/orderfile: keep MAINTAINERS at bottom

Posted by Philippe Mathieu-Daudé 8 years, 4 months ago

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 scripts/git.orderfile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/git.orderfile b/scripts/git.orderfile
index ac699700b1..34619769c2 100644
--- a/scripts/git.orderfile
+++ b/scripts/git.orderfile
@@ -27,3 +27,4 @@ Makefile*
 # code
 *.c
 
+MAINTAINERS
-- 
2.14.1

Re: [Qemu-devel] [PATCH] scripts/orderfile: keep MAINTAINERS at bottom

Posted by Eric Blake 8 years, 4 months ago

On 09/22/2017 11:13 AM, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  scripts/git.orderfile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/scripts/git.orderfile b/scripts/git.orderfile
> index ac699700b1..34619769c2 100644
> --- a/scripts/git.orderfile
> +++ b/scripts/git.orderfile
> @@ -27,3 +27,4 @@ Makefile*
>  # code
>  *.c
>  
> +MAINTAINERS

Well, after any file that matches above, but before any file that
doesn't match any pattern, so not strictly the end.

But why not earlier with the build system?  Generally, if you are going
to add a file, you are going to also tweak a Makefile to get it to build
- at which point, a MAINTAINERS tweak feels more on par with a Makefile
tweak.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org