1. Patchew
  2. QEMU
  3. View series

[Qemu-devel] [PATCH] MAINTAINERS: Fix subsystem name for "Build and test automation"

Eduardo Habkost posted 1 patch 6 years, 6 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170921170209.9101-1-ehabkost@redhat.com
Test checkpatch passed
Test docker passed
Test s390x passed
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
[Qemu-devel] [PATCH] MAINTAINERS: Fix subsystem name for "Build and test automation"
Posted by Eduardo Habkost 6 years, 6 months ago 
The subsystem name for the "Build test automation" section is
"-------------------------", because an actual subsystem name
line is missing:

  $ ./scripts/get_maintainer.pl -f tests/docker/docker.py
  "Alex Bennée" <alex.bennee@linaro.org> (maintainer:-----------------...)
  Fam Zheng <famz@redhat.com> (maintainer:-----------------...)
  "Philippe Mathieu-Daudé" <f4bug@amsat.org> (reviewer:-----------------...)
  qemu-devel@nongnu.org (open list:-----------------...)

Fix the issue by inserting a subsystem name line where
get_maintainer.pl expects it.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index e511ba780f..13c1ac65b7 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1896,6 +1896,7 @@ F: docs/block-replication.txt
 
 Build and test automation
 -------------------------
+Build and test automation
 M: Alex Bennée <alex.bennee@linaro.org>
 M: Fam Zheng <famz@redhat.com>
 R: Philippe Mathieu-Daudé <f4bug@amsat.org>
-- 
2.13.5
Re: [Qemu-devel] [PATCH] MAINTAINERS: Fix subsystem name for "Build and test automation"
Posted by Fam Zheng 6 years, 6 months ago 
On Thu, 09/21 14:02, Eduardo Habkost wrote:
> The subsystem name for the "Build test automation" section is
> "-------------------------", because an actual subsystem name
> line is missing:
> 
>   $ ./scripts/get_maintainer.pl -f tests/docker/docker.py
>   "Alex Bennée" <alex.bennee@linaro.org> (maintainer:-----------------...)
>   Fam Zheng <famz@redhat.com> (maintainer:-----------------...)
>   "Philippe Mathieu-Daudé" <f4bug@amsat.org> (reviewer:-----------------...)
>   qemu-devel@nongnu.org (open list:-----------------...)
> 
> Fix the issue by inserting a subsystem name line where
> get_maintainer.pl expects it.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e511ba780f..13c1ac65b7 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1896,6 +1896,7 @@ F: docs/block-replication.txt
>  
>  Build and test automation
>  -------------------------
> +Build and test automation
>  M: Alex Bennée <alex.bennee@linaro.org>
>  M: Fam Zheng <famz@redhat.com>
>  R: Philippe Mathieu-Daudé <f4bug@amsat.org>
> -- 
> 2.13.5
> 

Queued, thanks.

Fam
Re: [Qemu-devel] [PATCH] MAINTAINERS: Fix subsystem name for "Build and test automation"
Posted by Thomas Huth 6 years, 6 months ago 
On 21.09.2017 19:02, Eduardo Habkost wrote:
> The subsystem name for the "Build test automation" section is
> "-------------------------", because an actual subsystem name
> line is missing:
> 
>   $ ./scripts/get_maintainer.pl -f tests/docker/docker.py
>   "Alex Bennée" <alex.bennee@linaro.org> (maintainer:-----------------...)
>   Fam Zheng <famz@redhat.com> (maintainer:-----------------...)
>   "Philippe Mathieu-Daudé" <f4bug@amsat.org> (reviewer:-----------------...)
>   qemu-devel@nongnu.org (open list:-----------------...)
> 
> Fix the issue by inserting a subsystem name line where
> get_maintainer.pl expects it.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e511ba780f..13c1ac65b7 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1896,6 +1896,7 @@ F: docs/block-replication.txt
>  
>  Build and test automation
>  -------------------------
> +Build and test automation

Would it make sense to use something more specific here? Like "Travis
and Docker" or so? ... in case we add other subsections in the future?

 Thomas
Re: [Qemu-devel] [PATCH] MAINTAINERS: Fix subsystem name for "Build and test automation"
Posted by Fam Zheng 6 years, 6 months ago 
On Fri, 09/22 05:14, Thomas Huth wrote:
> On 21.09.2017 19:02, Eduardo Habkost wrote:
> > The subsystem name for the "Build test automation" section is
> > "-------------------------", because an actual subsystem name
> > line is missing:
> > 
> >   $ ./scripts/get_maintainer.pl -f tests/docker/docker.py
> >   "Alex Bennée" <alex.bennee@linaro.org> (maintainer:-----------------...)
> >   Fam Zheng <famz@redhat.com> (maintainer:-----------------...)
> >   "Philippe Mathieu-Daudé" <f4bug@amsat.org> (reviewer:-----------------...)
> >   qemu-devel@nongnu.org (open list:-----------------...)
> > 
> > Fix the issue by inserting a subsystem name line where
> > get_maintainer.pl expects it.
> > 
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> > ---
> >  MAINTAINERS | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index e511ba780f..13c1ac65b7 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -1896,6 +1896,7 @@ F: docs/block-replication.txt
> >  
> >  Build and test automation
> >  -------------------------
> > +Build and test automation
> 
> Would it make sense to use something more specific here? Like "Travis
> and Docker" or so? ... in case we add other subsections in the future?

Unless we are to split off (i.e. more people volunteering maintaining a certain
subset), the list will just go on and on in this line. For not it's already
going to be "Travis, Shippable, Docker and VM test".. so I think a generic
description here is okay, though the duplication is a bit odd (but I don't have
a better idea).

Fam
Re: [Qemu-devel] [PATCH] MAINTAINERS: Fix subsystem name for "Build and test automation"
Posted by Eric Blake 6 years, 6 months ago 
On 09/21/2017 10:30 PM, Fam Zheng wrote:

>>>  Build and test automation
>>>  -------------------------
>>> +Build and test automation
>>
>> Would it make sense to use something more specific here? Like "Travis
>> and Docker" or so? ... in case we add other subsections in the future?
> 
> Unless we are to split off (i.e. more people volunteering maintaining a certain
> subset), the list will just go on and on in this line. For not it's already
> going to be "Travis, Shippable, Docker and VM test".. so I think a generic
> description here is okay, though the duplication is a bit odd (but I don't have
> a better idea).

Or we could make a generic section of "Build, Tests, and Documentation",
and merge in the "Build system architecture" of the
immediately-subsequent "Documentation" section, as well as possibly any
future sections for someone to maintain top-level build-related files
(including MAINTAINERS itself...), so that we have just one larger
section with multiple sub-sections, instead of two sections each with
one sub-section.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org
Re: [Qemu-devel] [PATCH] MAINTAINERS: Fix subsystem name for "Build and test automation"
Posted by Fam Zheng 6 years, 6 months ago 
On Fri, 09/22 16:02, Eric Blake wrote:
> On 09/21/2017 10:30 PM, Fam Zheng wrote:
> 
> >>>  Build and test automation
> >>>  -------------------------
> >>> +Build and test automation
> >>
> >> Would it make sense to use something more specific here? Like "Travis
> >> and Docker" or so? ... in case we add other subsections in the future?
> > 
> > Unless we are to split off (i.e. more people volunteering maintaining a certain
> > subset), the list will just go on and on in this line. For not it's already
> > going to be "Travis, Shippable, Docker and VM test".. so I think a generic
> > description here is okay, though the duplication is a bit odd (but I don't have
> > a better idea).
> 
> Or we could make a generic section of "Build, Tests, and Documentation",
> and merge in the "Build system architecture" of the
> immediately-subsequent "Documentation" section, as well as possibly any
> future sections for someone to maintain top-level build-related files
> (including MAINTAINERS itself...), so that we have just one larger
> section with multiple sub-sections, instead of two sections each with
> one sub-section.

That sounds okay, but actually most of the files under docs/ don't have a
maintainer, so in the hope that one day they will, the "Documentation" section
may be a good place to host more entries.

Fam

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.