scripts/qemu.py: fix continuation

[Qemu-devel] [PATCH] scripts/qemu.py: fix continuation

Alex Bennée posted 1 patch 6 years, 7 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170918093740.25198-1-alex.bennee@linaro.org

Test checkpatch passed

Test docker passed

Test s390x passed

scripts/qemu.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH] scripts/qemu.py: fix continuation

Posted by Alex Bennée 6 years, 7 months ago

Commit dab91d9aa00e41ee680524e4f6e99a1e7fe12eb2 broke the invocation by
dropping the surrounding braces. I'm not sure how this could have
worked, maybe some pythons are more forgiving?

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
CC: Amador Pahim <apahim@redhat.com>
CC: Fam Zheng <famz@redhat.com>
CC: Eduardo Habkost <ehabkost@redhat.com>
---
 scripts/qemu.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/qemu.py b/scripts/qemu.py
index 774e201e8b..2b5c2accb5 100644
--- a/scripts/qemu.py
+++ b/scripts/qemu.py
@@ -193,8 +193,8 @@ class QEMUMachine(object):
         qemulog = open(self._qemu_log_path, 'wb')
         try:
             self._pre_launch()
-            self._qemu_full_args = self._wrapper + [self._binary] +
-                                    self._base_args() + self._args
+            self._qemu_full_args = (self._wrapper + [self._binary] +
+                                    self._base_args() + self._args)
             self._popen = subprocess.Popen(self._qemu_full_args,
                                            stdin=devnull,
                                            stdout=qemulog,
-- 
2.14.1