configure | 32 + cpus.c | 107 +- hw/intc/apic.c | 11 + include/hw/i386/apic.h | 1 + include/qom/cpu.h | 2 + include/sysemu/hvf.h | 106 ++ qemu-options.hx | 20 +- target/i386/Makefile.objs | 1 + target/i386/cpu-qom.h | 4 +- target/i386/cpu.c | 111 +- target/i386/cpu.h | 30 + target/i386/hvf-all.c | 1123 ++++++++++++++++++ target/i386/hvf-i386.h | 48 + target/i386/hvf-utils/Makefile.objs | 1 + target/i386/hvf-utils/README.md | 7 + target/i386/hvf-utils/vmcs.h | 371 ++++++ target/i386/hvf-utils/vmx.h | 222 ++++ target/i386/hvf-utils/x86.c | 184 +++ target/i386/hvf-utils/x86.h | 476 ++++++++ target/i386/hvf-utils/x86_cpuid.c | 417 +++++++ target/i386/hvf-utils/x86_cpuid.h | 52 + target/i386/hvf-utils/x86_decode.c | 2186 +++++++++++++++++++++++++++++++++++ target/i386/hvf-utils/x86_decode.h | 325 ++++++ target/i386/hvf-utils/x86_descr.c | 124 ++ target/i386/hvf-utils/x86_descr.h | 55 + target/i386/hvf-utils/x86_emu.c | 1536 ++++++++++++++++++++++++ target/i386/hvf-utils/x86_emu.h | 32 + target/i386/hvf-utils/x86_flags.c | 333 ++++++ target/i386/hvf-utils/x86_flags.h | 243 ++++ target/i386/hvf-utils/x86_gen.h | 36 + target/i386/hvf-utils/x86_mmu.c | 273 +++++ target/i386/hvf-utils/x86_mmu.h | 28 + target/i386/hvf-utils/x86hvf.c | 463 ++++++++ target/i386/hvf-utils/x86hvf.h | 22 + target/i386/kvm.c | 2 - vl.c | 7 + 36 files changed, 8957 insertions(+), 34 deletions(-) create mode 100644 include/sysemu/hvf.h create mode 100644 target/i386/hvf-all.c create mode 100644 target/i386/hvf-i386.h create mode 100644 target/i386/hvf-utils/Makefile.objs create mode 100644 target/i386/hvf-utils/README.md create mode 100644 target/i386/hvf-utils/vmcs.h create mode 100644 target/i386/hvf-utils/vmx.h create mode 100644 target/i386/hvf-utils/x86.c create mode 100644 target/i386/hvf-utils/x86.h create mode 100644 target/i386/hvf-utils/x86_cpuid.c create mode 100644 target/i386/hvf-utils/x86_cpuid.h create mode 100644 target/i386/hvf-utils/x86_decode.c create mode 100644 target/i386/hvf-utils/x86_decode.h create mode 100644 target/i386/hvf-utils/x86_descr.c create mode 100644 target/i386/hvf-utils/x86_descr.h create mode 100644 target/i386/hvf-utils/x86_emu.c create mode 100644 target/i386/hvf-utils/x86_emu.h create mode 100644 target/i386/hvf-utils/x86_flags.c create mode 100644 target/i386/hvf-utils/x86_flags.h create mode 100644 target/i386/hvf-utils/x86_gen.h create mode 100644 target/i386/hvf-utils/x86_mmu.c create mode 100644 target/i386/hvf-utils/x86_mmu.h create mode 100644 target/i386/hvf-utils/x86hvf.c create mode 100644 target/i386/hvf-utils/x86hvf.h
The following patchset adds to QEMU the supporting for macOS's native hypervisor, Hypervisor.framework (hvf). The code base is taken from Google's Android emulator at https://android.googlesource.com/platform/external/qemu/+/emu-master-dev. Apart from general code refactoring, some additional features were implemented: retrieve the set of features supported by host cpu and hvf (cpuid); dirty page tracking for VGA memory area; reimplementation of the event injection mechanism to allow injection of exceptions during vmexits, which is exemplified by the injection of a GP fault when the guest vmexits due to execution of the vmcall instruction; changing the emulator's use of CPUState structure in favor of CPUX86State, so as to in the future remove data structures that are uselessly specific to hvf and unified some of the state between kvm/tcg and hvf. Some features initially planned to implement that didn't make it include: page fault handling in the emulator and implementing the dummy_signal to handle the SIG_IPI signal without race conditions. Hopefully these can be implemented in the near future. Sergio Andres Gomez Del Real (14): hvf: add support for Hypervisor.framework in the configure script hvf: add code base from Google's QEMU repository hvf: add conditional macros around hvf code in cpus.c hvf: add fields to CPUState and CPUX86State; add definitions hvf: use new helper functions for put/get xsave hvf: add compilation rules to Makefile.objs hvf: run hvf code through checkpatch.pl and fix style issues apic: add function to apic that will be used by hvf hvf: implement hvf_get_supported_cpuid hvf: refactor cpuid code hvf: implement vga dirty page tracking hvf: move fields from CPUState to CPUX86State hvf: refactor event injection code for hvf hvf: inject General Protection Fault when vmexit through vmcall configure | 32 + cpus.c | 107 +- hw/intc/apic.c | 11 + include/hw/i386/apic.h | 1 + include/qom/cpu.h | 2 + include/sysemu/hvf.h | 106 ++ qemu-options.hx | 20 +- target/i386/Makefile.objs | 1 + target/i386/cpu-qom.h | 4 +- target/i386/cpu.c | 111 +- target/i386/cpu.h | 30 + target/i386/hvf-all.c | 1123 ++++++++++++++++++ target/i386/hvf-i386.h | 48 + target/i386/hvf-utils/Makefile.objs | 1 + target/i386/hvf-utils/README.md | 7 + target/i386/hvf-utils/vmcs.h | 371 ++++++ target/i386/hvf-utils/vmx.h | 222 ++++ target/i386/hvf-utils/x86.c | 184 +++ target/i386/hvf-utils/x86.h | 476 ++++++++ target/i386/hvf-utils/x86_cpuid.c | 417 +++++++ target/i386/hvf-utils/x86_cpuid.h | 52 + target/i386/hvf-utils/x86_decode.c | 2186 +++++++++++++++++++++++++++++++++++ target/i386/hvf-utils/x86_decode.h | 325 ++++++ target/i386/hvf-utils/x86_descr.c | 124 ++ target/i386/hvf-utils/x86_descr.h | 55 + target/i386/hvf-utils/x86_emu.c | 1536 ++++++++++++++++++++++++ target/i386/hvf-utils/x86_emu.h | 32 + target/i386/hvf-utils/x86_flags.c | 333 ++++++ target/i386/hvf-utils/x86_flags.h | 243 ++++ target/i386/hvf-utils/x86_gen.h | 36 + target/i386/hvf-utils/x86_mmu.c | 273 +++++ target/i386/hvf-utils/x86_mmu.h | 28 + target/i386/hvf-utils/x86hvf.c | 463 ++++++++ target/i386/hvf-utils/x86hvf.h | 22 + target/i386/kvm.c | 2 - vl.c | 7 + 36 files changed, 8957 insertions(+), 34 deletions(-) create mode 100644 include/sysemu/hvf.h create mode 100644 target/i386/hvf-all.c create mode 100644 target/i386/hvf-i386.h create mode 100644 target/i386/hvf-utils/Makefile.objs create mode 100644 target/i386/hvf-utils/README.md create mode 100644 target/i386/hvf-utils/vmcs.h create mode 100644 target/i386/hvf-utils/vmx.h create mode 100644 target/i386/hvf-utils/x86.c create mode 100644 target/i386/hvf-utils/x86.h create mode 100644 target/i386/hvf-utils/x86_cpuid.c create mode 100644 target/i386/hvf-utils/x86_cpuid.h create mode 100644 target/i386/hvf-utils/x86_decode.c create mode 100644 target/i386/hvf-utils/x86_decode.h create mode 100644 target/i386/hvf-utils/x86_descr.c create mode 100644 target/i386/hvf-utils/x86_descr.h create mode 100644 target/i386/hvf-utils/x86_emu.c create mode 100644 target/i386/hvf-utils/x86_emu.h create mode 100644 target/i386/hvf-utils/x86_flags.c create mode 100644 target/i386/hvf-utils/x86_flags.h create mode 100644 target/i386/hvf-utils/x86_gen.h create mode 100644 target/i386/hvf-utils/x86_mmu.c create mode 100644 target/i386/hvf-utils/x86_mmu.h create mode 100644 target/i386/hvf-utils/x86hvf.c create mode 100644 target/i386/hvf-utils/x86hvf.h -- 2.14.1 Subject: [PATCH 00/15]
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Subject: [Qemu-devel] [PATCH 00/14] add support for Hypervisor.framework in QEMU
Message-id: 20170828015654.2530-1-Sergio.G.DelReal@gmail.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20170828015654.2530-1-Sergio.G.DelReal@gmail.com -> patchew/20170828015654.2530-1-Sergio.G.DelReal@gmail.com
Switched to a new branch 'test'
b279706053 hvf: inject General Protection Fault when vmexit through vmcall
3f4eacf577 hvf: refactor event injection code for hvf
6aa5077cc9 hvf: move fields from CPUState to CPUX86State
a6d5a70cee hvf: implement vga dirty page tracking
8c4e7701f9 hvf: refactor cpuid code
b6fd2efc4a hvf: implement hvf_get_supported_cpuid
c0e093a40a apic: add function to apic that will be used by hvf
eb479acf42 hvf: run hvf code through checkpatch.pl and fix style issues
19a4b813a6 hvf: add compilation rules to Makefile.objs
977ccbfd5a hvf: use new helper functions for put/get xsave
1f90c0f943 hvf: add fields to CPUState and CPUX86State; add definitions
f5c67bec92 hvf: add conditional macros around hvf code in cpus.c
33276f37df hvf: add code base from Google's QEMU repository
18621fd06c hvf: add support for Hypervisor.framework in the configure script
=== OUTPUT BEGIN ===
Checking PATCH 1/14: hvf: add support for Hypervisor.framework in the configure script...
Checking PATCH 2/14: hvf: add code base from Google's QEMU repository...
Argument "m" isn't numeric in numeric eq (==) at ./scripts/checkpatch.pl line 2479.
Argument "m" isn't numeric in numeric eq (==) at ./scripts/checkpatch.pl line 2479.
Use of uninitialized value $1 in concatenation (.) or string at ./scripts/checkpatch.pl line 2480.
Argument "m" isn't numeric in numeric eq (==) at ./scripts/checkpatch.pl line 2479.
Use of uninitialized value $1 in concatenation (.) or string at ./scripts/checkpatch.pl line 2480.
Argument "m" isn't numeric in numeric eq (==) at ./scripts/checkpatch.pl line 2479.
Use of uninitialized value $1 in concatenation (.) or string at ./scripts/checkpatch.pl line 2480.
ERROR: line over 90 characters
#129: FILE: include/sysemu/hvf.h:59:
+/* Disable HVF if |disable| is 1, otherwise, enable it iff it is supported by the host CPU.
WARNING: line over 80 characters
#133: FILE: include/sysemu/hvf.h:63:
+/* Returns non-0 if the host CPU supports the VMX "unrestricted guest" feature which
WARNING: line over 80 characters
#134: FILE: include/sysemu/hvf.h:64:
+ * allows the virtual CPU to directly run in "real mode". If true, this allows QEMU to run
WARNING: line over 80 characters
#135: FILE: include/sysemu/hvf.h:65:
+ * several vCPU threads in parallel (see cpus.c). Otherwise, only a a single TCG thread
WARNING: line over 80 characters
#136: FILE: include/sysemu/hvf.h:66:
+ * can run, and it will call HVF to run the current instructions, except in case of
WARNING: line over 80 characters
#138: FILE: include/sysemu/hvf.h:68:
+// int hvf_ug_platform(void); does not apply to HVF; assume we must be in UG mode
ERROR: do not use C99 // comments
#138: FILE: include/sysemu/hvf.h:68:
+// int hvf_ug_platform(void); does not apply to HVF; assume we must be in UG mode
ERROR: do not use C99 // comments
#152: FILE: include/sysemu/hvf.h:82:
+// void hvf_reset_vcpu_state(void *opaque);
ERROR: braces {} are necessary for all arms of this statement
#209: FILE: target/i386/hvf-all.c:37:
+ if (ret == HV_SUCCESS)
[...]
ERROR: switch and case should be at the same indent
#212: FILE: target/i386/hvf-all.c:40:
+ switch (ret) {
+ case HV_ERROR:
[...]
+ case HV_BUSY:
[...]
+ case HV_BAD_ARGUMENT:
[...]
+ case HV_NO_RESOURCES:
[...]
+ case HV_NO_DEVICE:
[...]
+ case HV_UNSUPPORTED:
[...]
+ default:
ERROR: do not use C99 // comments
#238: FILE: target/i386/hvf-all.c:66:
+// Memory slots/////////////////////////////////////////////////////////////////
ERROR: open brace '{' following function declarations go on the next line
#240: FILE: target/i386/hvf-all.c:68:
+hvf_slot *hvf_find_overlap_slot(uint64_t start, uint64_t end) {
WARNING: line over 80 characters
#245: FILE: target/i386/hvf-all.c:73:
+ if (slot->size && start < (slot->start + slot->size) && end > slot->start)
ERROR: braces {} are necessary for all arms of this statement
#245: FILE: target/i386/hvf-all.c:73:
+ if (slot->size && start < (slot->start + slot->size) && end > slot->start)
[...]
ERROR: spaces required around that '+' (ctx:VxV)
#259: FILE: target/i386/hvf-all.c:87:
+#define ALIGN(x, y) (((x)+(y)-1) & ~((y)-1))
^
ERROR: spaces required around that '-' (ctx:VxV)
#259: FILE: target/i386/hvf-all.c:87:
+#define ALIGN(x, y) (((x)+(y)-1) & ~((y)-1))
^
ERROR: spaces required around that '-' (ctx:VxV)
#259: FILE: target/i386/hvf-all.c:87:
+#define ALIGN(x, y) (((x)+(y)-1) & ~((y)-1))
^
ERROR: "foo* bar" should be "foo *bar"
#294: FILE: target/i386/hvf-all.c:122:
+void hvf_set_phys_mem(MemoryRegionSection* section, bool add)
ERROR: trailing statements should be on next line
#299: FILE: target/i386/hvf-all.c:127:
+ if (!memory_region_is_ram(area)) return;
ERROR: braces {} are necessary for all arms of this statement
#299: FILE: target/i386/hvf-all.c:127:
+ if (!memory_region_is_ram(area)) return;
[...]
ERROR: braces {} are necessary for all arms of this statement
#306: FILE: target/i386/hvf-all.c:134:
+ if (mem->size == int128_get64(section->size) &&
[...]
ERROR: line over 90 characters
#308: FILE: target/i386/hvf-all.c:136:
+ mem->mem == (memory_region_get_ram_ptr(area) + section->offset_within_region))
ERROR: do not use C99 // comments
#309: FILE: target/i386/hvf-all.c:137:
+ return; // Same region was attempted to register, go away.
ERROR: do not use C99 // comments
#312: FILE: target/i386/hvf-all.c:140:
+ // Region needs to be reset. set the size to 0 and remap it.
ERROR: trailing statements should be on next line
#321: FILE: target/i386/hvf-all.c:149:
+ if (!add) return;
ERROR: braces {} are necessary for all arms of this statement
#321: FILE: target/i386/hvf-all.c:149:
+ if (!add) return;
[...]
ERROR: do not use C99 // comments
#323: FILE: target/i386/hvf-all.c:151:
+ // Now make a new slot.
ERROR: braces {} are necessary for all arms of this statement
#328: FILE: target/i386/hvf-all.c:156:
+ if (!mem->size)
[...]
ERROR: do not use C99 // comments
#361: FILE: target/i386/hvf-all.c:189:
+ // TODO: need integrate APIC handling
ERROR: braces {} are necessary for all arms of this statement
#367: FILE: target/i386/hvf-all.c:195:
+ if (irr == -1)
[...]
+ else
[...]
WARNING: line over 80 characters
#370: FILE: target/i386/hvf-all.c:198:
+ wvmcs(cpu->hvf_fd, VMCS_TPR_THRESHOLD, (irr > tpr) ? tpr >> 4 : irr >> 4);
ERROR: do not use C99 // comments
#382: FILE: target/i386/hvf-all.c:210:
+// TODO: taskswitch handling
WARNING: line over 80 characters
#422: FILE: target/i386/hvf-all.c:250:
+ vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->ldt}}, REG_SEG_LDTR);
ERROR: space required before the open brace '{'
#422: FILE: target/i386/hvf-all.c:250:
+ vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->ldt}}, REG_SEG_LDTR);
ERROR: space required after that close brace '}'
#422: FILE: target/i386/hvf-all.c:250:
+ vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->ldt}}, REG_SEG_LDTR);
WARNING: line over 80 characters
#423: FILE: target/i386/hvf-all.c:251:
+ vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->es}}, REG_SEG_ES);
ERROR: space required before the open brace '{'
#423: FILE: target/i386/hvf-all.c:251:
+ vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->es}}, REG_SEG_ES);
ERROR: space required after that close brace '}'
#423: FILE: target/i386/hvf-all.c:251:
+ vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->es}}, REG_SEG_ES);
WARNING: line over 80 characters
#424: FILE: target/i386/hvf-all.c:252:
+ vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->cs}}, REG_SEG_CS);
ERROR: space required before the open brace '{'
#424: FILE: target/i386/hvf-all.c:252:
+ vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->cs}}, REG_SEG_CS);
ERROR: space required after that close brace '}'
#424: FILE: target/i386/hvf-all.c:252:
+ vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->cs}}, REG_SEG_CS);
WARNING: line over 80 characters
#425: FILE: target/i386/hvf-all.c:253:
+ vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->ss}}, REG_SEG_SS);
ERROR: space required before the open brace '{'
#425: FILE: target/i386/hvf-all.c:253:
+ vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->ss}}, REG_SEG_SS);
ERROR: space required after that close brace '}'
#425: FILE: target/i386/hvf-all.c:253:
+ vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->ss}}, REG_SEG_SS);
WARNING: line over 80 characters
#426: FILE: target/i386/hvf-all.c:254:
+ vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->ds}}, REG_SEG_DS);
ERROR: space required before the open brace '{'
#426: FILE: target/i386/hvf-all.c:254:
+ vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->ds}}, REG_SEG_DS);
ERROR: space required after that close brace '}'
#426: FILE: target/i386/hvf-all.c:254:
+ vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->ds}}, REG_SEG_DS);
WARNING: line over 80 characters
#427: FILE: target/i386/hvf-all.c:255:
+ vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->fs}}, REG_SEG_FS);
ERROR: space required before the open brace '{'
#427: FILE: target/i386/hvf-all.c:255:
+ vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->fs}}, REG_SEG_FS);
ERROR: space required after that close brace '}'
#427: FILE: target/i386/hvf-all.c:255:
+ vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->fs}}, REG_SEG_FS);
WARNING: line over 80 characters
#428: FILE: target/i386/hvf-all.c:256:
+ vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->gs}}, REG_SEG_GS);
ERROR: space required before the open brace '{'
#428: FILE: target/i386/hvf-all.c:256:
+ vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->gs}}, REG_SEG_GS);
ERROR: space required after that close brace '}'
#428: FILE: target/i386/hvf-all.c:256:
+ vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->gs}}, REG_SEG_GS);
ERROR: if this code is redundant consider removing it
#430: FILE: target/i386/hvf-all.c:258:
+#if 0
ERROR: line over 90 characters
#441: FILE: target/i386/hvf-all.c:269:
+static int task_switch_32(CPUState *cpu, x68_segment_selector tss_sel, x68_segment_selector old_tss_sel,
WARNING: line over 80 characters
#442: FILE: target/i386/hvf-all.c:270:
+ uint64_t old_tss_base, struct x86_segment_descriptor *new_desc)
ERROR: line over 90 characters
#452: FILE: target/i386/hvf-all.c:280:
+ vmx_write_mem(cpu, old_tss_base + eip_offset, &tss_seg.eip, ldt_sel_offset - eip_offset);
WARNING: line over 80 characters
#458: FILE: target/i386/hvf-all.c:286:
+ vmx_write_mem(cpu, new_tss_base, &tss_seg.prev_tss, sizeof(tss_seg.prev_tss));
ERROR: line over 90 characters
#464: FILE: target/i386/hvf-all.c:292:
+static void vmx_handle_task_switch(CPUState *cpu, x68_segment_selector tss_sel, int reason, bool gate_valid, uint8_t gate, uint64_t gate_type)
WARNING: line over 80 characters
#479: FILE: target/i386/hvf-all.c:307:
+ x68_segment_selector old_tss_sel = vmx_read_segment_selector(cpu, REG_SEG_TR);
ERROR: braces {} are necessary for all arms of this statement
#495: FILE: target/i386/hvf-all.c:323:
+ if (tss_sel.rpl > dpl || cs.rpl > dpl)
[...]
ERROR: do not use C99 // comments
#496: FILE: target/i386/hvf-all.c:324:
+ ;//DPRINTF("emulate_gp");
ERROR: line over 90 characters
#500: FILE: target/i386/hvf-all.c:328:
+ if (!next_tss_desc.p || ((desc_limit < 0x67 && (next_tss_desc.type & 8)) || desc_limit < 0x2b)) {
ERROR: braces {} are necessary for all arms of this statement
#509: FILE: target/i386/hvf-all.c:337:
+ if (reason == TSR_IRET)
[...]
ERROR: braces {} are necessary for all arms of this statement
#512: FILE: target/i386/hvf-all.c:340:
+ if (reason != TSR_CALL && reason != TSR_IDT_GATE)
[...]
ERROR: braces {} are necessary for all arms of this statement
#520: FILE: target/i386/hvf-all.c:348:
+ if (next_tss_desc.type & 8)
[...]
+ else
[...]
WARNING: line over 80 characters
#521: FILE: target/i386/hvf-all.c:349:
+ ret = task_switch_32(cpu, tss_sel, old_tss_sel, old_tss_base, &next_tss_desc);
WARNING: line over 80 characters
#523: FILE: target/i386/hvf-all.c:351:
+ //ret = task_switch_16(cpu, tss_sel, old_tss_sel, old_tss_base, &next_tss_desc);
ERROR: do not use C99 // comments
#523: FILE: target/i386/hvf-all.c:351:
+ //ret = task_switch_16(cpu, tss_sel, old_tss_sel, old_tss_base, &next_tss_desc);
ERROR: "foo * bar" should be "foo *bar"
#536: FILE: target/i386/hvf-all.c:364:
+static void hvf_handle_interrupt(CPUState * cpu, int mask)
ERROR: "foo * bar" should be "foo *bar"
#544: FILE: target/i386/hvf-all.c:372:
+void hvf_handle_io(CPUArchState * env, uint16_t port, void* buffer,
ERROR: do not use C99 // comments
#557: FILE: target/i386/hvf-all.c:385:
+//
ERROR: do not use C99 // comments
#558: FILE: target/i386/hvf-all.c:386:
+// TODO: synchronize vcpu state
ERROR: do not use C99 // comments
#561: FILE: target/i386/hvf-all.c:389:
+ CPUState *cpu_state = cpu;//(CPUState *)data;
ERROR: braces {} are necessary for all arms of this statement
#562: FILE: target/i386/hvf-all.c:390:
+ if (cpu_state->hvf_vcpu_dirty == 0)
[...]
ERROR: braces {} are necessary for all arms of this statement
#570: FILE: target/i386/hvf-all.c:398:
+ if (cpu_state->hvf_vcpu_dirty == 0)
[...]
ERROR: trailing whitespace
#597: FILE: target/i386/hvf-all.c:425:
+ $
ERROR: do not use C99 // comments
#598: FILE: target/i386/hvf-all.c:426:
+// TODO: ept fault handlig
ERROR: externs should be avoided in .c files
#599: FILE: target/i386/hvf-all.c:427:
+void vmx_clear_int_window_exiting(CPUState *cpu);
ERROR: code indent should never use tabs
#602: FILE: target/i386/hvf-all.c:430:
+^Iint read, write;$
ERROR: code indent should never use tabs
#604: FILE: target/i386/hvf-all.c:432:
+^I/* EPT fault on an instruction fetch doesn't make sense here */$
ERROR: code indent should never use tabs
#605: FILE: target/i386/hvf-all.c:433:
+^Iif (ept_qual & EPT_VIOLATION_INST_FETCH)$
ERROR: braces {} are necessary for all arms of this statement
#605: FILE: target/i386/hvf-all.c:433:
+ if (ept_qual & EPT_VIOLATION_INST_FETCH)
[...]
ERROR: code indent should never use tabs
#606: FILE: target/i386/hvf-all.c:434:
+^I^Ireturn false;$
ERROR: code indent should never use tabs
#608: FILE: target/i386/hvf-all.c:436:
+^I/* EPT fault must be a read fault or a write fault */$
ERROR: code indent should never use tabs
#609: FILE: target/i386/hvf-all.c:437:
+^Iread = ept_qual & EPT_VIOLATION_DATA_READ ? 1 : 0;$
ERROR: code indent should never use tabs
#610: FILE: target/i386/hvf-all.c:438:
+^Iwrite = ept_qual & EPT_VIOLATION_DATA_WRITE ? 1 : 0;$
ERROR: code indent should never use tabs
#611: FILE: target/i386/hvf-all.c:439:
+^Iif ((read | write) == 0)$
ERROR: braces {} are necessary for all arms of this statement
#611: FILE: target/i386/hvf-all.c:439:
+ if ((read | write) == 0)
[...]
ERROR: code indent should never use tabs
#612: FILE: target/i386/hvf-all.c:440:
+^I^Ireturn false;$
ERROR: code indent should never use tabs
#614: FILE: target/i386/hvf-all.c:442:
+^I/*$
ERROR: code indent should never use tabs
#615: FILE: target/i386/hvf-all.c:443:
+^I * The EPT violation must have been caused by accessing a$
ERROR: code indent should never use tabs
#616: FILE: target/i386/hvf-all.c:444:
+^I * guest-physical address that is a translation of a guest-linear$
ERROR: code indent should never use tabs
#617: FILE: target/i386/hvf-all.c:445:
+^I * address.$
ERROR: code indent should never use tabs
#618: FILE: target/i386/hvf-all.c:446:
+^I */$
ERROR: code indent should never use tabs
#619: FILE: target/i386/hvf-all.c:447:
+^Iif ((ept_qual & EPT_VIOLATION_GLA_VALID) == 0 ||$
ERROR: code indent should never use tabs
#620: FILE: target/i386/hvf-all.c:448:
+^I (ept_qual & EPT_VIOLATION_XLAT_VALID) == 0) {$
ERROR: code indent should never use tabs
#621: FILE: target/i386/hvf-all.c:449:
+^I^Ireturn false;$
ERROR: code indent should never use tabs
#622: FILE: target/i386/hvf-all.c:450:
+^I}$
ERROR: code indent should never use tabs
#624: FILE: target/i386/hvf-all.c:452:
+^Ireturn true;$
ERROR: "foo * bar" should be "foo *bar"
#627: FILE: target/i386/hvf-all.c:455:
+static void hvf_region_add(MemoryListener * listener,
ERROR: "foo * bar" should be "foo *bar"
#628: FILE: target/i386/hvf-all.c:456:
+ MemoryRegionSection * section)
ERROR: "foo * bar" should be "foo *bar"
#633: FILE: target/i386/hvf-all.c:461:
+static void hvf_region_del(MemoryListener * listener,
ERROR: "foo * bar" should be "foo *bar"
#634: FILE: target/i386/hvf-all.c:462:
+ MemoryRegionSection * section)
ERROR: open brace '{' following function declarations go on the next line
#649: FILE: target/i386/hvf-all.c:477:
+void vmx_reset_vcpu(CPUState *cpu) {
ERROR: do not use C99 // comments
#659: FILE: target/i386/hvf-all.c:487:
+ // set VMCS guest state fields
ERROR: do not use C99 // comments
#706: FILE: target/i386/hvf-all.c:534:
+ //wvmcs(cpu->hvf_fd, VMCS_GUEST_CR2, 0x0);
ERROR: suspect code indent for conditional statements (4, 9)
#720: FILE: target/i386/hvf-all.c:548:
+ for (int i = 0; i < 8; i++)
+ wreg(cpu->hvf_fd, HV_X86_R8+i, 0x0);
ERROR: braces {} are necessary even for single statement blocks
#720: FILE: target/i386/hvf-all.c:548:
+ for (int i = 0; i < 8; i++)
+ wreg(cpu->hvf_fd, HV_X86_R8+i, 0x0);
ERROR: spaces required around that '+' (ctx:VxV)
#721: FILE: target/i386/hvf-all.c:549:
+ wreg(cpu->hvf_fd, HV_X86_R8+i, 0x0);
^
ERROR: trailing whitespace
#729: FILE: target/i386/hvf-all.c:557:
+void hvf_vcpu_destroy(CPUState* cpu) $
ERROR: "foo* bar" should be "foo *bar"
#729: FILE: target/i386/hvf-all.c:557:
+void hvf_vcpu_destroy(CPUState* cpu)
ERROR: "foo * bar" should be "foo *bar"
#739: FILE: target/i386/hvf-all.c:567:
+int hvf_init_vcpu(CPUState * cpu) {
ERROR: open brace '{' following function declarations go on the next line
#739: FILE: target/i386/hvf-all.c:567:
+int hvf_init_vcpu(CPUState * cpu) {
ERROR: trailing whitespace
#742: FILE: target/i386/hvf-all.c:570:
+ $
ERROR: do not use C99 // comments
#743: FILE: target/i386/hvf-all.c:571:
+ // init cpu signals
WARNING: line over 80 characters
#759: FILE: target/i386/hvf-all.c:587:
+ cpu->hvf_caps = (struct hvf_vcpu_caps*)g_malloc0(sizeof(struct hvf_vcpu_caps));
ERROR: "(foo*)" should be "(foo *)"
#759: FILE: target/i386/hvf-all.c:587:
+ cpu->hvf_caps = (struct hvf_vcpu_caps*)g_malloc0(sizeof(struct hvf_vcpu_caps));
ERROR: unnecessary cast may hide bugs, use g_new0 instead
#759: FILE: target/i386/hvf-all.c:587:
+ cpu->hvf_caps = (struct hvf_vcpu_caps*)g_malloc0(sizeof(struct hvf_vcpu_caps));
WARNING: line over 80 characters
#760: FILE: target/i386/hvf-all.c:588:
+ cpu->hvf_x86 = (struct hvf_x86_state*)g_malloc0(sizeof(struct hvf_x86_state));
ERROR: "(foo*)" should be "(foo *)"
#760: FILE: target/i386/hvf-all.c:588:
+ cpu->hvf_x86 = (struct hvf_x86_state*)g_malloc0(sizeof(struct hvf_x86_state));
ERROR: unnecessary cast may hide bugs, use g_new0 instead
#760: FILE: target/i386/hvf-all.c:588:
+ cpu->hvf_x86 = (struct hvf_x86_state*)g_malloc0(sizeof(struct hvf_x86_state));
WARNING: line over 80 characters
#766: FILE: target/i386/hvf-all.c:594:
+ if (hv_vmx_read_capability(HV_VMX_CAP_PINBASED, &cpu->hvf_caps->vmx_cap_pinbased))
ERROR: code indent should never use tabs
#766: FILE: target/i386/hvf-all.c:594:
+^Iif (hv_vmx_read_capability(HV_VMX_CAP_PINBASED, &cpu->hvf_caps->vmx_cap_pinbased))$
ERROR: braces {} are necessary for all arms of this statement
#766: FILE: target/i386/hvf-all.c:594:
+ if (hv_vmx_read_capability(HV_VMX_CAP_PINBASED, &cpu->hvf_caps->vmx_cap_pinbased))
[...]
ERROR: code indent should never use tabs
#767: FILE: target/i386/hvf-all.c:595:
+^I^Iabort();$
ERROR: line over 90 characters
#768: FILE: target/i386/hvf-all.c:596:
+ if (hv_vmx_read_capability(HV_VMX_CAP_PROCBASED, &cpu->hvf_caps->vmx_cap_procbased))
ERROR: code indent should never use tabs
#768: FILE: target/i386/hvf-all.c:596:
+^Iif (hv_vmx_read_capability(HV_VMX_CAP_PROCBASED, &cpu->hvf_caps->vmx_cap_procbased))$
ERROR: braces {} are necessary for all arms of this statement
#768: FILE: target/i386/hvf-all.c:596:
+ if (hv_vmx_read_capability(HV_VMX_CAP_PROCBASED, &cpu->hvf_caps->vmx_cap_procbased))
[...]
ERROR: code indent should never use tabs
#769: FILE: target/i386/hvf-all.c:597:
+^I^Iabort();$
ERROR: line over 90 characters
#770: FILE: target/i386/hvf-all.c:598:
+ if (hv_vmx_read_capability(HV_VMX_CAP_PROCBASED2, &cpu->hvf_caps->vmx_cap_procbased2))
ERROR: code indent should never use tabs
#770: FILE: target/i386/hvf-all.c:598:
+^Iif (hv_vmx_read_capability(HV_VMX_CAP_PROCBASED2, &cpu->hvf_caps->vmx_cap_procbased2))$
ERROR: braces {} are necessary for all arms of this statement
#770: FILE: target/i386/hvf-all.c:598:
+ if (hv_vmx_read_capability(HV_VMX_CAP_PROCBASED2, &cpu->hvf_caps->vmx_cap_procbased2))
[...]
ERROR: code indent should never use tabs
#771: FILE: target/i386/hvf-all.c:599:
+^I^Iabort();$
WARNING: line over 80 characters
#772: FILE: target/i386/hvf-all.c:600:
+ if (hv_vmx_read_capability(HV_VMX_CAP_ENTRY, &cpu->hvf_caps->vmx_cap_entry))
ERROR: code indent should never use tabs
#772: FILE: target/i386/hvf-all.c:600:
+^Iif (hv_vmx_read_capability(HV_VMX_CAP_ENTRY, &cpu->hvf_caps->vmx_cap_entry))$
ERROR: braces {} are necessary for all arms of this statement
#772: FILE: target/i386/hvf-all.c:600:
+ if (hv_vmx_read_capability(HV_VMX_CAP_ENTRY, &cpu->hvf_caps->vmx_cap_entry))
[...]
ERROR: code indent should never use tabs
#773: FILE: target/i386/hvf-all.c:601:
+^I^Iabort();$
ERROR: code indent should never use tabs
#775: FILE: target/i386/hvf-all.c:603:
+^I/* set VMCS control fields */$
WARNING: line over 80 characters
#776: FILE: target/i386/hvf-all.c:604:
+ wvmcs(cpu->hvf_fd, VMCS_PIN_BASED_CTLS, cap2ctrl(cpu->hvf_caps->vmx_cap_pinbased, 0));
ERROR: line over 90 characters
#777: FILE: target/i386/hvf-all.c:605:
+ wvmcs(cpu->hvf_fd, VMCS_PRI_PROC_BASED_CTLS, cap2ctrl(cpu->hvf_caps->vmx_cap_procbased,
WARNING: line over 80 characters
#778: FILE: target/i386/hvf-all.c:606:
+ VMCS_PRI_PROC_BASED_CTLS_HLT |
WARNING: line over 80 characters
#779: FILE: target/i386/hvf-all.c:607:
+ VMCS_PRI_PROC_BASED_CTLS_MWAIT |
WARNING: line over 80 characters
#780: FILE: target/i386/hvf-all.c:608:
+ VMCS_PRI_PROC_BASED_CTLS_TSC_OFFSET |
WARNING: line over 80 characters
#781: FILE: target/i386/hvf-all.c:609:
+ VMCS_PRI_PROC_BASED_CTLS_TPR_SHADOW) |
WARNING: line over 80 characters
#782: FILE: target/i386/hvf-all.c:610:
+ VMCS_PRI_PROC_BASED_CTLS_SEC_CONTROL);
ERROR: code indent should never use tabs
#783: FILE: target/i386/hvf-all.c:611:
+^Iwvmcs(cpu->hvf_fd, VMCS_SEC_PROC_BASED_CTLS,$
ERROR: line over 90 characters
#784: FILE: target/i386/hvf-all.c:612:
+ cap2ctrl(cpu->hvf_caps->vmx_cap_procbased2,VMCS_PRI_PROC_BASED2_CTLS_APIC_ACCESSES));
ERROR: space required after that ',' (ctx:VxV)
#784: FILE: target/i386/hvf-all.c:612:
+ cap2ctrl(cpu->hvf_caps->vmx_cap_procbased2,VMCS_PRI_PROC_BASED2_CTLS_APIC_ACCESSES));
^
WARNING: line over 80 characters
#786: FILE: target/i386/hvf-all.c:614:
+ wvmcs(cpu->hvf_fd, VMCS_ENTRY_CTLS, cap2ctrl(cpu->hvf_caps->vmx_cap_entry, 0));
ERROR: code indent should never use tabs
#786: FILE: target/i386/hvf-all.c:614:
+^Iwvmcs(cpu->hvf_fd, VMCS_ENTRY_CTLS, cap2ctrl(cpu->hvf_caps->vmx_cap_entry, 0));$
ERROR: code indent should never use tabs
#787: FILE: target/i386/hvf-all.c:615:
+^Iwvmcs(cpu->hvf_fd, VMCS_EXCEPTION_BITMAP, 0); /* Double fault */$
WARNING: line over 80 characters
#794: FILE: target/i386/hvf-all.c:622:
+ x86cpu->env.kvm_xsave_buf = qemu_memalign(4096, sizeof(struct hvf_xsave_buf));
ERROR: do not use C99 // comments
#804: FILE: target/i386/hvf-all.c:632:
+ //hv_vcpu_enable_native_msr(cpu->hvf_fd, MSR_IA32_TSC, 1);
ERROR: open brace '{' following function declarations go on the next line
#813: FILE: target/i386/hvf-all.c:641:
+void hvf_disable(int shouldDisable) {
ERROR: "foo* bar" should be "foo *bar"
#817: FILE: target/i386/hvf-all.c:645:
+int hvf_vcpu_exec(CPUState* cpu) {
ERROR: open brace '{' following function declarations go on the next line
#817: FILE: target/i386/hvf-all.c:645:
+int hvf_vcpu_exec(CPUState* cpu) {
WARNING: line over 80 characters
#837: FILE: target/i386/hvf-all.c:665:
+ (VMCS_INTERRUPTIBILITY_STI_BLOCKING | VMCS_INTERRUPTIBILITY_MOVSS_BLOCKING));
WARNING: line over 80 characters
#855: FILE: target/i386/hvf-all.c:683:
+ uint32_t ins_len = (uint32_t)rvmcs(cpu->hvf_fd, VMCS_EXIT_INSTRUCTION_LENGTH);
ERROR: switch and case should be at the same indent
#869: FILE: target/i386/hvf-all.c:697:
+ switch (exit_reason) {
[...]
+ case EXIT_REASON_EPT_FAULT:
[...]
+ case EXIT_REASON_INOUT:
[...]
+ case EXIT_REASON_INTR_WINDOW:
[...]
+ case EXIT_REASON_NMI_WINDOW:
[...]
+ case EXIT_REASON_EXT_INTR:
[...]
+ case EXIT_REASON_RDMSR:
+ case EXIT_REASON_WRMSR:
[...]
+ case EXIT_REASON_RDPMC:
[...]
+ case VMX_REASON_VMCALL:
[...]
+ default:
ERROR: line over 90 characters
#872: FILE: target/i386/hvf-all.c:700:
+ if (!((cpu->interrupt_request & CPU_INTERRUPT_HARD) && (EFLAGS(cpu) & IF_MASK))
ERROR: line over 90 characters
#892: FILE: target/i386/hvf-all.c:720:
+ if ((idtvec_info & VMCS_IDT_VEC_VALID) == 0 && (exit_qual & EXIT_QUAL_NMIUDTI) != 0)
ERROR: braces {} are necessary for all arms of this statement
#892: FILE: target/i386/hvf-all.c:720:
+ if ((idtvec_info & VMCS_IDT_VEC_VALID) == 0 && (exit_qual & EXIT_QUAL_NMIUDTI) != 0)
[...]
ERROR: do not use C99 // comments
#896: FILE: target/i386/hvf-all.c:724:
+ // mmio
ERROR: braces {} are necessary for all arms of this statement
#912: FILE: target/i386/hvf-all.c:740:
+ if (!read && !write)
[...]
ERROR: trailing statements should be on next line
#915: FILE: target/i386/hvf-all.c:743:
+ if (write) flags |= HV_MEMORY_WRITE;
ERROR: braces {} are necessary for all arms of this statement
#915: FILE: target/i386/hvf-all.c:743:
+ if (write) flags |= HV_MEMORY_WRITE;
[...]
ERROR: braces {} are necessary for all arms of this statement
#918: FILE: target/i386/hvf-all.c:746:
+ if (write)
[...]
ERROR: do not use C99 // comments
#932: FILE: target/i386/hvf-all.c:760:
+ //uint32_t rep = (exit_qual & 0x20) != 0;
ERROR: trailing statements should be on next line
#939: FILE: target/i386/hvf-all.c:767:
+ if (size == 1) AL(cpu) = val;
ERROR: braces {} are necessary for all arms of this statement
#939: FILE: target/i386/hvf-all.c:767:
+ if (size == 1) AL(cpu) = val;
[...]
+ else if (size == 2) AX(cpu) = val;
[...]
+ else if (size == 4) RAX(cpu) = (uint32_t)val;
[...]
+ else VM_PANIC("size");
[...]
ERROR: trailing statements should be on next line
#940: FILE: target/i386/hvf-all.c:768:
+ else if (size == 2) AX(cpu) = val;
ERROR: braces {} are necessary for all arms of this statement
#940: FILE: target/i386/hvf-all.c:768:
+ else if (size == 2) AX(cpu) = val;
[...]
+ else if (size == 4) RAX(cpu) = (uint32_t)val;
[...]
+ else VM_PANIC("size");
[...]
ERROR: trailing statements should be on next line
#941: FILE: target/i386/hvf-all.c:769:
+ else if (size == 4) RAX(cpu) = (uint32_t)val;
ERROR: braces {} are necessary for all arms of this statement
#941: FILE: target/i386/hvf-all.c:769:
+ else if (size == 4) RAX(cpu) = (uint32_t)val;
[...]
+ else VM_PANIC("size");
[...]
ERROR: trailing statements should be on next line
#942: FILE: target/i386/hvf-all.c:770:
+ else VM_PANIC("size");
ERROR: braces {} are necessary for all arms of this statement
#1013: FILE: target/i386/hvf-all.c:841:
+ if (exit_reason == EXIT_REASON_RDMSR)
[...]
+ else
[...]
ERROR: switch and case should be at the same indent
#1029: FILE: target/i386/hvf-all.c:857:
+ switch (cr) {
[...]
+ default:
WARNING: line over 80 characters
#1041: FILE: target/i386/hvf-all.c:869:
+ RRX(cpu, reg) = cpu_get_apic_tpr(x86_cpu->apic_state);
ERROR: else should follow close brace '}'
#1043: FILE: target/i386/hvf-all.c:871:
+ }
+ else {
ERROR: do not use C99 // comments
#1058: FILE: target/i386/hvf-all.c:886:
+ case EXIT_REASON_APIC_ACCESS: { // TODO
ERROR: line over 90 characters
#1077: FILE: target/i386/hvf-all.c:905:
+ vinfo & VMCS_INTR_VALID, vinfo & VECTORING_INFO_VECTOR_MASK, vinfo & VMCS_INTR_T_MASK);
ERROR: do not use C99 // comments
#1081: FILE: target/i386/hvf-all.c:909:
+ //addr_t gpa = rvmcs(cpu->hvf_fd, VMCS_GUEST_PHYSICAL_ADDRESS);
ERROR: do not use C99 // comments
#1093: FILE: target/i386/hvf-all.c:921:
+ // TODO: maybe just take this out?
ERROR: do not use C99 // comments
#1094: FILE: target/i386/hvf-all.c:922:
+ // if (g_hypervisor_iface) {
ERROR: do not use C99 // comments
#1095: FILE: target/i386/hvf-all.c:923:
+ // load_regs(cpu);
ERROR: do not use C99 // comments
#1096: FILE: target/i386/hvf-all.c:924:
+ // g_hypervisor_iface->hypercall_handler(cpu);
WARNING: line over 80 characters
#1097: FILE: target/i386/hvf-all.c:925:
+ // RIP(cpu) += rvmcs(cpu->hvf_fd, VMCS_EXIT_INSTRUCTION_LENGTH);
ERROR: do not use C99 // comments
#1097: FILE: target/i386/hvf-all.c:925:
+ // RIP(cpu) += rvmcs(cpu->hvf_fd, VMCS_EXIT_INSTRUCTION_LENGTH);
ERROR: do not use C99 // comments
#1098: FILE: target/i386/hvf-all.c:926:
+ // store_regs(cpu);
ERROR: do not use C99 // comments
#1099: FILE: target/i386/hvf-all.c:927:
+ // }
WARNING: line over 80 characters
#1102: FILE: target/i386/hvf-all.c:930:
+ fprintf(stderr, "%llx: unhandled exit %llx\n", rip, exit_reason);
ERROR: unnecessary cast may hide bugs, use g_new0 instead
#1120: FILE: target/i386/hvf-all.c:948:
+ s = (HVFState *)g_malloc0(sizeof(HVFState));
ERROR: trailing whitespace
#1121: FILE: target/i386/hvf-all.c:949:
+ $
ERROR: trailing whitespace
#1127: FILE: target/i386/hvf-all.c:955:
+ $
ERROR: "foo * bar" should be "foo *bar"
#1204: FILE: target/i386/hvf-i386.h:44:
+int hvf_inject_interrupt(CPUArchState * env, int vector);
ERROR: code indent should never use tabs
#1264: FILE: target/i386/hvf-utils/vmcs.h:30:
+#define^I_VMCS_H_$
ERROR: code indent should never use tabs
#1269: FILE: target/i386/hvf-utils/vmcs.h:35:
+#define^IVMCS_INITIAL^I^I^I0xffffffffffffffff$
ERROR: code indent should never use tabs
#1271: FILE: target/i386/hvf-utils/vmcs.h:37:
+#define^IVMCS_IDENT(encoding)^I^I((encoding) | 0x80000000)$
ERROR: code indent should never use tabs
#1275: FILE: target/i386/hvf-utils/vmcs.h:41:
+#define^IVMCS_INVALID_ENCODING^I^I0xffffffff$
ERROR: code indent should never use tabs
#1278: FILE: target/i386/hvf-utils/vmcs.h:44:
+#define^IVMCS_VPID^I^I^I0x00000000$
ERROR: code indent should never use tabs
#1279: FILE: target/i386/hvf-utils/vmcs.h:45:
+#define^IVMCS_PIR_VECTOR^I^I^I0x00000002$
ERROR: code indent should never use tabs
#1282: FILE: target/i386/hvf-utils/vmcs.h:48:
+#define^IVMCS_GUEST_ES_SELECTOR^I^I0x00000800$
ERROR: code indent should never use tabs
#1283: FILE: target/i386/hvf-utils/vmcs.h:49:
+#define^IVMCS_GUEST_CS_SELECTOR^I^I0x00000802$
ERROR: code indent should never use tabs
#1284: FILE: target/i386/hvf-utils/vmcs.h:50:
+#define^IVMCS_GUEST_SS_SELECTOR^I^I0x00000804$
ERROR: code indent should never use tabs
#1285: FILE: target/i386/hvf-utils/vmcs.h:51:
+#define^IVMCS_GUEST_DS_SELECTOR^I^I0x00000806$
ERROR: code indent should never use tabs
#1286: FILE: target/i386/hvf-utils/vmcs.h:52:
+#define^IVMCS_GUEST_FS_SELECTOR^I^I0x00000808$
ERROR: code indent should never use tabs
#1287: FILE: target/i386/hvf-utils/vmcs.h:53:
+#define^IVMCS_GUEST_GS_SELECTOR^I^I0x0000080A$
ERROR: code indent should never use tabs
#1288: FILE: target/i386/hvf-utils/vmcs.h:54:
+#define^IVMCS_GUEST_LDTR_SELECTOR^I0x0000080C$
ERROR: code indent should never use tabs
#1289: FILE: target/i386/hvf-utils/vmcs.h:55:
+#define^IVMCS_GUEST_TR_SELECTOR^I^I0x0000080E$
ERROR: code indent should never use tabs
#1290: FILE: target/i386/hvf-utils/vmcs.h:56:
+#define^IVMCS_GUEST_INTR_STATUS^I^I0x00000810$
ERROR: code indent should never use tabs
#1293: FILE: target/i386/hvf-utils/vmcs.h:59:
+#define^IVMCS_HOST_ES_SELECTOR^I^I0x00000C00$
ERROR: code indent should never use tabs
#1294: FILE: target/i386/hvf-utils/vmcs.h:60:
+#define^IVMCS_HOST_CS_SELECTOR^I^I0x00000C02$
ERROR: code indent should never use tabs
#1295: FILE: target/i386/hvf-utils/vmcs.h:61:
+#define^IVMCS_HOST_SS_SELECTOR^I^I0x00000C04$
ERROR: code indent should never use tabs
#1296: FILE: target/i386/hvf-utils/vmcs.h:62:
+#define^IVMCS_HOST_DS_SELECTOR^I^I0x00000C06$
ERROR: code indent should never use tabs
#1297: FILE: target/i386/hvf-utils/vmcs.h:63:
+#define^IVMCS_HOST_FS_SELECTOR^I^I0x00000C08$
ERROR: code indent should never use tabs
#1298: FILE: target/i386/hvf-utils/vmcs.h:64:
+#define^IVMCS_HOST_GS_SELECTOR^I^I0x00000C0A$
ERROR: code indent should never use tabs
#1299: FILE: target/i386/hvf-utils/vmcs.h:65:
+#define^IVMCS_HOST_TR_SELECTOR^I^I0x00000C0C$
ERROR: code indent should never use tabs
#1302: FILE: target/i386/hvf-utils/vmcs.h:68:
+#define^IVMCS_IO_BITMAP_A^I^I0x00002000$
ERROR: code indent should never use tabs
#1303: FILE: target/i386/hvf-utils/vmcs.h:69:
+#define^IVMCS_IO_BITMAP_B^I^I0x00002002$
ERROR: code indent should never use tabs
#1304: FILE: target/i386/hvf-utils/vmcs.h:70:
+#define^IVMCS_MSR_BITMAP^I^I^I0x00002004$
ERROR: code indent should never use tabs
#1305: FILE: target/i386/hvf-utils/vmcs.h:71:
+#define^IVMCS_EXIT_MSR_STORE^I^I0x00002006$
ERROR: code indent should never use tabs
#1306: FILE: target/i386/hvf-utils/vmcs.h:72:
+#define^IVMCS_EXIT_MSR_LOAD^I^I0x00002008$
ERROR: code indent should never use tabs
#1307: FILE: target/i386/hvf-utils/vmcs.h:73:
+#define^IVMCS_ENTRY_MSR_LOAD^I^I0x0000200A$
ERROR: code indent should never use tabs
#1308: FILE: target/i386/hvf-utils/vmcs.h:74:
+#define^IVMCS_EXECUTIVE_VMCS^I^I0x0000200C$
ERROR: code indent should never use tabs
#1309: FILE: target/i386/hvf-utils/vmcs.h:75:
+#define^IVMCS_TSC_OFFSET^I^I^I0x00002010$
ERROR: code indent should never use tabs
#1310: FILE: target/i386/hvf-utils/vmcs.h:76:
+#define^IVMCS_VIRTUAL_APIC^I^I0x00002012$
ERROR: code indent should never use tabs
#1311: FILE: target/i386/hvf-utils/vmcs.h:77:
+#define^IVMCS_APIC_ACCESS^I^I0x00002014$
ERROR: code indent should never use tabs
#1312: FILE: target/i386/hvf-utils/vmcs.h:78:
+#define^IVMCS_PIR_DESC^I^I^I0x00002016$
ERROR: code indent should never use tabs
#1313: FILE: target/i386/hvf-utils/vmcs.h:79:
+#define^IVMCS_EPTP^I^I^I0x0000201A$
ERROR: code indent should never use tabs
#1314: FILE: target/i386/hvf-utils/vmcs.h:80:
+#define^IVMCS_EOI_EXIT0^I^I^I0x0000201C$
ERROR: code indent should never use tabs
#1315: FILE: target/i386/hvf-utils/vmcs.h:81:
+#define^IVMCS_EOI_EXIT1^I^I^I0x0000201E$
ERROR: code indent should never use tabs
#1316: FILE: target/i386/hvf-utils/vmcs.h:82:
+#define^IVMCS_EOI_EXIT2^I^I^I0x00002020$
ERROR: code indent should never use tabs
#1317: FILE: target/i386/hvf-utils/vmcs.h:83:
+#define^IVMCS_EOI_EXIT3^I^I^I0x00002022$
ERROR: code indent should never use tabs
#1318: FILE: target/i386/hvf-utils/vmcs.h:84:
+#define^IVMCS_EOI_EXIT(vector)^I^I(VMCS_EOI_EXIT0 + ((vector) / 64) * 2)$
ERROR: code indent should never use tabs
#1321: FILE: target/i386/hvf-utils/vmcs.h:87:
+#define^IVMCS_GUEST_PHYSICAL_ADDRESS^I0x00002400$
ERROR: code indent should never use tabs
#1324: FILE: target/i386/hvf-utils/vmcs.h:90:
+#define^IVMCS_LINK_POINTER^I^I0x00002800$
ERROR: code indent should never use tabs
#1325: FILE: target/i386/hvf-utils/vmcs.h:91:
+#define^IVMCS_GUEST_IA32_DEBUGCTL^I0x00002802$
ERROR: code indent should never use tabs
#1326: FILE: target/i386/hvf-utils/vmcs.h:92:
+#define^IVMCS_GUEST_IA32_PAT^I^I0x00002804$
ERROR: code indent should never use tabs
#1327: FILE: target/i386/hvf-utils/vmcs.h:93:
+#define^IVMCS_GUEST_IA32_EFER^I^I0x00002806$
ERROR: code indent should never use tabs
#1328: FILE: target/i386/hvf-utils/vmcs.h:94:
+#define^IVMCS_GUEST_IA32_PERF_GLOBAL_CTRL 0x00002808$
ERROR: code indent should never use tabs
#1329: FILE: target/i386/hvf-utils/vmcs.h:95:
+#define^IVMCS_GUEST_PDPTE0^I^I0x0000280A$
ERROR: code indent should never use tabs
#1330: FILE: target/i386/hvf-utils/vmcs.h:96:
+#define^IVMCS_GUEST_PDPTE1^I^I0x0000280C$
ERROR: code indent should never use tabs
#1331: FILE: target/i386/hvf-utils/vmcs.h:97:
+#define^IVMCS_GUEST_PDPTE2^I^I0x0000280E$
ERROR: code indent should never use tabs
#1332: FILE: target/i386/hvf-utils/vmcs.h:98:
+#define^IVMCS_GUEST_PDPTE3^I^I0x00002810$
ERROR: code indent should never use tabs
#1335: FILE: target/i386/hvf-utils/vmcs.h:101:
+#define^IVMCS_HOST_IA32_PAT^I^I0x00002C00$
ERROR: code indent should never use tabs
#1336: FILE: target/i386/hvf-utils/vmcs.h:102:
+#define^IVMCS_HOST_IA32_EFER^I^I0x00002C02$
ERROR: code indent should never use tabs
#1337: FILE: target/i386/hvf-utils/vmcs.h:103:
+#define^IVMCS_HOST_IA32_PERF_GLOBAL_CTRL^I0x00002C04$
ERROR: code indent should never use tabs
#1340: FILE: target/i386/hvf-utils/vmcs.h:106:
+#define^IVMCS_PIN_BASED_CTLS^I^I0x00004000$
ERROR: code indent should never use tabs
#1341: FILE: target/i386/hvf-utils/vmcs.h:107:
+#define^IVMCS_PRI_PROC_BASED_CTLS^I0x00004002$
ERROR: code indent should never use tabs
#1342: FILE: target/i386/hvf-utils/vmcs.h:108:
+#define^IVMCS_EXCEPTION_BITMAP^I^I0x00004004$
ERROR: code indent should never use tabs
#1343: FILE: target/i386/hvf-utils/vmcs.h:109:
+#define^IVMCS_PF_ERROR_MASK^I^I0x00004006$
ERROR: code indent should never use tabs
#1344: FILE: target/i386/hvf-utils/vmcs.h:110:
+#define^IVMCS_PF_ERROR_MATCH^I^I0x00004008$
ERROR: code indent should never use tabs
#1345: FILE: target/i386/hvf-utils/vmcs.h:111:
+#define^IVMCS_CR3_TARGET_COUNT^I^I0x0000400A$
ERROR: code indent should never use tabs
#1346: FILE: target/i386/hvf-utils/vmcs.h:112:
+#define^IVMCS_EXIT_CTLS^I^I^I0x0000400C$
ERROR: code indent should never use tabs
#1347: FILE: target/i386/hvf-utils/vmcs.h:113:
+#define^IVMCS_EXIT_MSR_STORE_COUNT^I0x0000400E$
ERROR: code indent should never use tabs
#1348: FILE: target/i386/hvf-utils/vmcs.h:114:
+#define^IVMCS_EXIT_MSR_LOAD_COUNT^I0x00004010$
ERROR: code indent should never use tabs
#1349: FILE: target/i386/hvf-utils/vmcs.h:115:
+#define^IVMCS_ENTRY_CTLS^I^I^I0x00004012$
ERROR: code indent should never use tabs
#1350: FILE: target/i386/hvf-utils/vmcs.h:116:
+#define^IVMCS_ENTRY_MSR_LOAD_COUNT^I0x00004014$
ERROR: code indent should never use tabs
#1351: FILE: target/i386/hvf-utils/vmcs.h:117:
+#define^IVMCS_ENTRY_INTR_INFO^I^I0x00004016$
ERROR: code indent should never use tabs
#1352: FILE: target/i386/hvf-utils/vmcs.h:118:
+#define^IVMCS_ENTRY_EXCEPTION_ERROR^I0x00004018$
ERROR: code indent should never use tabs
#1353: FILE: target/i386/hvf-utils/vmcs.h:119:
+#define^IVMCS_ENTRY_INST_LENGTH^I^I0x0000401A$
ERROR: code indent should never use tabs
#1354: FILE: target/i386/hvf-utils/vmcs.h:120:
+#define^IVMCS_TPR_THRESHOLD^I^I0x0000401C$
ERROR: code indent should never use tabs
#1355: FILE: target/i386/hvf-utils/vmcs.h:121:
+#define^IVMCS_SEC_PROC_BASED_CTLS^I0x0000401E$
ERROR: code indent should never use tabs
#1356: FILE: target/i386/hvf-utils/vmcs.h:122:
+#define^IVMCS_PLE_GAP^I^I^I0x00004020$
ERROR: code indent should never use tabs
#1357: FILE: target/i386/hvf-utils/vmcs.h:123:
+#define^IVMCS_PLE_WINDOW^I^I^I0x00004022$
ERROR: code indent should never use tabs
#1360: FILE: target/i386/hvf-utils/vmcs.h:126:
+#define^IVMCS_INSTRUCTION_ERROR^I^I0x00004400$
ERROR: code indent should never use tabs
#1361: FILE: target/i386/hvf-utils/vmcs.h:127:
+#define^IVMCS_EXIT_REASON^I^I0x00004402$
ERROR: code indent should never use tabs
#1362: FILE: target/i386/hvf-utils/vmcs.h:128:
+#define^IVMCS_EXIT_INTR_INFO^I^I0x00004404$
ERROR: code indent should never use tabs
#1363: FILE: target/i386/hvf-utils/vmcs.h:129:
+#define^IVMCS_EXIT_INTR_ERRCODE^I^I0x00004406$
ERROR: code indent should never use tabs
#1364: FILE: target/i386/hvf-utils/vmcs.h:130:
+#define^IVMCS_IDT_VECTORING_INFO^I^I0x00004408$
ERROR: code indent should never use tabs
#1365: FILE: target/i386/hvf-utils/vmcs.h:131:
+#define^IVMCS_IDT_VECTORING_ERROR^I0x0000440A$
ERROR: code indent should never use tabs
#1366: FILE: target/i386/hvf-utils/vmcs.h:132:
+#define^IVMCS_EXIT_INSTRUCTION_LENGTH^I0x0000440C$
ERROR: code indent should never use tabs
#1367: FILE: target/i386/hvf-utils/vmcs.h:133:
+#define^IVMCS_EXIT_INSTRUCTION_INFO^I0x0000440E$
ERROR: code indent should never use tabs
#1370: FILE: target/i386/hvf-utils/vmcs.h:136:
+#define^IVMCS_GUEST_ES_LIMIT^I^I0x00004800$
ERROR: code indent should never use tabs
#1371: FILE: target/i386/hvf-utils/vmcs.h:137:
+#define^IVMCS_GUEST_CS_LIMIT^I^I0x00004802$
ERROR: code indent should never use tabs
#1372: FILE: target/i386/hvf-utils/vmcs.h:138:
+#define^IVMCS_GUEST_SS_LIMIT^I^I0x00004804$
ERROR: code indent should never use tabs
#1373: FILE: target/i386/hvf-utils/vmcs.h:139:
+#define^IVMCS_GUEST_DS_LIMIT^I^I0x00004806$
ERROR: code indent should never use tabs
#1374: FILE: target/i386/hvf-utils/vmcs.h:140:
+#define^IVMCS_GUEST_FS_LIMIT^I^I0x00004808$
ERROR: code indent should never use tabs
#1375: FILE: target/i386/hvf-utils/vmcs.h:141:
+#define^IVMCS_GUEST_GS_LIMIT^I^I0x0000480A$
ERROR: code indent should never use tabs
#1376: FILE: target/i386/hvf-utils/vmcs.h:142:
+#define^IVMCS_GUEST_LDTR_LIMIT^I^I0x0000480C$
ERROR: code indent should never use tabs
#1377: FILE: target/i386/hvf-utils/vmcs.h:143:
+#define^IVMCS_GUEST_TR_LIMIT^I^I0x0000480E$
ERROR: code indent should never use tabs
#1378: FILE: target/i386/hvf-utils/vmcs.h:144:
+#define^IVMCS_GUEST_GDTR_LIMIT^I^I0x00004810$
ERROR: code indent should never use tabs
#1379: FILE: target/i386/hvf-utils/vmcs.h:145:
+#define^IVMCS_GUEST_IDTR_LIMIT^I^I0x00004812$
ERROR: code indent should never use tabs
#1380: FILE: target/i386/hvf-utils/vmcs.h:146:
+#define^IVMCS_GUEST_ES_ACCESS_RIGHTS^I0x00004814$
ERROR: code indent should never use tabs
#1381: FILE: target/i386/hvf-utils/vmcs.h:147:
+#define^IVMCS_GUEST_CS_ACCESS_RIGHTS^I0x00004816$
ERROR: code indent should never use tabs
#1382: FILE: target/i386/hvf-utils/vmcs.h:148:
+#define^IVMCS_GUEST_SS_ACCESS_RIGHTS^I0x00004818$
ERROR: code indent should never use tabs
#1383: FILE: target/i386/hvf-utils/vmcs.h:149:
+#define^IVMCS_GUEST_DS_ACCESS_RIGHTS^I0x0000481A$
ERROR: code indent should never use tabs
#1384: FILE: target/i386/hvf-utils/vmcs.h:150:
+#define^IVMCS_GUEST_FS_ACCESS_RIGHTS^I0x0000481C$
ERROR: code indent should never use tabs
#1385: FILE: target/i386/hvf-utils/vmcs.h:151:
+#define^IVMCS_GUEST_GS_ACCESS_RIGHTS^I0x0000481E$
ERROR: code indent should never use tabs
#1386: FILE: target/i386/hvf-utils/vmcs.h:152:
+#define^IVMCS_GUEST_LDTR_ACCESS_RIGHTS^I0x00004820$
ERROR: code indent should never use tabs
#1387: FILE: target/i386/hvf-utils/vmcs.h:153:
+#define^IVMCS_GUEST_TR_ACCESS_RIGHTS^I0x00004822$
ERROR: code indent should never use tabs
#1388: FILE: target/i386/hvf-utils/vmcs.h:154:
+#define^IVMCS_GUEST_INTERRUPTIBILITY^I0x00004824$
ERROR: code indent should never use tabs
#1389: FILE: target/i386/hvf-utils/vmcs.h:155:
+#define^IVMCS_GUEST_ACTIVITY^I^I0x00004826$
ERROR: code indent should never use tabs
#1390: FILE: target/i386/hvf-utils/vmcs.h:156:
+#define VMCS_GUEST_SMBASE^I^I0x00004828$
ERROR: code indent should never use tabs
#1391: FILE: target/i386/hvf-utils/vmcs.h:157:
+#define^IVMCS_GUEST_IA32_SYSENTER_CS^I0x0000482A$
ERROR: code indent should never use tabs
#1392: FILE: target/i386/hvf-utils/vmcs.h:158:
+#define^IVMCS_PREEMPTION_TIMER_VALUE^I0x0000482E$
ERROR: code indent should never use tabs
#1395: FILE: target/i386/hvf-utils/vmcs.h:161:
+#define^IVMCS_HOST_IA32_SYSENTER_CS^I0x00004C00$
ERROR: code indent should never use tabs
#1398: FILE: target/i386/hvf-utils/vmcs.h:164:
+#define^IVMCS_CR0_MASK^I^I^I0x00006000$
ERROR: code indent should never use tabs
#1399: FILE: target/i386/hvf-utils/vmcs.h:165:
+#define^IVMCS_CR4_MASK^I^I^I0x00006002$
ERROR: code indent should never use tabs
#1400: FILE: target/i386/hvf-utils/vmcs.h:166:
+#define^IVMCS_CR0_SHADOW^I^I^I0x00006004$
ERROR: code indent should never use tabs
#1401: FILE: target/i386/hvf-utils/vmcs.h:167:
+#define^IVMCS_CR4_SHADOW^I^I^I0x00006006$
ERROR: code indent should never use tabs
#1402: FILE: target/i386/hvf-utils/vmcs.h:168:
+#define^IVMCS_CR3_TARGET0^I^I0x00006008$
ERROR: code indent should never use tabs
#1403: FILE: target/i386/hvf-utils/vmcs.h:169:
+#define^IVMCS_CR3_TARGET1^I^I0x0000600A$
ERROR: code indent should never use tabs
#1404: FILE: target/i386/hvf-utils/vmcs.h:170:
+#define^IVMCS_CR3_TARGET2^I^I0x0000600C$
ERROR: code indent should never use tabs
#1405: FILE: target/i386/hvf-utils/vmcs.h:171:
+#define^IVMCS_CR3_TARGET3^I^I0x0000600E$
ERROR: code indent should never use tabs
#1408: FILE: target/i386/hvf-utils/vmcs.h:174:
+#define^IVMCS_EXIT_QUALIFICATION^I^I0x00006400$
ERROR: code indent should never use tabs
#1409: FILE: target/i386/hvf-utils/vmcs.h:175:
+#define^IVMCS_IO_RCX^I^I^I0x00006402$
ERROR: code indent should never use tabs
#1410: FILE: target/i386/hvf-utils/vmcs.h:176:
+#define^IVMCS_IO_RSI^I^I^I0x00006404$
ERROR: code indent should never use tabs
#1411: FILE: target/i386/hvf-utils/vmcs.h:177:
+#define^IVMCS_IO_RDI^I^I^I0x00006406$
ERROR: code indent should never use tabs
#1412: FILE: target/i386/hvf-utils/vmcs.h:178:
+#define^IVMCS_IO_RIP^I^I^I0x00006408$
ERROR: code indent should never use tabs
#1413: FILE: target/i386/hvf-utils/vmcs.h:179:
+#define^IVMCS_GUEST_LINEAR_ADDRESS^I0x0000640A$
ERROR: code indent should never use tabs
#1416: FILE: target/i386/hvf-utils/vmcs.h:182:
+#define^IVMCS_GUEST_CR0^I^I^I0x00006800$
ERROR: code indent should never use tabs
#1417: FILE: target/i386/hvf-utils/vmcs.h:183:
+#define^IVMCS_GUEST_CR3^I^I^I0x00006802$
ERROR: code indent should never use tabs
#1418: FILE: target/i386/hvf-utils/vmcs.h:184:
+#define^IVMCS_GUEST_CR4^I^I^I0x00006804$
ERROR: code indent should never use tabs
#1419: FILE: target/i386/hvf-utils/vmcs.h:185:
+#define^IVMCS_GUEST_ES_BASE^I^I0x00006806$
ERROR: code indent should never use tabs
#1420: FILE: target/i386/hvf-utils/vmcs.h:186:
+#define^IVMCS_GUEST_CS_BASE^I^I0x00006808$
ERROR: code indent should never use tabs
#1421: FILE: target/i386/hvf-utils/vmcs.h:187:
+#define^IVMCS_GUEST_SS_BASE^I^I0x0000680A$
ERROR: code indent should never use tabs
#1422: FILE: target/i386/hvf-utils/vmcs.h:188:
+#define^IVMCS_GUEST_DS_BASE^I^I0x0000680C$
ERROR: code indent should never use tabs
#1423: FILE: target/i386/hvf-utils/vmcs.h:189:
+#define^IVMCS_GUEST_FS_BASE^I^I0x0000680E$
ERROR: code indent should never use tabs
#1424: FILE: target/i386/hvf-utils/vmcs.h:190:
+#define^IVMCS_GUEST_GS_BASE^I^I0x00006810$
ERROR: code indent should never use tabs
#1425: FILE: target/i386/hvf-utils/vmcs.h:191:
+#define^IVMCS_GUEST_LDTR_BASE^I^I0x00006812$
ERROR: code indent should never use tabs
#1426: FILE: target/i386/hvf-utils/vmcs.h:192:
+#define^IVMCS_GUEST_TR_BASE^I^I0x00006814$
ERROR: code indent should never use tabs
#1427: FILE: target/i386/hvf-utils/vmcs.h:193:
+#define^IVMCS_GUEST_GDTR_BASE^I^I0x00006816$
ERROR: code indent should never use tabs
#1428: FILE: target/i386/hvf-utils/vmcs.h:194:
+#define^IVMCS_GUEST_IDTR_BASE^I^I0x00006818$
ERROR: code indent should never use tabs
#1429: FILE: target/i386/hvf-utils/vmcs.h:195:
+#define^IVMCS_GUEST_DR7^I^I^I0x0000681A$
ERROR: code indent should never use tabs
#1430: FILE: target/i386/hvf-utils/vmcs.h:196:
+#define^IVMCS_GUEST_RSP^I^I^I0x0000681C$
ERROR: code indent should never use tabs
#1431: FILE: target/i386/hvf-utils/vmcs.h:197:
+#define^IVMCS_GUEST_RIP^I^I^I0x0000681E$
ERROR: code indent should never use tabs
#1432: FILE: target/i386/hvf-utils/vmcs.h:198:
+#define^IVMCS_GUEST_RFLAGS^I^I0x00006820$
ERROR: code indent should never use tabs
#1433: FILE: target/i386/hvf-utils/vmcs.h:199:
+#define^IVMCS_GUEST_PENDING_DBG_EXCEPTIONS 0x00006822$
ERROR: code indent should never use tabs
#1434: FILE: target/i386/hvf-utils/vmcs.h:200:
+#define^IVMCS_GUEST_IA32_SYSENTER_ESP^I0x00006824$
ERROR: code indent should never use tabs
#1435: FILE: target/i386/hvf-utils/vmcs.h:201:
+#define^IVMCS_GUEST_IA32_SYSENTER_EIP^I0x00006826$
ERROR: code indent should never use tabs
#1438: FILE: target/i386/hvf-utils/vmcs.h:204:
+#define^IVMCS_HOST_CR0^I^I^I0x00006C00$
ERROR: code indent should never use tabs
#1439: FILE: target/i386/hvf-utils/vmcs.h:205:
+#define^IVMCS_HOST_CR3^I^I^I0x00006C02$
ERROR: code indent should never use tabs
#1440: FILE: target/i386/hvf-utils/vmcs.h:206:
+#define^IVMCS_HOST_CR4^I^I^I0x00006C04$
ERROR: code indent should never use tabs
#1441: FILE: target/i386/hvf-utils/vmcs.h:207:
+#define^IVMCS_HOST_FS_BASE^I^I0x00006C06$
ERROR: code indent should never use tabs
#1442: FILE: target/i386/hvf-utils/vmcs.h:208:
+#define^IVMCS_HOST_GS_BASE^I^I0x00006C08$
ERROR: code indent should never use tabs
#1443: FILE: target/i386/hvf-utils/vmcs.h:209:
+#define^IVMCS_HOST_TR_BASE^I^I0x00006C0A$
ERROR: code indent should never use tabs
#1444: FILE: target/i386/hvf-utils/vmcs.h:210:
+#define^IVMCS_HOST_GDTR_BASE^I^I0x00006C0C$
ERROR: code indent should never use tabs
#1445: FILE: target/i386/hvf-utils/vmcs.h:211:
+#define^IVMCS_HOST_IDTR_BASE^I^I0x00006C0E$
ERROR: code indent should never use tabs
#1446: FILE: target/i386/hvf-utils/vmcs.h:212:
+#define^IVMCS_HOST_IA32_SYSENTER_ESP^I0x00006C10$
ERROR: code indent should never use tabs
#1447: FILE: target/i386/hvf-utils/vmcs.h:213:
+#define^IVMCS_HOST_IA32_SYSENTER_EIP^I0x00006C12$
ERROR: code indent should never use tabs
#1448: FILE: target/i386/hvf-utils/vmcs.h:214:
+#define^IVMCS_HOST_RSP^I^I^I0x00006C14$
ERROR: code indent should never use tabs
#1449: FILE: target/i386/hvf-utils/vmcs.h:215:
+#define^IVMCS_HOST_RIP^I^I^I0x00006c16$
ERROR: code indent should never use tabs
#1454: FILE: target/i386/hvf-utils/vmcs.h:220:
+#define^IVMRESUME_WITH_NON_LAUNCHED_VMCS^I5$
ERROR: code indent should never use tabs
#1459: FILE: target/i386/hvf-utils/vmcs.h:225:
+#define EXIT_REASON_EXCEPTION^I^I0$
ERROR: code indent should never use tabs
#1460: FILE: target/i386/hvf-utils/vmcs.h:226:
+#define EXIT_REASON_EXT_INTR^I^I1$
ERROR: code indent should never use tabs
#1461: FILE: target/i386/hvf-utils/vmcs.h:227:
+#define EXIT_REASON_TRIPLE_FAULT^I2$
ERROR: code indent should never use tabs
#1462: FILE: target/i386/hvf-utils/vmcs.h:228:
+#define EXIT_REASON_INIT^I^I3$
ERROR: code indent should never use tabs
#1463: FILE: target/i386/hvf-utils/vmcs.h:229:
+#define EXIT_REASON_SIPI^I^I4$
ERROR: code indent should never use tabs
#1464: FILE: target/i386/hvf-utils/vmcs.h:230:
+#define EXIT_REASON_IO_SMI^I^I5$
ERROR: code indent should never use tabs
#1465: FILE: target/i386/hvf-utils/vmcs.h:231:
+#define EXIT_REASON_SMI^I^I^I6$
ERROR: code indent should never use tabs
#1466: FILE: target/i386/hvf-utils/vmcs.h:232:
+#define EXIT_REASON_INTR_WINDOW^I^I7$
ERROR: code indent should never use tabs
#1467: FILE: target/i386/hvf-utils/vmcs.h:233:
+#define EXIT_REASON_NMI_WINDOW^I^I8$
ERROR: code indent should never use tabs
#1468: FILE: target/i386/hvf-utils/vmcs.h:234:
+#define EXIT_REASON_TASK_SWITCH^I^I9$
ERROR: code indent should never use tabs
#1469: FILE: target/i386/hvf-utils/vmcs.h:235:
+#define EXIT_REASON_CPUID^I^I10$
ERROR: code indent should never use tabs
#1470: FILE: target/i386/hvf-utils/vmcs.h:236:
+#define EXIT_REASON_GETSEC^I^I11$
ERROR: code indent should never use tabs
#1471: FILE: target/i386/hvf-utils/vmcs.h:237:
+#define EXIT_REASON_HLT^I^I^I12$
ERROR: code indent should never use tabs
#1472: FILE: target/i386/hvf-utils/vmcs.h:238:
+#define EXIT_REASON_INVD^I^I13$
ERROR: code indent should never use tabs
#1473: FILE: target/i386/hvf-utils/vmcs.h:239:
+#define EXIT_REASON_INVLPG^I^I14$
ERROR: code indent should never use tabs
#1474: FILE: target/i386/hvf-utils/vmcs.h:240:
+#define EXIT_REASON_RDPMC^I^I15$
ERROR: code indent should never use tabs
#1475: FILE: target/i386/hvf-utils/vmcs.h:241:
+#define EXIT_REASON_RDTSC^I^I16$
ERROR: code indent should never use tabs
#1476: FILE: target/i386/hvf-utils/vmcs.h:242:
+#define EXIT_REASON_RSM^I^I^I17$
ERROR: code indent should never use tabs
#1477: FILE: target/i386/hvf-utils/vmcs.h:243:
+#define EXIT_REASON_VMCALL^I^I18$
ERROR: code indent should never use tabs
#1478: FILE: target/i386/hvf-utils/vmcs.h:244:
+#define EXIT_REASON_VMCLEAR^I^I19$
ERROR: code indent should never use tabs
#1479: FILE: target/i386/hvf-utils/vmcs.h:245:
+#define EXIT_REASON_VMLAUNCH^I^I20$
ERROR: code indent should never use tabs
#1480: FILE: target/i386/hvf-utils/vmcs.h:246:
+#define EXIT_REASON_VMPTRLD^I^I21$
ERROR: code indent should never use tabs
#1481: FILE: target/i386/hvf-utils/vmcs.h:247:
+#define EXIT_REASON_VMPTRST^I^I22$
ERROR: code indent should never use tabs
#1482: FILE: target/i386/hvf-utils/vmcs.h:248:
+#define EXIT_REASON_VMREAD^I^I23$
ERROR: code indent should never use tabs
#1483: FILE: target/i386/hvf-utils/vmcs.h:249:
+#define EXIT_REASON_VMRESUME^I^I24$
ERROR: code indent should never use tabs
#1484: FILE: target/i386/hvf-utils/vmcs.h:250:
+#define EXIT_REASON_VMWRITE^I^I25$
ERROR: code indent should never use tabs
#1485: FILE: target/i386/hvf-utils/vmcs.h:251:
+#define EXIT_REASON_VMXOFF^I^I26$
ERROR: code indent should never use tabs
#1486: FILE: target/i386/hvf-utils/vmcs.h:252:
+#define EXIT_REASON_VMXON^I^I27$
ERROR: code indent should never use tabs
#1487: FILE: target/i386/hvf-utils/vmcs.h:253:
+#define EXIT_REASON_CR_ACCESS^I^I28$
ERROR: code indent should never use tabs
#1488: FILE: target/i386/hvf-utils/vmcs.h:254:
+#define EXIT_REASON_DR_ACCESS^I^I29$
ERROR: code indent should never use tabs
#1489: FILE: target/i386/hvf-utils/vmcs.h:255:
+#define EXIT_REASON_INOUT^I^I30$
ERROR: code indent should never use tabs
#1490: FILE: target/i386/hvf-utils/vmcs.h:256:
+#define EXIT_REASON_RDMSR^I^I31$
ERROR: code indent should never use tabs
#1491: FILE: target/i386/hvf-utils/vmcs.h:257:
+#define EXIT_REASON_WRMSR^I^I32$
ERROR: code indent should never use tabs
#1492: FILE: target/i386/hvf-utils/vmcs.h:258:
+#define EXIT_REASON_INVAL_VMCS^I^I33$
ERROR: code indent should never use tabs
#1493: FILE: target/i386/hvf-utils/vmcs.h:259:
+#define EXIT_REASON_INVAL_MSR^I^I34$
ERROR: code indent should never use tabs
#1494: FILE: target/i386/hvf-utils/vmcs.h:260:
+#define EXIT_REASON_MWAIT^I^I36$
ERROR: code indent should never use tabs
#1495: FILE: target/i386/hvf-utils/vmcs.h:261:
+#define EXIT_REASON_MTF^I^I^I37$
ERROR: code indent should never use tabs
#1496: FILE: target/i386/hvf-utils/vmcs.h:262:
+#define EXIT_REASON_MONITOR^I^I39$
ERROR: code indent should never use tabs
#1497: FILE: target/i386/hvf-utils/vmcs.h:263:
+#define EXIT_REASON_PAUSE^I^I40$
ERROR: code indent should never use tabs
#1498: FILE: target/i386/hvf-utils/vmcs.h:264:
+#define EXIT_REASON_MCE_DURING_ENTRY^I41$
ERROR: code indent should never use tabs
#1499: FILE: target/i386/hvf-utils/vmcs.h:265:
+#define EXIT_REASON_TPR^I^I^I43$
ERROR: code indent should never use tabs
#1500: FILE: target/i386/hvf-utils/vmcs.h:266:
+#define EXIT_REASON_APIC_ACCESS^I^I44$
ERROR: code indent should never use tabs
#1501: FILE: target/i386/hvf-utils/vmcs.h:267:
+#define^IEXIT_REASON_VIRTUALIZED_EOI^I45$
ERROR: code indent should never use tabs
#1502: FILE: target/i386/hvf-utils/vmcs.h:268:
+#define EXIT_REASON_GDTR_IDTR^I^I46$
ERROR: code indent should never use tabs
#1503: FILE: target/i386/hvf-utils/vmcs.h:269:
+#define EXIT_REASON_LDTR_TR^I^I47$
ERROR: code indent should never use tabs
#1504: FILE: target/i386/hvf-utils/vmcs.h:270:
+#define EXIT_REASON_EPT_FAULT^I^I48$
ERROR: code indent should never use tabs
#1505: FILE: target/i386/hvf-utils/vmcs.h:271:
+#define EXIT_REASON_EPT_MISCONFIG^I49$
ERROR: code indent should never use tabs
#1506: FILE: target/i386/hvf-utils/vmcs.h:272:
+#define EXIT_REASON_INVEPT^I^I50$
ERROR: code indent should never use tabs
#1507: FILE: target/i386/hvf-utils/vmcs.h:273:
+#define EXIT_REASON_RDTSCP^I^I51$
ERROR: code indent should never use tabs
#1508: FILE: target/i386/hvf-utils/vmcs.h:274:
+#define EXIT_REASON_VMX_PREEMPT^I^I52$
ERROR: code indent should never use tabs
#1509: FILE: target/i386/hvf-utils/vmcs.h:275:
+#define EXIT_REASON_INVVPID^I^I53$
ERROR: code indent should never use tabs
#1510: FILE: target/i386/hvf-utils/vmcs.h:276:
+#define EXIT_REASON_WBINVD^I^I54$
ERROR: code indent should never use tabs
#1511: FILE: target/i386/hvf-utils/vmcs.h:277:
+#define EXIT_REASON_XSETBV^I^I55$
ERROR: code indent should never use tabs
#1512: FILE: target/i386/hvf-utils/vmcs.h:278:
+#define^IEXIT_REASON_APIC_WRITE^I^I56$
ERROR: code indent should never use tabs
#1519: FILE: target/i386/hvf-utils/vmcs.h:285:
+#define^IEXIT_QUAL_NMIUDTI^I(1 << 12)$
ERROR: code indent should never use tabs
#1523: FILE: target/i386/hvf-utils/vmcs.h:289:
+#define^IVMCS_INTR_VALID^I^I(1U << 31)$
ERROR: code indent should never use tabs
#1524: FILE: target/i386/hvf-utils/vmcs.h:290:
+#define^IVMCS_INTR_T_MASK^I0x700^I^I/* Interruption-info type */$
ERROR: code indent should never use tabs
#1525: FILE: target/i386/hvf-utils/vmcs.h:291:
+#define^IVMCS_INTR_T_HWINTR^I(0 << 8)$
ERROR: code indent should never use tabs
#1526: FILE: target/i386/hvf-utils/vmcs.h:292:
+#define^IVMCS_INTR_T_NMI^I^I(2 << 8)$
ERROR: code indent should never use tabs
#1527: FILE: target/i386/hvf-utils/vmcs.h:293:
+#define^IVMCS_INTR_T_HWEXCEPTION^I(3 << 8)$
ERROR: code indent should never use tabs
#1528: FILE: target/i386/hvf-utils/vmcs.h:294:
+#define^IVMCS_INTR_T_SWINTR^I(4 << 8)$
ERROR: code indent should never use tabs
#1529: FILE: target/i386/hvf-utils/vmcs.h:295:
+#define^IVMCS_INTR_T_PRIV_SWEXCEPTION (5 << 8)$
ERROR: code indent should never use tabs
#1530: FILE: target/i386/hvf-utils/vmcs.h:296:
+#define^IVMCS_INTR_T_SWEXCEPTION^I(6 << 8)$
ERROR: code indent should never use tabs
#1531: FILE: target/i386/hvf-utils/vmcs.h:297:
+#define^IVMCS_INTR_DEL_ERRCODE^I(1 << 11)$
ERROR: code indent should never use tabs
#1536: FILE: target/i386/hvf-utils/vmcs.h:302:
+#define^IVMCS_IDT_VEC_VALID (1U << 31)$
ERROR: code indent should never use tabs
#1537: FILE: target/i386/hvf-utils/vmcs.h:303:
+#define^IVMCS_IDT_VEC_TYPE 0x700$
ERROR: code indent should never use tabs
#1538: FILE: target/i386/hvf-utils/vmcs.h:304:
+#define^IVMCS_IDT_VEC_ERRCODE_VALID^I(1U << 11)$
ERROR: code indent should never use tabs
#1539: FILE: target/i386/hvf-utils/vmcs.h:305:
+#define^IVMCS_IDT_VEC_HWINTR (0 << 8)$
ERROR: code indent should never use tabs
#1540: FILE: target/i386/hvf-utils/vmcs.h:306:
+#define^IVMCS_IDT_VEC_NMI (2 << 8)$
ERROR: code indent should never use tabs
#1541: FILE: target/i386/hvf-utils/vmcs.h:307:
+#define^IVMCS_IDT_VEC_HWEXCEPTION^I(3 << 8)$
ERROR: code indent should never use tabs
#1542: FILE: target/i386/hvf-utils/vmcs.h:308:
+#define^IVMCS_IDT_VEC_SWINTR (4 << 8)$
ERROR: code indent should never use tabs
#1547: FILE: target/i386/hvf-utils/vmcs.h:313:
+#define^IVMCS_INTERRUPTIBILITY_STI_BLOCKING^I(1 << 0)$
ERROR: code indent should never use tabs
#1548: FILE: target/i386/hvf-utils/vmcs.h:314:
+#define^IVMCS_INTERRUPTIBILITY_MOVSS_BLOCKING^I(1 << 1)$
ERROR: code indent should never use tabs
#1549: FILE: target/i386/hvf-utils/vmcs.h:315:
+#define^IVMCS_INTERRUPTIBILITY_SMI_BLOCKING^I(1 << 2)$
ERROR: code indent should never use tabs
#1550: FILE: target/i386/hvf-utils/vmcs.h:316:
+#define^IVMCS_INTERRUPTIBILITY_NMI_BLOCKING^I(1 << 3)$
ERROR: code indent should never use tabs
#1555: FILE: target/i386/hvf-utils/vmcs.h:321:
+#define^IEXIT_QUAL_NMI_WHILE_STI_BLOCKING^I3$
ERROR: code indent should never use tabs
#1560: FILE: target/i386/hvf-utils/vmcs.h:326:
+#define^IEPT_VIOLATION_DATA_READ^I^I(1UL << 0)$
ERROR: code indent should never use tabs
#1561: FILE: target/i386/hvf-utils/vmcs.h:327:
+#define^IEPT_VIOLATION_DATA_WRITE^I(1UL << 1)$
ERROR: code indent should never use tabs
#1562: FILE: target/i386/hvf-utils/vmcs.h:328:
+#define^IEPT_VIOLATION_INST_FETCH^I(1UL << 2)$
ERROR: code indent should never use tabs
#1563: FILE: target/i386/hvf-utils/vmcs.h:329:
+#define^IEPT_VIOLATION_GPA_READABLE^I(1UL << 3)$
ERROR: code indent should never use tabs
#1564: FILE: target/i386/hvf-utils/vmcs.h:330:
+#define^IEPT_VIOLATION_GPA_WRITEABLE^I(1UL << 4)$
ERROR: code indent should never use tabs
#1565: FILE: target/i386/hvf-utils/vmcs.h:331:
+#define^IEPT_VIOLATION_GPA_EXECUTABLE^I(1UL << 5)$
ERROR: code indent should never use tabs
#1566: FILE: target/i386/hvf-utils/vmcs.h:332:
+#define^IEPT_VIOLATION_GLA_VALID^I^I(1UL << 7)$
ERROR: code indent should never use tabs
#1567: FILE: target/i386/hvf-utils/vmcs.h:333:
+#define^IEPT_VIOLATION_XLAT_VALID^I(1UL << 8)$
ERROR: code indent should never use tabs
#1572: FILE: target/i386/hvf-utils/vmcs.h:338:
+#define^IAPIC_ACCESS_OFFSET(qual)^I((qual) & 0xFFF)$
ERROR: code indent should never use tabs
#1573: FILE: target/i386/hvf-utils/vmcs.h:339:
+#define^IAPIC_ACCESS_TYPE(qual)^I^I(((qual) >> 12) & 0xF)$
ERROR: code indent should never use tabs
#1578: FILE: target/i386/hvf-utils/vmcs.h:344:
+#define^IAPIC_WRITE_OFFSET(qual)^I^I((qual) & 0xFFF)$
ERROR: code indent should never use tabs
#1596: FILE: target/i386/hvf-utils/vmcs.h:362:
+^ITSR_CALL,$
ERROR: code indent should never use tabs
#1597: FILE: target/i386/hvf-utils/vmcs.h:363:
+^ITSR_IRET,$
ERROR: code indent should never use tabs
#1599: FILE: target/i386/hvf-utils/vmcs.h:365:
+^ITSR_IDT_GATE,^I/* task gate in IDT */$
ERROR: inline keyword should sit between storage class and type
#1642: FILE: target/i386/hvf-utils/vmx.h:34:
+static uint64_t inline rreg(hv_vcpuid_t vcpu, hv_x86_reg_t reg)
ERROR: code indent should never use tabs
#1644: FILE: target/i386/hvf-utils/vmx.h:36:
+^Iuint64_t v;$
ERROR: code indent should never use tabs
#1646: FILE: target/i386/hvf-utils/vmx.h:38:
+^Iif (hv_vcpu_read_register(vcpu, reg, &v)) {$
ERROR: code indent should never use tabs
#1647: FILE: target/i386/hvf-utils/vmx.h:39:
+^I^Iabort();$
ERROR: code indent should never use tabs
#1648: FILE: target/i386/hvf-utils/vmx.h:40:
+^I}$
ERROR: code indent should never use tabs
#1650: FILE: target/i386/hvf-utils/vmx.h:42:
+^Ireturn v;$
ERROR: inline keyword should sit between storage class and type
#1654: FILE: target/i386/hvf-utils/vmx.h:46:
+static void inline wreg(hv_vcpuid_t vcpu, hv_x86_reg_t reg, uint64_t v)
ERROR: code indent should never use tabs
#1656: FILE: target/i386/hvf-utils/vmx.h:48:
+^Iif (hv_vcpu_write_register(vcpu, reg, v)) {$
ERROR: code indent should never use tabs
#1657: FILE: target/i386/hvf-utils/vmx.h:49:
+^I^Iabort();$
ERROR: code indent should never use tabs
#1658: FILE: target/i386/hvf-utils/vmx.h:50:
+^I}$
ERROR: inline keyword should sit between storage class and type
#1662: FILE: target/i386/hvf-utils/vmx.h:54:
+static uint64_t inline rvmcs(hv_vcpuid_t vcpu, uint32_t field)
ERROR: code indent should never use tabs
#1664: FILE: target/i386/hvf-utils/vmx.h:56:
+^Iuint64_t v;$
ERROR: code indent should never use tabs
#1666: FILE: target/i386/hvf-utils/vmx.h:58:
+^Ihv_vmx_vcpu_read_vmcs(vcpu, field, &v);$
ERROR: code indent should never use tabs
#1668: FILE: target/i386/hvf-utils/vmx.h:60:
+^Ireturn v;$
ERROR: inline keyword should sit between storage class and type
#1672: FILE: target/i386/hvf-utils/vmx.h:64:
+static void inline wvmcs(hv_vcpuid_t vcpu, uint32_t field, uint64_t v)
ERROR: code indent should never use tabs
#1674: FILE: target/i386/hvf-utils/vmx.h:66:
+^Ihv_vmx_vcpu_write_vmcs(vcpu, field, v);$
ERROR: inline keyword should sit between storage class and type
#1678: FILE: target/i386/hvf-utils/vmx.h:70:
+static uint64_t inline cap2ctrl(uint64_t cap, uint64_t ctrl)
ERROR: code indent should never use tabs
#1680: FILE: target/i386/hvf-utils/vmx.h:72:
+^Ireturn (ctrl | (cap & 0xffffffff)) & (cap >> 32);$
WARNING: line over 80 characters
#1702: FILE: target/i386/hvf-utils/vmx.h:94:
+ wvmcs(vcpu, VMCS_ENTRY_CTLS, rvmcs(vcpu, VMCS_ENTRY_CTLS) | VM_ENTRY_GUEST_LMA);
WARNING: line over 80 characters
#1705: FILE: target/i386/hvf-utils/vmx.h:97:
+ if ((efer & EFER_LME) && (guest_tr_ar & AR_TYPE_MASK) != AR_TYPE_BUSY_64_TSS) {
ERROR: line over 90 characters
#1706: FILE: target/i386/hvf-utils/vmx.h:98:
+ wvmcs(vcpu, VMCS_GUEST_TR_ACCESS_RIGHTS, (guest_tr_ar & ~AR_TYPE_MASK) | AR_TYPE_BUSY_64_TSS);
ERROR: inline keyword should sit between storage class and type
#1721: FILE: target/i386/hvf-utils/vmx.h:113:
+static void inline macvm_set_cr0(hv_vcpuid_t vcpu, uint64_t cr0)
WARNING: line over 80 characters
#1728: FILE: target/i386/hvf-utils/vmx.h:120:
+ if ((cr0 & CR0_PG) && (rvmcs(vcpu, VMCS_GUEST_CR4) & CR4_PAE) && !(efer & EFER_LME))
ERROR: braces {} are necessary for all arms of this statement
#1728: FILE: target/i386/hvf-utils/vmx.h:120:
+ if ((cr0 & CR0_PG) && (rvmcs(vcpu, VMCS_GUEST_CR4) & CR4_PAE) && !(efer & EFER_LME))
[...]
WARNING: line over 80 characters
#1729: FILE: target/i386/hvf-utils/vmx.h:121:
+ address_space_rw(&address_space_memory, rvmcs(vcpu, VMCS_GUEST_CR3) & ~0x1f,
ERROR: braces {} are necessary even for single statement blocks
#1733: FILE: target/i386/hvf-utils/vmx.h:125:
+ for (i = 0; i < 4; i++)
+ wvmcs(vcpu, VMCS_GUEST_PDPTE0 + i * 2, pdpte[i]);
ERROR: spaces required around that '|' (ctx:VxW)
#1740: FILE: target/i386/hvf-utils/vmx.h:132:
+ wvmcs(vcpu, VMCS_GUEST_CR0, cr0 | CR0_NE| CR0_ET);
^
ERROR: suspect code indent for conditional statements (8, 13)
#1743: FILE: target/i386/hvf-utils/vmx.h:135:
+ if (!(old_cr0 & CR0_PG) && (cr0 & CR0_PG))
+ enter_long_mode(vcpu, cr0, efer);
ERROR: braces {} are necessary for all arms of this statement
#1743: FILE: target/i386/hvf-utils/vmx.h:135:
+ if (!(old_cr0 & CR0_PG) && (cr0 & CR0_PG))
[...]
ERROR: braces {} are necessary for all arms of this statement
#1745: FILE: target/i386/hvf-utils/vmx.h:137:
+ if (/*(old_cr0 & CR0_PG) &&*/ !(cr0 & CR0_PG))
[...]
ERROR: inline keyword should sit between storage class and type
#1753: FILE: target/i386/hvf-utils/vmx.h:145:
+static void inline macvm_set_cr4(hv_vcpuid_t vcpu, uint64_t cr4)
ERROR: inline keyword should sit between storage class and type
#1764: FILE: target/i386/hvf-utils/vmx.h:156:
+static void inline macvm_set_rip(CPUState *cpu, uint64_t rip)
WARNING: line over 80 characters
#1773: FILE: target/i386/hvf-utils/vmx.h:165:
+ if (val & (VMCS_INTERRUPTIBILITY_STI_BLOCKING | VMCS_INTERRUPTIBILITY_MOVSS_BLOCKING))
ERROR: braces {} are necessary for all arms of this statement
#1773: FILE: target/i386/hvf-utils/vmx.h:165:
+ if (val & (VMCS_INTERRUPTIBILITY_STI_BLOCKING | VMCS_INTERRUPTIBILITY_MOVSS_BLOCKING))
[...]
ERROR: line over 90 characters
#1775: FILE: target/i386/hvf-utils/vmx.h:167:
+ val & ~(VMCS_INTERRUPTIBILITY_STI_BLOCKING | VMCS_INTERRUPTIBILITY_MOVSS_BLOCKING));
ERROR: inline keyword should sit between storage class and type
#1778: FILE: target/i386/hvf-utils/vmx.h:170:
+static void inline vmx_clear_nmi_blocking(CPUState *cpu)
ERROR: inline keyword should sit between storage class and type
#1785: FILE: target/i386/hvf-utils/vmx.h:177:
+static void inline vmx_set_nmi_blocking(CPUState *cpu)
ERROR: inline keyword should sit between storage class and type
#1792: FILE: target/i386/hvf-utils/vmx.h:184:
+static void inline vmx_set_nmi_window_exiting(CPUState *cpu)
ERROR: line over 90 characters
#1796: FILE: target/i386/hvf-utils/vmx.h:188:
+ wvmcs(cpu->hvf_fd, VMCS_PRI_PROC_BASED_CTLS, val | VMCS_PRI_PROC_BASED_CTLS_NMI_WINDOW_EXITING);
ERROR: inline keyword should sit between storage class and type
#1800: FILE: target/i386/hvf-utils/vmx.h:192:
+static void inline vmx_clear_nmi_window_exiting(CPUState *cpu)
ERROR: line over 90 characters
#1805: FILE: target/i386/hvf-utils/vmx.h:197:
+ wvmcs(cpu->hvf_fd, VMCS_PRI_PROC_BASED_CTLS, val & ~VMCS_PRI_PROC_BASED_CTLS_NMI_WINDOW_EXITING);
ERROR: line over 90 characters
#1863: FILE: target/i386/hvf-utils/x86.c:49:
+bool x86_read_segment_descriptor(struct CPUState *cpu, struct x86_segment_descriptor *desc, x68_segment_selector sel)
ERROR: do not use C99 // comments
#1869: FILE: target/i386/hvf-utils/x86.c:55:
+ // valid gdt descriptors start from index 1
ERROR: braces {} are necessary for all arms of this statement
#1870: FILE: target/i386/hvf-utils/x86.c:56:
+ if (!sel.index && GDT_SEL == sel.ti)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1881: FILE: target/i386/hvf-utils/x86.c:67:
+ if (sel.index * 8 >= limit)
[...]
ERROR: line over 90 characters
#1888: FILE: target/i386/hvf-utils/x86.c:74:
+bool x86_write_segment_descriptor(struct CPUState *cpu, struct x86_segment_descriptor *desc, x68_segment_selector sel)
ERROR: trailing whitespace
#1892: FILE: target/i386/hvf-utils/x86.c:78:
+ $
ERROR: trailing whitespace
#1900: FILE: target/i386/hvf-utils/x86.c:86:
+ $
ERROR: __func__ should be used instead of gcc specific __FUNCTION__
#1902: FILE: target/i386/hvf-utils/x86.c:88:
+ printf("%s: gdt limit\n", __FUNCTION__);
WARNING: line over 80 characters
#1909: FILE: target/i386/hvf-utils/x86.c:95:
+bool x86_read_call_gate(struct CPUState *cpu, struct x86_call_gate *idt_desc, int gate)
ERROR: __func__ should be used instead of gcc specific __FUNCTION__
#1916: FILE: target/i386/hvf-utils/x86.c:102:
+ printf("%s: idt limit\n", __FUNCTION__);
ERROR: return is not a function, parentheses are not required
#1937: FILE: target/i386/hvf-utils/x86.c:123:
+ return (x86_is_protected(cpu) && (RFLAGS(cpu) & RFLAGS_VM));
WARNING: line over 80 characters
#1970: FILE: target/i386/hvf-utils/x86.c:156:
+addr_t linear_addr_size(struct CPUState *cpu, addr_t addr, int size, x86_reg_segment seg)
ERROR: switch and case should be at the same indent
#1972: FILE: target/i386/hvf-utils/x86.c:158:
+ switch (size) {
+ case 2:
[...]
+ case 4:
[...]
+ default:
ERROR: do not use C99 // comments
#2022: FILE: target/i386/hvf-utils/x86.h:28:
+// exceptions
ERROR: do not use C99 // comments
#2024: FILE: target/i386/hvf-utils/x86.h:30:
+ EXCEPTION_DE, // divide error
ERROR: do not use C99 // comments
#2025: FILE: target/i386/hvf-utils/x86.h:31:
+ EXCEPTION_DB, // debug fault
ERROR: do not use C99 // comments
#2026: FILE: target/i386/hvf-utils/x86.h:32:
+ EXCEPTION_NMI, // non-maskable interrupt
ERROR: code indent should never use tabs
#2027: FILE: target/i386/hvf-utils/x86.h:33:
+ EXCEPTION_BP, // breakpoint^Itrap$
ERROR: do not use C99 // comments
#2027: FILE: target/i386/hvf-utils/x86.h:33:
+ EXCEPTION_BP, // breakpoint trap
ERROR: code indent should never use tabs
#2028: FILE: target/i386/hvf-utils/x86.h:34:
+ EXCEPTION_OF, // overflow^Itrap$
ERROR: do not use C99 // comments
#2028: FILE: target/i386/hvf-utils/x86.h:34:
+ EXCEPTION_OF, // overflow trap
ERROR: code indent should never use tabs
#2029: FILE: target/i386/hvf-utils/x86.h:35:
+ EXCEPTION_BR, // boundary range exceeded^Ifault$
ERROR: do not use C99 // comments
#2029: FILE: target/i386/hvf-utils/x86.h:35:
+ EXCEPTION_BR, // boundary range exceeded fault
ERROR: do not use C99 // comments
#2030: FILE: target/i386/hvf-utils/x86.h:36:
+ EXCEPTION_UD, // undefined opcode
ERROR: do not use C99 // comments
#2031: FILE: target/i386/hvf-utils/x86.h:37:
+ EXCEPTION_NM, // device not available
ERROR: do not use C99 // comments
#2032: FILE: target/i386/hvf-utils/x86.h:38:
+ EXCEPTION_DF, // double fault
ERROR: do not use C99 // comments
#2033: FILE: target/i386/hvf-utils/x86.h:39:
+ EXCEPTION_RSVD, // not defined
ERROR: code indent should never use tabs
#2034: FILE: target/i386/hvf-utils/x86.h:40:
+ EXCEPTION_TS, // invalid TSS^Ifault$
ERROR: do not use C99 // comments
#2034: FILE: target/i386/hvf-utils/x86.h:40:
+ EXCEPTION_TS, // invalid TSS fault
ERROR: code indent should never use tabs
#2035: FILE: target/i386/hvf-utils/x86.h:41:
+ EXCEPTION_NP, // not present^Ifault$
ERROR: do not use C99 // comments
#2035: FILE: target/i386/hvf-utils/x86.h:41:
+ EXCEPTION_NP, // not present fault
ERROR: code indent should never use tabs
#2036: FILE: target/i386/hvf-utils/x86.h:42:
+ EXCEPTION_GP, // general protection^Ifault$
ERROR: do not use C99 // comments
#2036: FILE: target/i386/hvf-utils/x86.h:42:
+ EXCEPTION_GP, // general protection fault
ERROR: do not use C99 // comments
#2037: FILE: target/i386/hvf-utils/x86.h:43:
+ EXCEPTION_PF, // page fault
ERROR: do not use C99 // comments
#2038: FILE: target/i386/hvf-utils/x86.h:44:
+ EXCEPTION_RSVD2, // not defined
ERROR: do not use C99 // comments
#2041: FILE: target/i386/hvf-utils/x86.h:47:
+// general purpose regs
ERROR: do not use C99 // comments
#2061: FILE: target/i386/hvf-utils/x86.h:67:
+// segment regs
ERROR: open brace '{' following struct go on the same line
#2074: FILE: target/i386/hvf-utils/x86.h:80:
+typedef struct x86_register
+{
ERROR: do not use C99 // comments
#2077: FILE: target/i386/hvf-utils/x86.h:83:
+ uint64_t rrx; // full 64 bit
ERROR: do not use C99 // comments
#2080: FILE: target/i386/hvf-utils/x86.h:86:
+ uint32_t erx; // low 32 bit part
ERROR: do not use C99 // comments
#2084: FILE: target/i386/hvf-utils/x86.h:90:
+ uint16_t rx; // low 16 bit part
ERROR: do not use C99 // comments
#2089: FILE: target/i386/hvf-utils/x86.h:95:
+ uint8_t lx; // low 8 bit part
ERROR: do not use C99 // comments
#2090: FILE: target/i386/hvf-utils/x86.h:96:
+ uint8_t hx; // high 8 bit
ERROR: do not use C99 // comments
#2117: FILE: target/i386/hvf-utils/x86.h:123:
+// rflags register
ERROR: do not use C99 // comments
#2202: FILE: target/i386/hvf-utils/x86.h:208:
+// 16 bit Task State Segment
ERROR: do not use C99 // comments
#2228: FILE: target/i386/hvf-utils/x86.h:234:
+// 32 bit Task State Segment
ERROR: open brace '{' following struct go on the same line
#2230: FILE: target/i386/hvf-utils/x86.h:236:
+typedef struct x86_tss_segment32
+{
ERROR: do not use C99 // comments
#2260: FILE: target/i386/hvf-utils/x86.h:266:
+// 64 bit Task State Segment
ERROR: open brace '{' following struct go on the same line
#2262: FILE: target/i386/hvf-utils/x86.h:268:
+typedef struct x86_tss_segment64
+{
ERROR: do not use C99 // comments
#2280: FILE: target/i386/hvf-utils/x86.h:286:
+// segment descriptors
WARNING: line over 80 characters
#2302: FILE: target/i386/hvf-utils/x86.h:308:
+static inline void x86_set_segment_base(x86_segment_descriptor *desc, uint32_t base)
ERROR: braces {} are necessary for all arms of this statement
#2312: FILE: target/i386/hvf-utils/x86.h:318:
+ if (desc->g)
[...]
WARNING: line over 80 characters
#2317: FILE: target/i386/hvf-utils/x86.h:323:
+static inline void x86_set_segment_limit(x86_segment_descriptor *desc, uint32_t limit)
ERROR: do not use C99 // comments
#2353: FILE: target/i386/hvf-utils/x86.h:359:
+// Definition of hvf_x86_state is here
ERROR: trailing whitespace
#2357: FILE: target/i386/hvf-utils/x86.h:363:
+ $
ERROR: "foo* bar" should be "foo *bar"
#2367: FILE: target/i386/hvf-utils/x86.h:373:
+ uint8_t* apic_page;
ERROR: do not use C99 // comments
#2377: FILE: target/i386/hvf-utils/x86.h:383:
+// useful register access macros
ERROR: do not use C99 // comments
#2433: FILE: target/i386/hvf-utils/x86.h:439:
+// deal with GDT/LDT descriptors in memory
ERROR: line over 90 characters
#2434: FILE: target/i386/hvf-utils/x86.h:440:
+bool x86_read_segment_descriptor(struct CPUState *cpu, struct x86_segment_descriptor *desc, x68_segment_selector sel);
ERROR: line over 90 characters
#2435: FILE: target/i386/hvf-utils/x86.h:441:
+bool x86_write_segment_descriptor(struct CPUState *cpu, struct x86_segment_descriptor *desc, x68_segment_selector sel);
WARNING: line over 80 characters
#2437: FILE: target/i386/hvf-utils/x86.h:443:
+bool x86_read_call_gate(struct CPUState *cpu, struct x86_call_gate *idt_desc, int gate);
ERROR: do not use C99 // comments
#2439: FILE: target/i386/hvf-utils/x86.h:445:
+// helpers
WARNING: line over 80 characters
#2449: FILE: target/i386/hvf-utils/x86.h:455:
+addr_t linear_addr_size(struct CPUState *cpu, addr_t addr, int size, x86_reg_segment seg);
ERROR: do not use C99 // comments
#2455: FILE: target/i386/hvf-utils/x86.h:461:
+ __asm__ __volatile__("rdtscp; " // serializing read of tsc
WARNING: line over 80 characters
#2456: FILE: target/i386/hvf-utils/x86.h:462:
+ "shl $32,%%rdx; " // shift higher 32 bits stored in rdx up
ERROR: do not use C99 // comments
#2456: FILE: target/i386/hvf-utils/x86.h:462:
+ "shl $32,%%rdx; " // shift higher 32 bits stored in rdx up
ERROR: do not use C99 // comments
#2457: FILE: target/i386/hvf-utils/x86.h:463:
+ "or %%rdx,%%rax" // and or onto rax
ERROR: do not use C99 // comments
#2458: FILE: target/i386/hvf-utils/x86.h:464:
+ : "=a"(tsc) // output to tsc variable
ERROR: do not use C99 // comments
#2460: FILE: target/i386/hvf-utils/x86.h:466:
+ : "%rcx", "%rdx"); // rcx and rdx are clobbered
ERROR: trailing whitespace
#2461: FILE: target/i386/hvf-utils/x86.h:467:
+ $
WARNING: line over 80 characters
#2514: FILE: target/i386/hvf-utils/x86_cpuid.c:44:
+ .ext_features = /*CPUID_EXT_SSE3 |*/ CPUID_EXT_POPCNT, CPUID_MTRR | CPUID_CLFLUSH,
ERROR: do not use C99 // comments
#2517: FILE: target/i386/hvf-utils/x86_cpuid.c:47:
+ .ext3_features = 0,//CPUID_EXT3_LAHF_LM,
ERROR: trailing whitespace
#2534: FILE: target/i386/hvf-utils/x86_cpuid.c:64:
+ .ext_features = CPUID_EXT_SSE3 | CPUID_EXT_SSSE3 | $
ERROR: do not initialise statics to 0 or NULL
#2565: FILE: target/i386/hvf-utils/x86_cpuid.c:95:
+static struct x86_cpuid *_cpuid = NULL;
ERROR: "foo* bar" should be "foo *bar"
#2567: FILE: target/i386/hvf-utils/x86_cpuid.c:97:
+void init_cpuid(struct CPUState* cpu)
ERROR: do not use C99 // comments
#2569: FILE: target/i386/hvf-utils/x86_cpuid.c:99:
+ _cpuid = &builtin_cpus[2]; // core2duo
ERROR: line over 90 characters
#2572: FILE: target/i386/hvf-utils/x86_cpuid.c:102:
+void get_cpuid_func(struct CPUState* cpu, int func, int cnt, uint32_t *eax, uint32_t *ebx, uint32_t *ecx, uint32_t *edx)
ERROR: "foo* bar" should be "foo *bar"
#2572: FILE: target/i386/hvf-utils/x86_cpuid.c:102:
+void get_cpuid_func(struct CPUState* cpu, int func, int cnt, uint32_t *eax, uint32_t *ebx, uint32_t *ecx, uint32_t *edx)
ERROR: switch and case should be at the same indent
#2580: FILE: target/i386/hvf-utils/x86_cpuid.c:110:
+ switch(func) {
+ case 0:
[...]
+ case 1:
[...]
+ case 2:
[...]
+ case 4:
[...]
+ case 5:
[...]
+ case 6:
[...]
+ case 7:
[...]
+ case 9:
[...]
+ case 0xA:
[...]
+ case 0xB:
[...]
+ case 0xD:
[...]
+ case 0x80000000:
[...]
+ case 0x80000001:
[...]
+ case 0x80000002:
+ case 0x80000003:
+ case 0x80000004:
[...]
+ case 0x80000005:
[...]
+ case 0x80000006:
[...]
+ case 0x80000007:
[...]
+ case 0x80000008:
[...]
+ case 0x8000000A:
[...]
+ case 0x80000019:
[...]
+ case 0xC0000000:
[...]
+ default:
ERROR: space required before the open parenthesis '('
#2580: FILE: target/i386/hvf-utils/x86_cpuid.c:110:
+ switch(func) {
ERROR: line over 90 characters
#2588: FILE: target/i386/hvf-utils/x86_cpuid.c:118:
+ *eax = h_rax;//_cpuid->stepping | (_cpuid->model << 3) | (_cpuid->family << 6);
ERROR: do not use C99 // comments
#2588: FILE: target/i386/hvf-utils/x86_cpuid.c:118:
+ *eax = h_rax;//_cpuid->stepping | (_cpuid->model << 3) | (_cpuid->family << 6);
WARNING: line over 80 characters
#2598: FILE: target/i386/hvf-utils/x86_cpuid.c:128:
+ *ecx = *ecx & ~(CPUID_EXT_OSXSAVE | CPUID_EXT_MONITOR | CPUID_EXT_X2APIC |
ERROR: line over 90 characters
#2599: FILE: target/i386/hvf-utils/x86_cpuid.c:129:
+ CPUID_EXT_VMX | CPUID_EXT_TSC_DEADLINE_TIMER | CPUID_EXT_TM2 | CPUID_EXT_PCID |
ERROR: line over 90 characters
#2633: FILE: target/i386/hvf-utils/x86_cpuid.c:163:
+ *ebx = h_rbx & ~(CPUID_7_0_EBX_AVX512F | CPUID_7_0_EBX_AVX512PF | CPUID_7_0_EBX_AVX512ER | CPUID_7_0_EBX_AVX512CD |
ERROR: line over 90 characters
#2634: FILE: target/i386/hvf-utils/x86_cpuid.c:164:
+ CPUID_7_0_EBX_AVX512BW | CPUID_7_0_EBX_AVX512VL | CPUID_7_0_EBX_MPX | CPUID_7_0_EBX_INVPCID);
ERROR: braces {} are necessary for all arms of this statement
#2661: FILE: target/i386/hvf-utils/x86_cpuid.c:191:
+ if (!cnt)
[...]
ERROR: braces {} are necessary for all arms of this statement
#2663: FILE: target/i386/hvf-utils/x86_cpuid.c:193:
+ if (1 == cnt)
[...]
ERROR: line over 90 characters
#2676: FILE: target/i386/hvf-utils/x86_cpuid.c:206:
+ *eax = h_rax;//_cpuid->stepping | (_cpuid->model << 3) | (_cpuid->family << 6);
ERROR: do not use C99 // comments
#2676: FILE: target/i386/hvf-utils/x86_cpuid.c:206:
+ *eax = h_rax;//_cpuid->stepping | (_cpuid->model << 3) | (_cpuid->family << 6);
WARNING: architecture specific defines should be avoided
#2763: FILE: target/i386/hvf-utils/x86_cpuid.h:17:
+#ifndef __CPUID_H__
ERROR: "foo* bar" should be "foo *bar"
#2793: FILE: target/i386/hvf-utils/x86_cpuid.h:47:
+void init_cpuid(struct CPUState* cpu);
ERROR: line over 90 characters
#2794: FILE: target/i386/hvf-utils/x86_cpuid.h:48:
+void get_cpuid_func(struct CPUState *cpu, int func, int cnt, uint32_t *eax, uint32_t *ebx, uint32_t *ecx, uint32_t *edx);
WARNING: line over 80 characters
#2835: FILE: target/i386/hvf-utils/x86_decode.c:32:
+ printf("%llx: failed to decode instruction ", cpu->hvf_x86->fetch_rip - decode->len);
ERROR: braces {} are necessary even for single statement blocks
#2836: FILE: target/i386/hvf-utils/x86_decode.c:33:
+ for (int i = 0; i < decode->opcode_len; i++)
+ printf("%x ", decode->opcode[i]);
ERROR: switch and case should be at the same indent
#2844: FILE: target/i386/hvf-utils/x86_decode.c:41:
+ switch (size) {
+ case 1:
[...]
+ case 2:
[...]
+ case 4:
[...]
+ case 8:
[...]
+ default:
ERROR: __func__ should be used instead of gcc specific __FUNCTION__
#2858: FILE: target/i386/hvf-utils/x86_decode.c:55:
+ VM_PANIC_EX("%s invalid size %d\n", __FUNCTION__, size);
WARNING: line over 80 characters
#2864: FILE: target/i386/hvf-utils/x86_decode.c:61:
+static inline uint64_t decode_bytes(CPUState *cpu, struct x86_decode *decode, int size)
ERROR: trailing whitespace
#2867: FILE: target/i386/hvf-utils/x86_decode.c:64:
+ $
ERROR: switch and case should be at the same indent
#2868: FILE: target/i386/hvf-utils/x86_decode.c:65:
+ switch (size) {
+ case 1:
+ case 2:
+ case 4:
+ case 8:
[...]
+ default:
ERROR: __func__ should be used instead of gcc specific __FUNCTION__
#2875: FILE: target/i386/hvf-utils/x86_decode.c:72:
+ VM_PANIC_EX("%s invalid size %d\n", __FUNCTION__, size);
ERROR: trailing whitespace
#2881: FILE: target/i386/hvf-utils/x86_decode.c:78:
+ $
ERROR: line over 90 characters
#2905: FILE: target/i386/hvf-utils/x86_decode.c:102:
+static void decode_modrm_rm(CPUState *cpu, struct x86_decode *decode, struct x86_decode_op *op)
ERROR: line over 90 characters
#2910: FILE: target/i386/hvf-utils/x86_decode.c:107:
+static void decode_modrm_reg(CPUState *cpu, struct x86_decode *decode, struct x86_decode_op *op)
WARNING: line over 80 characters
#2917: FILE: target/i386/hvf-utils/x86_decode.c:114:
+static void decode_rax(CPUState *cpu, struct x86_decode *decode, struct x86_decode_op *op)
ERROR: line over 90 characters
#2924: FILE: target/i386/hvf-utils/x86_decode.c:121:
+static inline void decode_immediate(CPUState *cpu, struct x86_decode *decode, struct x86_decode_op *var, int size)
ERROR: switch and case should be at the same indent
#2928: FILE: target/i386/hvf-utils/x86_decode.c:125:
+ switch (size) {
+ case 1:
[...]
+ case 2:
[...]
+ case 4:
[...]
+ case 8:
[...]
+ default:
ERROR: line over 90 characters
#2946: FILE: target/i386/hvf-utils/x86_decode.c:143:
+static void decode_imm8(CPUState *cpu, struct x86_decode *decode, struct x86_decode_op *op)
ERROR: line over 90 characters
#2952: FILE: target/i386/hvf-utils/x86_decode.c:149:
+static void decode_imm8_signed(CPUState *cpu, struct x86_decode *decode, struct x86_decode_op *op)
ERROR: line over 90 characters
#2959: FILE: target/i386/hvf-utils/x86_decode.c:156:
+static void decode_imm16(CPUState *cpu, struct x86_decode *decode, struct x86_decode_op *op)
WARNING: line over 80 characters
#2966: FILE: target/i386/hvf-utils/x86_decode.c:163:
+static void decode_imm(CPUState *cpu, struct x86_decode *decode, struct x86_decode_op *op)
ERROR: line over 90 characters
#2977: FILE: target/i386/hvf-utils/x86_decode.c:174:
+static void decode_imm_signed(CPUState *cpu, struct x86_decode *decode, struct x86_decode_op *op)
ERROR: line over 90 characters
#2984: FILE: target/i386/hvf-utils/x86_decode.c:181:
+static void decode_imm_1(CPUState *cpu, struct x86_decode *decode, struct x86_decode_op *op)
ERROR: line over 90 characters
#2990: FILE: target/i386/hvf-utils/x86_decode.c:187:
+static void decode_imm_0(CPUState *cpu, struct x86_decode *decode, struct x86_decode_op *op)
WARNING: line over 80 characters
#2999: FILE: target/i386/hvf-utils/x86_decode.c:196:
+ uint8_t op = (decode->opcode_len > 1) ? decode->opcode[1] : decode->opcode[0];
ERROR: trailing whitespace
#3000: FILE: target/i386/hvf-utils/x86_decode.c:197:
+ $
ERROR: switch and case should be at the same indent
#3002: FILE: target/i386/hvf-utils/x86_decode.c:199:
+ switch (op) {
+ case 0xe:
[...]
+ case 0x16:
[...]
+ case 0x1e:
[...]
+ case 0x06:
[...]
+ case 0xa0:
[...]
+ case 0xa8:
WARNING: line over 80 characters
#3026: FILE: target/i386/hvf-utils/x86_decode.c:223:
+ uint8_t op = (decode->opcode_len > 1) ? decode->opcode[1] : decode->opcode[0];
ERROR: trailing whitespace
#3027: FILE: target/i386/hvf-utils/x86_decode.c:224:
+ $
ERROR: switch and case should be at the same indent
#3029: FILE: target/i386/hvf-utils/x86_decode.c:226:
+ switch (op) {
+ case 0xf:
[...]
+ case 0x17:
[...]
+ case 0x1f:
[...]
+ case 0x07:
[...]
+ case 0xa1:
[...]
+ case 0xa9:
ERROR: line over 90 characters
#3055: FILE: target/i386/hvf-utils/x86_decode.c:252:
+ decode->op[0].ptr = get_reg_ref(cpu, decode->op[0].reg, decode->rex.b, decode->operand_size);
ERROR: line over 90 characters
#3062: FILE: target/i386/hvf-utils/x86_decode.c:259:
+ decode->op[0].ptr = get_reg_ref(cpu, decode->op[0].reg, decode->rex.b, decode->operand_size);
ERROR: braces {} are necessary for all arms of this statement
#3067: FILE: target/i386/hvf-utils/x86_decode.c:264:
+ if (!decode->modrm.reg)
[...]
+ else if (1 == decode->modrm.reg)
[...]
ERROR: braces {} are necessary for all arms of this statement
#3069: FILE: target/i386/hvf-utils/x86_decode.c:266:
+ else if (1 == decode->modrm.reg)
[...]
ERROR: line over 90 characters
#3077: FILE: target/i386/hvf-utils/x86_decode.c:274:
+ decode->op[0].ptr = get_reg_ref(cpu, decode->op[0].reg, decode->rex.b, decode->operand_size);
ERROR: line over 90 characters
#3084: FILE: target/i386/hvf-utils/x86_decode.c:281:
+ decode->op[0].ptr = get_reg_ref(cpu, decode->op[0].reg, decode->rex.b, decode->operand_size);
ERROR: switch and case should be at the same indent
#3145: FILE: target/i386/hvf-utils/x86_decode.c:342:
+ switch (decode->modrm.reg) {
+ case 0:
+ case 1:
[...]
+ case 2:
[...]
+ case 3:
[...]
+ default:
ERROR: line over 90 characters
#3165: FILE: target/i386/hvf-utils/x86_decode.c:362:
+ decode->op[0].ptr = get_reg_ref(cpu, decode->op[0].reg, decode->rex.b, decode->operand_size);
ERROR: line over 90 characters
#3172: FILE: target/i386/hvf-utils/x86_decode.c:369:
+ decode->op[0].ptr = get_reg_ref(cpu, decode->op[0].reg, decode->rex.b, decode->operand_size);
ERROR: line over 90 characters
#3176: FILE: target/i386/hvf-utils/x86_decode.c:373:
+static void fetch_moffs(CPUState *cpu, struct x86_decode *decode, struct x86_decode_op *op)
ERROR: line over 90 characters
#3186: FILE: target/i386/hvf-utils/x86_decode.c:383:
+ decode->op[0].ptr = get_reg_ref(cpu, decode->op[0].reg, decode->rex.b, decode->operand_size);
WARNING: line over 80 characters
#3190: FILE: target/i386/hvf-utils/x86_decode.c:387:
+static void decode_rcx(CPUState *cpu, struct x86_decode *decode, struct x86_decode_op *op)
ERROR: line over 90 characters
#3202: FILE: target/i386/hvf-utils/x86_decode.c:399:
+ void (*decode_op1)(CPUState *cpu, struct x86_decode *decode, struct x86_decode_op *op1);
ERROR: line over 90 characters
#3203: FILE: target/i386/hvf-utils/x86_decode.c:400:
+ void (*decode_op2)(CPUState *cpu, struct x86_decode *decode, struct x86_decode_op *op2);
ERROR: line over 90 characters
#3204: FILE: target/i386/hvf-utils/x86_decode.c:401:
+ void (*decode_op3)(CPUState *cpu, struct x86_decode *decode, struct x86_decode_op *op3);
ERROR: line over 90 characters
#3205: FILE: target/i386/hvf-utils/x86_decode.c:402:
+ void (*decode_op4)(CPUState *cpu, struct x86_decode *decode, struct x86_decode_op *op4);
ERROR: line over 90 characters
#3218: FILE: target/i386/hvf-utils/x86_decode.c:415:
+ void (*decode_op1)(CPUState *cpu, struct x86_decode *decode, struct x86_decode_op *op1);
ERROR: line over 90 characters
#3219: FILE: target/i386/hvf-utils/x86_decode.c:416:
+ void (*decode_op2)(CPUState *cpu, struct x86_decode *decode, struct x86_decode_op *op2);
WARNING: line over 80 characters
#3224: FILE: target/i386/hvf-utils/x86_decode.c:421:
+struct decode_tbl invl_inst = {0x0, 0, 0, false, NULL, NULL, NULL, NULL, decode_invalid};
ERROR: trailing whitespace
#3233: FILE: target/i386/hvf-utils/x86_decode.c:430:
+ $
WARNING: line over 80 characters
#3236: FILE: target/i386/hvf-utils/x86_decode.c:433:
+ int index = ((decode->opcode[0] & 0xf) << 4) | (mode << 3) | decode->modrm.reg;
ERROR: trailing whitespace
#3237: FILE: target/i386/hvf-utils/x86_decode.c:434:
+ $
ERROR: trailing whitespace
#3239: FILE: target/i386/hvf-utils/x86_decode.c:436:
+ $
ERROR: braces {} are necessary for all arms of this statement
#3241: FILE: target/i386/hvf-utils/x86_decode.c:438:
+ if (decoder->operand_size)
[...]
ERROR: trailing whitespace
#3246: FILE: target/i386/hvf-utils/x86_decode.c:443:
+ $
ERROR: braces {} are necessary for all arms of this statement
#3247: FILE: target/i386/hvf-utils/x86_decode.c:444:
+ if (decoder->decode_op1)
[...]
ERROR: braces {} are necessary for all arms of this statement
#3249: FILE: target/i386/hvf-utils/x86_decode.c:446:
+ if (decoder->decode_op2)
[...]
ERROR: braces {} are necessary for all arms of this statement
#3251: FILE: target/i386/hvf-utils/x86_decode.c:448:
+ if (decoder->decode_postfix)
[...]
ERROR: trailing whitespace
#3253: FILE: target/i386/hvf-utils/x86_decode.c:450:
+ $
ERROR: line over 90 characters
#3254: FILE: target/i386/hvf-utils/x86_decode.c:451:
+ VM_PANIC_ON_EX(!decode->cmd, "x87 opcode %x %x (%x %x) not decoded\n", decode->opcode[0], decode->modrm.modrm, decoder->modrm_reg, decoder->modrm_mod);
ERROR: braces {} are necessary for all arms of this statement
#3271: FILE: target/i386/hvf-utils/x86_decode.c:468:
+ if (decode->modrm.reg > 2)
[...]
WARNING: line over 80 characters
#3288: FILE: target/i386/hvf-utils/x86_decode.c:485:
+ printf("%llx: decode_sldtgroup: %d\n", cpu->hvf_x86->fetch_rip, decode->modrm.reg);
ERROR: line over 90 characters
#3330: FILE: target/i386/hvf-utils/x86_decode.c:527:
+static void decode_x87_modrm_floatp(CPUState *cpu, struct x86_decode *decode, struct x86_decode_op *op)
ERROR: line over 90 characters
#3335: FILE: target/i386/hvf-utils/x86_decode.c:532:
+static void decode_x87_modrm_intp(CPUState *cpu, struct x86_decode *decode, struct x86_decode_op *op)
ERROR: line over 90 characters
#3340: FILE: target/i386/hvf-utils/x86_decode.c:537:
+static void decode_x87_modrm_bytep(CPUState *cpu, struct x86_decode *decode, struct x86_decode_op *op)
ERROR: line over 90 characters
#3345: FILE: target/i386/hvf-utils/x86_decode.c:542:
+static void decode_x87_modrm_st0(CPUState *cpu, struct x86_decode *decode, struct x86_decode_op *op)
ERROR: line over 90 characters
#3351: FILE: target/i386/hvf-utils/x86_decode.c:548:
+static void decode_decode_x87_modrm_st0(CPUState *cpu, struct x86_decode *decode, struct x86_decode_op *op)
ERROR: switch and case should be at the same indent
#3361: FILE: target/i386/hvf-utils/x86_decode.c:558:
+ switch (decode->modrm.reg) {
+ case 0:
[...]
+ case 1:
[...]
+ case 5:
[...]
+ case 6:
[...]
+ case 7:
[...]
+ default:
ERROR: line over 90 characters
#3398: FILE: target/i386/hvf-utils/x86_decode.c:595:
+ decode->op[0].ptr = get_reg_ref(cpu, decode->op[0].reg, decode->rex.b, decode->operand_size);
ERROR: switch and case should be at the same indent
#3403: FILE: target/i386/hvf-utils/x86_decode.c:600:
+ switch(decode->modrm.modrm) {
+ case 0xe0:
[...]
+ case 0xe1:
[...]
+ case 0xe4:
[...]
+ case 0xe5:
[...]
+ default:
ERROR: space required before the open parenthesis '('
#3403: FILE: target/i386/hvf-utils/x86_decode.c:600:
+ switch(decode->modrm.modrm) {
ERROR: do not use C99 // comments
#3405: FILE: target/i386/hvf-utils/x86_decode.c:602:
+ // FCHS
ERROR: do not use C99 // comments
#3415: FILE: target/i386/hvf-utils/x86_decode.c:612:
+ // FXAM
ERROR: switch and case should be at the same indent
#3426: FILE: target/i386/hvf-utils/x86_decode.c:623:
+ switch (decode->modrm.modrm) {
+ case 0xe0:
[...]
+ case 0xe1:
[...]
+ case 0xe2:
[...]
+ case 0xe3:
[...]
+ case 0xe4:
[...]
+ default:
ERROR: line over 90 characters
#3428: FILE: target/i386/hvf-utils/x86_decode.c:625:
+ VM_PANIC_ON_EX(1, "unhandled FNENI: %x %x\n", decode->opcode[0], decode->modrm.modrm);
ERROR: line over 90 characters
#3431: FILE: target/i386/hvf-utils/x86_decode.c:628:
+ VM_PANIC_ON_EX(1, "unhandled FNDISI: %x %x\n", decode->opcode[0], decode->modrm.modrm);
ERROR: line over 90 characters
#3434: FILE: target/i386/hvf-utils/x86_decode.c:631:
+ VM_PANIC_ON_EX(1, "unhandled FCLEX: %x %x\n", decode->opcode[0], decode->modrm.modrm);
ERROR: line over 90 characters
#3443: FILE: target/i386/hvf-utils/x86_decode.c:640:
+ VM_PANIC_ON_EX(1, "unhandled fpu opcode: %x %x\n", decode->opcode[0], decode->modrm.modrm);
ERROR: line over 90 characters
#3450: FILE: target/i386/hvf-utils/x86_decode.c:647:
+#define RFLAGS_MASK_OSZAPC (RFLAGS_OF | RFLAGS_SF | RFLAGS_ZF | RFLAGS_AF | RFLAGS_PF | RFLAGS_CF)
WARNING: line over 80 characters
#3451: FILE: target/i386/hvf-utils/x86_decode.c:648:
+#define RFLAGS_MASK_LAHF (RFLAGS_SF | RFLAGS_ZF | RFLAGS_AF | RFLAGS_PF | RFLAGS_CF)
ERROR: that open brace { should be on the previous line
#3459: FILE: target/i386/hvf-utils/x86_decode.c:656:
+struct decode_tbl _1op_inst[] =
+{
ERROR: line over 90 characters
#3460: FILE: target/i386/hvf-utils/x86_decode.c:657:
+ {0x0, X86_DECODE_CMD_ADD, 1, true, decode_modrm_rm, decode_modrm_reg, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3461: FILE: target/i386/hvf-utils/x86_decode.c:658:
+ {0x1, X86_DECODE_CMD_ADD, 0, true, decode_modrm_rm, decode_modrm_reg, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3462: FILE: target/i386/hvf-utils/x86_decode.c:659:
+ {0x2, X86_DECODE_CMD_ADD, 1, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3463: FILE: target/i386/hvf-utils/x86_decode.c:660:
+ {0x3, X86_DECODE_CMD_ADD, 0, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3464: FILE: target/i386/hvf-utils/x86_decode.c:661:
+ {0x4, X86_DECODE_CMD_ADD, 1, false, decode_rax, decode_imm8, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3465: FILE: target/i386/hvf-utils/x86_decode.c:662:
+ {0x5, X86_DECODE_CMD_ADD, 0, false, decode_rax, decode_imm, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3466: FILE: target/i386/hvf-utils/x86_decode.c:663:
+ {0x6, X86_DECODE_CMD_PUSH_SEG, 0, false, false, NULL, NULL, NULL, decode_pushseg, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3467: FILE: target/i386/hvf-utils/x86_decode.c:664:
+ {0x7, X86_DECODE_CMD_POP_SEG, 0, false, false, NULL, NULL, NULL, decode_popseg, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3468: FILE: target/i386/hvf-utils/x86_decode.c:665:
+ {0x8, X86_DECODE_CMD_OR, 1, true, decode_modrm_rm, decode_modrm_reg, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3469: FILE: target/i386/hvf-utils/x86_decode.c:666:
+ {0x9, X86_DECODE_CMD_OR, 0, true, decode_modrm_rm, decode_modrm_reg, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3470: FILE: target/i386/hvf-utils/x86_decode.c:667:
+ {0xa, X86_DECODE_CMD_OR, 1, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3471: FILE: target/i386/hvf-utils/x86_decode.c:668:
+ {0xb, X86_DECODE_CMD_OR, 0, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3472: FILE: target/i386/hvf-utils/x86_decode.c:669:
+ {0xc, X86_DECODE_CMD_OR, 1, false, decode_rax, decode_imm8, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3473: FILE: target/i386/hvf-utils/x86_decode.c:670:
+ {0xd, X86_DECODE_CMD_OR, 0, false, decode_rax, decode_imm, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: trailing whitespace
#3474: FILE: target/i386/hvf-utils/x86_decode.c:671:
+ $
ERROR: line over 90 characters
#3475: FILE: target/i386/hvf-utils/x86_decode.c:672:
+ {0xe, X86_DECODE_CMD_PUSH_SEG, 0, false, false, NULL, NULL, NULL, decode_pushseg, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3476: FILE: target/i386/hvf-utils/x86_decode.c:673:
+ {0xf, X86_DECODE_CMD_POP_SEG, 0, false, false, NULL, NULL, NULL, decode_popseg, RFLAGS_MASK_NONE},
ERROR: trailing whitespace
#3477: FILE: target/i386/hvf-utils/x86_decode.c:674:
+ $
ERROR: line over 90 characters
#3478: FILE: target/i386/hvf-utils/x86_decode.c:675:
+ {0x10, X86_DECODE_CMD_ADC, 1, true, decode_modrm_rm, decode_modrm_reg, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3479: FILE: target/i386/hvf-utils/x86_decode.c:676:
+ {0x11, X86_DECODE_CMD_ADC, 0, true, decode_modrm_rm, decode_modrm_reg, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3480: FILE: target/i386/hvf-utils/x86_decode.c:677:
+ {0x12, X86_DECODE_CMD_ADC, 1, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3481: FILE: target/i386/hvf-utils/x86_decode.c:678:
+ {0x13, X86_DECODE_CMD_ADC, 0, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3482: FILE: target/i386/hvf-utils/x86_decode.c:679:
+ {0x14, X86_DECODE_CMD_ADC, 1, false, decode_rax, decode_imm, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3483: FILE: target/i386/hvf-utils/x86_decode.c:680:
+ {0x15, X86_DECODE_CMD_ADC, 0, false, decode_rax, decode_imm, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: trailing whitespace
#3484: FILE: target/i386/hvf-utils/x86_decode.c:681:
+ $
ERROR: line over 90 characters
#3485: FILE: target/i386/hvf-utils/x86_decode.c:682:
+ {0x16, X86_DECODE_CMD_PUSH_SEG, 0, false, false, NULL, NULL, NULL, decode_pushseg, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3486: FILE: target/i386/hvf-utils/x86_decode.c:683:
+ {0x17, X86_DECODE_CMD_POP_SEG, 0, false, false, NULL, NULL, NULL, decode_popseg, RFLAGS_MASK_NONE},
ERROR: trailing whitespace
#3487: FILE: target/i386/hvf-utils/x86_decode.c:684:
+ $
ERROR: line over 90 characters
#3488: FILE: target/i386/hvf-utils/x86_decode.c:685:
+ {0x18, X86_DECODE_CMD_SBB, 1, true, decode_modrm_rm, decode_modrm_reg, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3489: FILE: target/i386/hvf-utils/x86_decode.c:686:
+ {0x19, X86_DECODE_CMD_SBB, 0, true, decode_modrm_rm, decode_modrm_reg, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3490: FILE: target/i386/hvf-utils/x86_decode.c:687:
+ {0x1a, X86_DECODE_CMD_SBB, 1, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3491: FILE: target/i386/hvf-utils/x86_decode.c:688:
+ {0x1b, X86_DECODE_CMD_SBB, 0, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3492: FILE: target/i386/hvf-utils/x86_decode.c:689:
+ {0x1c, X86_DECODE_CMD_SBB, 1, false, decode_rax, decode_imm8, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3493: FILE: target/i386/hvf-utils/x86_decode.c:690:
+ {0x1d, X86_DECODE_CMD_SBB, 0, false, decode_rax, decode_imm, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: trailing whitespace
#3494: FILE: target/i386/hvf-utils/x86_decode.c:691:
+ $
ERROR: line over 90 characters
#3495: FILE: target/i386/hvf-utils/x86_decode.c:692:
+ {0x1e, X86_DECODE_CMD_PUSH_SEG, 0, false, false, NULL, NULL, NULL, decode_pushseg, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3496: FILE: target/i386/hvf-utils/x86_decode.c:693:
+ {0x1f, X86_DECODE_CMD_POP_SEG, 0, false, false, NULL, NULL, NULL, decode_popseg, RFLAGS_MASK_NONE},
ERROR: trailing whitespace
#3497: FILE: target/i386/hvf-utils/x86_decode.c:694:
+ $
ERROR: line over 90 characters
#3498: FILE: target/i386/hvf-utils/x86_decode.c:695:
+ {0x20, X86_DECODE_CMD_AND, 1, true, decode_modrm_rm, decode_modrm_reg, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3499: FILE: target/i386/hvf-utils/x86_decode.c:696:
+ {0x21, X86_DECODE_CMD_AND, 0, true, decode_modrm_rm, decode_modrm_reg, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3500: FILE: target/i386/hvf-utils/x86_decode.c:697:
+ {0x22, X86_DECODE_CMD_AND, 1, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3501: FILE: target/i386/hvf-utils/x86_decode.c:698:
+ {0x23, X86_DECODE_CMD_AND, 0, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3502: FILE: target/i386/hvf-utils/x86_decode.c:699:
+ {0x24, X86_DECODE_CMD_AND, 1, false, decode_rax, decode_imm, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3503: FILE: target/i386/hvf-utils/x86_decode.c:700:
+ {0x25, X86_DECODE_CMD_AND, 0, false, decode_rax, decode_imm, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3504: FILE: target/i386/hvf-utils/x86_decode.c:701:
+ {0x28, X86_DECODE_CMD_SUB, 1, true, decode_modrm_rm, decode_modrm_reg, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3505: FILE: target/i386/hvf-utils/x86_decode.c:702:
+ {0x29, X86_DECODE_CMD_SUB, 0, true, decode_modrm_rm, decode_modrm_reg, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3506: FILE: target/i386/hvf-utils/x86_decode.c:703:
+ {0x2a, X86_DECODE_CMD_SUB, 1, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3507: FILE: target/i386/hvf-utils/x86_decode.c:704:
+ {0x2b, X86_DECODE_CMD_SUB, 0, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3508: FILE: target/i386/hvf-utils/x86_decode.c:705:
+ {0x2c, X86_DECODE_CMD_SUB, 1, false, decode_rax, decode_imm, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3509: FILE: target/i386/hvf-utils/x86_decode.c:706:
+ {0x2d, X86_DECODE_CMD_SUB, 0, false, decode_rax, decode_imm, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3510: FILE: target/i386/hvf-utils/x86_decode.c:707:
+ {0x2f, X86_DECODE_CMD_DAS, 0, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3511: FILE: target/i386/hvf-utils/x86_decode.c:708:
+ {0x30, X86_DECODE_CMD_XOR, 1, true, decode_modrm_rm, decode_modrm_reg, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3512: FILE: target/i386/hvf-utils/x86_decode.c:709:
+ {0x31, X86_DECODE_CMD_XOR, 0, true, decode_modrm_rm, decode_modrm_reg, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3513: FILE: target/i386/hvf-utils/x86_decode.c:710:
+ {0x32, X86_DECODE_CMD_XOR, 1, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3514: FILE: target/i386/hvf-utils/x86_decode.c:711:
+ {0x33, X86_DECODE_CMD_XOR, 0, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3515: FILE: target/i386/hvf-utils/x86_decode.c:712:
+ {0x34, X86_DECODE_CMD_XOR, 1, false, decode_rax, decode_imm, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3516: FILE: target/i386/hvf-utils/x86_decode.c:713:
+ {0x35, X86_DECODE_CMD_XOR, 0, false, decode_rax, decode_imm, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: trailing whitespace
#3517: FILE: target/i386/hvf-utils/x86_decode.c:714:
+ $
ERROR: line over 90 characters
#3518: FILE: target/i386/hvf-utils/x86_decode.c:715:
+ {0x38, X86_DECODE_CMD_CMP, 1, true, decode_modrm_rm, decode_modrm_reg, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3519: FILE: target/i386/hvf-utils/x86_decode.c:716:
+ {0x39, X86_DECODE_CMD_CMP, 0, true, decode_modrm_rm, decode_modrm_reg, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3520: FILE: target/i386/hvf-utils/x86_decode.c:717:
+ {0x3a, X86_DECODE_CMD_CMP, 1, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3521: FILE: target/i386/hvf-utils/x86_decode.c:718:
+ {0x3b, X86_DECODE_CMD_CMP, 0, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3522: FILE: target/i386/hvf-utils/x86_decode.c:719:
+ {0x3c, X86_DECODE_CMD_CMP, 1, false, decode_rax, decode_imm8, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3523: FILE: target/i386/hvf-utils/x86_decode.c:720:
+ {0x3d, X86_DECODE_CMD_CMP, 0, false, decode_rax, decode_imm, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: trailing whitespace
#3524: FILE: target/i386/hvf-utils/x86_decode.c:721:
+ $
ERROR: line over 90 characters
#3525: FILE: target/i386/hvf-utils/x86_decode.c:722:
+ {0x3f, X86_DECODE_CMD_AAS, 0, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: trailing whitespace
#3526: FILE: target/i386/hvf-utils/x86_decode.c:723:
+ $
ERROR: line over 90 characters
#3527: FILE: target/i386/hvf-utils/x86_decode.c:724:
+ {0x40, X86_DECODE_CMD_INC, 0, false, NULL, NULL, NULL, NULL, decode_incgroup, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3528: FILE: target/i386/hvf-utils/x86_decode.c:725:
+ {0x41, X86_DECODE_CMD_INC, 0, false, NULL, NULL, NULL, NULL, decode_incgroup, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3529: FILE: target/i386/hvf-utils/x86_decode.c:726:
+ {0x42, X86_DECODE_CMD_INC, 0, false, NULL, NULL, NULL, NULL, decode_incgroup, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3530: FILE: target/i386/hvf-utils/x86_decode.c:727:
+ {0x43, X86_DECODE_CMD_INC, 0, false, NULL, NULL, NULL, NULL, decode_incgroup, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3531: FILE: target/i386/hvf-utils/x86_decode.c:728:
+ {0x44, X86_DECODE_CMD_INC, 0, false, NULL, NULL, NULL, NULL, decode_incgroup, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3532: FILE: target/i386/hvf-utils/x86_decode.c:729:
+ {0x45, X86_DECODE_CMD_INC, 0, false, NULL, NULL, NULL, NULL, decode_incgroup, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3533: FILE: target/i386/hvf-utils/x86_decode.c:730:
+ {0x46, X86_DECODE_CMD_INC, 0, false, NULL, NULL, NULL, NULL, decode_incgroup, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3534: FILE: target/i386/hvf-utils/x86_decode.c:731:
+ {0x47, X86_DECODE_CMD_INC, 0, false, NULL, NULL, NULL, NULL, decode_incgroup, RFLAGS_MASK_OSZAPC},
ERROR: trailing whitespace
#3535: FILE: target/i386/hvf-utils/x86_decode.c:732:
+ $
ERROR: line over 90 characters
#3536: FILE: target/i386/hvf-utils/x86_decode.c:733:
+ {0x48, X86_DECODE_CMD_DEC, 0, false, NULL, NULL, NULL, NULL, decode_decgroup, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3537: FILE: target/i386/hvf-utils/x86_decode.c:734:
+ {0x49, X86_DECODE_CMD_DEC, 0, false, NULL, NULL, NULL, NULL, decode_decgroup, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3538: FILE: target/i386/hvf-utils/x86_decode.c:735:
+ {0x4a, X86_DECODE_CMD_DEC, 0, false, NULL, NULL, NULL, NULL, decode_decgroup, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3539: FILE: target/i386/hvf-utils/x86_decode.c:736:
+ {0x4b, X86_DECODE_CMD_DEC, 0, false, NULL, NULL, NULL, NULL, decode_decgroup, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3540: FILE: target/i386/hvf-utils/x86_decode.c:737:
+ {0x4c, X86_DECODE_CMD_DEC, 0, false, NULL, NULL, NULL, NULL, decode_decgroup, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3541: FILE: target/i386/hvf-utils/x86_decode.c:738:
+ {0x4d, X86_DECODE_CMD_DEC, 0, false, NULL, NULL, NULL, NULL, decode_decgroup, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3542: FILE: target/i386/hvf-utils/x86_decode.c:739:
+ {0x4e, X86_DECODE_CMD_DEC, 0, false, NULL, NULL, NULL, NULL, decode_decgroup, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3543: FILE: target/i386/hvf-utils/x86_decode.c:740:
+ {0x4f, X86_DECODE_CMD_DEC, 0, false, NULL, NULL, NULL, NULL, decode_decgroup, RFLAGS_MASK_OSZAPC},
ERROR: trailing whitespace
#3544: FILE: target/i386/hvf-utils/x86_decode.c:741:
+ $
ERROR: line over 90 characters
#3545: FILE: target/i386/hvf-utils/x86_decode.c:742:
+ {0x50, X86_DECODE_CMD_PUSH, 0, false, NULL, NULL, NULL, NULL, decode_pushgroup, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3546: FILE: target/i386/hvf-utils/x86_decode.c:743:
+ {0x51, X86_DECODE_CMD_PUSH, 0, false, NULL, NULL, NULL, NULL, decode_pushgroup, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3547: FILE: target/i386/hvf-utils/x86_decode.c:744:
+ {0x52, X86_DECODE_CMD_PUSH, 0, false, NULL, NULL, NULL, NULL, decode_pushgroup, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3548: FILE: target/i386/hvf-utils/x86_decode.c:745:
+ {0x53, X86_DECODE_CMD_PUSH, 0, false, NULL, NULL, NULL, NULL, decode_pushgroup, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3549: FILE: target/i386/hvf-utils/x86_decode.c:746:
+ {0x54, X86_DECODE_CMD_PUSH, 0, false, NULL, NULL, NULL, NULL, decode_pushgroup, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3550: FILE: target/i386/hvf-utils/x86_decode.c:747:
+ {0x55, X86_DECODE_CMD_PUSH, 0, false, NULL, NULL, NULL, NULL, decode_pushgroup, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3551: FILE: target/i386/hvf-utils/x86_decode.c:748:
+ {0x56, X86_DECODE_CMD_PUSH, 0, false, NULL, NULL, NULL, NULL, decode_pushgroup, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3552: FILE: target/i386/hvf-utils/x86_decode.c:749:
+ {0x57, X86_DECODE_CMD_PUSH, 0, false, NULL, NULL, NULL, NULL, decode_pushgroup, RFLAGS_MASK_NONE},
ERROR: trailing whitespace
#3553: FILE: target/i386/hvf-utils/x86_decode.c:750:
+ $
ERROR: line over 90 characters
#3554: FILE: target/i386/hvf-utils/x86_decode.c:751:
+ {0x58, X86_DECODE_CMD_POP, 0, false, NULL, NULL, NULL, NULL, decode_popgroup, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3555: FILE: target/i386/hvf-utils/x86_decode.c:752:
+ {0x59, X86_DECODE_CMD_POP, 0, false, NULL, NULL, NULL, NULL, decode_popgroup, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3556: FILE: target/i386/hvf-utils/x86_decode.c:753:
+ {0x5a, X86_DECODE_CMD_POP, 0, false, NULL, NULL, NULL, NULL, decode_popgroup, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3557: FILE: target/i386/hvf-utils/x86_decode.c:754:
+ {0x5b, X86_DECODE_CMD_POP, 0, false, NULL, NULL, NULL, NULL, decode_popgroup, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3558: FILE: target/i386/hvf-utils/x86_decode.c:755:
+ {0x5c, X86_DECODE_CMD_POP, 0, false, NULL, NULL, NULL, NULL, decode_popgroup, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3559: FILE: target/i386/hvf-utils/x86_decode.c:756:
+ {0x5d, X86_DECODE_CMD_POP, 0, false, NULL, NULL, NULL, NULL, decode_popgroup, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3560: FILE: target/i386/hvf-utils/x86_decode.c:757:
+ {0x5e, X86_DECODE_CMD_POP, 0, false, NULL, NULL, NULL, NULL, decode_popgroup, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3561: FILE: target/i386/hvf-utils/x86_decode.c:758:
+ {0x5f, X86_DECODE_CMD_POP, 0, false, NULL, NULL, NULL, NULL, decode_popgroup, RFLAGS_MASK_NONE},
ERROR: trailing whitespace
#3562: FILE: target/i386/hvf-utils/x86_decode.c:759:
+ $
ERROR: line over 90 characters
#3563: FILE: target/i386/hvf-utils/x86_decode.c:760:
+ {0x60, X86_DECODE_CMD_PUSHA, 0, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
WARNING: line over 80 characters
#3564: FILE: target/i386/hvf-utils/x86_decode.c:761:
+ {0x61, X86_DECODE_CMD_POPA, 0, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: trailing whitespace
#3565: FILE: target/i386/hvf-utils/x86_decode.c:762:
+ $
ERROR: line over 90 characters
#3566: FILE: target/i386/hvf-utils/x86_decode.c:763:
+ {0x68, X86_DECODE_CMD_PUSH, 0, false, decode_imm, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3567: FILE: target/i386/hvf-utils/x86_decode.c:764:
+ {0x6a, X86_DECODE_CMD_PUSH, 0, false, decode_imm8_signed, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3568: FILE: target/i386/hvf-utils/x86_decode.c:765:
+ {0x69, X86_DECODE_CMD_IMUL_3, 0, true, decode_modrm_reg, decode_modrm_rm, decode_imm, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3569: FILE: target/i386/hvf-utils/x86_decode.c:766:
+ {0x6b, X86_DECODE_CMD_IMUL_3, 0, true, decode_modrm_reg, decode_modrm_rm, decode_imm8_signed, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: trailing whitespace
#3570: FILE: target/i386/hvf-utils/x86_decode.c:767:
+ $
WARNING: line over 80 characters
#3571: FILE: target/i386/hvf-utils/x86_decode.c:768:
+ {0x6c, X86_DECODE_CMD_INS, 1, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
WARNING: line over 80 characters
#3572: FILE: target/i386/hvf-utils/x86_decode.c:769:
+ {0x6d, X86_DECODE_CMD_INS, 0, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
WARNING: line over 80 characters
#3573: FILE: target/i386/hvf-utils/x86_decode.c:770:
+ {0x6e, X86_DECODE_CMD_OUTS, 1, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
WARNING: line over 80 characters
#3574: FILE: target/i386/hvf-utils/x86_decode.c:771:
+ {0x6f, X86_DECODE_CMD_OUTS, 0, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: trailing whitespace
#3575: FILE: target/i386/hvf-utils/x86_decode.c:772:
+ $
ERROR: line over 90 characters
#3576: FILE: target/i386/hvf-utils/x86_decode.c:773:
+ {0x70, X86_DECODE_CMD_JXX, 1, false, NULL, NULL, NULL, NULL, decode_jxx, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3577: FILE: target/i386/hvf-utils/x86_decode.c:774:
+ {0x71, X86_DECODE_CMD_JXX, 1, false, NULL, NULL, NULL, NULL, decode_jxx, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3578: FILE: target/i386/hvf-utils/x86_decode.c:775:
+ {0x72, X86_DECODE_CMD_JXX, 1, false, NULL, NULL, NULL, NULL, decode_jxx, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3579: FILE: target/i386/hvf-utils/x86_decode.c:776:
+ {0x73, X86_DECODE_CMD_JXX, 1, false, NULL, NULL, NULL, NULL, decode_jxx, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3580: FILE: target/i386/hvf-utils/x86_decode.c:777:
+ {0x74, X86_DECODE_CMD_JXX, 1, false, NULL, NULL, NULL, NULL, decode_jxx, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3581: FILE: target/i386/hvf-utils/x86_decode.c:778:
+ {0x75, X86_DECODE_CMD_JXX, 1, false, NULL, NULL, NULL, NULL, decode_jxx, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3582: FILE: target/i386/hvf-utils/x86_decode.c:779:
+ {0x76, X86_DECODE_CMD_JXX, 1, false, NULL, NULL, NULL, NULL, decode_jxx, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3583: FILE: target/i386/hvf-utils/x86_decode.c:780:
+ {0x77, X86_DECODE_CMD_JXX, 1, false, NULL, NULL, NULL, NULL, decode_jxx, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3584: FILE: target/i386/hvf-utils/x86_decode.c:781:
+ {0x78, X86_DECODE_CMD_JXX, 1, false, NULL, NULL, NULL, NULL, decode_jxx, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3585: FILE: target/i386/hvf-utils/x86_decode.c:782:
+ {0x79, X86_DECODE_CMD_JXX, 1, false, NULL, NULL, NULL, NULL, decode_jxx, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3586: FILE: target/i386/hvf-utils/x86_decode.c:783:
+ {0x7a, X86_DECODE_CMD_JXX, 1, false, NULL, NULL, NULL, NULL, decode_jxx, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3587: FILE: target/i386/hvf-utils/x86_decode.c:784:
+ {0x7b, X86_DECODE_CMD_JXX, 1, false, NULL, NULL, NULL, NULL, decode_jxx, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3588: FILE: target/i386/hvf-utils/x86_decode.c:785:
+ {0x7c, X86_DECODE_CMD_JXX, 1, false, NULL, NULL, NULL, NULL, decode_jxx, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3589: FILE: target/i386/hvf-utils/x86_decode.c:786:
+ {0x7d, X86_DECODE_CMD_JXX, 1, false, NULL, NULL, NULL, NULL, decode_jxx, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3590: FILE: target/i386/hvf-utils/x86_decode.c:787:
+ {0x7e, X86_DECODE_CMD_JXX, 1, false, NULL, NULL, NULL, NULL, decode_jxx, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3591: FILE: target/i386/hvf-utils/x86_decode.c:788:
+ {0x7f, X86_DECODE_CMD_JXX, 1, false, NULL, NULL, NULL, NULL, decode_jxx, RFLAGS_MASK_NONE},
ERROR: trailing whitespace
#3592: FILE: target/i386/hvf-utils/x86_decode.c:789:
+ $
ERROR: line over 90 characters
#3593: FILE: target/i386/hvf-utils/x86_decode.c:790:
+ {0x80, X86_DECODE_CMD_INVL, 1, true, decode_modrm_rm, decode_imm8, NULL, NULL, decode_addgroup, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3594: FILE: target/i386/hvf-utils/x86_decode.c:791:
+ {0x81, X86_DECODE_CMD_INVL, 0, true, decode_modrm_rm, decode_imm, NULL, NULL, decode_addgroup, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3595: FILE: target/i386/hvf-utils/x86_decode.c:792:
+ {0x82, X86_DECODE_CMD_INVL, 1, true, decode_modrm_rm, decode_imm8, NULL, NULL, decode_addgroup, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3596: FILE: target/i386/hvf-utils/x86_decode.c:793:
+ {0x83, X86_DECODE_CMD_INVL, 0, true, decode_modrm_rm, decode_imm8_signed, NULL, NULL, decode_addgroup, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3597: FILE: target/i386/hvf-utils/x86_decode.c:794:
+ {0x84, X86_DECODE_CMD_TST, 1, true, decode_modrm_rm, decode_modrm_reg, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3598: FILE: target/i386/hvf-utils/x86_decode.c:795:
+ {0x85, X86_DECODE_CMD_TST, 0, true, decode_modrm_rm, decode_modrm_reg, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3599: FILE: target/i386/hvf-utils/x86_decode.c:796:
+ {0x86, X86_DECODE_CMD_XCHG, 1, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3600: FILE: target/i386/hvf-utils/x86_decode.c:797:
+ {0x87, X86_DECODE_CMD_XCHG, 0, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3601: FILE: target/i386/hvf-utils/x86_decode.c:798:
+ {0x88, X86_DECODE_CMD_MOV, 1, true, decode_modrm_rm, decode_modrm_reg, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3602: FILE: target/i386/hvf-utils/x86_decode.c:799:
+ {0x89, X86_DECODE_CMD_MOV, 0, true, decode_modrm_rm, decode_modrm_reg, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3603: FILE: target/i386/hvf-utils/x86_decode.c:800:
+ {0x8a, X86_DECODE_CMD_MOV, 1, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3604: FILE: target/i386/hvf-utils/x86_decode.c:801:
+ {0x8b, X86_DECODE_CMD_MOV, 0, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3605: FILE: target/i386/hvf-utils/x86_decode.c:802:
+ {0x8c, X86_DECODE_CMD_MOV_FROM_SEG, 0, true, decode_modrm_rm, decode_modrm_reg, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3606: FILE: target/i386/hvf-utils/x86_decode.c:803:
+ {0x8d, X86_DECODE_CMD_LEA, 0, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3607: FILE: target/i386/hvf-utils/x86_decode.c:804:
+ {0x8e, X86_DECODE_CMD_MOV_TO_SEG, 0, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3608: FILE: target/i386/hvf-utils/x86_decode.c:805:
+ {0x8f, X86_DECODE_CMD_POP, 0, true, decode_modrm_rm, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: trailing whitespace
#3609: FILE: target/i386/hvf-utils/x86_decode.c:806:
+ $
WARNING: line over 80 characters
#3610: FILE: target/i386/hvf-utils/x86_decode.c:807:
+ {0x90, X86_DECODE_CMD_NOP, 0, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3611: FILE: target/i386/hvf-utils/x86_decode.c:808:
+ {0x91, X86_DECODE_CMD_XCHG, 0, false, NULL, decode_rax, NULL, NULL, decode_xchgroup, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3612: FILE: target/i386/hvf-utils/x86_decode.c:809:
+ {0x92, X86_DECODE_CMD_XCHG, 0, false, NULL, decode_rax, NULL, NULL, decode_xchgroup, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3613: FILE: target/i386/hvf-utils/x86_decode.c:810:
+ {0x93, X86_DECODE_CMD_XCHG, 0, false, NULL, decode_rax, NULL, NULL, decode_xchgroup, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3614: FILE: target/i386/hvf-utils/x86_decode.c:811:
+ {0x94, X86_DECODE_CMD_XCHG, 0, false, NULL, decode_rax, NULL, NULL, decode_xchgroup, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3615: FILE: target/i386/hvf-utils/x86_decode.c:812:
+ {0x95, X86_DECODE_CMD_XCHG, 0, false, NULL, decode_rax, NULL, NULL, decode_xchgroup, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3616: FILE: target/i386/hvf-utils/x86_decode.c:813:
+ {0x96, X86_DECODE_CMD_XCHG, 0, false, NULL, decode_rax, NULL, NULL, decode_xchgroup, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3617: FILE: target/i386/hvf-utils/x86_decode.c:814:
+ {0x97, X86_DECODE_CMD_XCHG, 0, false, NULL, decode_rax, NULL, NULL, decode_xchgroup, RFLAGS_MASK_NONE},
ERROR: trailing whitespace
#3618: FILE: target/i386/hvf-utils/x86_decode.c:815:
+ $
WARNING: line over 80 characters
#3619: FILE: target/i386/hvf-utils/x86_decode.c:816:
+ {0x98, X86_DECODE_CMD_CBW, 0, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
WARNING: line over 80 characters
#3620: FILE: target/i386/hvf-utils/x86_decode.c:817:
+ {0x99, X86_DECODE_CMD_CWD, 0, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: trailing whitespace
#3621: FILE: target/i386/hvf-utils/x86_decode.c:818:
+ $
ERROR: line over 90 characters
#3622: FILE: target/i386/hvf-utils/x86_decode.c:819:
+ {0x9a, X86_DECODE_CMD_CALL_FAR, 0, false, NULL, NULL, NULL, NULL, decode_farjmp, RFLAGS_MASK_NONE},
ERROR: trailing whitespace
#3623: FILE: target/i386/hvf-utils/x86_decode.c:820:
+ $
ERROR: line over 90 characters
#3624: FILE: target/i386/hvf-utils/x86_decode.c:821:
+ {0x9c, X86_DECODE_CMD_PUSHF, 0, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3625: FILE: target/i386/hvf-utils/x86_decode.c:822:
+ //{0x9d, X86_DECODE_CMD_POPF, 0, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_POPF},
ERROR: do not use C99 // comments
#3625: FILE: target/i386/hvf-utils/x86_decode.c:822:
+ //{0x9d, X86_DECODE_CMD_POPF, 0, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_POPF},
WARNING: line over 80 characters
#3626: FILE: target/i386/hvf-utils/x86_decode.c:823:
+ {0x9e, X86_DECODE_CMD_SAHF, 0, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
WARNING: line over 80 characters
#3627: FILE: target/i386/hvf-utils/x86_decode.c:824:
+ {0x9f, X86_DECODE_CMD_LAHF, 0, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_LAHF},
ERROR: trailing whitespace
#3628: FILE: target/i386/hvf-utils/x86_decode.c:825:
+ $
ERROR: line over 90 characters
#3629: FILE: target/i386/hvf-utils/x86_decode.c:826:
+ {0xa0, X86_DECODE_CMD_MOV, 1, false, decode_rax, fetch_moffs, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3630: FILE: target/i386/hvf-utils/x86_decode.c:827:
+ {0xa1, X86_DECODE_CMD_MOV, 0, false, decode_rax, fetch_moffs, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3631: FILE: target/i386/hvf-utils/x86_decode.c:828:
+ {0xa2, X86_DECODE_CMD_MOV, 1, false, fetch_moffs, decode_rax, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3632: FILE: target/i386/hvf-utils/x86_decode.c:829:
+ {0xa3, X86_DECODE_CMD_MOV, 0, false, fetch_moffs, decode_rax, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: trailing whitespace
#3633: FILE: target/i386/hvf-utils/x86_decode.c:830:
+ $
WARNING: line over 80 characters
#3634: FILE: target/i386/hvf-utils/x86_decode.c:831:
+ {0xa4, X86_DECODE_CMD_MOVS, 1, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
WARNING: line over 80 characters
#3635: FILE: target/i386/hvf-utils/x86_decode.c:832:
+ {0xa5, X86_DECODE_CMD_MOVS, 0, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3636: FILE: target/i386/hvf-utils/x86_decode.c:833:
+ {0xa6, X86_DECODE_CMD_CMPS, 1, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3637: FILE: target/i386/hvf-utils/x86_decode.c:834:
+ {0xa7, X86_DECODE_CMD_CMPS, 0, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
WARNING: line over 80 characters
#3638: FILE: target/i386/hvf-utils/x86_decode.c:835:
+ {0xaa, X86_DECODE_CMD_STOS, 1, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
WARNING: line over 80 characters
#3639: FILE: target/i386/hvf-utils/x86_decode.c:836:
+ {0xab, X86_DECODE_CMD_STOS, 0, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
WARNING: line over 80 characters
#3640: FILE: target/i386/hvf-utils/x86_decode.c:837:
+ {0xac, X86_DECODE_CMD_LODS, 1, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
WARNING: line over 80 characters
#3641: FILE: target/i386/hvf-utils/x86_decode.c:838:
+ {0xad, X86_DECODE_CMD_LODS, 0, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3642: FILE: target/i386/hvf-utils/x86_decode.c:839:
+ {0xae, X86_DECODE_CMD_SCAS, 1, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3643: FILE: target/i386/hvf-utils/x86_decode.c:840:
+ {0xaf, X86_DECODE_CMD_SCAS, 0, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: trailing whitespace
#3644: FILE: target/i386/hvf-utils/x86_decode.c:841:
+ $
ERROR: line over 90 characters
#3645: FILE: target/i386/hvf-utils/x86_decode.c:842:
+ {0xa8, X86_DECODE_CMD_TST, 1, false, decode_rax, decode_imm, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3646: FILE: target/i386/hvf-utils/x86_decode.c:843:
+ {0xa9, X86_DECODE_CMD_TST, 0, false, decode_rax, decode_imm, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: trailing whitespace
#3647: FILE: target/i386/hvf-utils/x86_decode.c:844:
+ $
ERROR: line over 90 characters
#3648: FILE: target/i386/hvf-utils/x86_decode.c:845:
+ {0xb0, X86_DECODE_CMD_MOV, 1, false, NULL, NULL, NULL, NULL, decode_movgroup8, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3649: FILE: target/i386/hvf-utils/x86_decode.c:846:
+ {0xb1, X86_DECODE_CMD_MOV, 1, false, NULL, NULL, NULL, NULL, decode_movgroup8, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3650: FILE: target/i386/hvf-utils/x86_decode.c:847:
+ {0xb2, X86_DECODE_CMD_MOV, 1, false, NULL, NULL, NULL, NULL, decode_movgroup8, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3651: FILE: target/i386/hvf-utils/x86_decode.c:848:
+ {0xb3, X86_DECODE_CMD_MOV, 1, false, NULL, NULL, NULL, NULL, decode_movgroup8, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3652: FILE: target/i386/hvf-utils/x86_decode.c:849:
+ {0xb4, X86_DECODE_CMD_MOV, 1, false, NULL, NULL, NULL, NULL, decode_movgroup8, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3653: FILE: target/i386/hvf-utils/x86_decode.c:850:
+ {0xb5, X86_DECODE_CMD_MOV, 1, false, NULL, NULL, NULL, NULL, decode_movgroup8, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3654: FILE: target/i386/hvf-utils/x86_decode.c:851:
+ {0xb6, X86_DECODE_CMD_MOV, 1, false, NULL, NULL, NULL, NULL, decode_movgroup8, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3655: FILE: target/i386/hvf-utils/x86_decode.c:852:
+ {0xb7, X86_DECODE_CMD_MOV, 1, false, NULL, NULL, NULL, NULL, decode_movgroup8, RFLAGS_MASK_NONE},
ERROR: trailing whitespace
#3656: FILE: target/i386/hvf-utils/x86_decode.c:853:
+ $
ERROR: line over 90 characters
#3657: FILE: target/i386/hvf-utils/x86_decode.c:854:
+ {0xb8, X86_DECODE_CMD_MOV, 0, false, NULL, NULL, NULL, NULL, decode_movgroup, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3658: FILE: target/i386/hvf-utils/x86_decode.c:855:
+ {0xb9, X86_DECODE_CMD_MOV, 0, false, NULL, NULL, NULL, NULL, decode_movgroup, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3659: FILE: target/i386/hvf-utils/x86_decode.c:856:
+ {0xba, X86_DECODE_CMD_MOV, 0, false, NULL, NULL, NULL, NULL, decode_movgroup, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3660: FILE: target/i386/hvf-utils/x86_decode.c:857:
+ {0xbb, X86_DECODE_CMD_MOV, 0, false, NULL, NULL, NULL, NULL, decode_movgroup, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3661: FILE: target/i386/hvf-utils/x86_decode.c:858:
+ {0xbc, X86_DECODE_CMD_MOV, 0, false, NULL, NULL, NULL, NULL, decode_movgroup, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3662: FILE: target/i386/hvf-utils/x86_decode.c:859:
+ {0xbd, X86_DECODE_CMD_MOV, 0, false, NULL, NULL, NULL, NULL, decode_movgroup, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3663: FILE: target/i386/hvf-utils/x86_decode.c:860:
+ {0xbe, X86_DECODE_CMD_MOV, 0, false, NULL, NULL, NULL, NULL, decode_movgroup, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3664: FILE: target/i386/hvf-utils/x86_decode.c:861:
+ {0xbf, X86_DECODE_CMD_MOV, 0, false, NULL, NULL, NULL, NULL, decode_movgroup, RFLAGS_MASK_NONE},
ERROR: trailing whitespace
#3665: FILE: target/i386/hvf-utils/x86_decode.c:862:
+ $
ERROR: line over 90 characters
#3666: FILE: target/i386/hvf-utils/x86_decode.c:863:
+ {0xc0, X86_DECODE_CMD_INVL, 1, true, decode_modrm_rm, decode_imm8, NULL, NULL, decode_rotgroup, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3667: FILE: target/i386/hvf-utils/x86_decode.c:864:
+ {0xc1, X86_DECODE_CMD_INVL, 0, true, decode_modrm_rm, decode_imm8, NULL, NULL, decode_rotgroup, RFLAGS_MASK_OSZAPC},
ERROR: trailing whitespace
#3668: FILE: target/i386/hvf-utils/x86_decode.c:865:
+ $
ERROR: line over 90 characters
#3669: FILE: target/i386/hvf-utils/x86_decode.c:866:
+ {0xc2, X86_DECODE_RET_NEAR, 0, false, decode_imm16, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
WARNING: line over 80 characters
#3670: FILE: target/i386/hvf-utils/x86_decode.c:867:
+ {0xc3, X86_DECODE_RET_NEAR, 0, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: trailing whitespace
#3671: FILE: target/i386/hvf-utils/x86_decode.c:868:
+ $
ERROR: line over 90 characters
#3672: FILE: target/i386/hvf-utils/x86_decode.c:869:
+ {0xc4, X86_DECODE_CMD_LES, 0, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3673: FILE: target/i386/hvf-utils/x86_decode.c:870:
+ {0xc5, X86_DECODE_CMD_LDS, 0, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: trailing whitespace
#3674: FILE: target/i386/hvf-utils/x86_decode.c:871:
+ $
ERROR: line over 90 characters
#3675: FILE: target/i386/hvf-utils/x86_decode.c:872:
+ {0xc6, X86_DECODE_CMD_MOV, 1, true, decode_modrm_rm, decode_imm8, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3676: FILE: target/i386/hvf-utils/x86_decode.c:873:
+ {0xc7, X86_DECODE_CMD_MOV, 0, true, decode_modrm_rm, decode_imm, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: trailing whitespace
#3677: FILE: target/i386/hvf-utils/x86_decode.c:874:
+ $
ERROR: line over 90 characters
#3678: FILE: target/i386/hvf-utils/x86_decode.c:875:
+ {0xc8, X86_DECODE_CMD_ENTER, 0, false, decode_imm16, decode_imm8, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3679: FILE: target/i386/hvf-utils/x86_decode.c:876:
+ {0xc9, X86_DECODE_CMD_LEAVE, 0, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3680: FILE: target/i386/hvf-utils/x86_decode.c:877:
+ {0xca, X86_DECODE_RET_FAR, 0, false, decode_imm16, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3681: FILE: target/i386/hvf-utils/x86_decode.c:878:
+ {0xcb, X86_DECODE_RET_FAR, 0, false, decode_imm_0, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3682: FILE: target/i386/hvf-utils/x86_decode.c:879:
+ {0xcd, X86_DECODE_CMD_INT, 0, false, decode_imm8, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3683: FILE: target/i386/hvf-utils/x86_decode.c:880:
+ //{0xcf, X86_DECODE_CMD_IRET, 0, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_IRET},
ERROR: do not use C99 // comments
#3683: FILE: target/i386/hvf-utils/x86_decode.c:880:
+ //{0xcf, X86_DECODE_CMD_IRET, 0, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_IRET},
ERROR: trailing whitespace
#3684: FILE: target/i386/hvf-utils/x86_decode.c:881:
+ $
ERROR: line over 90 characters
#3685: FILE: target/i386/hvf-utils/x86_decode.c:882:
+ {0xd0, X86_DECODE_CMD_INVL, 1, true, decode_modrm_rm, decode_imm_1, NULL, NULL, decode_rotgroup, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3686: FILE: target/i386/hvf-utils/x86_decode.c:883:
+ {0xd1, X86_DECODE_CMD_INVL, 0, true, decode_modrm_rm, decode_imm_1, NULL, NULL, decode_rotgroup, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3687: FILE: target/i386/hvf-utils/x86_decode.c:884:
+ {0xd2, X86_DECODE_CMD_INVL, 1, true, decode_modrm_rm, decode_rcx, NULL, NULL, decode_rotgroup, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3688: FILE: target/i386/hvf-utils/x86_decode.c:885:
+ {0xd3, X86_DECODE_CMD_INVL, 0, true, decode_modrm_rm, decode_rcx, NULL, NULL, decode_rotgroup, RFLAGS_MASK_OSZAPC},
ERROR: trailing whitespace
#3689: FILE: target/i386/hvf-utils/x86_decode.c:886:
+ $
ERROR: line over 90 characters
#3690: FILE: target/i386/hvf-utils/x86_decode.c:887:
+ {0xd4, X86_DECODE_CMD_AAM, 0, false, decode_imm8, NULL, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3691: FILE: target/i386/hvf-utils/x86_decode.c:888:
+ {0xd5, X86_DECODE_CMD_AAD, 0, false, decode_imm8, NULL, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: trailing whitespace
#3692: FILE: target/i386/hvf-utils/x86_decode.c:889:
+ $
WARNING: line over 80 characters
#3693: FILE: target/i386/hvf-utils/x86_decode.c:890:
+ {0xd7, X86_DECODE_CMD_XLAT, 0, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: trailing whitespace
#3694: FILE: target/i386/hvf-utils/x86_decode.c:891:
+ $
ERROR: line over 90 characters
#3695: FILE: target/i386/hvf-utils/x86_decode.c:892:
+ {0xd8, X86_DECODE_CMD_INVL, 0, true, NULL, NULL, NULL, NULL, decode_x87_ins, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3696: FILE: target/i386/hvf-utils/x86_decode.c:893:
+ {0xd9, X86_DECODE_CMD_INVL, 0, true, NULL, NULL, NULL, NULL, decode_x87_ins, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3697: FILE: target/i386/hvf-utils/x86_decode.c:894:
+ {0xda, X86_DECODE_CMD_INVL, 0, true, NULL, NULL, NULL, NULL, decode_x87_ins, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3698: FILE: target/i386/hvf-utils/x86_decode.c:895:
+ {0xdb, X86_DECODE_CMD_INVL, 0, true, NULL, NULL, NULL, NULL, decode_x87_ins, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3699: FILE: target/i386/hvf-utils/x86_decode.c:896:
+ {0xdc, X86_DECODE_CMD_INVL, 0, true, NULL, NULL, NULL, NULL, decode_x87_ins, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3700: FILE: target/i386/hvf-utils/x86_decode.c:897:
+ {0xdd, X86_DECODE_CMD_INVL, 0, true, NULL, NULL, NULL, NULL, decode_x87_ins, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3701: FILE: target/i386/hvf-utils/x86_decode.c:898:
+ {0xde, X86_DECODE_CMD_INVL, 0, true, NULL, NULL, NULL, NULL, decode_x87_ins, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3702: FILE: target/i386/hvf-utils/x86_decode.c:899:
+ {0xdf, X86_DECODE_CMD_INVL, 0, true, NULL, NULL, NULL, NULL, decode_x87_ins, RFLAGS_MASK_NONE},
ERROR: trailing whitespace
#3703: FILE: target/i386/hvf-utils/x86_decode.c:900:
+ $
ERROR: line over 90 characters
#3704: FILE: target/i386/hvf-utils/x86_decode.c:901:
+ {0xe0, X86_DECODE_CMD_LOOP, 0, false, decode_imm8_signed, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3705: FILE: target/i386/hvf-utils/x86_decode.c:902:
+ {0xe1, X86_DECODE_CMD_LOOP, 0, false, decode_imm8_signed, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3706: FILE: target/i386/hvf-utils/x86_decode.c:903:
+ {0xe2, X86_DECODE_CMD_LOOP, 0, false, decode_imm8_signed, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: trailing whitespace
#3707: FILE: target/i386/hvf-utils/x86_decode.c:904:
+ $
ERROR: line over 90 characters
#3708: FILE: target/i386/hvf-utils/x86_decode.c:905:
+ {0xe3, X86_DECODE_CMD_JCXZ, 1, false, NULL, NULL, NULL, NULL, decode_jxx, RFLAGS_MASK_NONE},
ERROR: trailing whitespace
#3709: FILE: target/i386/hvf-utils/x86_decode.c:906:
+ $
ERROR: line over 90 characters
#3710: FILE: target/i386/hvf-utils/x86_decode.c:907:
+ {0xe4, X86_DECODE_CMD_IN, 1, false, decode_imm8, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3711: FILE: target/i386/hvf-utils/x86_decode.c:908:
+ {0xe5, X86_DECODE_CMD_IN, 0, false, decode_imm8, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3712: FILE: target/i386/hvf-utils/x86_decode.c:909:
+ {0xe6, X86_DECODE_CMD_OUT, 1, false, decode_imm8, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3713: FILE: target/i386/hvf-utils/x86_decode.c:910:
+ {0xe7, X86_DECODE_CMD_OUT, 0, false, decode_imm8, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3714: FILE: target/i386/hvf-utils/x86_decode.c:911:
+ {0xe8, X86_DECODE_CMD_CALL_NEAR, 0, false, decode_imm_signed, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3715: FILE: target/i386/hvf-utils/x86_decode.c:912:
+ {0xe9, X86_DECODE_CMD_JMP_NEAR, 0, false, decode_imm_signed, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3716: FILE: target/i386/hvf-utils/x86_decode.c:913:
+ {0xea, X86_DECODE_CMD_JMP_FAR, 0, false, NULL, NULL, NULL, NULL, decode_farjmp, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3717: FILE: target/i386/hvf-utils/x86_decode.c:914:
+ {0xeb, X86_DECODE_CMD_JMP_NEAR, 1, false, decode_imm8_signed, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
WARNING: line over 80 characters
#3718: FILE: target/i386/hvf-utils/x86_decode.c:915:
+ {0xec, X86_DECODE_CMD_IN, 1, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
WARNING: line over 80 characters
#3719: FILE: target/i386/hvf-utils/x86_decode.c:916:
+ {0xed, X86_DECODE_CMD_IN, 0, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
WARNING: line over 80 characters
#3720: FILE: target/i386/hvf-utils/x86_decode.c:917:
+ {0xee, X86_DECODE_CMD_OUT, 1, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
WARNING: line over 80 characters
#3721: FILE: target/i386/hvf-utils/x86_decode.c:918:
+ {0xef, X86_DECODE_CMD_OUT, 0, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: trailing whitespace
#3722: FILE: target/i386/hvf-utils/x86_decode.c:919:
+ $
WARNING: line over 80 characters
#3723: FILE: target/i386/hvf-utils/x86_decode.c:920:
+ {0xf4, X86_DECODE_CMD_HLT, 0, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: trailing whitespace
#3724: FILE: target/i386/hvf-utils/x86_decode.c:921:
+ $
WARNING: line over 80 characters
#3725: FILE: target/i386/hvf-utils/x86_decode.c:922:
+ {0xf5, X86_DECODE_CMD_CMC, 0, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_CF},
ERROR: trailing whitespace
#3726: FILE: target/i386/hvf-utils/x86_decode.c:923:
+ $
ERROR: line over 90 characters
#3727: FILE: target/i386/hvf-utils/x86_decode.c:924:
+ {0xf6, X86_DECODE_CMD_INVL, 1, true, NULL, NULL, NULL, NULL, decode_f7group, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3728: FILE: target/i386/hvf-utils/x86_decode.c:925:
+ {0xf7, X86_DECODE_CMD_INVL, 0, true, NULL, NULL, NULL, NULL, decode_f7group, RFLAGS_MASK_OSZAPC},
ERROR: trailing whitespace
#3729: FILE: target/i386/hvf-utils/x86_decode.c:926:
+ $
WARNING: line over 80 characters
#3730: FILE: target/i386/hvf-utils/x86_decode.c:927:
+ {0xf8, X86_DECODE_CMD_CLC, 0, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_CF},
WARNING: line over 80 characters
#3731: FILE: target/i386/hvf-utils/x86_decode.c:928:
+ {0xf9, X86_DECODE_CMD_STC, 0, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_CF},
ERROR: trailing whitespace
#3732: FILE: target/i386/hvf-utils/x86_decode.c:929:
+ $
WARNING: line over 80 characters
#3733: FILE: target/i386/hvf-utils/x86_decode.c:930:
+ {0xfa, X86_DECODE_CMD_CLI, 0, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_IF},
WARNING: line over 80 characters
#3734: FILE: target/i386/hvf-utils/x86_decode.c:931:
+ {0xfb, X86_DECODE_CMD_STI, 0, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_IF},
WARNING: line over 80 characters
#3735: FILE: target/i386/hvf-utils/x86_decode.c:932:
+ {0xfc, X86_DECODE_CMD_CLD, 0, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_DF},
WARNING: line over 80 characters
#3736: FILE: target/i386/hvf-utils/x86_decode.c:933:
+ {0xfd, X86_DECODE_CMD_STD, 0, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_DF},
ERROR: line over 90 characters
#3737: FILE: target/i386/hvf-utils/x86_decode.c:934:
+ {0xfe, X86_DECODE_CMD_INVL, 1, true, decode_modrm_rm, NULL, NULL, NULL, decode_incgroup2, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3738: FILE: target/i386/hvf-utils/x86_decode.c:935:
+ {0xff, X86_DECODE_CMD_INVL, 0, true, decode_modrm_rm, NULL, NULL, NULL, decode_ffgroup, RFLAGS_MASK_OSZAPC},
ERROR: that open brace { should be on the previous line
#3742: FILE: target/i386/hvf-utils/x86_decode.c:939:
+struct decode_tbl _2op_inst[] =
+{
ERROR: line over 90 characters
#3743: FILE: target/i386/hvf-utils/x86_decode.c:940:
+ {0x0, X86_DECODE_CMD_INVL, 0, true, decode_modrm_rm, NULL, NULL, NULL, decode_sldtgroup, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3744: FILE: target/i386/hvf-utils/x86_decode.c:941:
+ {0x1, X86_DECODE_CMD_INVL, 0, true, decode_modrm_rm, NULL, NULL, NULL, decode_lidtgroup, RFLAGS_MASK_NONE},
WARNING: line over 80 characters
#3745: FILE: target/i386/hvf-utils/x86_decode.c:942:
+ {0x6, X86_DECODE_CMD_CLTS, 0, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_TF},
ERROR: line over 90 characters
#3746: FILE: target/i386/hvf-utils/x86_decode.c:943:
+ {0x9, X86_DECODE_CMD_WBINVD, 0, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3747: FILE: target/i386/hvf-utils/x86_decode.c:944:
+ {0x18, X86_DECODE_CMD_PREFETCH, 0, true, NULL, NULL, NULL, NULL, decode_x87_general, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3748: FILE: target/i386/hvf-utils/x86_decode.c:945:
+ {0x1f, X86_DECODE_CMD_NOP, 0, true, decode_modrm_rm, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3749: FILE: target/i386/hvf-utils/x86_decode.c:946:
+ {0x20, X86_DECODE_CMD_MOV_FROM_CR, 0, true, decode_modrm_rm, decode_modrm_reg, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3750: FILE: target/i386/hvf-utils/x86_decode.c:947:
+ {0x21, X86_DECODE_CMD_MOV_FROM_DR, 0, true, decode_modrm_rm, decode_modrm_reg, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3751: FILE: target/i386/hvf-utils/x86_decode.c:948:
+ {0x22, X86_DECODE_CMD_MOV_TO_CR, 0, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3752: FILE: target/i386/hvf-utils/x86_decode.c:949:
+ {0x23, X86_DECODE_CMD_MOV_TO_DR, 0, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3753: FILE: target/i386/hvf-utils/x86_decode.c:950:
+ {0x30, X86_DECODE_CMD_WRMSR, 0, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3754: FILE: target/i386/hvf-utils/x86_decode.c:951:
+ {0x31, X86_DECODE_CMD_RDTSC, 0, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3755: FILE: target/i386/hvf-utils/x86_decode.c:952:
+ {0x32, X86_DECODE_CMD_RDMSR, 0, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3756: FILE: target/i386/hvf-utils/x86_decode.c:953:
+ {0x40, X86_DECODE_CMD_CMOV, 0, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3757: FILE: target/i386/hvf-utils/x86_decode.c:954:
+ {0x41, X86_DECODE_CMD_CMOV, 0, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3758: FILE: target/i386/hvf-utils/x86_decode.c:955:
+ {0x42, X86_DECODE_CMD_CMOV, 0, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3759: FILE: target/i386/hvf-utils/x86_decode.c:956:
+ {0x43, X86_DECODE_CMD_CMOV, 0, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3760: FILE: target/i386/hvf-utils/x86_decode.c:957:
+ {0x44, X86_DECODE_CMD_CMOV, 0, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3761: FILE: target/i386/hvf-utils/x86_decode.c:958:
+ {0x45, X86_DECODE_CMD_CMOV, 0, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3762: FILE: target/i386/hvf-utils/x86_decode.c:959:
+ {0x46, X86_DECODE_CMD_CMOV, 0, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3763: FILE: target/i386/hvf-utils/x86_decode.c:960:
+ {0x47, X86_DECODE_CMD_CMOV, 0, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3764: FILE: target/i386/hvf-utils/x86_decode.c:961:
+ {0x48, X86_DECODE_CMD_CMOV, 0, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3765: FILE: target/i386/hvf-utils/x86_decode.c:962:
+ {0x49, X86_DECODE_CMD_CMOV, 0, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3766: FILE: target/i386/hvf-utils/x86_decode.c:963:
+ {0x4a, X86_DECODE_CMD_CMOV, 0, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3767: FILE: target/i386/hvf-utils/x86_decode.c:964:
+ {0x4b, X86_DECODE_CMD_CMOV, 0, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3768: FILE: target/i386/hvf-utils/x86_decode.c:965:
+ {0x4c, X86_DECODE_CMD_CMOV, 0, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3769: FILE: target/i386/hvf-utils/x86_decode.c:966:
+ {0x4d, X86_DECODE_CMD_CMOV, 0, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3770: FILE: target/i386/hvf-utils/x86_decode.c:967:
+ {0x4e, X86_DECODE_CMD_CMOV, 0, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3771: FILE: target/i386/hvf-utils/x86_decode.c:968:
+ {0x4f, X86_DECODE_CMD_CMOV, 0, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3772: FILE: target/i386/hvf-utils/x86_decode.c:969:
+ {0x77, X86_DECODE_CMD_EMMS, 0, false, NULL, NULL, NULL, NULL, decode_x87_general, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3773: FILE: target/i386/hvf-utils/x86_decode.c:970:
+ {0x82, X86_DECODE_CMD_JXX, 0, false, NULL, NULL, NULL, NULL, decode_jxx, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3774: FILE: target/i386/hvf-utils/x86_decode.c:971:
+ {0x83, X86_DECODE_CMD_JXX, 0, false, NULL, NULL, NULL, NULL, decode_jxx, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3775: FILE: target/i386/hvf-utils/x86_decode.c:972:
+ {0x84, X86_DECODE_CMD_JXX, 0, false, NULL, NULL, NULL, NULL, decode_jxx, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3776: FILE: target/i386/hvf-utils/x86_decode.c:973:
+ {0x85, X86_DECODE_CMD_JXX, 0, false, NULL, NULL, NULL, NULL, decode_jxx, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3777: FILE: target/i386/hvf-utils/x86_decode.c:974:
+ {0x86, X86_DECODE_CMD_JXX, 0, false, NULL, NULL, NULL, NULL, decode_jxx, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3778: FILE: target/i386/hvf-utils/x86_decode.c:975:
+ {0x87, X86_DECODE_CMD_JXX, 0, false, NULL, NULL, NULL, NULL, decode_jxx, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3779: FILE: target/i386/hvf-utils/x86_decode.c:976:
+ {0x88, X86_DECODE_CMD_JXX, 0, false, NULL, NULL, NULL, NULL, decode_jxx, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3780: FILE: target/i386/hvf-utils/x86_decode.c:977:
+ {0x89, X86_DECODE_CMD_JXX, 0, false, NULL, NULL, NULL, NULL, decode_jxx, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3781: FILE: target/i386/hvf-utils/x86_decode.c:978:
+ {0x8a, X86_DECODE_CMD_JXX, 0, false, NULL, NULL, NULL, NULL, decode_jxx, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3782: FILE: target/i386/hvf-utils/x86_decode.c:979:
+ {0x8b, X86_DECODE_CMD_JXX, 0, false, NULL, NULL, NULL, NULL, decode_jxx, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3783: FILE: target/i386/hvf-utils/x86_decode.c:980:
+ {0x8c, X86_DECODE_CMD_JXX, 0, false, NULL, NULL, NULL, NULL, decode_jxx, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3784: FILE: target/i386/hvf-utils/x86_decode.c:981:
+ {0x8d, X86_DECODE_CMD_JXX, 0, false, NULL, NULL, NULL, NULL, decode_jxx, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3785: FILE: target/i386/hvf-utils/x86_decode.c:982:
+ {0x8e, X86_DECODE_CMD_JXX, 0, false, NULL, NULL, NULL, NULL, decode_jxx, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3786: FILE: target/i386/hvf-utils/x86_decode.c:983:
+ {0x8f, X86_DECODE_CMD_JXX, 0, false, NULL, NULL, NULL, NULL, decode_jxx, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3787: FILE: target/i386/hvf-utils/x86_decode.c:984:
+ {0x90, X86_DECODE_CMD_SETXX, 1, true, decode_modrm_rm, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3788: FILE: target/i386/hvf-utils/x86_decode.c:985:
+ {0x91, X86_DECODE_CMD_SETXX, 1, true, decode_modrm_rm, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3789: FILE: target/i386/hvf-utils/x86_decode.c:986:
+ {0x92, X86_DECODE_CMD_SETXX, 1, true, decode_modrm_rm, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3790: FILE: target/i386/hvf-utils/x86_decode.c:987:
+ {0x93, X86_DECODE_CMD_SETXX, 1, true, decode_modrm_rm, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3791: FILE: target/i386/hvf-utils/x86_decode.c:988:
+ {0x94, X86_DECODE_CMD_SETXX, 1, true, decode_modrm_rm, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3792: FILE: target/i386/hvf-utils/x86_decode.c:989:
+ {0x95, X86_DECODE_CMD_SETXX, 1, true, decode_modrm_rm, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3793: FILE: target/i386/hvf-utils/x86_decode.c:990:
+ {0x96, X86_DECODE_CMD_SETXX, 1, true, decode_modrm_rm, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3794: FILE: target/i386/hvf-utils/x86_decode.c:991:
+ {0x97, X86_DECODE_CMD_SETXX, 1, true, decode_modrm_rm, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3795: FILE: target/i386/hvf-utils/x86_decode.c:992:
+ {0x98, X86_DECODE_CMD_SETXX, 1, true, decode_modrm_rm, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3796: FILE: target/i386/hvf-utils/x86_decode.c:993:
+ {0x99, X86_DECODE_CMD_SETXX, 1, true, decode_modrm_rm, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3797: FILE: target/i386/hvf-utils/x86_decode.c:994:
+ {0x9a, X86_DECODE_CMD_SETXX, 1, true, decode_modrm_rm, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3798: FILE: target/i386/hvf-utils/x86_decode.c:995:
+ {0x9b, X86_DECODE_CMD_SETXX, 1, true, decode_modrm_rm, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3799: FILE: target/i386/hvf-utils/x86_decode.c:996:
+ {0x9c, X86_DECODE_CMD_SETXX, 1, true, decode_modrm_rm, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3800: FILE: target/i386/hvf-utils/x86_decode.c:997:
+ {0x9d, X86_DECODE_CMD_SETXX, 1, true, decode_modrm_rm, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3801: FILE: target/i386/hvf-utils/x86_decode.c:998:
+ {0x9e, X86_DECODE_CMD_SETXX, 1, true, decode_modrm_rm, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3802: FILE: target/i386/hvf-utils/x86_decode.c:999:
+ {0x9f, X86_DECODE_CMD_SETXX, 1, true, decode_modrm_rm, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: trailing whitespace
#3803: FILE: target/i386/hvf-utils/x86_decode.c:1000:
+ $
ERROR: line over 90 characters
#3804: FILE: target/i386/hvf-utils/x86_decode.c:1001:
+ {0xb0, X86_DECODE_CMD_CMPXCHG, 1, true, decode_modrm_rm, decode_modrm_reg, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3805: FILE: target/i386/hvf-utils/x86_decode.c:1002:
+ {0xb1, X86_DECODE_CMD_CMPXCHG, 0, true, decode_modrm_rm, decode_modrm_reg, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: trailing whitespace
#3806: FILE: target/i386/hvf-utils/x86_decode.c:1003:
+ $
ERROR: line over 90 characters
#3807: FILE: target/i386/hvf-utils/x86_decode.c:1004:
+ {0xb6, X86_DECODE_CMD_MOVZX, 0, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3808: FILE: target/i386/hvf-utils/x86_decode.c:1005:
+ {0xb7, X86_DECODE_CMD_MOVZX, 0, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3809: FILE: target/i386/hvf-utils/x86_decode.c:1006:
+ {0xb8, X86_DECODE_CMD_POPCNT, 0, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3810: FILE: target/i386/hvf-utils/x86_decode.c:1007:
+ {0xbe, X86_DECODE_CMD_MOVSX, 0, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3811: FILE: target/i386/hvf-utils/x86_decode.c:1008:
+ {0xbf, X86_DECODE_CMD_MOVSX, 0, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3812: FILE: target/i386/hvf-utils/x86_decode.c:1009:
+ {0xa0, X86_DECODE_CMD_PUSH_SEG, 0, false, false, NULL, NULL, NULL, decode_pushseg, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3813: FILE: target/i386/hvf-utils/x86_decode.c:1010:
+ {0xa1, X86_DECODE_CMD_POP_SEG, 0, false, false, NULL, NULL, NULL, decode_popseg, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3814: FILE: target/i386/hvf-utils/x86_decode.c:1011:
+ {0xa2, X86_DECODE_CMD_CPUID, 0, false, NULL, NULL, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3815: FILE: target/i386/hvf-utils/x86_decode.c:1012:
+ {0xa3, X86_DECODE_CMD_BT, 0, true, decode_modrm_rm, decode_modrm_reg, NULL, NULL, NULL, RFLAGS_MASK_CF},
ERROR: line over 90 characters
#3816: FILE: target/i386/hvf-utils/x86_decode.c:1013:
+ {0xa4, X86_DECODE_CMD_SHLD, 0, true, decode_modrm_rm, decode_modrm_reg, decode_imm8, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3817: FILE: target/i386/hvf-utils/x86_decode.c:1014:
+ {0xa5, X86_DECODE_CMD_SHLD, 0, true, decode_modrm_rm, decode_modrm_reg, decode_rcx, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3818: FILE: target/i386/hvf-utils/x86_decode.c:1015:
+ {0xa8, X86_DECODE_CMD_PUSH_SEG, 0, false, false, NULL, NULL, NULL, decode_pushseg, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3819: FILE: target/i386/hvf-utils/x86_decode.c:1016:
+ {0xa9, X86_DECODE_CMD_POP_SEG, 0, false, false, NULL, NULL, NULL, decode_popseg, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3820: FILE: target/i386/hvf-utils/x86_decode.c:1017:
+ {0xab, X86_DECODE_CMD_BTS, 0, true, decode_modrm_rm, decode_modrm_reg, NULL, NULL, NULL, RFLAGS_MASK_CF},
ERROR: line over 90 characters
#3821: FILE: target/i386/hvf-utils/x86_decode.c:1018:
+ {0xac, X86_DECODE_CMD_SHRD, 0, true, decode_modrm_rm, decode_modrm_reg, decode_imm8, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3822: FILE: target/i386/hvf-utils/x86_decode.c:1019:
+ {0xad, X86_DECODE_CMD_SHRD, 0, true, decode_modrm_rm, decode_modrm_reg, decode_rcx, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: trailing whitespace
#3823: FILE: target/i386/hvf-utils/x86_decode.c:1020:
+ $
ERROR: line over 90 characters
#3824: FILE: target/i386/hvf-utils/x86_decode.c:1021:
+ {0xae, X86_DECODE_CMD_INVL, 0, true, decode_modrm_rm, NULL, NULL, NULL, decode_aegroup, RFLAGS_MASK_NONE},
ERROR: trailing whitespace
#3825: FILE: target/i386/hvf-utils/x86_decode.c:1022:
+ $
ERROR: line over 90 characters
#3826: FILE: target/i386/hvf-utils/x86_decode.c:1023:
+ {0xaf, X86_DECODE_CMD_IMUL_2, 0, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3827: FILE: target/i386/hvf-utils/x86_decode.c:1024:
+ {0xb2, X86_DECODE_CMD_LSS, 0, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3828: FILE: target/i386/hvf-utils/x86_decode.c:1025:
+ {0xb3, X86_DECODE_CMD_BTR, 0, true, decode_modrm_rm, decode_modrm_reg, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3829: FILE: target/i386/hvf-utils/x86_decode.c:1026:
+ {0xba, X86_DECODE_CMD_INVL, 0, true, decode_modrm_rm, decode_imm8, NULL, NULL, decode_btgroup, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3830: FILE: target/i386/hvf-utils/x86_decode.c:1027:
+ {0xbb, X86_DECODE_CMD_BTC, 0, true, decode_modrm_rm, decode_modrm_reg, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3831: FILE: target/i386/hvf-utils/x86_decode.c:1028:
+ {0xbc, X86_DECODE_CMD_BSF, 0, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: line over 90 characters
#3832: FILE: target/i386/hvf-utils/x86_decode.c:1029:
+ {0xbd, X86_DECODE_CMD_BSR, 0, true, decode_modrm_reg, decode_modrm_rm, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: trailing whitespace
#3833: FILE: target/i386/hvf-utils/x86_decode.c:1030:
+ $
ERROR: line over 90 characters
#3834: FILE: target/i386/hvf-utils/x86_decode.c:1031:
+ {0xc1, X86_DECODE_CMD_XADD, 0, true, decode_modrm_rm, decode_modrm_reg, NULL, NULL, NULL, RFLAGS_MASK_OSZAPC},
ERROR: trailing whitespace
#3835: FILE: target/i386/hvf-utils/x86_decode.c:1032:
+ $
ERROR: line over 90 characters
#3836: FILE: target/i386/hvf-utils/x86_decode.c:1033:
+ {0xc7, X86_DECODE_CMD_CMPXCHG8B, 0, true, decode_modrm_rm, NULL, NULL, NULL, NULL, RFLAGS_MASK_ZF},
ERROR: trailing whitespace
#3837: FILE: target/i386/hvf-utils/x86_decode.c:1034:
+ $
ERROR: line over 90 characters
#3838: FILE: target/i386/hvf-utils/x86_decode.c:1035:
+ {0xc8, X86_DECODE_CMD_BSWAP, 0, false, NULL, NULL, NULL, NULL, decode_bswap, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3839: FILE: target/i386/hvf-utils/x86_decode.c:1036:
+ {0xc9, X86_DECODE_CMD_BSWAP, 0, false, NULL, NULL, NULL, NULL, decode_bswap, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3840: FILE: target/i386/hvf-utils/x86_decode.c:1037:
+ {0xca, X86_DECODE_CMD_BSWAP, 0, false, NULL, NULL, NULL, NULL, decode_bswap, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3841: FILE: target/i386/hvf-utils/x86_decode.c:1038:
+ {0xcb, X86_DECODE_CMD_BSWAP, 0, false, NULL, NULL, NULL, NULL, decode_bswap, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3842: FILE: target/i386/hvf-utils/x86_decode.c:1039:
+ {0xcc, X86_DECODE_CMD_BSWAP, 0, false, NULL, NULL, NULL, NULL, decode_bswap, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3843: FILE: target/i386/hvf-utils/x86_decode.c:1040:
+ {0xcd, X86_DECODE_CMD_BSWAP, 0, false, NULL, NULL, NULL, NULL, decode_bswap, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3844: FILE: target/i386/hvf-utils/x86_decode.c:1041:
+ {0xce, X86_DECODE_CMD_BSWAP, 0, false, NULL, NULL, NULL, NULL, decode_bswap, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3845: FILE: target/i386/hvf-utils/x86_decode.c:1042:
+ {0xcf, X86_DECODE_CMD_BSWAP, 0, false, NULL, NULL, NULL, NULL, decode_bswap, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3848: FILE: target/i386/hvf-utils/x86_decode.c:1045:
+struct decode_x87_tbl invl_inst_x87 = {0x0, 0, 0, 0, 0, false, false, NULL, NULL, decode_invalid, 0};
ERROR: that open brace { should be on the previous line
#3851: FILE: target/i386/hvf-utils/x86_decode.c:1048:
+struct decode_x87_tbl _x87_inst[] =
+{
ERROR: line over 90 characters
#3852: FILE: target/i386/hvf-utils/x86_decode.c:1049:
+ {0xd8, 0, 3, X86_DECODE_CMD_FADD, 10, false, false, decode_x87_modrm_st0, decode_decode_x87_modrm_st0, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3853: FILE: target/i386/hvf-utils/x86_decode.c:1050:
+ {0xd8, 0, 0, X86_DECODE_CMD_FADD, 4, false, false, decode_x87_modrm_st0, decode_x87_modrm_floatp, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3854: FILE: target/i386/hvf-utils/x86_decode.c:1051:
+ {0xd8, 1, 3, X86_DECODE_CMD_FMUL, 10, false, false, decode_x87_modrm_st0, decode_decode_x87_modrm_st0, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3855: FILE: target/i386/hvf-utils/x86_decode.c:1052:
+ {0xd8, 1, 0, X86_DECODE_CMD_FMUL, 4, false, false, decode_x87_modrm_st0, decode_x87_modrm_floatp, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3856: FILE: target/i386/hvf-utils/x86_decode.c:1053:
+ {0xd8, 4, 3, X86_DECODE_CMD_FSUB, 10, false, false, decode_x87_modrm_st0, decode_x87_modrm_st0, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3857: FILE: target/i386/hvf-utils/x86_decode.c:1054:
+ {0xd8, 4, 0, X86_DECODE_CMD_FSUB, 4, false, false, decode_x87_modrm_st0, decode_x87_modrm_floatp, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3858: FILE: target/i386/hvf-utils/x86_decode.c:1055:
+ {0xd8, 5, 3, X86_DECODE_CMD_FSUB, 10, true, false, decode_x87_modrm_st0, decode_x87_modrm_st0, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3859: FILE: target/i386/hvf-utils/x86_decode.c:1056:
+ {0xd8, 5, 0, X86_DECODE_CMD_FSUB, 4, true, false, decode_x87_modrm_st0, decode_x87_modrm_floatp, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3860: FILE: target/i386/hvf-utils/x86_decode.c:1057:
+ {0xd8, 6, 3, X86_DECODE_CMD_FDIV, 10, false, false, decode_x87_modrm_st0,decode_x87_modrm_st0, NULL, RFLAGS_MASK_NONE},
ERROR: space required after that ',' (ctx:VxV)
#3860: FILE: target/i386/hvf-utils/x86_decode.c:1057:
+ {0xd8, 6, 3, X86_DECODE_CMD_FDIV, 10, false, false, decode_x87_modrm_st0,decode_x87_modrm_st0, NULL, RFLAGS_MASK_NONE},
^
ERROR: line over 90 characters
#3861: FILE: target/i386/hvf-utils/x86_decode.c:1058:
+ {0xd8, 6, 0, X86_DECODE_CMD_FDIV, 4, false, false, decode_x87_modrm_st0, decode_x87_modrm_floatp, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3862: FILE: target/i386/hvf-utils/x86_decode.c:1059:
+ {0xd8, 7, 3, X86_DECODE_CMD_FDIV, 10, true, false, decode_x87_modrm_st0, decode_x87_modrm_st0, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3863: FILE: target/i386/hvf-utils/x86_decode.c:1060:
+ {0xd8, 7, 0, X86_DECODE_CMD_FDIV, 4, true, false, decode_x87_modrm_st0, decode_x87_modrm_floatp, NULL, RFLAGS_MASK_NONE},
ERROR: trailing whitespace
#3864: FILE: target/i386/hvf-utils/x86_decode.c:1061:
+ $
ERROR: line over 90 characters
#3865: FILE: target/i386/hvf-utils/x86_decode.c:1062:
+ {0xd9, 0, 3, X86_DECODE_CMD_FLD, 10, false, false, decode_x87_modrm_st0, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3866: FILE: target/i386/hvf-utils/x86_decode.c:1063:
+ {0xd9, 0, 0, X86_DECODE_CMD_FLD, 4, false, false, decode_x87_modrm_floatp, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3867: FILE: target/i386/hvf-utils/x86_decode.c:1064:
+ {0xd9, 1, 3, X86_DECODE_CMD_FXCH, 10, false, false, decode_x87_modrm_st0, decode_x87_modrm_st0, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3868: FILE: target/i386/hvf-utils/x86_decode.c:1065:
+ {0xd9, 1, 0, X86_DECODE_CMD_INVL, 10, false, false, decode_x87_modrm_st0, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3869: FILE: target/i386/hvf-utils/x86_decode.c:1066:
+ {0xd9, 2, 3, X86_DECODE_CMD_INVL, 10, false, false, decode_x87_modrm_st0, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3870: FILE: target/i386/hvf-utils/x86_decode.c:1067:
+ {0xd9, 2, 0, X86_DECODE_CMD_FST, 4, false, false, decode_x87_modrm_floatp, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3871: FILE: target/i386/hvf-utils/x86_decode.c:1068:
+ {0xd9, 3, 3, X86_DECODE_CMD_INVL, 10, false, false, decode_x87_modrm_st0, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3872: FILE: target/i386/hvf-utils/x86_decode.c:1069:
+ {0xd9, 3, 0, X86_DECODE_CMD_FST, 4, false, true, decode_x87_modrm_floatp, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3873: FILE: target/i386/hvf-utils/x86_decode.c:1070:
+ {0xd9, 4, 3, X86_DECODE_CMD_INVL, 10, false, false, decode_x87_modrm_st0, NULL, decode_d9_4, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3874: FILE: target/i386/hvf-utils/x86_decode.c:1071:
+ {0xd9, 4, 0, X86_DECODE_CMD_INVL, 4, false, false, decode_x87_modrm_bytep, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3875: FILE: target/i386/hvf-utils/x86_decode.c:1072:
+ {0xd9, 5, 3, X86_DECODE_CMD_FLDxx, 10, false, false, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3876: FILE: target/i386/hvf-utils/x86_decode.c:1073:
+ {0xd9, 5, 0, X86_DECODE_CMD_FLDCW, 2, false, false, decode_x87_modrm_bytep, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: do not use C99 // comments
#3877: FILE: target/i386/hvf-utils/x86_decode.c:1074:
+ //
ERROR: line over 90 characters
#3878: FILE: target/i386/hvf-utils/x86_decode.c:1075:
+ {0xd9, 7, 3, X86_DECODE_CMD_FNSTCW, 2, false, false, decode_x87_modrm_bytep, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3879: FILE: target/i386/hvf-utils/x86_decode.c:1076:
+ {0xd9, 7, 0, X86_DECODE_CMD_FNSTCW, 2, false, false, decode_x87_modrm_bytep, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: trailing whitespace
#3880: FILE: target/i386/hvf-utils/x86_decode.c:1077:
+ $
ERROR: line over 90 characters
#3881: FILE: target/i386/hvf-utils/x86_decode.c:1078:
+ {0xda, 0, 3, X86_DECODE_CMD_FCMOV, 10, false, false, decode_x87_modrm_st0, decode_x87_modrm_st0, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3882: FILE: target/i386/hvf-utils/x86_decode.c:1079:
+ {0xda, 0, 0, X86_DECODE_CMD_FADD, 4, false, false, decode_x87_modrm_st0, decode_x87_modrm_intp, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3883: FILE: target/i386/hvf-utils/x86_decode.c:1080:
+ {0xda, 1, 3, X86_DECODE_CMD_FCMOV, 10, false, false, decode_x87_modrm_st0, decode_decode_x87_modrm_st0, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3884: FILE: target/i386/hvf-utils/x86_decode.c:1081:
+ {0xda, 1, 0, X86_DECODE_CMD_FMUL, 4, false, false, decode_x87_modrm_st0, decode_x87_modrm_intp, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3885: FILE: target/i386/hvf-utils/x86_decode.c:1082:
+ {0xda, 2, 3, X86_DECODE_CMD_FCMOV, 10, false, false, decode_x87_modrm_st0, decode_x87_modrm_st0, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3886: FILE: target/i386/hvf-utils/x86_decode.c:1083:
+ {0xda, 3, 3, X86_DECODE_CMD_FCMOV, 10, false, false, decode_x87_modrm_st0, decode_x87_modrm_st0, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3887: FILE: target/i386/hvf-utils/x86_decode.c:1084:
+ {0xda, 4, 3, X86_DECODE_CMD_INVL, 10, false, false, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3888: FILE: target/i386/hvf-utils/x86_decode.c:1085:
+ {0xda, 4, 0, X86_DECODE_CMD_FSUB, 4, false, false, decode_x87_modrm_st0, decode_x87_modrm_intp, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3889: FILE: target/i386/hvf-utils/x86_decode.c:1086:
+ {0xda, 5, 3, X86_DECODE_CMD_FUCOM, 10, false, true, decode_x87_modrm_st0, decode_decode_x87_modrm_st0, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3890: FILE: target/i386/hvf-utils/x86_decode.c:1087:
+ {0xda, 5, 0, X86_DECODE_CMD_FSUB, 4, true, false, decode_x87_modrm_st0, decode_x87_modrm_intp, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3891: FILE: target/i386/hvf-utils/x86_decode.c:1088:
+ {0xda, 6, 3, X86_DECODE_CMD_INVL, 10, false, false, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3892: FILE: target/i386/hvf-utils/x86_decode.c:1089:
+ {0xda, 6, 0, X86_DECODE_CMD_FDIV, 4, false, false, decode_x87_modrm_st0, decode_x87_modrm_intp, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3893: FILE: target/i386/hvf-utils/x86_decode.c:1090:
+ {0xda, 7, 3, X86_DECODE_CMD_INVL, 10, false, false, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3894: FILE: target/i386/hvf-utils/x86_decode.c:1091:
+ {0xda, 7, 0, X86_DECODE_CMD_FDIV, 4, true, false, decode_x87_modrm_st0, decode_x87_modrm_intp, NULL, RFLAGS_MASK_NONE},
ERROR: trailing whitespace
#3895: FILE: target/i386/hvf-utils/x86_decode.c:1092:
+ $
ERROR: line over 90 characters
#3896: FILE: target/i386/hvf-utils/x86_decode.c:1093:
+ {0xdb, 0, 3, X86_DECODE_CMD_FCMOV, 10, false, false, decode_x87_modrm_st0, decode_x87_modrm_st0, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3897: FILE: target/i386/hvf-utils/x86_decode.c:1094:
+ {0xdb, 0, 0, X86_DECODE_CMD_FLD, 4, false, false, decode_x87_modrm_intp, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3898: FILE: target/i386/hvf-utils/x86_decode.c:1095:
+ {0xdb, 1, 3, X86_DECODE_CMD_FCMOV, 10, false, false, decode_x87_modrm_st0, decode_x87_modrm_st0, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3899: FILE: target/i386/hvf-utils/x86_decode.c:1096:
+ {0xdb, 2, 3, X86_DECODE_CMD_FCMOV, 10, false, false, decode_x87_modrm_st0, decode_x87_modrm_st0, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3900: FILE: target/i386/hvf-utils/x86_decode.c:1097:
+ {0xdb, 2, 0, X86_DECODE_CMD_FST, 4, false, false, decode_x87_modrm_intp, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3901: FILE: target/i386/hvf-utils/x86_decode.c:1098:
+ {0xdb, 3, 3, X86_DECODE_CMD_FCMOV, 10, false, false, decode_x87_modrm_st0, decode_x87_modrm_st0, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3902: FILE: target/i386/hvf-utils/x86_decode.c:1099:
+ {0xdb, 3, 0, X86_DECODE_CMD_FST, 4, false, true, decode_x87_modrm_intp, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3903: FILE: target/i386/hvf-utils/x86_decode.c:1100:
+ {0xdb, 4, 3, X86_DECODE_CMD_INVL, 10, false, false, NULL, NULL, decode_db_4, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3904: FILE: target/i386/hvf-utils/x86_decode.c:1101:
+ {0xdb, 4, 0, X86_DECODE_CMD_INVL, 10, false, false, NULL, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3905: FILE: target/i386/hvf-utils/x86_decode.c:1102:
+ {0xdb, 5, 3, X86_DECODE_CMD_FUCOMI, 10, false, false, decode_x87_modrm_st0, decode_x87_modrm_st0, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3906: FILE: target/i386/hvf-utils/x86_decode.c:1103:
+ {0xdb, 5, 0, X86_DECODE_CMD_FLD, 10, false, false, decode_x87_modrm_floatp, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3907: FILE: target/i386/hvf-utils/x86_decode.c:1104:
+ {0xdb, 7, 0, X86_DECODE_CMD_FST, 10, false, true, decode_x87_modrm_floatp, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: trailing whitespace
#3908: FILE: target/i386/hvf-utils/x86_decode.c:1105:
+ $
ERROR: line over 90 characters
#3909: FILE: target/i386/hvf-utils/x86_decode.c:1106:
+ {0xdc, 0, 3, X86_DECODE_CMD_FADD, 10, false, false, decode_x87_modrm_st0, decode_x87_modrm_st0, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3910: FILE: target/i386/hvf-utils/x86_decode.c:1107:
+ {0xdc, 0, 0, X86_DECODE_CMD_FADD, 8, false, false, decode_x87_modrm_st0, decode_x87_modrm_floatp, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3911: FILE: target/i386/hvf-utils/x86_decode.c:1108:
+ {0xdc, 1, 3, X86_DECODE_CMD_FMUL, 10, false, false, decode_x87_modrm_st0, decode_x87_modrm_st0, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3912: FILE: target/i386/hvf-utils/x86_decode.c:1109:
+ {0xdc, 1, 0, X86_DECODE_CMD_FMUL, 8, false, false, decode_x87_modrm_st0, decode_x87_modrm_floatp, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3913: FILE: target/i386/hvf-utils/x86_decode.c:1110:
+ {0xdc, 4, 3, X86_DECODE_CMD_FSUB, 10, true, false, decode_x87_modrm_st0, decode_x87_modrm_st0, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3914: FILE: target/i386/hvf-utils/x86_decode.c:1111:
+ {0xdc, 4, 0, X86_DECODE_CMD_FSUB, 8, false, false, decode_x87_modrm_st0, decode_x87_modrm_floatp, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3915: FILE: target/i386/hvf-utils/x86_decode.c:1112:
+ {0xdc, 5, 3, X86_DECODE_CMD_FSUB, 10, false, false, decode_x87_modrm_st0, decode_x87_modrm_st0, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3916: FILE: target/i386/hvf-utils/x86_decode.c:1113:
+ {0xdc, 5, 0, X86_DECODE_CMD_FSUB, 8, true, false, decode_x87_modrm_st0, decode_x87_modrm_floatp, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3917: FILE: target/i386/hvf-utils/x86_decode.c:1114:
+ {0xdc, 6, 3, X86_DECODE_CMD_FDIV, 10, true, false, decode_x87_modrm_st0, decode_x87_modrm_st0, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3918: FILE: target/i386/hvf-utils/x86_decode.c:1115:
+ {0xdc, 6, 0, X86_DECODE_CMD_FDIV, 8, false, false, decode_x87_modrm_st0, decode_x87_modrm_floatp, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3919: FILE: target/i386/hvf-utils/x86_decode.c:1116:
+ {0xdc, 7, 3, X86_DECODE_CMD_FDIV, 10, false, false, decode_x87_modrm_st0, decode_x87_modrm_st0, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3920: FILE: target/i386/hvf-utils/x86_decode.c:1117:
+ {0xdc, 7, 0, X86_DECODE_CMD_FDIV, 8, true, false, decode_x87_modrm_st0, decode_x87_modrm_floatp, NULL, RFLAGS_MASK_NONE},
ERROR: trailing whitespace
#3921: FILE: target/i386/hvf-utils/x86_decode.c:1118:
+ $
ERROR: line over 90 characters
#3922: FILE: target/i386/hvf-utils/x86_decode.c:1119:
+ {0xdd, 0, 0, X86_DECODE_CMD_FLD, 8, false, false, decode_x87_modrm_floatp, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3923: FILE: target/i386/hvf-utils/x86_decode.c:1120:
+ {0xdd, 1, 3, X86_DECODE_CMD_FXCH, 10, false, false, decode_x87_modrm_st0, decode_x87_modrm_st0, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3924: FILE: target/i386/hvf-utils/x86_decode.c:1121:
+ {0xdd, 2, 3, X86_DECODE_CMD_FST, 10, false, false, decode_x87_modrm_st0, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3925: FILE: target/i386/hvf-utils/x86_decode.c:1122:
+ {0xdd, 2, 0, X86_DECODE_CMD_FST, 8, false, false, decode_x87_modrm_floatp, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3926: FILE: target/i386/hvf-utils/x86_decode.c:1123:
+ {0xdd, 3, 3, X86_DECODE_CMD_FST, 10, false, true, decode_x87_modrm_st0, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3927: FILE: target/i386/hvf-utils/x86_decode.c:1124:
+ {0xdd, 3, 0, X86_DECODE_CMD_FST, 8, false, true, decode_x87_modrm_floatp, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3928: FILE: target/i386/hvf-utils/x86_decode.c:1125:
+ {0xdd, 4, 3, X86_DECODE_CMD_FUCOM, 10, false, false, decode_x87_modrm_st0, decode_x87_modrm_st0, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3929: FILE: target/i386/hvf-utils/x86_decode.c:1126:
+ {0xdd, 4, 0, X86_DECODE_CMD_FRSTOR, 8, false, false, decode_x87_modrm_bytep, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3930: FILE: target/i386/hvf-utils/x86_decode.c:1127:
+ {0xdd, 5, 3, X86_DECODE_CMD_FUCOM, 10, false, true, decode_x87_modrm_st0, decode_x87_modrm_st0, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3931: FILE: target/i386/hvf-utils/x86_decode.c:1128:
+ {0xdd, 7, 0, X86_DECODE_CMD_FNSTSW, 0, false, false, decode_x87_modrm_bytep, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3932: FILE: target/i386/hvf-utils/x86_decode.c:1129:
+ {0xdd, 7, 3, X86_DECODE_CMD_FNSTSW, 0, false, false, decode_x87_modrm_bytep, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: trailing whitespace
#3933: FILE: target/i386/hvf-utils/x86_decode.c:1130:
+ $
ERROR: line over 90 characters
#3934: FILE: target/i386/hvf-utils/x86_decode.c:1131:
+ {0xde, 0, 3, X86_DECODE_CMD_FADD, 10, false, true, decode_x87_modrm_st0, decode_x87_modrm_st0, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3935: FILE: target/i386/hvf-utils/x86_decode.c:1132:
+ {0xde, 0, 0, X86_DECODE_CMD_FADD, 2, false, false, decode_x87_modrm_st0, decode_x87_modrm_intp, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3936: FILE: target/i386/hvf-utils/x86_decode.c:1133:
+ {0xde, 1, 3, X86_DECODE_CMD_FMUL, 10, false, true, decode_x87_modrm_st0, decode_x87_modrm_st0, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3937: FILE: target/i386/hvf-utils/x86_decode.c:1134:
+ {0xde, 1, 0, X86_DECODE_CMD_FMUL, 2, false, false, decode_x87_modrm_st0, decode_x87_modrm_intp, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3938: FILE: target/i386/hvf-utils/x86_decode.c:1135:
+ {0xde, 4, 3, X86_DECODE_CMD_FSUB, 10, true, true, decode_x87_modrm_st0, decode_x87_modrm_st0, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3939: FILE: target/i386/hvf-utils/x86_decode.c:1136:
+ {0xde, 4, 0, X86_DECODE_CMD_FSUB, 2, false, false, decode_x87_modrm_st0, decode_x87_modrm_intp, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3940: FILE: target/i386/hvf-utils/x86_decode.c:1137:
+ {0xde, 5, 3, X86_DECODE_CMD_FSUB, 10, false, true, decode_x87_modrm_st0, decode_x87_modrm_st0, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3941: FILE: target/i386/hvf-utils/x86_decode.c:1138:
+ {0xde, 5, 0, X86_DECODE_CMD_FSUB, 2, true, false, decode_x87_modrm_st0, decode_x87_modrm_intp, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3942: FILE: target/i386/hvf-utils/x86_decode.c:1139:
+ {0xde, 6, 3, X86_DECODE_CMD_FDIV, 10, true, true, decode_x87_modrm_st0, decode_x87_modrm_st0, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3943: FILE: target/i386/hvf-utils/x86_decode.c:1140:
+ {0xde, 6, 0, X86_DECODE_CMD_FDIV, 2, false, false, decode_x87_modrm_st0, decode_x87_modrm_intp, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3944: FILE: target/i386/hvf-utils/x86_decode.c:1141:
+ {0xde, 7, 3, X86_DECODE_CMD_FDIV, 10, false, true, decode_x87_modrm_st0, decode_x87_modrm_st0, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3945: FILE: target/i386/hvf-utils/x86_decode.c:1142:
+ {0xde, 7, 0, X86_DECODE_CMD_FDIV, 2, true, false, decode_x87_modrm_st0, decode_x87_modrm_intp, NULL, RFLAGS_MASK_NONE},
ERROR: trailing whitespace
#3946: FILE: target/i386/hvf-utils/x86_decode.c:1143:
+ $
ERROR: line over 90 characters
#3947: FILE: target/i386/hvf-utils/x86_decode.c:1144:
+ {0xdf, 0, 0, X86_DECODE_CMD_FLD, 2, false, false, decode_x87_modrm_intp, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3948: FILE: target/i386/hvf-utils/x86_decode.c:1145:
+ {0xdf, 1, 3, X86_DECODE_CMD_FXCH, 10, false, false, decode_x87_modrm_st0, decode_x87_modrm_st0, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3949: FILE: target/i386/hvf-utils/x86_decode.c:1146:
+ {0xdf, 2, 3, X86_DECODE_CMD_FST, 10, false, true, decode_x87_modrm_st0, decode_x87_modrm_st0, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3950: FILE: target/i386/hvf-utils/x86_decode.c:1147:
+ {0xdf, 2, 0, X86_DECODE_CMD_FST, 2, false, false, decode_x87_modrm_intp, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3951: FILE: target/i386/hvf-utils/x86_decode.c:1148:
+ {0xdf, 3, 3, X86_DECODE_CMD_FST, 10, false, true, decode_x87_modrm_st0, decode_x87_modrm_st0, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3952: FILE: target/i386/hvf-utils/x86_decode.c:1149:
+ {0xdf, 3, 0, X86_DECODE_CMD_FST, 2, false, true, decode_x87_modrm_intp, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3953: FILE: target/i386/hvf-utils/x86_decode.c:1150:
+ {0xdf, 4, 3, X86_DECODE_CMD_FNSTSW, 2, false, true, decode_x87_modrm_bytep, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3954: FILE: target/i386/hvf-utils/x86_decode.c:1151:
+ {0xdf, 5, 3, X86_DECODE_CMD_FUCOMI, 10, false, true, decode_x87_modrm_st0, decode_x87_modrm_st0, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3955: FILE: target/i386/hvf-utils/x86_decode.c:1152:
+ {0xdf, 5, 0, X86_DECODE_CMD_FLD, 8, false, false, decode_x87_modrm_intp, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3956: FILE: target/i386/hvf-utils/x86_decode.c:1153:
+ {0xdf, 7, 0, X86_DECODE_CMD_FST, 8, false, true, decode_x87_modrm_intp, NULL, NULL, RFLAGS_MASK_NONE},
ERROR: line over 90 characters
#3959: FILE: target/i386/hvf-utils/x86_decode.c:1156:
+void calc_modrm_operand16(CPUState *cpu, struct x86_decode *decode, struct x86_decode_op *op)
ERROR: braces {} are necessary for all arms of this statement
#3969: FILE: target/i386/hvf-utils/x86_decode.c:1166:
+ if (decode->displacement_size)
[...]
ERROR: switch and case should be at the same indent
#3972: FILE: target/i386/hvf-utils/x86_decode.c:1169:
+ switch (decode->modrm.rm) {
+ case 0:
[...]
+ case 1:
[...]
+ case 2:
[...]
+ case 3:
[...]
+ case 4:
[...]
+ case 5:
[...]
+ case 6:
[...]
+ case 7:
ERROR: braces {} are necessary for all arms of this statement
#4002: FILE: target/i386/hvf-utils/x86_decode.c:1199:
+ if (X86_DECODE_CMD_LEA == decode->cmd)
[...]
+ else
[...]
ERROR: braces {} are necessary for all arms of this statement
#4013: FILE: target/i386/hvf-utils/x86_decode.c:1210:
+ if (is_extended)
[...]
ERROR: switch and case should be at the same indent
#4017: FILE: target/i386/hvf-utils/x86_decode.c:1214:
+ switch (size) {
+ case 1:
[...]
+ default:
ERROR: "(foo*)" should be "(foo *)"
#4038: FILE: target/i386/hvf-utils/x86_decode.c:1235:
+ memcpy(&val, (void*)get_reg_ref(cpu, reg, is_extended, size), size);
WARNING: line over 80 characters
#4042: FILE: target/i386/hvf-utils/x86_decode.c:1239:
+static addr_t get_sib_val(CPUState *cpu, struct x86_decode *decode, x86_reg_segment *sel)
ERROR: braces {} are necessary for all arms of this statement
#4053: FILE: target/i386/hvf-utils/x86_decode.c:1250:
+ if (decode->rex.b)
[...]
ERROR: braces {} are necessary for all arms of this statement
#4055: FILE: target/i386/hvf-utils/x86_decode.c:1252:
+ if (REG_RSP == base_reg || REG_RBP == base_reg)
[...]
ERROR: braces {} are necessary for all arms of this statement
#4060: FILE: target/i386/hvf-utils/x86_decode.c:1257:
+ if (decode->rex.x)
[...]
ERROR: braces {} are necessary for all arms of this statement
#4063: FILE: target/i386/hvf-utils/x86_decode.c:1260:
+ if (index_reg != REG_RSP)
[...]
ERROR: line over 90 characters
#4064: FILE: target/i386/hvf-utils/x86_decode.c:1261:
+ scaled_index = get_reg_val(cpu, index_reg, decode->rex.x, addr_size) << decode->sib.scale;
ERROR: line over 90 characters
#4068: FILE: target/i386/hvf-utils/x86_decode.c:1265:
+void calc_modrm_operand32(CPUState *cpu, struct x86_decode *decode, struct x86_decode_op *op)
ERROR: braces {} are necessary for all arms of this statement
#4074: FILE: target/i386/hvf-utils/x86_decode.c:1271:
+ if (decode->displacement_size)
[...]
ERROR: else should follow close brace '}'
#4080: FILE: target/i386/hvf-utils/x86_decode.c:1277:
+ }
+ else if (!decode->modrm.mod && 5 == decode->modrm.rm) {
ERROR: braces {} are necessary for all arms of this statement
#4081: FILE: target/i386/hvf-utils/x86_decode.c:1278:
+ if (x86_is_long_mode(cpu))
[...]
+ else
[...]
ERROR: else should follow close brace '}'
#4086: FILE: target/i386/hvf-utils/x86_decode.c:1283:
+ }
+ else {
ERROR: braces {} are necessary for all arms of this statement
#4087: FILE: target/i386/hvf-utils/x86_decode.c:1284:
+ if (REG_RBP == decode->modrm.rm || REG_RSP == decode->modrm.rm)
[...]
ERROR: braces {} are necessary for all arms of this statement
#4092: FILE: target/i386/hvf-utils/x86_decode.c:1289:
+ if (X86_DECODE_CMD_LEA == decode->cmd)
[...]
+ else
[...]
ERROR: line over 90 characters
#4098: FILE: target/i386/hvf-utils/x86_decode.c:1295:
+void calc_modrm_operand64(CPUState *cpu, struct x86_decode *decode, struct x86_decode_op *op)
ERROR: trailing whitespace
#4106: FILE: target/i386/hvf-utils/x86_decode.c:1303:
+ $
ERROR: braces {} are necessary for all arms of this statement
#4107: FILE: target/i386/hvf-utils/x86_decode.c:1304:
+ if (decode->displacement_size)
[...]
ERROR: braces {} are necessary for all arms of this statement
#4110: FILE: target/i386/hvf-utils/x86_decode.c:1307:
+ if (4 == rm)
[...]
+ else if (0 == mod && 5 == rm)
[...]
+ else
[...]
ERROR: braces {} are necessary for all arms of this statement
#4112: FILE: target/i386/hvf-utils/x86_decode.c:1309:
+ else if (0 == mod && 5 == rm)
[...]
+ else
[...]
ERROR: trailing whitespace
#4116: FILE: target/i386/hvf-utils/x86_decode.c:1313:
+ $
ERROR: braces {} are necessary for all arms of this statement
#4117: FILE: target/i386/hvf-utils/x86_decode.c:1314:
+ if (X86_DECODE_CMD_LEA == decode->cmd)
[...]
+ else
[...]
ERROR: line over 90 characters
#4124: FILE: target/i386/hvf-utils/x86_decode.c:1321:
+void calc_modrm_operand(CPUState *cpu, struct x86_decode *decode, struct x86_decode_op *op)
WARNING: line over 80 characters
#4129: FILE: target/i386/hvf-utils/x86_decode.c:1326:
+ op->ptr = get_reg_ref(cpu, decode->modrm.rm, decode->rex.b, decode->operand_size);
ERROR: switch and case should be at the same indent
#4133: FILE: target/i386/hvf-utils/x86_decode.c:1330:
+ switch (decode->addressing_size) {
+ case 2:
[...]
+ case 4:
[...]
+ case 8:
[...]
+ default:
WARNING: line over 80 characters
#4144: FILE: target/i386/hvf-utils/x86_decode.c:1341:
+ VM_PANIC_EX("unsupported address size %d\n", decode->addressing_size);
ERROR: switch and case should be at the same indent
#4153: FILE: target/i386/hvf-utils/x86_decode.c:1350:
+ switch (byte) {
+ case PREFIX_LOCK:
[...]
+ case PREFIX_REPN:
+ case PREFIX_REP:
[...]
+ case PREFIX_CS_SEG_OVEERIDE:
+ case PREFIX_SS_SEG_OVEERIDE:
+ case PREFIX_DS_SEG_OVEERIDE:
+ case PREFIX_ES_SEG_OVEERIDE:
+ case PREFIX_FS_SEG_OVEERIDE:
+ case PREFIX_GS_SEG_OVEERIDE:
[...]
+ case PREFIX_OP_SIZE_OVERRIDE:
[...]
+ case PREFIX_ADDR_SIZE_OVERRIDE:
[...]
+ case PREFIX_REX ... (PREFIX_REX + 0xf):
[...]
+ default:
ERROR: do not use C99 // comments
#4180: FILE: target/i386/hvf-utils/x86_decode.c:1377:
+ // fall through when not in long mode
ERROR: spaces required around that ':' (ctx:VxE)
#4181: FILE: target/i386/hvf-utils/x86_decode.c:1378:
+ default:
^
ERROR: braces {} are necessary for all arms of this statement
#4192: FILE: target/i386/hvf-utils/x86_decode.c:1389:
+ if (decode->addr_size_override)
[...]
+ else
[...]
ERROR: else should follow close brace '}'
#4197: FILE: target/i386/hvf-utils/x86_decode.c:1394:
+ }
+ else if (!x86_is_long_mode(cpu)) {
ERROR: do not use C99 // comments
#4198: FILE: target/i386/hvf-utils/x86_decode.c:1395:
+ // protected
ERROR: do not use C99 // comments
#4201: FILE: target/i386/hvf-utils/x86_decode.c:1398:
+ // check db
ERROR: braces {} are necessary for all arms of this statement
#4203: FILE: target/i386/hvf-utils/x86_decode.c:1400:
+ if (decode->addr_size_override)
[...]
+ else
[...]
ERROR: braces {} are necessary for all arms of this statement
#4208: FILE: target/i386/hvf-utils/x86_decode.c:1405:
+ if (decode->addr_size_override)
[...]
+ else
[...]
ERROR: do not use C99 // comments
#4214: FILE: target/i386/hvf-utils/x86_decode.c:1411:
+ // long
ERROR: braces {} are necessary for all arms of this statement
#4215: FILE: target/i386/hvf-utils/x86_decode.c:1412:
+ if (decode->addr_size_override)
[...]
+ else
[...]
ERROR: braces {} are necessary for all arms of this statement
#4226: FILE: target/i386/hvf-utils/x86_decode.c:1423:
+ if (decode->op_size_override)
[...]
+ else
[...]
ERROR: else should follow close brace '}'
#4231: FILE: target/i386/hvf-utils/x86_decode.c:1428:
+ }
+ else if (!x86_is_long_mode(cpu)) {
ERROR: do not use C99 // comments
#4232: FILE: target/i386/hvf-utils/x86_decode.c:1429:
+ // protected
ERROR: do not use C99 // comments
#4235: FILE: target/i386/hvf-utils/x86_decode.c:1432:
+ // check db
ERROR: braces {} are necessary for all arms of this statement
#4237: FILE: target/i386/hvf-utils/x86_decode.c:1434:
+ if (decode->op_size_override)
[...]
+ else
[...]
ERROR: braces {} are necessary for all arms of this statement
#4242: FILE: target/i386/hvf-utils/x86_decode.c:1439:
+ if (decode->op_size_override)
[...]
+ else
[...]
ERROR: do not use C99 // comments
#4248: FILE: target/i386/hvf-utils/x86_decode.c:1445:
+ // long
ERROR: braces {} are necessary for all arms of this statement
#4249: FILE: target/i386/hvf-utils/x86_decode.c:1446:
+ if (decode->op_size_override)
[...]
+ else
[...]
ERROR: braces {} are necessary for all arms of this statement
#4254: FILE: target/i386/hvf-utils/x86_decode.c:1451:
+ if (decode->rex.w)
[...]
ERROR: line over 90 characters
#4261: FILE: target/i386/hvf-utils/x86_decode.c:1458:
+ if ((decode->modrm.mod != 3) && (4 == decode->modrm.rm) && (decode->addressing_size != 2)) {
ERROR: line over 90 characters
#4269: FILE: target/i386/hvf-utils/x86_decode.c:1466:
+ * 00 [BX+SI] [BX+DI] [BP+SI] [BP+DI] [SI] [DI] [disp16] [BX]
ERROR: code indent should never use tabs
#4269: FILE: target/i386/hvf-utils/x86_decode.c:1466:
+ * 00^I[BX+SI] [BX+DI] [BP+SI] [BP+DI] [SI] [DI] [disp16]^I[BX]$
ERROR: line over 90 characters
#4270: FILE: target/i386/hvf-utils/x86_decode.c:1467:
+ * 01 [BX+SI+disp8] [BX+DI+disp8] [BP+SI+disp8] [BP+DI+disp8] [SI+disp8] [DI+disp8] [BP+disp8] [BX+disp8]
ERROR: code indent should never use tabs
#4270: FILE: target/i386/hvf-utils/x86_decode.c:1467:
+ * 01^I[BX+SI+disp8]^I[BX+DI+disp8]^I[BP+SI+disp8]^I[BP+DI+disp8]^I[SI+disp8]^I[DI+disp8]^I[BP+disp8]^I[BX+disp8]$
ERROR: line over 90 characters
#4271: FILE: target/i386/hvf-utils/x86_decode.c:1468:
+ * 10 [BX+SI+disp16] [BX+DI+disp16] [BP+SI+disp16] [BP+DI+disp16] [SI+disp16] [DI+disp16] [BP+disp16] [BX+disp16]
ERROR: code indent should never use tabs
#4271: FILE: target/i386/hvf-utils/x86_decode.c:1468:
+ * 10^I[BX+SI+disp16]^I[BX+DI+disp16]^I[BP+SI+disp16]^I[BP+DI+disp16]^I[SI+disp16]^I[DI+disp16]^I[BP+disp16]^I[BX+disp16]$
ERROR: line over 90 characters
#4272: FILE: target/i386/hvf-utils/x86_decode.c:1469:
+ * 11 - - - - - - - -
ERROR: that open brace { should be on the previous line
#4275: FILE: target/i386/hvf-utils/x86_decode.c:1472:
+int disp16_tbl[4][8] =
+ {{0, 0, 0, 0, 0, 0, 2, 0},
ERROR: space required after that close brace '}'
#4278: FILE: target/i386/hvf-utils/x86_decode.c:1475:
+ {0, 0, 0, 0, 0, 0, 0, 0}};
ERROR: code indent should never use tabs
#4281: FILE: target/i386/hvf-utils/x86_decode.c:1478:
+ 32/64-bit^I modrm$
ERROR: line over 90 characters
#4283: FILE: target/i386/hvf-utils/x86_decode.c:1480:
+ 00 [r/m] [r/m] [r/m] [r/m] [SIB] [RIP/EIP1,2+disp32] [r/m] [r/m]
ERROR: line over 90 characters
#4284: FILE: target/i386/hvf-utils/x86_decode.c:1481:
+ 01 [r/m+disp8] [r/m+disp8] [r/m+disp8] [r/m+disp8] [SIB+disp8] [r/m+disp8] [SIB+disp8] [r/m+disp8]
ERROR: line over 90 characters
#4285: FILE: target/i386/hvf-utils/x86_decode.c:1482:
+ 10 [r/m+disp32] [r/m+disp32] [r/m+disp32] [r/m+disp32] [SIB+disp32] [r/m+disp32] [SIB+disp32] [r/m+disp32]
ERROR: code indent should never use tabs
#4285: FILE: target/i386/hvf-utils/x86_decode.c:1482:
+ 10 [r/m+disp32] [r/m+disp32] [r/m+disp32] [r/m+disp32] [SIB+disp32] [r/m+disp32] [SIB+disp32]^I [r/m+disp32]$
ERROR: line over 90 characters
#4286: FILE: target/i386/hvf-utils/x86_decode.c:1483:
+ 11 - - - - - - - -
ERROR: that open brace { should be on the previous line
#4289: FILE: target/i386/hvf-utils/x86_decode.c:1486:
+int disp32_tbl[4][8] =
+ {{0, 0, 0, 0, -1, 4, 0, 0},
ERROR: space required after that close brace '}'
#4292: FILE: target/i386/hvf-utils/x86_decode.c:1489:
+ {0, 0, 0, 0, 0, 0, 0, 0}};
ERROR: trailing whitespace
#4299: FILE: target/i386/hvf-utils/x86_decode.c:1496:
+ $
ERROR: switch and case should be at the same indent
#4301: FILE: target/i386/hvf-utils/x86_decode.c:1498:
+ switch (addressing_size) {
+ case 2:
[...]
+ case 4:
+ case 8:
ERROR: braces {} are necessary for all arms of this statement
#4304: FILE: target/i386/hvf-utils/x86_decode.c:1501:
+ if (decode->displacement_size)
[...]
ERROR: line over 90 characters
#4305: FILE: target/i386/hvf-utils/x86_decode.c:1502:
+ decode->displacement = (uint16_t)decode_bytes(cpu, decode, decode->displacement_size);
ERROR: braces {} are necessary for all arms of this statement
#4309: FILE: target/i386/hvf-utils/x86_decode.c:1506:
+ if (-1 == disp32_tbl[mod][rm]) {
[...]
+ else
[...]
ERROR: braces {} are necessary for all arms of this statement
#4310: FILE: target/i386/hvf-utils/x86_decode.c:1507:
+ if (5 == decode->sib.base)
[...]
ERROR: else should follow close brace '}'
#4313: FILE: target/i386/hvf-utils/x86_decode.c:1510:
+ }
+ else
ERROR: trailing whitespace
#4315: FILE: target/i386/hvf-utils/x86_decode.c:1512:
+ $
ERROR: braces {} are necessary for all arms of this statement
#4316: FILE: target/i386/hvf-utils/x86_decode.c:1513:
+ if (decode->displacement_size)
[...]
ERROR: line over 90 characters
#4317: FILE: target/i386/hvf-utils/x86_decode.c:1514:
+ decode->displacement = (uint32_t)decode_bytes(cpu, decode, decode->displacement_size);
ERROR: trailing whitespace
#4326: FILE: target/i386/hvf-utils/x86_decode.c:1523:
+ $
ERROR: line over 90 characters
#4331: FILE: target/i386/hvf-utils/x86_decode.c:1528:
+static inline void decode_opcode_general(CPUState *cpu, struct x86_decode *decode, uint8_t opcode, struct decode_tbl *inst_decoder)
ERROR: braces {} are necessary for all arms of this statement
#4334: FILE: target/i386/hvf-utils/x86_decode.c:1531:
+ if (inst_decoder->operand_size)
[...]
ERROR: trailing whitespace
#4337: FILE: target/i386/hvf-utils/x86_decode.c:1534:
+ $
ERROR: braces {} are necessary for all arms of this statement
#4338: FILE: target/i386/hvf-utils/x86_decode.c:1535:
+ if (inst_decoder->is_modrm)
[...]
ERROR: braces {} are necessary for all arms of this statement
#4340: FILE: target/i386/hvf-utils/x86_decode.c:1537:
+ if (inst_decoder->decode_op1)
[...]
ERROR: braces {} are necessary for all arms of this statement
#4342: FILE: target/i386/hvf-utils/x86_decode.c:1539:
+ if (inst_decoder->decode_op2)
[...]
ERROR: braces {} are necessary for all arms of this statement
#4344: FILE: target/i386/hvf-utils/x86_decode.c:1541:
+ if (inst_decoder->decode_op3)
[...]
ERROR: braces {} are necessary for all arms of this statement
#4346: FILE: target/i386/hvf-utils/x86_decode.c:1543:
+ if (inst_decoder->decode_op4)
[...]
ERROR: braces {} are necessary for all arms of this statement
#4348: FILE: target/i386/hvf-utils/x86_decode.c:1545:
+ if (inst_decoder->decode_postfix)
[...]
ERROR: line over 90 characters
#4352: FILE: target/i386/hvf-utils/x86_decode.c:1549:
+static inline void decode_opcode_1(CPUState *cpu, struct x86_decode *decode, uint8_t opcode)
ERROR: line over 90 characters
#4359: FILE: target/i386/hvf-utils/x86_decode.c:1556:
+static inline void decode_opcode_2(CPUState *cpu, struct x86_decode *decode, uint8_t opcode)
ERROR: trailing whitespace
#4368: FILE: target/i386/hvf-utils/x86_decode.c:1565:
+ $
ERROR: trailing whitespace
#4389: FILE: target/i386/hvf-utils/x86_decode.c:1586:
+ $
ERROR: trailing whitespace
#4396: FILE: target/i386/hvf-utils/x86_decode.c:1593:
+ $
ERROR: braces {} are necessary even for single statement blocks
#4397: FILE: target/i386/hvf-utils/x86_decode.c:1594:
+ for (i = 0; i < ARRAY_SIZE(_decode_tbl2); i++)
+ memcpy(_decode_tbl1, &invl_inst, sizeof(invl_inst));
ERROR: braces {} are necessary even for single statement blocks
#4399: FILE: target/i386/hvf-utils/x86_decode.c:1596:
+ for (i = 0; i < ARRAY_SIZE(_decode_tbl2); i++)
+ memcpy(_decode_tbl2, &invl_inst, sizeof(invl_inst));
ERROR: braces {} are necessary even for single statement blocks
#4401: FILE: target/i386/hvf-utils/x86_decode.c:1598:
+ for (i = 0; i < ARRAY_SIZE(_decode_tbl3); i++)
+ memcpy(_decode_tbl3, &invl_inst, sizeof(invl_inst_x87));
ERROR: trailing whitespace
#4403: FILE: target/i386/hvf-utils/x86_decode.c:1600:
+ $
ERROR: line over 90 characters
#4411: FILE: target/i386/hvf-utils/x86_decode.c:1608:
+ int index = ((_x87_inst[i].opcode & 0xf) << 4) | ((_x87_inst[i].modrm_mod & 1) << 3) | _x87_inst[i].modrm_reg;
ERROR: line over 90 characters
#4419: FILE: target/i386/hvf-utils/x86_decode.c:1616:
+ static const char *cmds[] = {"INVL", "PUSH", "PUSH_SEG", "POP", "POP_SEG", "MOV", "MOVSX", "MOVZX", "CALL_NEAR",
ERROR: line over 90 characters
#4420: FILE: target/i386/hvf-utils/x86_decode.c:1617:
+ "CALL_NEAR_ABS_INDIRECT", "CALL_FAR_ABS_INDIRECT", "CMD_CALL_FAR", "RET_NEAR", "RET_FAR", "ADD", "OR",
ERROR: line over 90 characters
#4421: FILE: target/i386/hvf-utils/x86_decode.c:1618:
+ "ADC", "SBB", "AND", "SUB", "XOR", "CMP", "INC", "DEC", "TST", "NOT", "NEG", "JMP_NEAR", "JMP_NEAR_ABS_INDIRECT",
WARNING: line over 80 characters
#4423: FILE: target/i386/hvf-utils/x86_decode.c:1620:
+ "JCXZ", "SETXX", "MOV_TO_SEG", "MOV_FROM_SEG", "CLI", "STI", "CLD", "STD", "STC",
ERROR: line over 90 characters
#4424: FILE: target/i386/hvf-utils/x86_decode.c:1621:
+ "CLC", "OUT", "IN", "INS", "OUTS", "LIDT", "SIDT", "LGDT", "SGDT", "SMSW", "LMSW", "RDTSCP", "INVLPG", "MOV_TO_CR",
ERROR: line over 90 characters
#4425: FILE: target/i386/hvf-utils/x86_decode.c:1622:
+ "MOV_FROM_CR", "MOV_TO_DR", "MOV_FROM_DR", "PUSHF", "POPF", "CPUID", "ROL", "ROR", "RCL", "RCR", "SHL", "SAL",
ERROR: line over 90 characters
#4426: FILE: target/i386/hvf-utils/x86_decode.c:1623:
+ "SHR","SHRD", "SHLD", "SAR", "DIV", "IDIV", "MUL", "IMUL_3", "IMUL_2", "IMUL_1", "MOVS", "CMPS", "SCAS",
ERROR: space required after that ',' (ctx:VxV)
#4426: FILE: target/i386/hvf-utils/x86_decode.c:1623:
+ "SHR","SHRD", "SHLD", "SAR", "DIV", "IDIV", "MUL", "IMUL_3", "IMUL_2", "IMUL_1", "MOVS", "CMPS", "SCAS",
^
ERROR: line over 90 characters
#4427: FILE: target/i386/hvf-utils/x86_decode.c:1624:
+ "LODS", "STOS", "BSWAP", "XCHG", "RDTSC", "RDMSR", "WRMSR", "ENTER", "LEAVE", "BT", "BTS", "BTC", "BTR", "BSF",
ERROR: line over 90 characters
#4428: FILE: target/i386/hvf-utils/x86_decode.c:1625:
+ "BSR", "IRET", "INT", "POPA", "PUSHA", "CWD", "CBW", "DAS", "AAD", "AAM", "AAS", "LOOP", "SLDT", "STR", "LLDT",
ERROR: line over 90 characters
#4429: FILE: target/i386/hvf-utils/x86_decode.c:1626:
+ "LTR", "VERR", "VERW", "SAHF", "LAHF", "WBINVD", "LDS", "LSS", "LES", "LGS", "LFS", "CMC", "XLAT", "NOP", "CMOV",
ERROR: line over 90 characters
#4431: FILE: target/i386/hvf-utils/x86_decode.c:1628:
+ "FNINIT", "FLD", "FLDxx", "FNSTCW", "FNSTSW", "FNSETPM", "FSAVE", "FRSTOR", "FXSAVE", "FXRSTOR", "FDIV", "FMUL",
ERROR: line over 90 characters
#4432: FILE: target/i386/hvf-utils/x86_decode.c:1629:
+ "FSUB", "FADD", "EMMS", "MFENCE", "SFENCE", "LFENCE", "PREFETCH", "FST", "FABS", "FUCOM", "FUCOMI", "FLDCW",
ERROR: line over 90 characters
#4437: FILE: target/i386/hvf-utils/x86_decode.c:1634:
+addr_t decode_linear_addr(struct CPUState *cpu, struct x86_decode *decode, addr_t addr, x86_reg_segment seg)
ERROR: switch and case should be at the same indent
#4439: FILE: target/i386/hvf-utils/x86_decode.c:1636:
+ switch (decode->segment_override) {
+ case PREFIX_CS_SEG_OVEERIDE:
[...]
+ case PREFIX_SS_SEG_OVEERIDE:
[...]
+ case PREFIX_DS_SEG_OVEERIDE:
[...]
+ case PREFIX_ES_SEG_OVEERIDE:
[...]
+ case PREFIX_FS_SEG_OVEERIDE:
[...]
+ case PREFIX_GS_SEG_OVEERIDE:
[...]
+ default:
ERROR: do not use C99 // comments
#4496: FILE: target/i386/hvf-utils/x86_decode.h:28:
+ // group 1
ERROR: do not use C99 // comments
#4500: FILE: target/i386/hvf-utils/x86_decode.h:32:
+ // group 2
ERROR: do not use C99 // comments
#4507: FILE: target/i386/hvf-utils/x86_decode.h:39:
+ // group 3
ERROR: do not use C99 // comments
#4509: FILE: target/i386/hvf-utils/x86_decode.h:41:
+ // group 4
ERROR: trailing whitespace
#4517: FILE: target/i386/hvf-utils/x86_decode.h:49:
+ $
ERROR: trailing whitespace
#4648: FILE: target/i386/hvf-utils/x86_decode.h:180:
+ $
ERROR: do not use C99 // comments
#4726: FILE: target/i386/hvf-utils/x86_decode.h:258:
+ // for floating point computations
ERROR: line over 90 characters
#4779: FILE: target/i386/hvf-utils/x86_decode.h:311:
+void calc_modrm_operand(CPUState *cpu, struct x86_decode *decode, struct x86_decode_op *op);
ERROR: line over 90 characters
#4780: FILE: target/i386/hvf-utils/x86_decode.h:312:
+addr_t decode_linear_addr(struct CPUState *cpu, struct x86_decode *decode, addr_t addr, x86_reg_segment seg);
ERROR: "foo* bar" should be "foo *bar"
#4782: FILE: target/i386/hvf-utils/x86_decode.h:314:
+void init_decoder(CPUState* cpu);
WARNING: line over 80 characters
#4851: FILE: target/i386/hvf-utils/x86_descr.c:63:
+x68_segment_selector vmx_read_segment_selector(CPUState *cpu, x86_reg_segment seg)
ERROR: line over 90 characters
#4858: FILE: target/i386/hvf-utils/x86_descr.c:70:
+void vmx_write_segment_selector(struct CPUState *cpu, x68_segment_selector selector, x86_reg_segment seg)
ERROR: line over 90 characters
#4863: FILE: target/i386/hvf-utils/x86_descr.c:75:
+void vmx_read_segment_descriptor(struct CPUState *cpu, struct vmx_segment *desc, x86_reg_segment seg)
ERROR: line over 90 characters
#4871: FILE: target/i386/hvf-utils/x86_descr.c:83:
+void vmx_write_segment_descriptor(CPUState *cpu, struct vmx_segment *desc, x86_reg_segment seg)
ERROR: line over 90 characters
#4881: FILE: target/i386/hvf-utils/x86_descr.c:93:
+void x86_segment_descriptor_to_vmx(struct CPUState *cpu, x68_segment_selector selector, struct x86_segment_descriptor *desc, struct vmx_segment *vmx_desc)
ERROR: line over 90 characters
#4898: FILE: target/i386/hvf-utils/x86_descr.c:110:
+void vmx_segment_to_x86_descriptor(struct CPUState *cpu, struct vmx_segment *vmx_desc, struct x86_segment_descriptor *desc)
ERROR: trailing whitespace
#4902: FILE: target/i386/hvf-utils/x86_descr.c:114:
+ $
ERROR: do not use C99 // comments
#4948: FILE: target/i386/hvf-utils/x86_descr.h:30:
+// deal with vmstate descriptors
ERROR: line over 90 characters
#4949: FILE: target/i386/hvf-utils/x86_descr.h:31:
+void vmx_read_segment_descriptor(struct CPUState *cpu, struct vmx_segment *desc, x86_reg_segment seg);
ERROR: line over 90 characters
#4950: FILE: target/i386/hvf-utils/x86_descr.h:32:
+void vmx_write_segment_descriptor(CPUState *cpu, struct vmx_segment *desc, x86_reg_segment seg);
WARNING: line over 80 characters
#4952: FILE: target/i386/hvf-utils/x86_descr.h:34:
+x68_segment_selector vmx_read_segment_selector(struct CPUState *cpu, x86_reg_segment seg);
ERROR: line over 90 characters
#4953: FILE: target/i386/hvf-utils/x86_descr.h:35:
+void vmx_write_segment_selector(struct CPUState *cpu, x68_segment_selector selector, x86_reg_segment seg);
WARNING: line over 80 characters
#4956: FILE: target/i386/hvf-utils/x86_descr.h:38:
+void vmx_write_segment_base(struct CPUState *cpu, x86_reg_segment seg, uint64_t base);
ERROR: line over 90 characters
#4958: FILE: target/i386/hvf-utils/x86_descr.h:40:
+void x86_segment_descriptor_to_vmx(struct CPUState *cpu, x68_segment_selector selector, struct x86_segment_descriptor *desc, struct vmx_segment *vmx_desc);
ERROR: do not use C99 // comments
#4983: FILE: target/i386/hvf-utils/x86_emu.c:19:
+/////////////////////////////////////////////////////////////////////////
ERROR: do not use C99 // comments
#4984: FILE: target/i386/hvf-utils/x86_emu.c:20:
+//
ERROR: do not use C99 // comments
#4985: FILE: target/i386/hvf-utils/x86_emu.c:21:
+// Copyright (C) 2001-2012 The Bochs Project
ERROR: do not use C99 // comments
#4986: FILE: target/i386/hvf-utils/x86_emu.c:22:
+//
ERROR: do not use C99 // comments
#4987: FILE: target/i386/hvf-utils/x86_emu.c:23:
+// This library is free software; you can redistribute it and/or
ERROR: do not use C99 // comments
#4988: FILE: target/i386/hvf-utils/x86_emu.c:24:
+// modify it under the terms of the GNU Lesser General Public
ERROR: do not use C99 // comments
#4989: FILE: target/i386/hvf-utils/x86_emu.c:25:
+// License as published by the Free Software Foundation; either
ERROR: do not use C99 // comments
#4990: FILE: target/i386/hvf-utils/x86_emu.c:26:
+// version 2 of the License, or (at your option) any later version.
ERROR: do not use C99 // comments
#4991: FILE: target/i386/hvf-utils/x86_emu.c:27:
+//
ERROR: do not use C99 // comments
#4992: FILE: target/i386/hvf-utils/x86_emu.c:28:
+// This library is distributed in the hope that it will be useful,
ERROR: do not use C99 // comments
#4993: FILE: target/i386/hvf-utils/x86_emu.c:29:
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
ERROR: do not use C99 // comments
#4994: FILE: target/i386/hvf-utils/x86_emu.c:30:
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
ERROR: do not use C99 // comments
#4995: FILE: target/i386/hvf-utils/x86_emu.c:31:
+// Lesser General Public License for more details.
ERROR: do not use C99 // comments
#4996: FILE: target/i386/hvf-utils/x86_emu.c:32:
+//
ERROR: do not use C99 // comments
#4997: FILE: target/i386/hvf-utils/x86_emu.c:33:
+// You should have received a copy of the GNU Lesser General Public
ERROR: do not use C99 // comments
#4998: FILE: target/i386/hvf-utils/x86_emu.c:34:
+// License along with this library; if not, write to the Free Software
ERROR: do not use C99 // comments
#4999: FILE: target/i386/hvf-utils/x86_emu.c:35:
+// Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA B 02110-1301 USA
ERROR: do not use C99 // comments
#5000: FILE: target/i386/hvf-utils/x86_emu.c:36:
+/////////////////////////////////////////////////////////////////////////
ERROR: line over 90 characters
#5013: FILE: target/i386/hvf-utils/x86_emu.c:49:
+void hvf_handle_io(struct CPUState *cpu, uint16_t port, void *data, int direction, int size, uint32_t count);
ERROR: externs should be avoided in .c files
#5013: FILE: target/i386/hvf-utils/x86_emu.c:49:
+void hvf_handle_io(struct CPUState *cpu, uint16_t port, void *data, int direction, int size, uint32_t count);
ERROR: braces {} are necessary for all arms of this statement
#5024: FILE: target/i386/hvf-utils/x86_emu.c:60:
+ if (save_res) \
[...]
ERROR: braces {} are necessary for all arms of this statement
#5034: FILE: target/i386/hvf-utils/x86_emu.c:70:
+ if (save_res) \
[...]
ERROR: braces {} are necessary for all arms of this statement
#5044: FILE: target/i386/hvf-utils/x86_emu.c:80:
+ if (save_res) \
[...]
ERROR: braces {} are necessary for all arms of this statement
#5064: FILE: target/i386/hvf-utils/x86_emu.c:100:
+ if (save_res) \
[...]
ERROR: braces {} are necessary for all arms of this statement
#5074: FILE: target/i386/hvf-utils/x86_emu.c:110:
+ if (save_res) \
[...]
ERROR: braces {} are necessary for all arms of this statement
#5084: FILE: target/i386/hvf-utils/x86_emu.c:120:
+ if (save_res) \
[...]
ERROR: "foo* bar" should be "foo *bar"
#5094: FILE: target/i386/hvf-utils/x86_emu.c:130:
+addr_t read_reg(struct CPUState* cpu, int reg, int size)
ERROR: switch and case should be at the same indent
#5096: FILE: target/i386/hvf-utils/x86_emu.c:132:
+ switch (size) {
+ case 1:
[...]
+ case 2:
[...]
+ case 4:
[...]
+ case 8:
[...]
+ default:
ERROR: "foo* bar" should be "foo *bar"
#5111: FILE: target/i386/hvf-utils/x86_emu.c:147:
+void write_reg(struct CPUState* cpu, int reg, addr_t val, int size)
ERROR: switch and case should be at the same indent
#5113: FILE: target/i386/hvf-utils/x86_emu.c:149:
+ switch (size) {
+ case 1:
[...]
+ case 2:
[...]
+ case 4:
[...]
+ case 8:
[...]
+ default:
ERROR: trailing whitespace
#5134: FILE: target/i386/hvf-utils/x86_emu.c:170:
+ $
ERROR: switch and case should be at the same indent
#5135: FILE: target/i386/hvf-utils/x86_emu.c:171:
+ switch (size) {
+ case 1:
[...]
+ case 2:
[...]
+ case 4:
[...]
+ case 8:
[...]
+ default:
ERROR: "(foo*)" should be "(foo *)"
#5137: FILE: target/i386/hvf-utils/x86_emu.c:173:
+ val = *(uint8_t*)reg_ptr;
ERROR: "(foo*)" should be "(foo *)"
#5140: FILE: target/i386/hvf-utils/x86_emu.c:176:
+ val = *(uint16_t*)reg_ptr;
ERROR: "(foo*)" should be "(foo *)"
#5143: FILE: target/i386/hvf-utils/x86_emu.c:179:
+ val = *(uint32_t*)reg_ptr;
ERROR: "(foo*)" should be "(foo *)"
#5146: FILE: target/i386/hvf-utils/x86_emu.c:182:
+ val = *(uint64_t*)reg_ptr;
ERROR: switch and case should be at the same indent
#5157: FILE: target/i386/hvf-utils/x86_emu.c:193:
+ switch (size) {
+ case 1:
[...]
+ case 2:
[...]
+ case 4:
[...]
+ case 8:
[...]
+ default:
ERROR: "(foo*)" should be "(foo *)"
#5159: FILE: target/i386/hvf-utils/x86_emu.c:195:
+ *(uint8_t*)reg_ptr = val;
ERROR: "(foo*)" should be "(foo *)"
#5162: FILE: target/i386/hvf-utils/x86_emu.c:198:
+ *(uint16_t*)reg_ptr = val;
ERROR: "(foo*)" should be "(foo *)"
#5165: FILE: target/i386/hvf-utils/x86_emu.c:201:
+ *(uint64_t*)reg_ptr = (uint32_t)val;
ERROR: "(foo*)" should be "(foo *)"
#5168: FILE: target/i386/hvf-utils/x86_emu.c:204:
+ *(uint64_t*)reg_ptr = val;
ERROR: "foo* bar" should be "foo *bar"
#5176: FILE: target/i386/hvf-utils/x86_emu.c:212:
+static bool is_host_reg(struct CPUState* cpu, addr_t ptr) {
ERROR: open brace '{' following function declarations go on the next line
#5176: FILE: target/i386/hvf-utils/x86_emu.c:212:
+static bool is_host_reg(struct CPUState* cpu, addr_t ptr) {
ERROR: line over 90 characters
#5178: FILE: target/i386/hvf-utils/x86_emu.c:214:
+ (ptr > (addr_t)cpu->hvf_x86 && ptr < (addr_t)(cpu->hvf_x86 + sizeof(struct hvf_x86_state)));
ERROR: "foo* bar" should be "foo *bar"
#5181: FILE: target/i386/hvf-utils/x86_emu.c:217:
+void write_val_ext(struct CPUState* cpu, addr_t ptr, addr_t val, int size)
ERROR: "foo* bar" should be "foo *bar"
#5196: FILE: target/i386/hvf-utils/x86_emu.c:232:
+addr_t read_val_ext(struct CPUState* cpu, addr_t ptr, int size)
ERROR: trailing whitespace
#5200: FILE: target/i386/hvf-utils/x86_emu.c:236:
+ $
ERROR: trailing whitespace
#5204: FILE: target/i386/hvf-utils/x86_emu.c:240:
+ $
ERROR: switch and case should be at the same indent
#5206: FILE: target/i386/hvf-utils/x86_emu.c:242:
+ switch (size) {
+ case 1:
[...]
+ case 2:
[...]
+ case 4:
[...]
+ case 8:
[...]
+ default:
ERROR: "(foo*)" should be "(foo *)"
#5208: FILE: target/i386/hvf-utils/x86_emu.c:244:
+ val = *(uint8_t*)mmio_ptr;
ERROR: "(foo*)" should be "(foo *)"
#5211: FILE: target/i386/hvf-utils/x86_emu.c:247:
+ val = *(uint16_t*)mmio_ptr;
ERROR: "(foo*)" should be "(foo *)"
#5214: FILE: target/i386/hvf-utils/x86_emu.c:250:
+ val = *(uint32_t*)mmio_ptr;
ERROR: "(foo*)" should be "(foo *)"
#5217: FILE: target/i386/hvf-utils/x86_emu.c:253:
+ val = *(uint64_t*)mmio_ptr;
ERROR: line over 90 characters
#5226: FILE: target/i386/hvf-utils/x86_emu.c:262:
+static void fetch_operands(struct CPUState *cpu, struct x86_decode *decode, int n, bool val_op0, bool val_op1, bool val_op2)
ERROR: switch and case should be at the same indent
#5232: FILE: target/i386/hvf-utils/x86_emu.c:268:
+ switch (decode->op[i].type) {
+ case X86_VAR_IMMEDIATE:
[...]
+ case X86_VAR_REG:
[...]
+ case X86_VAR_RM:
[...]
+ case X86_VAR_OFFSET:
[...]
+ default:
ERROR: braces {} are necessary for all arms of this statement
#5237: FILE: target/i386/hvf-utils/x86_emu.c:273:
+ if (calc_val[i])
[...]
ERROR: line over 90 characters
#5238: FILE: target/i386/hvf-utils/x86_emu.c:274:
+ decode->op[i].val = read_val_from_reg(decode->op[i].ptr, decode->operand_size);
ERROR: braces {} are necessary for all arms of this statement
#5242: FILE: target/i386/hvf-utils/x86_emu.c:278:
+ if (calc_val[i])
[...]
ERROR: line over 90 characters
#5243: FILE: target/i386/hvf-utils/x86_emu.c:279:
+ decode->op[i].val = read_val_ext(cpu, decode->op[i].ptr, decode->operand_size);
ERROR: line over 90 characters
#5246: FILE: target/i386/hvf-utils/x86_emu.c:282:
+ decode->op[i].ptr = decode_linear_addr(cpu, decode, decode->op[i].ptr, REG_SEG_DS);
ERROR: braces {} are necessary for all arms of this statement
#5247: FILE: target/i386/hvf-utils/x86_emu.c:283:
+ if (calc_val[i])
[...]
ERROR: line over 90 characters
#5248: FILE: target/i386/hvf-utils/x86_emu.c:284:
+ decode->op[i].val = read_val_ext(cpu, decode->op[i].ptr, decode->operand_size);
WARNING: line over 80 characters
#5259: FILE: target/i386/hvf-utils/x86_emu.c:295:
+ write_val_ext(cpu, decode->op[0].ptr, decode->op[1].val, decode->operand_size);
ERROR: spaces required around that '+' (ctx:WxV)
#5278: FILE: target/i386/hvf-utils/x86_emu.c:314:
+ EXEC_2OP_ARITH_CMD(cpu, decode, +get_CF(cpu)+, SET_FLAGS_OSZAPC_ADD, true);
^
ERROR: spaces required around that '+' (ctx:VxO)
#5278: FILE: target/i386/hvf-utils/x86_emu.c:314:
+ EXEC_2OP_ARITH_CMD(cpu, decode, +get_CF(cpu)+, SET_FLAGS_OSZAPC_ADD, true);
^
ERROR: spaces required around that '-' (ctx:VxO)
#5284: FILE: target/i386/hvf-utils/x86_emu.c:320:
+ EXEC_2OP_ARITH_CMD(cpu, decode, -get_CF(cpu)-, SET_FLAGS_OSZAPC_SUB, true);
^
ERROR: do not use C99 // comments
#5308: FILE: target/i386/hvf-utils/x86_emu.c:344:
+ //EXEC_2OP_ARITH_CMD(cpu, decode, -, SET_FLAGS_OSZAPC_SUB, false);
ERROR: else should follow close brace '}'
#5318: FILE: target/i386/hvf-utils/x86_emu.c:354:
+ }
+ else if (2 == decode->operand_size) {
ERROR: else should follow close brace '}'
#5321: FILE: target/i386/hvf-utils/x86_emu.c:357:
+ }
+ else if (1 == decode->operand_size) {
ERROR: do not use C99 // comments
#5327: FILE: target/i386/hvf-utils/x86_emu.c:363:
+ //lflags_to_rflags(cpu);
ERROR: spaces required around that '+' (ctx:WxV)
#5342: FILE: target/i386/hvf-utils/x86_emu.c:378:
+ EXEC_2OP_ARITH_CMD(cpu, decode, +1+, SET_FLAGS_OSZAP_ADD, true);
^
ERROR: spaces required around that '+' (ctx:VxO)
#5342: FILE: target/i386/hvf-utils/x86_emu.c:378:
+ EXEC_2OP_ARITH_CMD(cpu, decode, +1+, SET_FLAGS_OSZAP_ADD, true);
^
ERROR: spaces required around that '-' (ctx:VxO)
#5352: FILE: target/i386/hvf-utils/x86_emu.c:388:
+ EXEC_2OP_ARITH_CMD(cpu, decode, -1-, SET_FLAGS_OSZAP_SUB, true);
^
WARNING: line over 80 characters
#5366: FILE: target/i386/hvf-utils/x86_emu.c:402:
+ write_val_ext(cpu, decode->op[0].ptr, ~decode->op[0].val, decode->operand_size);
ERROR: braces {} are necessary for all arms of this statement
#5377: FILE: target/i386/hvf-utils/x86_emu.c:413:
+ if (0xb6 == decode->opcode[1])
[...]
+ else
[...]
ERROR: switch and case should be at the same indent
#5391: FILE: target/i386/hvf-utils/x86_emu.c:427:
+ switch (decode->opcode[0]) {
+ case 0xe6:
[...]
+ case 0xe7:
[...]
+ case 0xee:
[...]
+ case 0xef:
[...]
+ default:
WARNING: line over 80 characters
#5396: FILE: target/i386/hvf-utils/x86_emu.c:432:
+ hvf_handle_io(cpu, decode->op[0].val, &RAX(cpu), 1, decode->operand_size, 1);
ERROR: switch and case should be at the same indent
#5414: FILE: target/i386/hvf-utils/x86_emu.c:450:
+ switch (decode->opcode[0]) {
+ case 0xe4:
[...]
+ case 0xe5:
[...]
+ case 0xec:
[...]
+ case 0xed:
[...]
+ default:
WARNING: line over 80 characters
#5419: FILE: target/i386/hvf-utils/x86_emu.c:455:
+ hvf_handle_io(cpu, decode->op[0].val, &val, 0, decode->operand_size, 1);
ERROR: braces {} are necessary for all arms of this statement
#5420: FILE: target/i386/hvf-utils/x86_emu.c:456:
+ if (decode->operand_size == 2)
[...]
+ else
[...]
ERROR: braces {} are necessary for all arms of this statement
#5430: FILE: target/i386/hvf-utils/x86_emu.c:466:
+ if (decode->operand_size == 2)
[...]
+ else
[...]
ERROR: line over 90 characters
#5444: FILE: target/i386/hvf-utils/x86_emu.c:480:
+static inline void string_increment_reg(struct CPUState * cpu, int reg, struct x86_decode *decode)
ERROR: "foo * bar" should be "foo *bar"
#5444: FILE: target/i386/hvf-utils/x86_emu.c:480:
+static inline void string_increment_reg(struct CPUState * cpu, int reg, struct x86_decode *decode)
ERROR: braces {} are necessary for all arms of this statement
#5447: FILE: target/i386/hvf-utils/x86_emu.c:483:
+ if (cpu->hvf_x86->rflags.df)
[...]
+ else
[...]
ERROR: line over 90 characters
#5454: FILE: target/i386/hvf-utils/x86_emu.c:490:
+static inline void string_rep(struct CPUState * cpu, struct x86_decode *decode, void (*func)(struct CPUState *cpu, struct x86_decode *ins), int rep)
ERROR: "foo * bar" should be "foo *bar"
#5454: FILE: target/i386/hvf-utils/x86_emu.c:490:
+static inline void string_rep(struct CPUState * cpu, struct x86_decode *decode, void (*func)(struct CPUState *cpu, struct x86_decode *ins), int rep)
ERROR: braces {} are necessary for all arms of this statement
#5460: FILE: target/i386/hvf-utils/x86_emu.c:496:
+ if ((PREFIX_REP == rep) && !get_ZF(cpu))
[...]
ERROR: braces {} are necessary for all arms of this statement
#5462: FILE: target/i386/hvf-utils/x86_emu.c:498:
+ if ((PREFIX_REPN == rep) && get_ZF(cpu))
[...]
WARNING: line over 80 characters
#5469: FILE: target/i386/hvf-utils/x86_emu.c:505:
+ addr_t addr = linear_addr_size(cpu, RDI(cpu), decode->addressing_size, REG_SEG_ES);
WARNING: line over 80 characters
#5471: FILE: target/i386/hvf-utils/x86_emu.c:507:
+ hvf_handle_io(cpu, DX(cpu), cpu->hvf_x86->mmio_buf, 0, decode->operand_size, 1);
ERROR: braces {} are necessary for all arms of this statement
#5479: FILE: target/i386/hvf-utils/x86_emu.c:515:
+ if (decode->rep)
[...]
+ else
[...]
WARNING: line over 80 characters
#5492: FILE: target/i386/hvf-utils/x86_emu.c:528:
+ hvf_handle_io(cpu, DX(cpu), cpu->hvf_x86->mmio_buf, 1, decode->operand_size, 1);
ERROR: braces {} are necessary for all arms of this statement
#5499: FILE: target/i386/hvf-utils/x86_emu.c:535:
+ if (decode->rep)
[...]
+ else
[...]
ERROR: trailing whitespace
#5503: FILE: target/i386/hvf-utils/x86_emu.c:539:
+ $
ERROR: trailing whitespace
#5512: FILE: target/i386/hvf-utils/x86_emu.c:548:
+ $
WARNING: line over 80 characters
#5514: FILE: target/i386/hvf-utils/x86_emu.c:550:
+ dst_addr = linear_addr_size(cpu, RDI(cpu), decode->addressing_size, REG_SEG_ES);
ERROR: trailing whitespace
#5515: FILE: target/i386/hvf-utils/x86_emu.c:551:
+ $
ERROR: braces {} are necessary for all arms of this statement
#5525: FILE: target/i386/hvf-utils/x86_emu.c:561:
+ if (decode->rep) {
[...]
+ else
[...]
ERROR: else should follow close brace '}'
#5528: FILE: target/i386/hvf-utils/x86_emu.c:564:
+ }
+ else
WARNING: line over 80 characters
#5540: FILE: target/i386/hvf-utils/x86_emu.c:576:
+ dst_addr = linear_addr_size(cpu, RDI(cpu), decode->addressing_size, REG_SEG_ES);
ERROR: braces {} are necessary for all arms of this statement
#5555: FILE: target/i386/hvf-utils/x86_emu.c:591:
+ if (decode->rep) {
[...]
+ else
[...]
ERROR: else should follow close brace '}'
#5558: FILE: target/i386/hvf-utils/x86_emu.c:594:
+ }
+ else
ERROR: braces {} are necessary for all arms of this statement
#5579: FILE: target/i386/hvf-utils/x86_emu.c:615:
+ if (decode->rep) {
[...]
+ else
[...]
ERROR: else should follow close brace '}'
#5582: FILE: target/i386/hvf-utils/x86_emu.c:618:
+ }
+ else
ERROR: trailing whitespace
#5591: FILE: target/i386/hvf-utils/x86_emu.c:627:
+ $
ERROR: braces {} are necessary for all arms of this statement
#5604: FILE: target/i386/hvf-utils/x86_emu.c:640:
+ if (decode->rep) {
[...]
+ else
[...]
ERROR: else should follow close brace '}'
#5607: FILE: target/i386/hvf-utils/x86_emu.c:643:
+ }
+ else
ERROR: trailing whitespace
#5617: FILE: target/i386/hvf-utils/x86_emu.c:653:
+ $
ERROR: braces {} are necessary for all arms of this statement
#5627: FILE: target/i386/hvf-utils/x86_emu.c:663:
+ if (decode->rep) {
[...]
+ else
[...]
ERROR: else should follow close brace '}'
#5630: FILE: target/i386/hvf-utils/x86_emu.c:666:
+ }
+ else
ERROR: code indent should never use tabs
#5636: FILE: target/i386/hvf-utils/x86_emu.c:672:
+#define MSR_IA32_UCODE_REV ^I^I0x00000017$
ERROR: switch and case should be at the same indent
#5645: FILE: target/i386/hvf-utils/x86_emu.c:681:
+ switch (msr) {
+ case MSR_IA32_TSC:
[...]
+ case MSR_IA32_APICBASE:
[...]
+ case MSR_IA32_UCODE_REV:
[...]
+ case MSR_EFER:
[...]
+ case MSR_FSBASE:
[...]
+ case MSR_GSBASE:
[...]
+ case MSR_KERNELGSBASE:
[...]
+ case MSR_STAR:
[...]
+ case MSR_LSTAR:
[...]
+ case MSR_CSTAR:
[...]
+ case MSR_IA32_MISC_ENABLE:
[...]
+ case MSR_MTRRphysBase(0):
+ case MSR_MTRRphysBase(1):
+ case MSR_MTRRphysBase(2):
+ case MSR_MTRRphysBase(3):
+ case MSR_MTRRphysBase(4):
+ case MSR_MTRRphysBase(5):
+ case MSR_MTRRphysBase(6):
+ case MSR_MTRRphysBase(7):
[...]
+ case MSR_MTRRphysMask(0):
+ case MSR_MTRRphysMask(1):
+ case MSR_MTRRphysMask(2):
+ case MSR_MTRRphysMask(3):
+ case MSR_MTRRphysMask(4):
+ case MSR_MTRRphysMask(5):
+ case MSR_MTRRphysMask(6):
+ case MSR_MTRRphysMask(7):
[...]
+ case MSR_MTRRfix64K_00000:
[...]
+ case MSR_MTRRfix16K_80000:
+ case MSR_MTRRfix16K_A0000:
[...]
+ case MSR_MTRRfix4K_C0000:
+ case MSR_MTRRfix4K_C8000:
+ case MSR_MTRRfix4K_D0000:
+ case MSR_MTRRfix4K_D8000:
+ case MSR_MTRRfix4K_E0000:
+ case MSR_MTRRfix4K_E8000:
+ case MSR_MTRRfix4K_F0000:
+ case MSR_MTRRfix4K_F8000:
[...]
+ case MSR_MTRRdefType:
[...]
+ default:
ERROR: do not use C99 // comments
#5720: FILE: target/i386/hvf-utils/x86_emu.c:756:
+ // fprintf(stderr, "%s: unknown msr 0x%x\n", __func__, msr);
ERROR: switch and case should be at the same indent
#5742: FILE: target/i386/hvf-utils/x86_emu.c:778:
+ switch (msr) {
+ case MSR_IA32_TSC:
[...]
+ case MSR_IA32_APICBASE:
[...]
+ case MSR_FSBASE:
[...]
+ case MSR_GSBASE:
[...]
+ case MSR_KERNELGSBASE:
[...]
+ case MSR_STAR:
[...]
+ case MSR_LSTAR:
[...]
+ case MSR_CSTAR:
[...]
+ case MSR_EFER:
[...]
+ case MSR_MTRRphysBase(0):
+ case MSR_MTRRphysBase(1):
+ case MSR_MTRRphysBase(2):
+ case MSR_MTRRphysBase(3):
+ case MSR_MTRRphysBase(4):
+ case MSR_MTRRphysBase(5):
+ case MSR_MTRRphysBase(6):
+ case MSR_MTRRphysBase(7):
[...]
+ case MSR_MTRRphysMask(0):
+ case MSR_MTRRphysMask(1):
+ case MSR_MTRRphysMask(2):
+ case MSR_MTRRphysMask(3):
+ case MSR_MTRRphysMask(4):
+ case MSR_MTRRphysMask(5):
+ case MSR_MTRRphysMask(6):
+ case MSR_MTRRphysMask(7):
[...]
+ case MSR_MTRRfix64K_00000:
[...]
+ case MSR_MTRRfix16K_80000:
+ case MSR_MTRRfix16K_A0000:
[...]
+ case MSR_MTRRfix4K_C0000:
+ case MSR_MTRRfix4K_C8000:
+ case MSR_MTRRfix4K_D0000:
+ case MSR_MTRRfix4K_D8000:
+ case MSR_MTRRfix4K_E0000:
+ case MSR_MTRRfix4K_E8000:
+ case MSR_MTRRfix4K_F0000:
+ case MSR_MTRRfix4K_F8000:
[...]
+ case MSR_MTRRdefType:
[...]
+ default:
ERROR: do not use C99 // comments
#5744: FILE: target/i386/hvf-utils/x86_emu.c:780:
+ // if (!osx_is_sierra())
ERROR: do not use C99 // comments
#5745: FILE: target/i386/hvf-utils/x86_emu.c:781:
+ // wvmcs(cpu->hvf_fd, VMCS_TSC_OFFSET, data - rdtscp());
ERROR: do not use C99 // comments
#5746: FILE: target/i386/hvf-utils/x86_emu.c:782:
+ //hv_vm_sync_tsc(data);
ERROR: do not use C99 // comments
#5771: FILE: target/i386/hvf-utils/x86_emu.c:807:
+ //printf("new efer %llx\n", EFER(cpu));
ERROR: braces {} are necessary for all arms of this statement
#5773: FILE: target/i386/hvf-utils/x86_emu.c:809:
+ if (data & EFER_NXE)
[...]
ERROR: do not use C99 // comments
#5821: FILE: target/i386/hvf-utils/x86_emu.c:857:
+ // if (g_hypervisor_iface)
ERROR: do not use C99 // comments
#5822: FILE: target/i386/hvf-utils/x86_emu.c:858:
+ // g_hypervisor_iface->wrmsr_handler(cpu, msr, data);
ERROR: do not use C99 // comments
#5824: FILE: target/i386/hvf-utils/x86_emu.c:860:
+ //printf("write msr %llx\n", RCX(cpu));
WARNING: line over 80 characters
#5860: FILE: target/i386/hvf-utils/x86_emu.c:896:
+ decode->op[0].val = read_val_ext(cpu, decode->op[0].ptr, decode->operand_size);
ERROR: switch and case should be at the same indent
#5863: FILE: target/i386/hvf-utils/x86_emu.c:899:
+ switch (flag) {
+ case 0:
[...]
+ case 1:
[...]
+ case 2:
[...]
+ case 3:
WARNING: line over 80 characters
#5877: FILE: target/i386/hvf-utils/x86_emu.c:913:
+ write_val_ext(cpu, decode->op[0].ptr, decode->op[0].val, decode->operand_size);
ERROR: do not use C99 // comments
#5913: FILE: target/i386/hvf-utils/x86_emu.c:949:
+ count &= 0x1f; // count is masked to 5 bits
ERROR: braces {} are necessary for all arms of this statement
#5914: FILE: target/i386/hvf-utils/x86_emu.c:950:
+ if (!count)
[...]
ERROR: switch and case should be at the same indent
#5917: FILE: target/i386/hvf-utils/x86_emu.c:953:
+ switch (decode->operand_size) {
+ case 1:
[...]
+ case 2:
[...]
+ case 4:
[...]
+ default:
ERROR: do not use C99 // comments
#5940: FILE: target/i386/hvf-utils/x86_emu.c:976:
+ of = cf ^ (res >> 15); // of = cf ^ result15
ERROR: trailing whitespace
#5951: FILE: target/i386/hvf-utils/x86_emu.c:987:
+ $
ERROR: do not use C99 // comments
#5955: FILE: target/i386/hvf-utils/x86_emu.c:991:
+ of = cf ^ (res >> 31); // of = cf ^ result31
ERROR: do not use C99 // comments
#5964: FILE: target/i386/hvf-utils/x86_emu.c:1000:
+ //lflags_to_rflags(cpu);
ERROR: braces {} are necessary for all arms of this statement
#5975: FILE: target/i386/hvf-utils/x86_emu.c:1011:
+ if (0xbe == decode->opcode[1])
[...]
+ else
[...]
ERROR: line over 90 characters
#5982: FILE: target/i386/hvf-utils/x86_emu.c:1018:
+ decode->op[1].val = sign(read_val_ext(cpu, decode->op[1].ptr, src_op_size), src_op_size);
ERROR: switch and case should be at the same indent
#5996: FILE: target/i386/hvf-utils/x86_emu.c:1032:
+ switch (decode->operand_size) {
+ case 1:
[...]
+ case 2:
[...]
+ case 4:
ERROR: line over 90 characters
#6010: FILE: target/i386/hvf-utils/x86_emu.c:1046:
+ res = ((uint8_t)decode->op[0].val >> count) | ((uint8_t)decode->op[0].val << (8 - count));
ERROR: do not use C99 // comments
#6028: FILE: target/i386/hvf-utils/x86_emu.c:1064:
+ // of = result14 ^ result15
ERROR: do not use C99 // comments
#6032: FILE: target/i386/hvf-utils/x86_emu.c:1068:
+ count &= 0x0f; // use only 4 LSB's
ERROR: line over 90 characters
#6033: FILE: target/i386/hvf-utils/x86_emu.c:1069:
+ res = ((uint16_t)decode->op[0].val >> count) | ((uint16_t)decode->op[0].val << (16 - count));
ERROR: do not use C99 // comments
#6038: FILE: target/i386/hvf-utils/x86_emu.c:1074:
+ // of = result14 ^ result15
ERROR: line over 90 characters
#6050: FILE: target/i386/hvf-utils/x86_emu.c:1086:
+ res = ((uint32_t)decode->op[0].val >> count) | ((uint32_t)decode->op[0].val << (32 - count));
ERROR: do not use C99 // comments
#6055: FILE: target/i386/hvf-utils/x86_emu.c:1091:
+ // of = result30 ^ result31
ERROR: switch and case should be at the same indent
#6071: FILE: target/i386/hvf-utils/x86_emu.c:1107:
+ switch (decode->operand_size) {
+ case 1:
[...]
+ case 2:
[...]
+ case 4:
ERROR: do not use C99 // comments
#6084: FILE: target/i386/hvf-utils/x86_emu.c:1120:
+ count &= 0x7; // use only lowest 3 bits
ERROR: line over 90 characters
#6085: FILE: target/i386/hvf-utils/x86_emu.c:1121:
+ res = ((uint8_t)decode->op[0].val << count) | ((uint8_t)decode->op[0].val >> (8 - count));
ERROR: do not use C99 // comments
#6106: FILE: target/i386/hvf-utils/x86_emu.c:1142:
+ // of = cf ^ result15
ERROR: do not use C99 // comments
#6110: FILE: target/i386/hvf-utils/x86_emu.c:1146:
+ count &= 0x0f; // only use bottom 4 bits
ERROR: line over 90 characters
#6111: FILE: target/i386/hvf-utils/x86_emu.c:1147:
+ res = ((uint16_t)decode->op[0].val << count) | ((uint16_t)decode->op[0].val >> (16 - count));
ERROR: do not use C99 // comments
#6116: FILE: target/i386/hvf-utils/x86_emu.c:1152:
+ // of = cf ^ result15
ERROR: line over 90 characters
#6128: FILE: target/i386/hvf-utils/x86_emu.c:1164:
+ res = ((uint32_t)decode->op[0].val << count) | ((uint32_t)decode->op[0].val >> (32 - count));
ERROR: do not use C99 // comments
#6133: FILE: target/i386/hvf-utils/x86_emu.c:1169:
+ // of = cf ^ result31
ERROR: switch and case should be at the same indent
#6151: FILE: target/i386/hvf-utils/x86_emu.c:1187:
+ switch(decode->operand_size) {
+ case 1:
[...]
+ case 2:
[...]
+ case 4:
ERROR: space required before the open parenthesis '('
#6151: FILE: target/i386/hvf-utils/x86_emu.c:1187:
+ switch(decode->operand_size) {
ERROR: braces {} are necessary for all arms of this statement
#6157: FILE: target/i386/hvf-utils/x86_emu.c:1193:
+ if (!count)
[...]
ERROR: braces {} are necessary for all arms of this statement
#6160: FILE: target/i386/hvf-utils/x86_emu.c:1196:
+ if (1 == count)
[...]
+ else
[...]
ERROR: line over 90 characters
#6163: FILE: target/i386/hvf-utils/x86_emu.c:1199:
+ res = (op1_8 << count) | (get_CF(cpu) << (count - 1)) | (op1_8 >> (9 - count));
ERROR: do not use C99 // comments
#6168: FILE: target/i386/hvf-utils/x86_emu.c:1204:
+ of = cf ^ (res >> 7); // of = cf ^ result7
ERROR: braces {} are necessary for all arms of this statement
#6178: FILE: target/i386/hvf-utils/x86_emu.c:1214:
+ if (!count)
[...]
ERROR: braces {} are necessary for all arms of this statement
#6181: FILE: target/i386/hvf-utils/x86_emu.c:1217:
+ if (1 == count)
[...]
+ else if (count == 16)
[...]
+ else // 2..15
[...]
ERROR: braces {} are necessary for all arms of this statement
#6183: FILE: target/i386/hvf-utils/x86_emu.c:1219:
+ else if (count == 16)
[...]
+ else // 2..15
[...]
ERROR: do not use C99 // comments
#6185: FILE: target/i386/hvf-utils/x86_emu.c:1221:
+ else // 2..15
ERROR: line over 90 characters
#6186: FILE: target/i386/hvf-utils/x86_emu.c:1222:
+ res = (op1_16 << count) | (get_CF(cpu) << (count - 1)) | (op1_16 >> (17 - count));
ERROR: trailing whitespace
#6187: FILE: target/i386/hvf-utils/x86_emu.c:1223:
+ $
ERROR: trailing whitespace
#6189: FILE: target/i386/hvf-utils/x86_emu.c:1225:
+ $
ERROR: do not use C99 // comments
#6191: FILE: target/i386/hvf-utils/x86_emu.c:1227:
+ of = cf ^ (res >> 15); // of = cf ^ result15
ERROR: braces {} are necessary for all arms of this statement
#6200: FILE: target/i386/hvf-utils/x86_emu.c:1236:
+ if (!count)
[...]
ERROR: braces {} are necessary for all arms of this statement
#6203: FILE: target/i386/hvf-utils/x86_emu.c:1239:
+ if (1 == count)
[...]
+ else
[...]
ERROR: line over 90 characters
#6206: FILE: target/i386/hvf-utils/x86_emu.c:1242:
+ res = (op1_32 << count) | (get_CF(cpu) << (count - 1)) | (op1_32 >> (33 - count));
ERROR: do not use C99 // comments
#6211: FILE: target/i386/hvf-utils/x86_emu.c:1247:
+ of = cf ^ (res >> 31); // of = cf ^ result31
ERROR: switch and case should be at the same indent
#6227: FILE: target/i386/hvf-utils/x86_emu.c:1263:
+ switch(decode->operand_size) {
+ case 1:
[...]
+ case 2:
[...]
+ case 4:
ERROR: space required before the open parenthesis '('
#6227: FILE: target/i386/hvf-utils/x86_emu.c:1263:
+ switch(decode->operand_size) {
ERROR: braces {} are necessary for all arms of this statement
#6234: FILE: target/i386/hvf-utils/x86_emu.c:1270:
+ if (!count)
[...]
ERROR: line over 90 characters
#6236: FILE: target/i386/hvf-utils/x86_emu.c:1272:
+ res = (op1_8 >> count) | (get_CF(cpu) << (8 - count)) | (op1_8 << (9 - count));
ERROR: do not use C99 // comments
#6241: FILE: target/i386/hvf-utils/x86_emu.c:1277:
+ of = (((res << 1) ^ res) >> 7) & 0x1; // of = result6 ^ result7
ERROR: braces {} are necessary for all arms of this statement
#6251: FILE: target/i386/hvf-utils/x86_emu.c:1287:
+ if (!count)
[...]
ERROR: line over 90 characters
#6253: FILE: target/i386/hvf-utils/x86_emu.c:1289:
+ res = (op1_16 >> count) | (get_CF(cpu) << (16 - count)) | (op1_16 << (17 - count));
WARNING: line over 80 characters
#6258: FILE: target/i386/hvf-utils/x86_emu.c:1294:
+ of = ((uint16_t)((res << 1) ^ res) >> 15) & 0x1; // of = result15 ^ result14
ERROR: do not use C99 // comments
#6258: FILE: target/i386/hvf-utils/x86_emu.c:1294:
+ of = ((uint16_t)((res << 1) ^ res) >> 15) & 0x1; // of = result15 ^ result14
ERROR: braces {} are necessary for all arms of this statement
#6267: FILE: target/i386/hvf-utils/x86_emu.c:1303:
+ if (!count)
[...]
ERROR: trailing whitespace
#6269: FILE: target/i386/hvf-utils/x86_emu.c:1305:
+ $
ERROR: braces {} are necessary for all arms of this statement
#6270: FILE: target/i386/hvf-utils/x86_emu.c:1306:
+ if (1 == count)
[...]
+ else
[...]
ERROR: line over 90 characters
#6273: FILE: target/i386/hvf-utils/x86_emu.c:1309:
+ res = (op1_32 >> count) | (get_CF(cpu) << (32 - count)) | (op1_32 << (33 - count));
ERROR: do not use C99 // comments
#6278: FILE: target/i386/hvf-utils/x86_emu.c:1314:
+ of = ((res << 1) ^ res) >> 31; // of = result30 ^ result31
WARNING: line over 80 characters
#6290: FILE: target/i386/hvf-utils/x86_emu.c:1326:
+ write_val_ext(cpu, decode->op[0].ptr, decode->op[1].val, decode->operand_size);
WARNING: line over 80 characters
#6291: FILE: target/i386/hvf-utils/x86_emu.c:1327:
+ write_val_ext(cpu, decode->op[1].ptr, decode->op[0].val, decode->operand_size);
WARNING: line over 80 characters
#6299: FILE: target/i386/hvf-utils/x86_emu.c:1335:
+ write_val_ext(cpu, decode->op[1].ptr, decode->op[0].val, decode->operand_size);
ERROR: braces {} are necessary even for single statement blocks
#6355: FILE: target/i386/hvf-utils/x86_emu.c:1391:
+ for (i = 0; i < ARRAY_SIZE(handlers); i++)
+ _cmd_handler[handlers[i].cmd] = handlers[i];
ERROR: line over 90 characters
#6361: FILE: target/i386/hvf-utils/x86_emu.c:1397:
+ printf("%llx: eax %llx ebx %llx ecx %llx edx %llx esi %llx edi %llx ebp %llx esp %llx flags %llx\n", RIP(cpu), RAX(cpu), RBX(cpu), RCX(cpu), RDX(cpu), RSI(cpu), RDI(cpu), RBP(cpu), RSP(cpu), EFLAGS(cpu));
ERROR: braces {} are necessary even for single statement blocks
#6375: FILE: target/i386/hvf-utils/x86_emu.c:1411:
+ for (i = 8; i < 16; i++)
+ RRX(cpu, i) = rreg(cpu->hvf_fd, HV_X86_RAX + i);
ERROR: trailing whitespace
#6377: FILE: target/i386/hvf-utils/x86_emu.c:1413:
+ $
ERROR: do not use C99 // comments
#6382: FILE: target/i386/hvf-utils/x86_emu.c:1418:
+ //print_debug(cpu);
ERROR: braces {} are necessary even for single statement blocks
#6396: FILE: target/i386/hvf-utils/x86_emu.c:1432:
+ for (i = 8; i < 16; i++)
+ wreg(cpu->hvf_fd, HV_X86_RAX + i, RRX(cpu, i));
ERROR: trailing whitespace
#6398: FILE: target/i386/hvf-utils/x86_emu.c:1434:
+ $
ERROR: do not use C99 // comments
#6403: FILE: target/i386/hvf-utils/x86_emu.c:1439:
+ //print_debug(cpu);
ERROR: do not use C99 // comments
#6408: FILE: target/i386/hvf-utils/x86_emu.c:1444:
+ //if (hvf_vcpu_id(cpu))
ERROR: line over 90 characters
#6409: FILE: target/i386/hvf-utils/x86_emu.c:1445:
+ //printf("%d, %llx: exec_instruction %s\n", hvf_vcpu_id(cpu), RIP(cpu), decode_cmd_to_string(ins->cmd));
ERROR: do not use C99 // comments
#6409: FILE: target/i386/hvf-utils/x86_emu.c:1445:
+ //printf("%d, %llx: exec_instruction %s\n", hvf_vcpu_id(cpu), RIP(cpu), decode_cmd_to_string(ins->cmd));
ERROR: trailing whitespace
#6410: FILE: target/i386/hvf-utils/x86_emu.c:1446:
+ $
ERROR: line over 90 characters
#6415: FILE: target/i386/hvf-utils/x86_emu.c:1451:
+ printf("Unimplemented handler (%llx) for %d (%x %x) \n", RIP(cpu), ins->cmd, ins->opcode[0],
ERROR: unnecessary whitespace before a quoted newline
#6415: FILE: target/i386/hvf-utils/x86_emu.c:1451:
+ printf("Unimplemented handler (%llx) for %d (%x %x) \n", RIP(cpu), ins->cmd, ins->opcode[0],
ERROR: trailing whitespace
#6420: FILE: target/i386/hvf-utils/x86_emu.c:1456:
+ $
ERROR: line over 90 characters
#6421: FILE: target/i386/hvf-utils/x86_emu.c:1457:
+ VM_PANIC_ON_EX(!_cmd_handler[ins->cmd].handler, "Unimplemented handler (%llx) for %d (%x %x) \n", RIP(cpu), ins->cmd, ins->opcode[0], ins->opcode_len > 1 ? ins->opcode[1] : 0);
ERROR: unnecessary whitespace before a quoted newline
#6421: FILE: target/i386/hvf-utils/x86_emu.c:1457:
+ VM_PANIC_ON_EX(!_cmd_handler[ins->cmd].handler, "Unimplemented handler (%llx) for %d (%x %x) \n", RIP(cpu), ins->cmd, ins->opcode[0], ins->opcode_len > 1 ? ins->opcode[1] : 0);
WARNING: architecture specific defines should be avoided
#6437: FILE: target/i386/hvf-utils/x86_emu.h:1:
+#ifndef __X86_EMU_H__
ERROR: do not use C99 // comments
#6459: FILE: target/i386/hvf-utils/x86_flags.c:1:
+/////////////////////////////////////////////////////////////////////////
ERROR: do not use C99 // comments
#6460: FILE: target/i386/hvf-utils/x86_flags.c:2:
+//
ERROR: do not use C99 // comments
#6461: FILE: target/i386/hvf-utils/x86_flags.c:3:
+// Copyright (C) 2001-2012 The Bochs Project
ERROR: do not use C99 // comments
#6462: FILE: target/i386/hvf-utils/x86_flags.c:4:
+// Copyright (C) 2017 Google Inc.
ERROR: do not use C99 // comments
#6463: FILE: target/i386/hvf-utils/x86_flags.c:5:
+//
ERROR: do not use C99 // comments
#6464: FILE: target/i386/hvf-utils/x86_flags.c:6:
+// This library is free software; you can redistribute it and/or
ERROR: do not use C99 // comments
#6465: FILE: target/i386/hvf-utils/x86_flags.c:7:
+// modify it under the terms of the GNU Lesser General Public
ERROR: do not use C99 // comments
#6466: FILE: target/i386/hvf-utils/x86_flags.c:8:
+// License as published by the Free Software Foundation; either
ERROR: do not use C99 // comments
#6467: FILE: target/i386/hvf-utils/x86_flags.c:9:
+// version 2 of the License, or (at your option) any later version.
ERROR: do not use C99 // comments
#6468: FILE: target/i386/hvf-utils/x86_flags.c:10:
+//
ERROR: do not use C99 // comments
#6469: FILE: target/i386/hvf-utils/x86_flags.c:11:
+// This library is distributed in the hope that it will be useful,
ERROR: do not use C99 // comments
#6470: FILE: target/i386/hvf-utils/x86_flags.c:12:
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
ERROR: do not use C99 // comments
#6471: FILE: target/i386/hvf-utils/x86_flags.c:13:
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
ERROR: do not use C99 // comments
#6472: FILE: target/i386/hvf-utils/x86_flags.c:14:
+// Lesser General Public License for more details.
ERROR: do not use C99 // comments
#6473: FILE: target/i386/hvf-utils/x86_flags.c:15:
+//
ERROR: do not use C99 // comments
#6474: FILE: target/i386/hvf-utils/x86_flags.c:16:
+// You should have received a copy of the GNU Lesser General Public
ERROR: do not use C99 // comments
#6475: FILE: target/i386/hvf-utils/x86_flags.c:17:
+// License along with this library; if not, write to the Free Software
ERROR: do not use C99 // comments
#6476: FILE: target/i386/hvf-utils/x86_flags.c:18:
+// Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA B 02110-1301 USA
ERROR: do not use C99 // comments
#6477: FILE: target/i386/hvf-utils/x86_flags.c:19:
+/////////////////////////////////////////////////////////////////////////
WARNING: line over 80 characters
#6493: FILE: target/i386/hvf-utils/x86_flags.c:35:
+ cpu->hvf_x86->lflags.auxbits |= (temp_po << LF_BIT_PO) | (new_cf << LF_BIT_CF);
WARNING: line over 80 characters
#6496: FILE: target/i386/hvf-utils/x86_flags.c:38:
+void SET_FLAGS_OSZAPC_SUB32(struct CPUState *cpu, uint32_t v1, uint32_t v2, uint32_t diff)
WARNING: line over 80 characters
#6501: FILE: target/i386/hvf-utils/x86_flags.c:43:
+void SET_FLAGS_OSZAPC_SUB16(struct CPUState *cpu, uint16_t v1, uint16_t v2, uint16_t diff)
WARNING: line over 80 characters
#6506: FILE: target/i386/hvf-utils/x86_flags.c:48:
+void SET_FLAGS_OSZAPC_SUB8(struct CPUState *cpu, uint8_t v1, uint8_t v2, uint8_t diff)
WARNING: line over 80 characters
#6511: FILE: target/i386/hvf-utils/x86_flags.c:53:
+void SET_FLAGS_OSZAPC_ADD32(struct CPUState *cpu, uint32_t v1, uint32_t v2, uint32_t diff)
WARNING: line over 80 characters
#6516: FILE: target/i386/hvf-utils/x86_flags.c:58:
+void SET_FLAGS_OSZAPC_ADD16(struct CPUState *cpu, uint16_t v1, uint16_t v2, uint16_t diff)
WARNING: line over 80 characters
#6521: FILE: target/i386/hvf-utils/x86_flags.c:63:
+void SET_FLAGS_OSZAPC_ADD8(struct CPUState *cpu, uint8_t v1, uint8_t v2, uint8_t diff)
WARNING: line over 80 characters
#6526: FILE: target/i386/hvf-utils/x86_flags.c:68:
+void SET_FLAGS_OSZAP_SUB32(struct CPUState *cpu, uint32_t v1, uint32_t v2, uint32_t diff)
WARNING: line over 80 characters
#6531: FILE: target/i386/hvf-utils/x86_flags.c:73:
+void SET_FLAGS_OSZAP_SUB16(struct CPUState *cpu, uint16_t v1, uint16_t v2, uint16_t diff)
WARNING: line over 80 characters
#6536: FILE: target/i386/hvf-utils/x86_flags.c:78:
+void SET_FLAGS_OSZAP_SUB8(struct CPUState *cpu, uint8_t v1, uint8_t v2, uint8_t diff)
WARNING: line over 80 characters
#6541: FILE: target/i386/hvf-utils/x86_flags.c:83:
+void SET_FLAGS_OSZAP_ADD32(struct CPUState *cpu, uint32_t v1, uint32_t v2, uint32_t diff)
WARNING: line over 80 characters
#6546: FILE: target/i386/hvf-utils/x86_flags.c:88:
+void SET_FLAGS_OSZAP_ADD16(struct CPUState *cpu, uint16_t v1, uint16_t v2, uint16_t diff)
WARNING: line over 80 characters
#6551: FILE: target/i386/hvf-utils/x86_flags.c:93:
+void SET_FLAGS_OSZAP_ADD8(struct CPUState *cpu, uint8_t v1, uint8_t v2, uint8_t diff)
WARNING: line over 80 characters
#6678: FILE: target/i386/hvf-utils/x86_flags.c:220:
+ return ((cpu->hvf_x86->lflags.auxbits + (1U << LF_BIT_PO)) >> LF_BIT_CF) & 1;
ERROR: braces {} are necessary for all arms of this statement
#6724: FILE: target/i386/hvf-utils/x86_flags.c:266:
+ if (val) {
[...]
+ } else
[...]
ERROR: line over 90 characters
#6725: FILE: target/i386/hvf-utils/x86_flags.c:267:
+ cpu->hvf_x86->lflags.auxbits ^= (((cpu->hvf_x86->lflags.result >> LF_SIGN_BIT) & 1) << LF_BIT_SD);
ERROR: do not use C99 // comments
#6726: FILE: target/i386/hvf-utils/x86_flags.c:268:
+ // merge the parity bits into the Parity Delta Byte
ERROR: do not use C99 // comments
#6729: FILE: target/i386/hvf-utils/x86_flags.c:271:
+ // now zero the .result value
ERROR: line over 90 characters
#6737: FILE: target/i386/hvf-utils/x86_flags.c:279:
+ return ((cpu->hvf_x86->lflags.result >> LF_SIGN_BIT) ^ (cpu->hvf_x86->lflags.auxbits >> LF_BIT_SD)) & 1;
ERROR: do not use C99 // comments
#6782: FILE: target/i386/hvf-utils/x86_flags.h:1:
+/////////////////////////////////////////////////////////////////////////
ERROR: do not use C99 // comments
#6783: FILE: target/i386/hvf-utils/x86_flags.h:2:
+//
ERROR: do not use C99 // comments
#6784: FILE: target/i386/hvf-utils/x86_flags.h:3:
+// Copyright (C) 2001-2012 The Bochs Project
ERROR: do not use C99 // comments
#6785: FILE: target/i386/hvf-utils/x86_flags.h:4:
+// Copyright (C) 2017 Google Inc.
ERROR: do not use C99 // comments
#6786: FILE: target/i386/hvf-utils/x86_flags.h:5:
+//
ERROR: do not use C99 // comments
#6787: FILE: target/i386/hvf-utils/x86_flags.h:6:
+// This library is free software; you can redistribute it and/or
ERROR: do not use C99 // comments
#6788: FILE: target/i386/hvf-utils/x86_flags.h:7:
+// modify it under the terms of the GNU Lesser General Public
ERROR: do not use C99 // comments
#6789: FILE: target/i386/hvf-utils/x86_flags.h:8:
+// License as published by the Free Software Foundation; either
ERROR: do not use C99 // comments
#6790: FILE: target/i386/hvf-utils/x86_flags.h:9:
+// version 2 of the License, or (at your option) any later version.
ERROR: do not use C99 // comments
#6791: FILE: target/i386/hvf-utils/x86_flags.h:10:
+//
ERROR: do not use C99 // comments
#6792: FILE: target/i386/hvf-utils/x86_flags.h:11:
+// This library is distributed in the hope that it will be useful,
ERROR: do not use C99 // comments
#6793: FILE: target/i386/hvf-utils/x86_flags.h:12:
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
ERROR: do not use C99 // comments
#6794: FILE: target/i386/hvf-utils/x86_flags.h:13:
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
ERROR: do not use C99 // comments
#6795: FILE: target/i386/hvf-utils/x86_flags.h:14:
+// Lesser General Public License for more details.
ERROR: do not use C99 // comments
#6796: FILE: target/i386/hvf-utils/x86_flags.h:15:
+//
ERROR: do not use C99 // comments
#6797: FILE: target/i386/hvf-utils/x86_flags.h:16:
+// You should have received a copy of the GNU Lesser General Public
ERROR: do not use C99 // comments
#6798: FILE: target/i386/hvf-utils/x86_flags.h:17:
+// License along with this library; if not, write to the Free Software
ERROR: do not use C99 // comments
#6799: FILE: target/i386/hvf-utils/x86_flags.h:18:
+// Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA B 02110-1301 USA
ERROR: do not use C99 // comments
#6800: FILE: target/i386/hvf-utils/x86_flags.h:19:
+/////////////////////////////////////////////////////////////////////////
WARNING: architecture specific defines should be avoided
#6804: FILE: target/i386/hvf-utils/x86_flags.h:23:
+#ifndef __X86_FLAGS_H__
ERROR: do not use C99 // comments
#6839: FILE: target/i386/hvf-utils/x86_flags.h:58:
+// *******************
ERROR: do not use C99 // comments
#6840: FILE: target/i386/hvf-utils/x86_flags.h:59:
+// OSZAPC
ERROR: do not use C99 // comments
#6841: FILE: target/i386/hvf-utils/x86_flags.h:60:
+// *******************
ERROR: trailing statements should be on next line
#6848: FILE: target/i386/hvf-utils/x86_flags.h:67:
+ if ((size) == 32) temp = ((lf_carries) & ~(LF_MASK_PDB | LF_MASK_SD)); \
ERROR: braces {} are necessary for all arms of this statement
#6848: FILE: target/i386/hvf-utils/x86_flags.h:67:
+ if ((size) == 32) temp = ((lf_carries) & ~(LF_MASK_PDB | LF_MASK_SD)); \
[...]
WARNING: line over 80 characters
#6849: FILE: target/i386/hvf-utils/x86_flags.h:68:
+ else if ((size) == 16) temp = ((lf_carries) & (LF_MASK_AF)) | ((lf_carries) << 16); \
ERROR: trailing statements should be on next line
#6849: FILE: target/i386/hvf-utils/x86_flags.h:68:
+ else if ((size) == 16) temp = ((lf_carries) & (LF_MASK_AF)) | ((lf_carries) << 16); \
ERROR: braces {} are necessary for all arms of this statement
#6849: FILE: target/i386/hvf-utils/x86_flags.h:68:
+ else if ((size) == 16) temp = ((lf_carries) & (LF_MASK_AF)) | ((lf_carries) << 16); \
[...]
WARNING: line over 80 characters
#6850: FILE: target/i386/hvf-utils/x86_flags.h:69:
+ else if ((size) == 8) temp = ((lf_carries) & (LF_MASK_AF)) | ((lf_carries) << 24); \
ERROR: trailing statements should be on next line
#6850: FILE: target/i386/hvf-utils/x86_flags.h:69:
+ else if ((size) == 8) temp = ((lf_carries) & (LF_MASK_AF)) | ((lf_carries) << 24); \
ERROR: braces {} are necessary for all arms of this statement
#6850: FILE: target/i386/hvf-utils/x86_flags.h:69:
+ else if ((size) == 8) temp = ((lf_carries) & (LF_MASK_AF)) | ((lf_carries) << 24); \
[...]
WARNING: line over 80 characters
#6851: FILE: target/i386/hvf-utils/x86_flags.h:70:
+ else VM_PANIC("unimplemented"); \
ERROR: trailing statements should be on next line
#6851: FILE: target/i386/hvf-utils/x86_flags.h:70:
+ else VM_PANIC("unimplemented"); \
ERROR: braces {} are necessary even for single statement blocks
#6851: FILE: target/i386/hvf-utils/x86_flags.h:70:
+ else VM_PANIC("unimplemented"); \
ERROR: space required after that ';' (ctx:VxV)
#6871: FILE: target/i386/hvf-utils/x86_flags.h:90:
+ if (32 == size) {SET_FLAGS_OSZAPC_LOGIC_32(result);} \
^
ERROR: trailing statements should be on next line
#6871: FILE: target/i386/hvf-utils/x86_flags.h:90:
+ if (32 == size) {SET_FLAGS_OSZAPC_LOGIC_32(result);} \
ERROR: space required after that ';' (ctx:VxV)
#6872: FILE: target/i386/hvf-utils/x86_flags.h:91:
+ else if (16 == size) {SET_FLAGS_OSZAPC_LOGIC_16(result);} \
^
ERROR: trailing statements should be on next line
#6872: FILE: target/i386/hvf-utils/x86_flags.h:91:
+ else if (16 == size) {SET_FLAGS_OSZAPC_LOGIC_16(result);} \
ERROR: space required after that ';' (ctx:VxV)
#6873: FILE: target/i386/hvf-utils/x86_flags.h:92:
+ else if (8 == size) {SET_FLAGS_OSZAPC_LOGIC_8(result);} \
^
ERROR: trailing statements should be on next line
#6873: FILE: target/i386/hvf-utils/x86_flags.h:92:
+ else if (8 == size) {SET_FLAGS_OSZAPC_LOGIC_8(result);} \
ERROR: trailing statements should be on next line
#6874: FILE: target/i386/hvf-utils/x86_flags.h:93:
+ else VM_PANIC("unimplemented"); \
ERROR: braces {} are necessary even for single statement blocks
#6874: FILE: target/i386/hvf-utils/x86_flags.h:93:
+ else VM_PANIC("unimplemented"); \
ERROR: do not use C99 // comments
#6893: FILE: target/i386/hvf-utils/x86_flags.h:112:
+// *******************
ERROR: do not use C99 // comments
#6894: FILE: target/i386/hvf-utils/x86_flags.h:113:
+// OSZAP
ERROR: do not use C99 // comments
#6895: FILE: target/i386/hvf-utils/x86_flags.h:114:
+// *******************
ERROR: trailing statements should be on next line
#6900: FILE: target/i386/hvf-utils/x86_flags.h:119:
+ if ((size) == 32) temp = ((lf_carries) & ~(LF_MASK_PDB | LF_MASK_SD)); \
ERROR: braces {} are necessary for all arms of this statement
#6900: FILE: target/i386/hvf-utils/x86_flags.h:119:
+ if ((size) == 32) temp = ((lf_carries) & ~(LF_MASK_PDB | LF_MASK_SD)); \
[...]
WARNING: line over 80 characters
#6901: FILE: target/i386/hvf-utils/x86_flags.h:120:
+ else if ((size) == 16) temp = ((lf_carries) & (LF_MASK_AF)) | ((lf_carries) << 16); \
ERROR: trailing statements should be on next line
#6901: FILE: target/i386/hvf-utils/x86_flags.h:120:
+ else if ((size) == 16) temp = ((lf_carries) & (LF_MASK_AF)) | ((lf_carries) << 16); \
ERROR: braces {} are necessary for all arms of this statement
#6901: FILE: target/i386/hvf-utils/x86_flags.h:120:
+ else if ((size) == 16) temp = ((lf_carries) & (LF_MASK_AF)) | ((lf_carries) << 16); \
[...]
WARNING: line over 80 characters
#6902: FILE: target/i386/hvf-utils/x86_flags.h:121:
+ else if ((size) == 8) temp = ((lf_carries) & (LF_MASK_AF)) | ((lf_carries) << 24); \
ERROR: trailing statements should be on next line
#6902: FILE: target/i386/hvf-utils/x86_flags.h:121:
+ else if ((size) == 8) temp = ((lf_carries) & (LF_MASK_AF)) | ((lf_carries) << 24); \
ERROR: braces {} are necessary for all arms of this statement
#6902: FILE: target/i386/hvf-utils/x86_flags.h:121:
+ else if ((size) == 8) temp = ((lf_carries) & (LF_MASK_AF)) | ((lf_carries) << 24); \
[...]
WARNING: line over 80 characters
#6903: FILE: target/i386/hvf-utils/x86_flags.h:122:
+ else VM_PANIC("unimplemented"); \
ERROR: trailing statements should be on next line
#6903: FILE: target/i386/hvf-utils/x86_flags.h:122:
+ else VM_PANIC("unimplemented"); \
ERROR: braces {} are necessary even for single statement blocks
#6903: FILE: target/i386/hvf-utils/x86_flags.h:122:
+ else VM_PANIC("unimplemented"); \
ERROR: do not use C99 // comments
#6934: FILE: target/i386/hvf-utils/x86_flags.h:153:
+// *******************
ERROR: do not use C99 // comments
#6935: FILE: target/i386/hvf-utils/x86_flags.h:154:
+// OSZAxC
ERROR: do not use C99 // comments
#6936: FILE: target/i386/hvf-utils/x86_flags.h:155:
+// *******************
ERROR: line over 90 characters
#6967: FILE: target/i386/hvf-utils/x86_flags.h:186:
+void SET_FLAGS_OSZAPC_SUB32(struct CPUState *cpu, uint32_t v1, uint32_t v2, uint32_t diff);
ERROR: line over 90 characters
#6968: FILE: target/i386/hvf-utils/x86_flags.h:187:
+void SET_FLAGS_OSZAPC_SUB16(struct CPUState *cpu, uint16_t v1, uint16_t v2, uint16_t diff);
WARNING: line over 80 characters
#6969: FILE: target/i386/hvf-utils/x86_flags.h:188:
+void SET_FLAGS_OSZAPC_SUB8(struct CPUState *cpu, uint8_t v1, uint8_t v2, uint8_t diff);
ERROR: line over 90 characters
#6971: FILE: target/i386/hvf-utils/x86_flags.h:190:
+void SET_FLAGS_OSZAPC_ADD32(struct CPUState *cpu, uint32_t v1, uint32_t v2, uint32_t diff);
ERROR: line over 90 characters
#6972: FILE: target/i386/hvf-utils/x86_flags.h:191:
+void SET_FLAGS_OSZAPC_ADD16(struct CPUState *cpu, uint16_t v1, uint16_t v2, uint16_t diff);
WARNING: line over 80 characters
#6973: FILE: target/i386/hvf-utils/x86_flags.h:192:
+void SET_FLAGS_OSZAPC_ADD8(struct CPUState *cpu, uint8_t v1, uint8_t v2, uint8_t diff);
WARNING: line over 80 characters
#6975: FILE: target/i386/hvf-utils/x86_flags.h:194:
+void SET_FLAGS_OSZAP_SUB32(struct CPUState *cpu, uint32_t v1, uint32_t v2, uint32_t diff);
WARNING: line over 80 characters
#6976: FILE: target/i386/hvf-utils/x86_flags.h:195:
+void SET_FLAGS_OSZAP_SUB16(struct CPUState *cpu, uint16_t v1, uint16_t v2, uint16_t diff);
WARNING: line over 80 characters
#6977: FILE: target/i386/hvf-utils/x86_flags.h:196:
+void SET_FLAGS_OSZAP_SUB8(struct CPUState *cpu, uint8_t v1, uint8_t v2, uint8_t diff);
WARNING: line over 80 characters
#6979: FILE: target/i386/hvf-utils/x86_flags.h:198:
+void SET_FLAGS_OSZAP_ADD32(struct CPUState *cpu, uint32_t v1, uint32_t v2, uint32_t diff);
WARNING: line over 80 characters
#6980: FILE: target/i386/hvf-utils/x86_flags.h:199:
+void SET_FLAGS_OSZAP_ADD16(struct CPUState *cpu, uint16_t v1, uint16_t v2, uint16_t diff);
WARNING: line over 80 characters
#6981: FILE: target/i386/hvf-utils/x86_flags.h:200:
+void SET_FLAGS_OSZAP_ADD8(struct CPUState *cpu, uint8_t v1, uint8_t v2, uint8_t diff);
WARNING: architecture specific defines should be avoided
#7006: FILE: target/i386/hvf-utils/x86_gen.h:1:
+#ifndef __X86_GEN_H__
ERROR: braces {} are necessary for all arms of this statement
#7104: FILE: target/i386/hvf-utils/x86_mmu.c:57:
+ if (!pae)
[...]
ERROR: braces {} are necessary for all arms of this statement
#7106: FILE: target/i386/hvf-utils/x86_mmu.c:59:
+ if (x86_is_long_mode(cpu))
[...]
WARNING: line over 80 characters
#7115: FILE: target/i386/hvf-utils/x86_mmu.c:68:
+ return (addr >> (level_shift * (level - 1) + 12)) & ((1 << level_shift) - 1);
ERROR: line over 90 characters
#7124: FILE: target/i386/hvf-utils/x86_mmu.c:77:
+static bool get_pt_entry(struct CPUState *cpu, struct gpt_translation *pt, int level, bool pae)
ERROR: braces {} are necessary for all arms of this statement
#7131: FILE: target/i386/hvf-utils/x86_mmu.c:84:
+ if (level == 3 && !x86_is_long_mode(cpu))
[...]
ERROR: line over 90 characters
#7135: FILE: target/i386/hvf-utils/x86_mmu.c:88:
+ address_space_rw(&address_space_memory, gpa + index * pte_size(pae), MEMTXATTRS_UNSPECIFIED, (uint8_t *)&pte, pte_size(pae), 0);
ERROR: line over 90 characters
#7143: FILE: target/i386/hvf-utils/x86_mmu.c:96:
+static bool test_pt_entry(struct CPUState *cpu, struct gpt_translation *pt, int level, bool *is_large, bool pae)
ERROR: trailing whitespace
#7146: FILE: target/i386/hvf-utils/x86_mmu.c:99:
+ $
ERROR: braces {} are necessary for all arms of this statement
#7147: FILE: target/i386/hvf-utils/x86_mmu.c:100:
+ if (pt->write_access)
[...]
ERROR: braces {} are necessary for all arms of this statement
#7149: FILE: target/i386/hvf-utils/x86_mmu.c:102:
+ if (pt->user_access)
[...]
ERROR: braces {} are necessary for all arms of this statement
#7151: FILE: target/i386/hvf-utils/x86_mmu.c:104:
+ if (pt->exec_access)
[...]
ERROR: trailing whitespace
#7158: FILE: target/i386/hvf-utils/x86_mmu.c:111:
+ $
ERROR: braces {} are necessary for all arms of this statement
#7159: FILE: target/i386/hvf-utils/x86_mmu.c:112:
+ if (pae && !x86_is_long_mode(cpu) && 2 == level)
[...]
ERROR: trailing whitespace
#7161: FILE: target/i386/hvf-utils/x86_mmu.c:114:
+ $
ERROR: braces {} are necessary for all arms of this statement
#7166: FILE: target/i386/hvf-utils/x86_mmu.c:119:
+ if (!level)
[...]
ERROR: trailing whitespace
#7168: FILE: target/i386/hvf-utils/x86_mmu.c:121:
+ $
ERROR: trailing whitespace
#7184: FILE: target/i386/hvf-utils/x86_mmu.c:137:
+ $
ERROR: braces {} are necessary for all arms of this statement
#7199: FILE: target/i386/hvf-utils/x86_mmu.c:152:
+ if (pae)
[...]
ERROR: trailing whitespace
#7201: FILE: target/i386/hvf-utils/x86_mmu.c:154:
+ $
ERROR: line over 90 characters
#7208: FILE: target/i386/hvf-utils/x86_mmu.c:161:
+static bool walk_gpt(struct CPUState *cpu, addr_t addr, int err_code, struct gpt_translation* pt, bool pae)
ERROR: trailing whitespace
#7214: FILE: target/i386/hvf-utils/x86_mmu.c:167:
+ $
ERROR: trailing whitespace
#7223: FILE: target/i386/hvf-utils/x86_mmu.c:176:
+ $
ERROR: braces {} are necessary for all arms of this statement
#7231: FILE: target/i386/hvf-utils/x86_mmu.c:184:
+ if (is_large)
[...]
ERROR: braces {} are necessary for all arms of this statement
#7235: FILE: target/i386/hvf-utils/x86_mmu.c:188:
+ if (!is_large)
[...]
+ else
[...]
ERROR: "foo* bar" should be "foo *bar"
#7264: FILE: target/i386/hvf-utils/x86_mmu.c:217:
+void vmx_write_mem(struct CPUState* cpu, addr_t gva, void *data, int bytes)
ERROR: do not use C99 // comments
#7269: FILE: target/i386/hvf-utils/x86_mmu.c:222:
+ // copy page
WARNING: line over 80 characters
#7273: FILE: target/i386/hvf-utils/x86_mmu.c:226:
+ VM_PANIC_ON_EX(1, "%s: mmu_gva_to_gpa %llx failed\n", __FUNCTION__, gva);
ERROR: __func__ should be used instead of gcc specific __FUNCTION__
#7273: FILE: target/i386/hvf-utils/x86_mmu.c:226:
+ VM_PANIC_ON_EX(1, "%s: mmu_gva_to_gpa %llx failed\n", __FUNCTION__, gva);
ERROR: line over 90 characters
#7275: FILE: target/i386/hvf-utils/x86_mmu.c:228:
+ address_space_rw(&address_space_memory, gpa, MEMTXATTRS_UNSPECIFIED, data, copy, 1);
ERROR: "foo* bar" should be "foo *bar"
#7284: FILE: target/i386/hvf-utils/x86_mmu.c:237:
+void vmx_read_mem(struct CPUState* cpu, void *data, addr_t gva, int bytes)
ERROR: do not use C99 // comments
#7289: FILE: target/i386/hvf-utils/x86_mmu.c:242:
+ // copy page
WARNING: line over 80 characters
#7293: FILE: target/i386/hvf-utils/x86_mmu.c:246:
+ VM_PANIC_ON_EX(1, "%s: mmu_gva_to_gpa %llx failed\n", __FUNCTION__, gva);
ERROR: __func__ should be used instead of gcc specific __FUNCTION__
#7293: FILE: target/i386/hvf-utils/x86_mmu.c:246:
+ VM_PANIC_ON_EX(1, "%s: mmu_gva_to_gpa %llx failed\n", __FUNCTION__, gva);
ERROR: line over 90 characters
#7295: FILE: target/i386/hvf-utils/x86_mmu.c:248:
+ address_space_rw(&address_space_memory, gpa, MEMTXATTRS_UNSPECIFIED, data, copy, 0);
WARNING: architecture specific defines should be avoided
#7308: FILE: target/i386/hvf-utils/x86_mmu.h:1:
+#ifndef __X86_MMU_H__
ERROR: do not use C99 // comments
#7324: FILE: target/i386/hvf-utils/x86_mmu.h:17:
+// error codes
ERROR: "foo* bar" should be "foo *bar"
#7332: FILE: target/i386/hvf-utils/x86_mmu.h:25:
+void vmx_write_mem(struct CPUState* cpu, addr_t gva, void *data, int bytes);
ERROR: "foo* bar" should be "foo *bar"
#7333: FILE: target/i386/hvf-utils/x86_mmu.h:26:
+void vmx_read_mem(struct CPUState* cpu, void *data, addr_t gva, int bytes);
ERROR: "foo* bar" should be "foo *bar"
#7379: FILE: target/i386/hvf-utils/x86hvf.c:38:
+void hvf_cpu_synchronize_state(struct CPUState* cpu_state);
ERROR: externs should be avoided in .c files
#7379: FILE: target/i386/hvf-utils/x86hvf.c:38:
+void hvf_cpu_synchronize_state(struct CPUState* cpu_state);
ERROR: line over 90 characters
#7381: FILE: target/i386/hvf-utils/x86hvf.c:40:
+void hvf_set_segment(struct CPUState *cpu, struct vmx_segment *vmx_seg, SegmentCache *qseg, bool is_tr)
WARNING: line over 80 characters
#7388: FILE: target/i386/hvf-utils/x86hvf.c:47:
+ // the TR register is usable after processor reset despite having a null selector
ERROR: do not use C99 // comments
#7388: FILE: target/i386/hvf-utils/x86hvf.c:47:
+ // the TR register is usable after processor reset despite having a null selector
ERROR: trailing whitespace
#7422: FILE: target/i386/hvf-utils/x86hvf.c:81:
+ $
ERROR: trailing whitespace
#7424: FILE: target/i386/hvf-utils/x86hvf.c:83:
+ memset(xsave, 0, sizeof(*xsave)); $
ERROR: trailing whitespace
#7425: FILE: target/i386/hvf-utils/x86hvf.c:84:
+ $
ERROR: line over 90 characters
#7426: FILE: target/i386/hvf-utils/x86hvf.c:85:
+ memcpy(&xsave->data[4], &X86_CPU(cpu_state)->env.fpdp, sizeof(X86_CPU(cpu_state)->env.fpdp));
ERROR: line over 90 characters
#7427: FILE: target/i386/hvf-utils/x86hvf.c:86:
+ memcpy(&xsave->data[2], &X86_CPU(cpu_state)->env.fpip, sizeof(X86_CPU(cpu_state)->env.fpip));
ERROR: line over 90 characters
#7428: FILE: target/i386/hvf-utils/x86hvf.c:87:
+ memcpy(&xsave->data[8], &X86_CPU(cpu_state)->env.fpregs, sizeof(X86_CPU(cpu_state)->env.fpregs));
ERROR: line over 90 characters
#7429: FILE: target/i386/hvf-utils/x86hvf.c:88:
+ memcpy(&xsave->data[144], &X86_CPU(cpu_state)->env.ymmh_regs, sizeof(X86_CPU(cpu_state)->env.ymmh_regs));
ERROR: line over 90 characters
#7430: FILE: target/i386/hvf-utils/x86hvf.c:89:
+ memcpy(&xsave->data[288], &X86_CPU(cpu_state)->env.zmmh_regs, sizeof(X86_CPU(cpu_state)->env.zmmh_regs));
ERROR: line over 90 characters
#7431: FILE: target/i386/hvf-utils/x86hvf.c:90:
+ memcpy(&xsave->data[272], &X86_CPU(cpu_state)->env.opmask_regs, sizeof(X86_CPU(cpu_state)->env.opmask_regs));
ERROR: line over 90 characters
#7432: FILE: target/i386/hvf-utils/x86hvf.c:91:
+ memcpy(&xsave->data[240], &X86_CPU(cpu_state)->env.bnd_regs, sizeof(X86_CPU(cpu_state)->env.bnd_regs));
ERROR: line over 90 characters
#7433: FILE: target/i386/hvf-utils/x86hvf.c:92:
+ memcpy(&xsave->data[256], &X86_CPU(cpu_state)->env.bndcs_regs, sizeof(X86_CPU(cpu_state)->env.bndcs_regs));
ERROR: line over 90 characters
#7434: FILE: target/i386/hvf-utils/x86hvf.c:93:
+ memcpy(&xsave->data[416], &X86_CPU(cpu_state)->env.hi16_zmm_regs, sizeof(X86_CPU(cpu_state)->env.hi16_zmm_regs));
ERROR: trailing whitespace
#7435: FILE: target/i386/hvf-utils/x86hvf.c:94:
+ $
ERROR: trailing whitespace
#7439: FILE: target/i386/hvf-utils/x86hvf.c:98:
+ $
ERROR: braces {} are necessary even for single statement blocks
#7440: FILE: target/i386/hvf-utils/x86hvf.c:99:
+ for (x = 0; x < 8; ++x)
+ xsave->data[1] |= ((!X86_CPU(cpu_state)->env.fptags[x]) << x);
ERROR: trailing whitespace
#7443: FILE: target/i386/hvf-utils/x86hvf.c:102:
+ $
ERROR: line over 90 characters
#7444: FILE: target/i386/hvf-utils/x86hvf.c:103:
+ memcpy(&xsave->data[40], &X86_CPU(cpu_state)->env.xmm_regs, sizeof(X86_CPU(cpu_state)->env.xmm_regs));
ERROR: trailing whitespace
#7445: FILE: target/i386/hvf-utils/x86hvf.c:104:
+ $
ERROR: trailing whitespace
#7448: FILE: target/i386/hvf-utils/x86hvf.c:107:
+ $
ERROR: space required before the open brace '{'
#7449: FILE: target/i386/hvf-utils/x86hvf.c:108:
+ if (hv_vcpu_write_fpstate(cpu_state->hvf_fd, xsave->data, 4096)){
ERROR: externs should be avoided in .c files
#7454: FILE: target/i386/hvf-utils/x86hvf.c:113:
+void vmx_update_tpr(CPUState *cpu);
ERROR: trailing whitespace
#7459: FILE: target/i386/hvf-utils/x86hvf.c:118:
+ $
ERROR: do not use C99 // comments
#7466: FILE: target/i386/hvf-utils/x86hvf.c:125:
+ //wvmcs(cpu_state->hvf_fd, VMCS_GUEST_CR2, env->cr[2]);
ERROR: trailing whitespace
#7476: FILE: target/i386/hvf-utils/x86hvf.c:135:
+ $
ERROR: trailing whitespace
#7497: FILE: target/i386/hvf-utils/x86hvf.c:156:
+ $
ERROR: trailing whitespace
#7500: FILE: target/i386/hvf-utils/x86hvf.c:159:
+ $
WARNING: line over 80 characters
#7505: FILE: target/i386/hvf-utils/x86hvf.c:164:
+ hv_vcpu_write_msr(cpu_state->hvf_fd, MSR_IA32_SYSENTER_CS, env->sysenter_cs);
WARNING: line over 80 characters
#7506: FILE: target/i386/hvf-utils/x86hvf.c:165:
+ hv_vcpu_write_msr(cpu_state->hvf_fd, MSR_IA32_SYSENTER_ESP, env->sysenter_esp);
WARNING: line over 80 characters
#7507: FILE: target/i386/hvf-utils/x86hvf.c:166:
+ hv_vcpu_write_msr(cpu_state->hvf_fd, MSR_IA32_SYSENTER_EIP, env->sysenter_eip);
ERROR: do not use C99 // comments
#7521: FILE: target/i386/hvf-utils/x86hvf.c:180:
+ // if (!osx_is_sierra())
ERROR: do not use C99 // comments
#7522: FILE: target/i386/hvf-utils/x86hvf.c:181:
+ // wvmcs(cpu_state->hvf_fd, VMCS_TSC_OFFSET, env->tsc - rdtscp());
ERROR: trailing whitespace
#7531: FILE: target/i386/hvf-utils/x86hvf.c:190:
+ $
ERROR: trailing whitespace
#7533: FILE: target/i386/hvf-utils/x86hvf.c:192:
+ $
ERROR: line over 90 characters
#7538: FILE: target/i386/hvf-utils/x86hvf.c:197:
+ memcpy(&X86_CPU(cpu_state)->env.fpdp, &xsave->data[4], sizeof(X86_CPU(cpu_state)->env.fpdp));
ERROR: line over 90 characters
#7539: FILE: target/i386/hvf-utils/x86hvf.c:198:
+ memcpy(&X86_CPU(cpu_state)->env.fpip, &xsave->data[2], sizeof(X86_CPU(cpu_state)->env.fpip));
ERROR: line over 90 characters
#7540: FILE: target/i386/hvf-utils/x86hvf.c:199:
+ memcpy(&X86_CPU(cpu_state)->env.fpregs, &xsave->data[8], sizeof(X86_CPU(cpu_state)->env.fpregs));
ERROR: line over 90 characters
#7541: FILE: target/i386/hvf-utils/x86hvf.c:200:
+ memcpy(&X86_CPU(cpu_state)->env.ymmh_regs, &xsave->data[144], sizeof(X86_CPU(cpu_state)->env.ymmh_regs));
ERROR: line over 90 characters
#7542: FILE: target/i386/hvf-utils/x86hvf.c:201:
+ memcpy(&X86_CPU(cpu_state)->env.zmmh_regs, &xsave->data[288], sizeof(X86_CPU(cpu_state)->env.zmmh_regs));
ERROR: line over 90 characters
#7543: FILE: target/i386/hvf-utils/x86hvf.c:202:
+ memcpy(&X86_CPU(cpu_state)->env.opmask_regs, &xsave->data[272], sizeof(X86_CPU(cpu_state)->env.opmask_regs));
ERROR: line over 90 characters
#7544: FILE: target/i386/hvf-utils/x86hvf.c:203:
+ memcpy(&X86_CPU(cpu_state)->env.bnd_regs, &xsave->data[240], sizeof(X86_CPU(cpu_state)->env.bnd_regs));
ERROR: line over 90 characters
#7545: FILE: target/i386/hvf-utils/x86hvf.c:204:
+ memcpy(&X86_CPU(cpu_state)->env.bndcs_regs, &xsave->data[256], sizeof(X86_CPU(cpu_state)->env.bndcs_regs));
ERROR: line over 90 characters
#7546: FILE: target/i386/hvf-utils/x86hvf.c:205:
+ memcpy(&X86_CPU(cpu_state)->env.hi16_zmm_regs, &xsave->data[416], sizeof(X86_CPU(cpu_state)->env.hi16_zmm_regs));
ERROR: trailing whitespace
#7547: FILE: target/i386/hvf-utils/x86hvf.c:206:
+ $
ERROR: trailing whitespace
#7548: FILE: target/i386/hvf-utils/x86hvf.c:207:
+ $
ERROR: trailing whitespace
#7553: FILE: target/i386/hvf-utils/x86hvf.c:212:
+ $
ERROR: suspect code indent for conditional statements (4, 7)
#7554: FILE: target/i386/hvf-utils/x86hvf.c:213:
+ for (x = 0; x < 8; ++x)
+ X86_CPU(cpu_state)->env.fptags[x] =
ERROR: trailing whitespace
#7557: FILE: target/i386/hvf-utils/x86hvf.c:216:
+ $
ERROR: line over 90 characters
#7558: FILE: target/i386/hvf-utils/x86hvf.c:217:
+ memcpy(&X86_CPU(cpu_state)->env.xmm_regs, &xsave->data[40], sizeof(X86_CPU(cpu_state)->env.xmm_regs));
ERROR: trailing whitespace
#7574: FILE: target/i386/hvf-utils/x86hvf.c:233:
+ $
ERROR: trailing whitespace
#7605: FILE: target/i386/hvf-utils/x86hvf.c:264:
+ $
ERROR: trailing whitespace
#7613: FILE: target/i386/hvf-utils/x86hvf.c:272:
+ $
ERROR: trailing whitespace
#7616: FILE: target/i386/hvf-utils/x86hvf.c:275:
+ $
ERROR: trailing whitespace
#7633: FILE: target/i386/hvf-utils/x86hvf.c:292:
+ $
ERROR: trailing whitespace
#7660: FILE: target/i386/hvf-utils/x86hvf.c:319:
+ $
ERROR: trailing whitespace
#7662: FILE: target/i386/hvf-utils/x86hvf.c:321:
+ $
ERROR: trailing whitespace
#7664: FILE: target/i386/hvf-utils/x86hvf.c:323:
+ $
ERROR: trailing whitespace
#7666: FILE: target/i386/hvf-utils/x86hvf.c:325:
+ $
ERROR: trailing whitespace
#7668: FILE: target/i386/hvf-utils/x86hvf.c:327:
+ $
ERROR: trailing whitespace
#7677: FILE: target/i386/hvf-utils/x86hvf.c:336:
+ $
ERROR: trailing whitespace
#7703: FILE: target/i386/hvf-utils/x86hvf.c:362:
+ $
ERROR: trailing whitespace
#7706: FILE: target/i386/hvf-utils/x86hvf.c:365:
+ $
ERROR: trailing whitespace
#7709: FILE: target/i386/hvf-utils/x86hvf.c:368:
+ $
ERROR: trailing whitespace
#7712: FILE: target/i386/hvf-utils/x86hvf.c:371:
+ $
ERROR: trailing whitespace
#7721: FILE: target/i386/hvf-utils/x86hvf.c:380:
+ $
ERROR: line over 90 characters
#7729: FILE: target/i386/hvf-utils/x86hvf.c:388:
+ wvmcs(cpu->hvf_fd, VMCS_PRI_PROC_BASED_CTLS, val | VMCS_PRI_PROC_BASED_CTLS_INT_WINDOW_EXITING);
ERROR: line over 90 characters
#7736: FILE: target/i386/hvf-utils/x86hvf.c:395:
+ wvmcs(cpu->hvf_fd, VMCS_PRI_PROC_BASED_CTLS, val & ~VMCS_PRI_PROC_BASED_CTLS_INT_WINDOW_EXITING);
ERROR: line over 90 characters
#7744: FILE: target/i386/hvf-utils/x86hvf.c:403:
+ int allow_nmi = !(rvmcs(cpu_state->hvf_fd, VMCS_GUEST_INTERRUPTIBILITY) & VMCS_INTERRUPTIBILITY_NMI_BLOCKING);
ERROR: trailing whitespace
#7748: FILE: target/i386/hvf-utils/x86hvf.c:407:
+ $
ERROR: trailing whitespace
#7753: FILE: target/i386/hvf-utils/x86hvf.c:412:
+ $
ERROR: trailing whitespace
#7759: FILE: target/i386/hvf-utils/x86hvf.c:418:
+ $
WARNING: line over 80 characters
#7765: FILE: target/i386/hvf-utils/x86hvf.c:424:
+ uint64_t ins_len = rvmcs(cpu_state->hvf_fd, VMCS_EXIT_INSTRUCTION_LENGTH);
WARNING: line over 80 characters
#7775: FILE: target/i386/hvf-utils/x86hvf.c:434:
+ uint64_t ins_len = rvmcs(cpu_state->hvf_fd, VMCS_EXIT_INSTRUCTION_LENGTH);
ERROR: trailing whitespace
#7778: FILE: target/i386/hvf-utils/x86hvf.c:437:
+ $
ERROR: do not use C99 // comments
#7784: FILE: target/i386/hvf-utils/x86hvf.c:443:
+ //printf("reinject %lx err %d\n", info, err);
ERROR: line over 90 characters
#7799: FILE: target/i386/hvf-utils/x86hvf.c:458:
+ if (cpu_state->hvf_x86->interruptable && (cpu_state->interrupt_request & CPU_INTERRUPT_HARD) &&
ERROR: braces {} are necessary for all arms of this statement
#7803: FILE: target/i386/hvf-utils/x86hvf.c:462:
+ if (line >= 0)
[...]
ERROR: line over 90 characters
#7804: FILE: target/i386/hvf-utils/x86hvf.c:463:
+ wvmcs(cpu_state->hvf_fd, VMCS_ENTRY_INTR_INFO, line | VMCS_INTR_VALID | VMCS_INTR_T_HWINTR);
ERROR: braces {} are necessary for all arms of this statement
#7806: FILE: target/i386/hvf-utils/x86hvf.c:465:
+ if (cpu_state->interrupt_request & CPU_INTERRUPT_HARD)
[...]
ERROR: trailing whitespace
#7814: FILE: target/i386/hvf-utils/x86hvf.c:473:
+ $
ERROR: line over 90 characters
#7826: FILE: target/i386/hvf-utils/x86hvf.c:485:
+ if (((cpu_state->interrupt_request & CPU_INTERRUPT_HARD) && (EFLAGS(cpu_state) & IF_MASK)) ||
ERROR: line over 90 characters
#7858: FILE: target/i386/hvf-utils/x86hvf.h:10:
+void hvf_set_segment(struct CPUState *cpu, struct vmx_segment *vmx_seg, SegmentCache *qseg, bool is_tr);
total: 1560 errors, 156 warnings, 7707 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 3/14: hvf: add conditional macros around hvf code in cpus.c...
Checking PATCH 4/14: hvf: add fields to CPUState and CPUX86State; add definitions...
ERROR: do not use C99 // comments
#21: FILE: include/qom/cpu.h:411:
+ // HVF
ERROR: do not use C99 // comments
#23: FILE: include/qom/cpu.h:413:
+ uint64_t hvf_fd; // fd of vcpu created by HVF
ERROR: do not use C99 // comments
#24: FILE: include/qom/cpu.h:414:
+ // Supporting data structures for VMCS capabilities
ERROR: do not use C99 // comments
#25: FILE: include/qom/cpu.h:415:
+ // and x86 emulation state
ERROR: "foo* bar" should be "foo *bar"
#26: FILE: include/qom/cpu.h:416:
+ struct hvf_vcpu_caps* hvf_caps;
ERROR: "foo* bar" should be "foo *bar"
#27: FILE: include/qom/cpu.h:417:
+ struct hvf_x86_state* hvf_x86;
total: 6 errors, 0 warnings, 71 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 5/14: hvf: use new helper functions for put/get xsave...
Checking PATCH 6/14: hvf: add compilation rules to Makefile.objs...
WARNING: architecture specific defines should be avoided
#32: FILE: vl.c:3754:
+#if defined(__APPLE__)
total: 0 errors, 1 warnings, 18 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 7/14: hvf: run hvf code through checkpatch.pl and fix style issues...
Argument "m" isn't numeric in numeric eq (==) at ./scripts/checkpatch.pl line 2479.
Argument "m" isn't numeric in numeric eq (==) at ./scripts/checkpatch.pl line 2479.
Use of uninitialized value $1 in concatenation (.) or string at ./scripts/checkpatch.pl line 2480.
Argument "m" isn't numeric in numeric eq (==) at ./scripts/checkpatch.pl line 2479.
Use of uninitialized value $1 in concatenation (.) or string at ./scripts/checkpatch.pl line 2480.
ERROR: space required before the open brace '{'
#291: FILE: target/i386/hvf-all.c:247:
+ vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->ldt}},
ERROR: space required after that close brace '}'
#291: FILE: target/i386/hvf-all.c:247:
+ vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->ldt}},
ERROR: space required before the open brace '{'
#293: FILE: target/i386/hvf-all.c:249:
+ vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->es}},
ERROR: space required after that close brace '}'
#293: FILE: target/i386/hvf-all.c:249:
+ vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->es}},
ERROR: space required before the open brace '{'
#295: FILE: target/i386/hvf-all.c:251:
+ vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->cs}},
ERROR: space required after that close brace '}'
#295: FILE: target/i386/hvf-all.c:251:
+ vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->cs}},
ERROR: space required before the open brace '{'
#297: FILE: target/i386/hvf-all.c:253:
+ vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->ss}},
ERROR: space required after that close brace '}'
#297: FILE: target/i386/hvf-all.c:253:
+ vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->ss}},
ERROR: space required before the open brace '{'
#299: FILE: target/i386/hvf-all.c:255:
+ vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->ds}},
ERROR: space required after that close brace '}'
#299: FILE: target/i386/hvf-all.c:255:
+ vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->ds}},
ERROR: space required before the open brace '{'
#301: FILE: target/i386/hvf-all.c:257:
+ vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->fs}},
ERROR: space required after that close brace '}'
#301: FILE: target/i386/hvf-all.c:257:
+ vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->fs}},
ERROR: space required before the open brace '{'
#303: FILE: target/i386/hvf-all.c:259:
+ vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->gs}},
ERROR: space required after that close brace '}'
#303: FILE: target/i386/hvf-all.c:259:
+ vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->gs}},
WARNING: line over 80 characters
#448: FILE: target/i386/hvf-all.c:420:
+static void do_hvf_cpu_synchronize_post_reset(CPUState *cpu, run_on_cpu_data arg)
ERROR: trailing whitespace
#554: FILE: target/i386/hvf-all.c:500:
+ $
ERROR: trailing whitespace
#560: FILE: target/i386/hvf-all.c:504:
+ $
ERROR: trailing whitespace
#567: FILE: target/i386/hvf-all.c:510:
+ $
ERROR: trailing whitespace
#573: FILE: target/i386/hvf-all.c:515:
+ $
ERROR: trailing whitespace
#579: FILE: target/i386/hvf-all.c:520:
+ $
ERROR: trailing whitespace
#585: FILE: target/i386/hvf-all.c:525:
+ $
ERROR: trailing whitespace
#591: FILE: target/i386/hvf-all.c:530:
+ $
ERROR: trailing whitespace
#597: FILE: target/i386/hvf-all.c:535:
+ $
ERROR: trailing whitespace
#603: FILE: target/i386/hvf-all.c:540:
+ $
ERROR: trailing whitespace
#609: FILE: target/i386/hvf-all.c:545:
+ $
ERROR: trailing whitespace
#613: FILE: target/i386/hvf-all.c:548:
+ $
ERROR: trailing whitespace
#618: FILE: target/i386/hvf-all.c:551:
+ $
ERROR: trailing whitespace
#622: FILE: target/i386/hvf-all.c:554:
+ $
ERROR: trailing whitespace
#633: FILE: target/i386/hvf-all.c:565:
+ $
WARNING: line over 80 characters
#671: FILE: target/i386/hvf-all.c:607:
+ cpu->hvf_caps = (struct hvf_vcpu_caps *)g_malloc0(sizeof(struct hvf_vcpu_caps));
ERROR: unnecessary cast may hide bugs, use g_new0 instead
#671: FILE: target/i386/hvf-all.c:607:
+ cpu->hvf_caps = (struct hvf_vcpu_caps *)g_malloc0(sizeof(struct hvf_vcpu_caps));
WARNING: line over 80 characters
#672: FILE: target/i386/hvf-all.c:608:
+ cpu->hvf_x86 = (struct hvf_x86_state *)g_malloc0(sizeof(struct hvf_x86_state));
ERROR: unnecessary cast may hide bugs, use g_new0 instead
#672: FILE: target/i386/hvf-all.c:608:
+ cpu->hvf_x86 = (struct hvf_x86_state *)g_malloc0(sizeof(struct hvf_x86_state));
WARNING: line over 80 characters
#2448: FILE: target/i386/hvf-utils/x86.h:468:
+ "shl $32,%%rdx; " /* shift higher 32 bits stored in rdx up */
ERROR: externs should be avoided in .c files
#5918: FILE: target/i386/hvf-utils/x86_emu.c:48:
+void hvf_handle_io(struct CPUState *cpu, uint16_t port, void *data,
ERROR: unnecessary whitespace before a quoted newline
#7707: FILE: target/i386/hvf-utils/x86_emu.c:1512:
+ printf("Unimplemented handler (%llx) for %d (%x %x) \n", RIP(cpu),
ERROR: unnecessary whitespace before a quoted newline
#7717: FILE: target/i386/hvf-utils/x86_emu.c:1520:
+ "Unimplemented handler (%llx) for %d (%x %x) \n", RIP(cpu),
total: 33 errors, 4 warnings, 8321 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 8/14: apic: add function to apic that will be used by hvf...
Checking PATCH 9/14: hvf: implement hvf_get_supported_cpuid...
ERROR: return is not a function, parentheses are not required
#46: FILE: target/i386/hvf-utils/x86_cpuid.c:116:
+ return ((cap_exit & (1 << 23)) && (cap_entry & (1 << 16)));
WARNING: line over 80 characters
#142: FILE: target/i386/hvf-utils/x86_cpuid.c:388:
+ CPUID_EXT2_SYSCALL | CPUID_MTRR | CPUID_PGE | CPUID_MCA | CPUID_CMOV |
WARNING: line over 80 characters
#144: FILE: target/i386/hvf-utils/x86_cpuid.c:390:
+ CPUID_FXSR | CPUID_EXT2_FXSR | CPUID_EXT2_PDPE1GB | CPUID_EXT2_3DNOWEXT |
WARNING: line over 80 characters
#145: FILE: target/i386/hvf-utils/x86_cpuid.c:391:
+ CPUID_EXT2_3DNOW | CPUID_EXT2_LM | CPUID_EXT2_RDTSCP | CPUID_EXT2_NX;
total: 1 errors, 3 warnings, 153 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 10/14: hvf: refactor cpuid code...
Argument "m" isn't numeric in numeric eq (==) at ./scripts/checkpatch.pl line 2479.
Argument "m" isn't numeric in numeric eq (==) at ./scripts/checkpatch.pl line 2479.
Use of uninitialized value $1 in concatenation (.) or string at ./scripts/checkpatch.pl line 2480.
ERROR: trailing whitespace
#218: FILE: target/i386/cpu.c:1742:
+ } $
WARNING: line over 80 characters
#367: FILE: target/i386/hvf-all.c:607:
+ hvf_state->hvf_caps = (struct hvf_vcpu_caps *)g_malloc0(sizeof(struct hvf_vcpu_caps));
ERROR: unnecessary cast may hide bugs, use g_new0 instead
#367: FILE: target/i386/hvf-all.c:607:
+ hvf_state->hvf_caps = (struct hvf_vcpu_caps *)g_malloc0(sizeof(struct hvf_vcpu_caps));
WARNING: line over 80 characters
#413: FILE: target/i386/hvf-all.c:645:
+ wvmcs(cpu->hvf_fd, VMCS_ENTRY_CTLS, cap2ctrl(hvf_state->hvf_caps->vmx_cap_entry,
total: 2 errors, 2 warnings, 361 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 11/14: hvf: implement vga dirty page tracking...
ERROR: braces {} are necessary for all arms of this statement
#104: FILE: target/i386/hvf-all.c:507:
+ if (old != 0)
[...]
ERROR: braces {} are necessary for all arms of this statement
#113: FILE: target/i386/hvf-all.c:516:
+ if (new != 0)
[...]
total: 2 errors, 0 warnings, 130 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 12/14: hvf: move fields from CPUState to CPUX86State...
Argument "m" isn't numeric in numeric eq (==) at ./scripts/checkpatch.pl line 2479.
Argument "m" isn't numeric in numeric eq (==) at ./scripts/checkpatch.pl line 2479.
Use of uninitialized value $1 in concatenation (.) or string at ./scripts/checkpatch.pl line 2480.
WARNING: line over 80 characters
#206: FILE: target/i386/hvf-all.c:678:
+ env->hvf_emul = (HVFX86EmulatorState *)g_malloc0(sizeof(HVFX86EmulatorState));
ERROR: unnecessary cast may hide bugs, use g_new0 instead
#206: FILE: target/i386/hvf-all.c:678:
+ env->hvf_emul = (HVFX86EmulatorState *)g_malloc0(sizeof(HVFX86EmulatorState));
WARNING: line over 80 characters
#1339: FILE: target/i386/hvf-utils/x86_decode.c:1988:
+static inline void decode_displacement(CPUX86State *env, struct x86_decode *decode)
WARNING: line over 80 characters
#1487: FILE: target/i386/hvf-utils/x86_decode.c:2185:
+ return linear_addr_size(ENV_GET_CPU(env), addr, decode->addressing_size, seg);
WARNING: line over 80 characters
#1681: FILE: target/i386/hvf-utils/x86_emu.c:221:
+ return (ptr - (addr_t)&env->hvf_emul->regs[0]) < sizeof(env->hvf_emul->regs);
ERROR: spaces required around that '+' (ctx:WxV)
#1793: FILE: target/i386/hvf-utils/x86_emu.c:331:
+ EXEC_2OP_ARITH_CMD(env, decode, +get_CF(env)+, SET_FLAGS_OSZAPC_ADD, true);
^
ERROR: spaces required around that '+' (ctx:VxO)
#1793: FILE: target/i386/hvf-utils/x86_emu.c:331:
+ EXEC_2OP_ARITH_CMD(env, decode, +get_CF(env)+, SET_FLAGS_OSZAPC_ADD, true);
^
ERROR: spaces required around that '-' (ctx:VxO)
#1802: FILE: target/i386/hvf-utils/x86_emu.c:337:
+ EXEC_2OP_ARITH_CMD(env, decode, -get_CF(env)-, SET_FLAGS_OSZAPC_SUB, true);
^
ERROR: spaces required around that '+' (ctx:WxV)
#1874: FILE: target/i386/hvf-utils/x86_emu.c:393:
+ EXEC_2OP_ARITH_CMD(env, decode, +1+, SET_FLAGS_OSZAP_ADD, true);
^
ERROR: spaces required around that '+' (ctx:VxO)
#1874: FILE: target/i386/hvf-utils/x86_emu.c:393:
+ EXEC_2OP_ARITH_CMD(env, decode, +1+, SET_FLAGS_OSZAP_ADD, true);
^
ERROR: spaces required around that '-' (ctx:VxO)
#1888: FILE: target/i386/hvf-utils/x86_emu.c:403:
+ EXEC_2OP_ARITH_CMD(env, decode, -1-, SET_FLAGS_OSZAP_SUB, true);
^
WARNING: line over 80 characters
#1959: FILE: target/i386/hvf-utils/x86_emu.c:456:
+ hvf_handle_io(ENV_GET_CPU(env), DX(env), &RAX(env), 1, decode->operand_size, 1);
ERROR: line over 90 characters
#1980: FILE: target/i386/hvf-utils/x86_emu.c:473:
+ hvf_handle_io(ENV_GET_CPU(env), decode->op[0].val, &val, 0, decode->operand_size, 1);
WARNING: line over 80 characters
#1995: FILE: target/i386/hvf-utils/x86_emu.c:484:
+ hvf_handle_io(ENV_GET_CPU(env), DX(env), &val, 0, decode->operand_size, 1);
WARNING: line over 80 characters
#2031: FILE: target/i386/hvf-utils/x86_emu.c:512:
+static inline void string_rep(struct CPUX86State *env, struct x86_decode *decode,
WARNING: line over 80 characters
#2057: FILE: target/i386/hvf-utils/x86_emu.c:531:
+ addr_t addr = linear_addr_size(ENV_GET_CPU(env), RDI(env), decode->addressing_size,
WARNING: line over 80 characters
#2064: FILE: target/i386/hvf-utils/x86_emu.c:536:
+ vmx_write_mem(ENV_GET_CPU(env), addr, env->hvf_emul->mmio_buf, decode->operand_size);
WARNING: line over 80 characters
#2093: FILE: target/i386/hvf-utils/x86_emu.c:556:
+ vmx_read_mem(ENV_GET_CPU(env), env->hvf_emul->mmio_buf, addr, decode->operand_size);
WARNING: line over 80 characters
#2126: FILE: target/i386/hvf-utils/x86_emu.c:581:
+ dst_addr = linear_addr_size(ENV_GET_CPU(env), RDI(env), decode->addressing_size,
WARNING: line over 80 characters
#2164: FILE: target/i386/hvf-utils/x86_emu.c:608:
+ dst_addr = linear_addr_size(ENV_GET_CPU(env), RDI(env), decode->addressing_size,
ERROR: line over 90 characters
#2207: FILE: target/i386/hvf-utils/x86_emu.c:638:
+ addr = linear_addr_size(ENV_GET_CPU(env), RDI(env), decode->addressing_size, REG_SEG_ES);
ERROR: line over 90 characters
#2237: FILE: target/i386/hvf-utils/x86_emu.c:661:
+ addr = linear_addr_size(ENV_GET_CPU(env), RDI(env), decode->addressing_size, REG_SEG_ES);
WARNING: line over 80 characters
#2240: FILE: target/i386/hvf-utils/x86_emu.c:663:
+ vmx_read_mem(ENV_GET_CPU(env), &decode->op[1].val, addr, decode->operand_size);
ERROR: unnecessary whitespace before a quoted newline
#3032: FILE: target/i386/hvf-utils/x86_emu.c:1517:
+ printf("Unimplemented handler (%llx) for %d (%x %x) \n", RIP(env),
ERROR: unnecessary whitespace before a quoted newline
#3042: FILE: target/i386/hvf-utils/x86_emu.c:1525:
+ "Unimplemented handler (%llx) for %d (%x %x) \n", RIP(env),
WARNING: line over 80 characters
#3357: FILE: target/i386/hvf-utils/x86_flags.c:233:
+ return ((env->hvf_emul->lflags.auxbits + (1U << LF_BIT_PO)) >> LF_BIT_CF) & 1;
total: 12 errors, 14 warnings, 3527 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 13/14: hvf: refactor event injection code for hvf...
WARNING: line over 80 characters
#36: FILE: target/i386/hvf-all.c:753:
+static void hvf_store_events(CPUState *cpu, uint32_t ins_len, uint64_t idtvec_info)
total: 0 errors, 1 warnings, 222 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 14/14: hvf: inject General Protection Fault when vmexit through vmcall...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
On Sun, Aug 27, 2017 at 08:56:40PM -0500, Sergio Andres Gomez Del Real wrote: > The following patchset adds to QEMU the supporting for macOS's native > hypervisor, Hypervisor.framework (hvf). The code base is taken from > Google's Android emulator at > https://android.googlesource.com/platform/external/qemu/+/emu-master-dev. There is no ./MAINTAINERS entry for these new files. Who will maintain this code? Stefan
On Sun, Aug 27, 2017 at 08:56:40PM -0500, Sergio Andres Gomez Del Real wrote: > The following patchset adds to QEMU the supporting for macOS's native > hypervisor, Hypervisor.framework (hvf). The code base is taken from > Google's Android emulator at > https://android.googlesource.com/platform/external/qemu/+/emu-master-dev. What is the status of this feature? Is it expected to run everything that TCG can run or are there limitations? Is live migration supported, etc? How do you test hvf? Are there automated test cases? Stefan
© 2016 - 2024 Red Hat, Inc.