v3: Enhance and reuse iscsi sense data translation. [Paolo]

First refactor and enhance the code in iscsi for sense data translation, then
modify error handing of scsi-block and expose the qdev properties.

Fam Zheng (3):
  scsi: Refactor scsi sense interpreting code
  scsi: Enhance scsi_sense_to_errno
  scsi-block: Support rerror/werror

 MAINTAINERS         |  2 ++
 block/iscsi.c       | 45 ++++----------------------------------------
 hw/scsi/scsi-disk.c | 54 +++++++++++++++++++++++++++++++++++++++--------------
 include/scsi/scsi.h | 19 +++++++++++++++++++
 util/Makefile.objs  |  1 +
 util/scsi.c         | 51 ++++++++++++++++++++++++++++++++++++++++++++++++++
 6 files changed, 117 insertions(+), 55 deletions(-)
 create mode 100644 include/scsi/scsi.h
 create mode 100644 util/scsi.c

-- 
2.13.4

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20170818141512.15205-1-famz@redhat.com
Subject: [Qemu-devel] [PATCH v3 0/3] scsi-block: Support werror/rerror

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/1503065708-28277-1-git-send-email-mark.cave-ayland@ilande.co.uk -> patchew/1503065708-28277-1-git-send-email-mark.cave-ayland@ilande.co.uk
Switched to a new branch 'test'
5097d927de scsi-block: Support rerror/werror
d2c536a47c scsi: Enhance scsi_sense_to_errno
17642e9a8e scsi: Refactor scsi sense interpreting code

=== OUTPUT BEGIN ===
Checking PATCH 1/3: scsi: Refactor scsi sense interpreting code...
ERROR: space prohibited after that '-' (ctx:WxW)
#84: FILE: block/iscsi.c:213:
+    return - scsi_sense_to_errno(sense->key,
            ^

ERROR: return of an errno should typically be -ve (return -EBUSY)
#151: FILE: util/scsi.c:22:
+        return EBUSY;

ERROR: return of an errno should typically be -ve (return -EACCES)
#153: FILE: util/scsi.c:24:
+        return EACCES;

ERROR: return of an errno should typically be -ve (return -ECANCELED)
#155: FILE: util/scsi.c:26:
+        return ECANCELED;

ERROR: return of an errno should typically be -ve (return -EIO)
#160: FILE: util/scsi.c:31:
+        return EIO;

ERROR: return of an errno should typically be -ve (return -EINVAL)
#167: FILE: util/scsi.c:38:
+        return EINVAL;

ERROR: return of an errno should typically be -ve (return -ENOSPC)
#169: FILE: util/scsi.c:40:
+        return ENOSPC;

ERROR: return of an errno should typically be -ve (return -ENOTSUP)
#171: FILE: util/scsi.c:42:
+        return ENOTSUP;

ERROR: return of an errno should typically be -ve (return -ENOMEDIUM)
#175: FILE: util/scsi.c:46:
+        return ENOMEDIUM;

ERROR: return of an errno should typically be -ve (return -EACCES)
#177: FILE: util/scsi.c:48:
+        return EACCES;

ERROR: return of an errno should typically be -ve (return -EIO)
#179: FILE: util/scsi.c:50:
+        return EIO;

total: 11 errors, 0 warnings, 141 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/3: scsi: Enhance scsi_sense_to_errno...
Checking PATCH 3/3: scsi-block: Support rerror/werror...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org