[Qemu-devel] [PATCH v5 00/10] qemu.py: Pylint/style fixes

Lukáš Doktor posted 10 patches 6 years, 8 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170815085732.9794-1-ldoktor@redhat.com
Test FreeBSD passed
Test checkpatch passed
Test docker passed
Test s390x passed
There is a newer version of this series
scripts/qemu.py       | 98 +++++++++++++++++++++++++++++++++++++--------------
scripts/qmp/qmp-shell |  4 +--
scripts/qmp/qmp.py    | 49 ++++++++++++++++----------
scripts/qtest.py      | 13 ++++---
4 files changed, 109 insertions(+), 55 deletions(-)
[Qemu-devel] [PATCH v5 00/10] qemu.py: Pylint/style fixes
Posted by Lukáš Doktor 6 years, 8 months ago
Hello guys,

I'm reading the available python modules to exercise qemu and while reading them
I fixed some issues that caught my attention. It usually starts with a simple
pylint/docstring fixes and slowly graduates to more controversial ones so I'm
open to suggestion to remove some of them.

Kind regards,
Lukáš

Changes in v2
- Squashed 2nd and 10th patches into 2nd one
- Use repr() in MonitorResponseError's description
- Improved commit message of the 6th patch
- Two tweaks to docstrings changed in the 6th patch
- Also updated qmp-shell to use new-style super calls (7th patch)
- Fixed the accidental rename of qmp `cmd_id` (kept the id->cmd_id patch)
- Changed the style of the style-fix in the 10th commit

Changes in v3
- Don't use repr in the 5th patch in MonitorResponseError

Changes in v4
- Use correct git base (remove unwanted commits)

Changes in v5
- Avoid bool comparison
- Change report to return in one docstring
- Removed the unnecessary spaces around single-line docstring

Lukáš Doktor (10):
  qemu.py: Pylint/style fixes
  qemu|qtest: Avoid dangerous arguments
  qemu.py: Use iteritems rather than keys()
  qemu.py: Simplify QMP key-conversion
  qemu.py: Use custom exceptions rather than Exception
  qmp.py: Couple of pylint/style fixes
  qmp.py: Use object-based class for QEMUMonitorProtocol
  qmp.py: Avoid "has_key" usage
  qmp.py: Avoid overriding a builtin object
  qtest.py: Few pylint/style fixes

 scripts/qemu.py       | 98 +++++++++++++++++++++++++++++++++++++--------------
 scripts/qmp/qmp-shell |  4 +--
 scripts/qmp/qmp.py    | 49 ++++++++++++++++----------
 scripts/qtest.py      | 13 ++++---
 4 files changed, 109 insertions(+), 55 deletions(-)

-- 
2.9.4