From nobody Fri May 3 05:58:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1502773555244766.5818050246838; Mon, 14 Aug 2017 22:05:55 -0700 (PDT) Received: from localhost ([::1]:37027 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhU37-00049E-SF for importer@patchew.org; Tue, 15 Aug 2017 01:05:53 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37855) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhU28-0003WM-G2 for qemu-devel@nongnu.org; Tue, 15 Aug 2017 01:04:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhU25-00081X-CD for qemu-devel@nongnu.org; Tue, 15 Aug 2017 01:04:52 -0400 Received: from m97139.mail.qiye.163.com ([220.181.97.139]:43848) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhU1y-0007xT-HV for qemu-devel@nongnu.org; Tue, 15 Aug 2017 01:04:49 -0400 Received: from localhost.localdomain (unknown [120.132.1.226]) by smtp10 (Coremail) with SMTP id vOCowAAnhCnPgJJZ+iScSg--.37S3; Tue, 15 Aug 2017 13:04:16 +0800 (CST) From: wei.yang@ucloud.cn To: mst@redhat.com Date: Tue, 15 Aug 2017 13:04:14 +0800 Message-Id: <20170815050414.29222-1-wei.yang@ucloud.cn> X-Mailer: git-send-email 2.11.0 X-CM-TRANSID: vOCowAAnhCnPgJJZ+iScSg--.37S3 X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvjfUkRVbUUUUU X-Originating-IP: [120.132.1.226] X-CM-SenderInfo: xzhlh5xdqjq3pfor3vgofq/1tbiaBA1cVlZsvOZawAAsP X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 220.181.97.139 Subject: [Qemu-devel] [PATCH] bios-tables-test: use strlen instead of sizeof X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, wei.yang@ucloud.cn Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Wei Yang sizeof(BLOCK_NAME_END) is actually 2. it can work because there's a space after ,. but It is better to replace it with strlen so it will work without a space too. Signed-off-by: Wei Yang CC: Michael S. Tsirkin CC: qemu-devel@nongnu.org --- tests/bios-tables-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c index 88dbf97853..d1f31b19d3 100644 --- a/tests/bios-tables-test.c +++ b/tests/bios-tables-test.c @@ -352,7 +352,7 @@ static GString *normalize_asl(gchar *asl_code) block_name =3D g_strstr_len(asl->str, asl->len, BLOCK_NAME_END); g_assert(block_name); asl =3D g_string_erase(asl, 0, - block_name + sizeof(BLOCK_NAME_END) - asl->st= r); + block_name + strlen(BLOCK_NAME_END) - asl->st= r); } =20 return asl; --=20 2.11.0