From nobody Mon Apr 29 12:01:58 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1501784145256316.79689185886923; Thu, 3 Aug 2017 11:15:45 -0700 (PDT) Received: from localhost ([::1]:38591 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ddKet-0000js-Q2 for importer@patchew.org; Thu, 03 Aug 2017 14:15:43 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35149) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ddKbm-0006OA-BK for qemu-devel@nongnu.org; Thu, 03 Aug 2017 14:12:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ddKbk-0003BO-7X for qemu-devel@nongnu.org; Thu, 03 Aug 2017 14:12:30 -0400 Received: from mail-pg0-x242.google.com ([2607:f8b0:400e:c05::242]:38685) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ddKbk-0003AT-1m for qemu-devel@nongnu.org; Thu, 03 Aug 2017 14:12:28 -0400 Received: by mail-pg0-x242.google.com with SMTP id 123so2155625pga.5 for ; Thu, 03 Aug 2017 11:12:27 -0700 (PDT) Received: from bigtime.twiddle.net (97-126-108-236.tukw.qwest.net. [97.126.108.236]) by smtp.gmail.com with ESMTPSA id 133sm16410964pge.29.2017.08.03.11.12.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 03 Aug 2017 11:12:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=LK6jCXZlW11PmWP2G3sEq1hN5ofU9z75iA45nh/Sjyk=; b=a99qyx6T4f+Uji+FEmrj2d78SrhaJ6N7v+C0rdcOaEh4Wu7WwN3A/P5Xb0rf2fabr3 zNKS7UnTTbi+F9MBPPLZG2oZHURPsPkIRMBQQSxnVZ1BZ6M7wPQSxkY+2YQ4iku/PIsS 5eBAtmNVB6VqEeMHo0N1N12AZwNzBs91cgY3j+9GE5+1B+lEZ3AUtPxYNK2uMRae40vt yJ+37OLtGnCmunYKN0/9aTshebBA+HAYNmgOuLw3N0qC8avc7Uw7bJKc49IYZRKWAV6N +qBUKOxhAm7RAy9yjVXCOUreMoZ8VVi+sPZXemJ8n2kqssOhGtT1hY1xHpjvppTG3N3L MM4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=LK6jCXZlW11PmWP2G3sEq1hN5ofU9z75iA45nh/Sjyk=; b=hK2hvjiV2+yA0gjAVaxggK+8RXFhfo3KzWMUSOVLhv14KWbYnutkRfMXDjeCtcWyNr ZHer8EyjAkZu2J3jQkS2Ike3EvwFypmFSOHgN0X5jNAn5KQ2JWjJ3sfMSJv8bBrfeYrG ++l8SdRazk1hHul1Iz2tR1UYXTE+233Os2zUG6Med8iUlsDydHwscZjXvljqt/VAK4lC l4qJVR6GdwNjNrwK/g9AuYlyziWkyVSID0ljzEV/AE9LxydEf6GdTjK6MlrIU3kxWyPc s6Ju/H4U0CYc3ashdQkT35VWlSZuU0t+Ep8Ih+HZLod3KgSfXHf5ezslWvRjQVpgj/ou VgVw== X-Gm-Message-State: AIVw112O1FjzHgeLadYTrAChy42IumyouuN0uM9KafAjpDh5PxaU2ePI 54inEVpQG+Mgy0y5XHE= X-Received: by 10.98.195.26 with SMTP id v26mr2548878pfg.118.1501783946648; Thu, 03 Aug 2017 11:12:26 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 3 Aug 2017 11:12:22 -0700 Message-Id: <20170803181224.21748-2-rth@twiddle.net> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170803181224.21748-1-rth@twiddle.net> References: <20170803181224.21748-1-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::242 Subject: [Qemu-devel] [PULL for-2.10 1/3] tcg/arm: Fix runtime overalignment test X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Patch 85aa80813dd changed the IF emitting the TST instruction, but failed to change the ?: converting CMP to CMPEQ, so the result of the TST is ignored. Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.inc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/arm/tcg-target.inc.c b/tcg/arm/tcg-target.inc.c index d1793ec77d..37efcf06af 100644 --- a/tcg/arm/tcg-target.inc.c +++ b/tcg/arm/tcg-target.inc.c @@ -1223,7 +1223,7 @@ static TCGReg tcg_out_tlb_read(TCGContext *s, TCGReg = addrlo, TCGReg addrhi, /* Load the tlb addend. */ tcg_out_ld32_12(s, COND_AL, TCG_REG_R2, TCG_REG_R2, add_off); =20 - tcg_out_dat_reg(s, (s_bits ? COND_EQ : COND_AL), ARITH_CMP, 0, + tcg_out_dat_reg(s, (a_bits ? COND_EQ : COND_AL), ARITH_CMP, 0, TCG_REG_R0, TCG_REG_TMP, SHIFT_IMM_LSL(TARGET_PAGE_BIT= S)); =20 if (TARGET_LONG_BITS =3D=3D 64) { --=20 2.13.3 From nobody Mon Apr 29 12:01:58 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 150178403125713.784428606003871; Thu, 3 Aug 2017 11:13:51 -0700 (PDT) Received: from localhost ([::1]:38464 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ddKd1-00073G-Am for importer@patchew.org; Thu, 03 Aug 2017 14:13:47 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35148) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ddKbm-0006O9-B4 for qemu-devel@nongnu.org; Thu, 03 Aug 2017 14:12:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ddKbl-0003Ci-A9 for qemu-devel@nongnu.org; Thu, 03 Aug 2017 14:12:30 -0400 Received: from mail-pf0-x242.google.com ([2607:f8b0:400e:c00::242]:34572) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ddKbk-0003BV-Q9 for qemu-devel@nongnu.org; Thu, 03 Aug 2017 14:12:29 -0400 Received: by mail-pf0-x242.google.com with SMTP id t86so2188886pfe.1 for ; Thu, 03 Aug 2017 11:12:28 -0700 (PDT) Received: from bigtime.twiddle.net (97-126-108-236.tukw.qwest.net. [97.126.108.236]) by smtp.gmail.com with ESMTPSA id 133sm16410964pge.29.2017.08.03.11.12.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 03 Aug 2017 11:12:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7/4GzL9wpw32MSXX43rRby94r1xXISy1VtpRt7eg3j0=; b=j4THOtQ6S6HU8vRASGXzE0WKcUrL6rIsJaq7TTJpMzNVx7SbJLW0uC5kuTpeSy1vHs W1W/Ca7ju+ak6PV/UoehsTQ/wKCItj8PdMbmiL5psNPwaNULHe4dQ5hnHiWxrJFbh8nz 3m8JNRqpVKhSrs0vouobzPQRTzs29IsgWmqUf0YehUXP9JBYw71bQXLL6IYJU3bhRTST 5QkZbmmdniQiw6lb8xqi+pIoahTHfgcnhl5VchPpTGXx7hUEHd2AeEK7ZGtaZ6xzlkID ekhSVI8K2u5srpe1utoY2/MPj0BNWcATQA/nKwQXn76V5jRMrcwtj8RtrHsDZVpMlqax W6OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=7/4GzL9wpw32MSXX43rRby94r1xXISy1VtpRt7eg3j0=; b=W1yg3FdGu9urf+g2X+xvZ9bVZTYssYaC7a6/3MY5XBy1Qa/vGj0ddAem0gWlvkRCPm 1JgccvZgWeuSV1bAiguZHPzddSXoTLMm+kpXoTRaT0ByPrfEwh2hRPSS0ggMQbjiUmQE Qt144BSuSRPP34BPEmjq1KeL7WCr7PJYlKKdDd1uCDr7n63scmQ0gLivD7rnk06xeJPD xg96C74RbJqg0H2QYkuyfuozgd6JHJ2tNaIKqbPXyToQmjIpEYaUkkONq0w+ngRbOtpH 8iWmAeZcdRkxXfynZ+boBkbfrNXycLl+3DcunRoZfTvqihHZllQxA4QaoDn94xLvZMfF JIew== X-Gm-Message-State: AIVw111G7J4VDi9HMoqpEJMrTRIxB+iak7LPjJEPXGugjdc4xfVV0CLx o7BlmKMpMv0zklKoqfs= X-Received: by 10.98.149.215 with SMTP id c84mr2482305pfk.95.1501783947785; Thu, 03 Aug 2017 11:12:27 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 3 Aug 2017 11:12:23 -0700 Message-Id: <20170803181224.21748-3-rth@twiddle.net> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170803181224.21748-1-rth@twiddle.net> References: <20170803181224.21748-1-rth@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::242 Subject: [Qemu-devel] [PULL for-2.10 2/3] target/s390x: Fix CSST for 16-byte store X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Found by Coverity (CID 1378273). Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reported-by: Paolo Bonzini Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index cdc78aa3d4..c71dce4b1e 100644 --- a/target/s390x/mem_helper.c +++ b/target/s390x/mem_helper.c @@ -1580,6 +1580,7 @@ uint32_t HELPER(csst)(CPUS390XState *env, uint32_t r3= , uint64_t a1, uint64_t a2) cpu_stq_data_ra(env, a2 + 0, svh, ra); cpu_stq_data_ra(env, a2 + 8, svl, ra); } + break; default: g_assert_not_reached(); } --=20 2.13.3 From nobody Mon Apr 29 12:01:58 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1501784216102440.05552354546035; Thu, 3 Aug 2017 11:16:56 -0700 (PDT) Received: from localhost ([::1]:38706 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ddKg2-0001RB-R0 for importer@patchew.org; Thu, 03 Aug 2017 14:16:54 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35183) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ddKbn-0006OS-0D for qemu-devel@nongnu.org; Thu, 03 Aug 2017 14:12:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ddKbm-0003Dl-73 for qemu-devel@nongnu.org; Thu, 03 Aug 2017 14:12:31 -0400 Received: from mail-pf0-x243.google.com ([2607:f8b0:400e:c00::243]:37812) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ddKbm-0003D8-1S for qemu-devel@nongnu.org; Thu, 03 Aug 2017 14:12:30 -0400 Received: by mail-pf0-x243.google.com with SMTP id p13so2180241pfd.4 for ; Thu, 03 Aug 2017 11:12:30 -0700 (PDT) Received: from bigtime.twiddle.net (97-126-108-236.tukw.qwest.net. [97.126.108.236]) by smtp.gmail.com with ESMTPSA id 133sm16410964pge.29.2017.08.03.11.12.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 03 Aug 2017 11:12:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=ZTvm9dawsrAvg/0kp+KzEWsiNH8QxHZk2ZLtJWCc5UU=; b=NCfn9ngDTjFU0k3ft+tNQDUow9bsqHibr6d7E56lJ4kmYDtsZWNCd9mUQIbPbsrAnC r9uIYkhEj4X0F1E2hJ4afYf+Bdn+1koiNzA2ovnbUpzhEfZawgG8kWP897T4swiNoiNX CK/DHdTjeIbykRyZdp7IexIy0TxSnS1K5Bwxvv6U9KzXBMBYHdZOUOufn6GNhIKUFuh3 BCdC3xSE+rm4gi3Bm551iVUL237PcghIMFdTKmRRmj27nHzVM+202vsiY+tfpWQCg+KM 41MwQ9gcgh0DJE2/A8uGX6dMdpin9JaPSwe1wNEJ/zjniIMoIY6XT9AlV4+R1pJ9j2TQ 2wgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=ZTvm9dawsrAvg/0kp+KzEWsiNH8QxHZk2ZLtJWCc5UU=; b=oZNBHd2qFiRYQqdnwTWx4oiiSA8PUH1A6oFYF7mOOxH12e54Wp2f2DPaWwQHpipt1C nO14i2tmVkfG5LOaX+IaMyCNhnBe5a28o6j8vud4jwZiUxSzkk+mxvSOSy5rFxmq1C38 tHOEsRs4Gr/lCEfjQ6AJQ4eS3Gt0AIqq/xIcnRknzXtFOKXv+bdryFIIWJW1HGhnwJ5J Or8T5cAa4DgIwXdUmdMzwWXJqv9EnR/cePdddI9McquWnkR/mxbEZqwI4IcJ6sgOTK8t de0ScQnEtDOA/FEGfQzkcvVRX8AYP0gPrMyL3a+UGMpFsQdEymkcu6VnHDGeJgbh0YY5 VSYg== X-Gm-Message-State: AIVw1129R6vLzWFjUbkmWMMqiEw/MQOvD/fN/vpvE2TTxwINPIRO2TtE OY2Oeij40QN+v4aZhEI= X-Received: by 10.98.106.6 with SMTP id f6mr2507201pfc.53.1501783948966; Thu, 03 Aug 2017 11:12:28 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 3 Aug 2017 11:12:24 -0700 Message-Id: <20170803181224.21748-4-rth@twiddle.net> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170803181224.21748-1-rth@twiddle.net> References: <20170803181224.21748-1-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::243 Subject: [Qemu-devel] [PULL for-2.10 3/3] tcg: Increase minimum alignment from tcg_malloc to 8 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" For a 64-bit ILP32 host, aligning to sizeof(long) is not enough. Guess the minimum for any host is 8, as that covers uint64_t. Qemu doesn't use a host long double or host vectors, except in extremely limited circumstances. Fixes a bus error for a sparc v8plus host. Signed-off-by: Richard Henderson --- tcg/tcg.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tcg/tcg.h b/tcg/tcg.h index da78721a0d..17b7750ee6 100644 --- a/tcg/tcg.h +++ b/tcg/tcg.h @@ -762,7 +762,10 @@ static inline void *tcg_malloc(int size) { TCGContext *s =3D &tcg_ctx; uint8_t *ptr, *ptr_end; - size =3D (size + sizeof(long) - 1) & ~(sizeof(long) - 1); + + /* ??? This is a weak placeholder for minimum malloc alignment. */ + size =3D QEMU_ALIGN_UP(size, 8); + ptr =3D s->pool_cur; ptr_end =3D ptr + size; if (unlikely(ptr_end > s->pool_end)) { --=20 2.13.3