From nobody Sun Apr 28 00:02:06 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1501604108851861.4525042256963; Tue, 1 Aug 2017 09:15:08 -0700 (PDT) Received: from localhost ([::1]:43567 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcZp5-0002pm-Bz for importer@patchew.org; Tue, 01 Aug 2017 12:15:07 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58482) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcZoJ-0002WD-LQ for qemu-devel@nongnu.org; Tue, 01 Aug 2017 12:14:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dcZoF-0004rI-03 for qemu-devel@nongnu.org; Tue, 01 Aug 2017 12:14:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56722) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dcZoE-0004pD-PY for qemu-devel@nongnu.org; Tue, 01 Aug 2017 12:14:14 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 553A133841B for ; Tue, 1 Aug 2017 16:04:36 +0000 (UTC) Received: from localhost (unknown [10.41.1.168]) by smtp.corp.redhat.com (Postfix) with ESMTP id ED81917A89; Tue, 1 Aug 2017 16:04:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 553A133841B Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=marcandre.lureau@redhat.com From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= To: qemu-devel@nongnu.org Date: Tue, 1 Aug 2017 17:04:18 +0100 Message-Id: <20170801160419.14180-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 01 Aug 2017 16:04:36 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] migration: fix small leaks X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , "Dr. David Alan Gilbert" , Juan Quintela Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Spotted thanks to valgrind and tests/device-introspect-test: =3D=3D11711=3D=3D 1 bytes in 1 blocks are definitely lost in loss record 6 = of 14,537 =3D=3D11711=3D=3D at 0x4C2EB6B: malloc (vg_replace_malloc.c:299) =3D=3D11711=3D=3D by 0x1E0CDBD8: g_malloc (gmem.c:94) =3D=3D11711=3D=3D by 0x1E0E696E: g_strdup (gstrfuncs.c:363) =3D=3D11711=3D=3D by 0x695693: migration_instance_init (migration.c:2226) =3D=3D11711=3D=3D by 0x717C4B: object_init_with_type (object.c:344) =3D=3D11711=3D=3D by 0x717E80: object_initialize_with_type (object.c:375) =3D=3D11711=3D=3D by 0x7182EB: object_new_with_type (object.c:483) =3D=3D11711=3D=3D by 0x718328: object_new (object.c:493) =3D=3D11711=3D=3D by 0x4B8A29: qmp_device_list_properties (qmp.c:542) =3D=3D11711=3D=3D by 0x4A9561: qmp_marshal_device_list_properties (qmp-m= arshal.c:1425) =3D=3D11711=3D=3D by 0x819D4A: do_qmp_dispatch (qmp-dispatch.c:104) =3D=3D11711=3D=3D by 0x819E82: qmp_dispatch (qmp-dispatch.c:131) Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Juan Quintela Reviewed-by: Peter Xu --- migration/migration.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/migration/migration.c b/migration/migration.c index 085c32c994..c3fe0ed9ca 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -2214,6 +2214,15 @@ static void migration_class_init(ObjectClass *klass,= void *data) dc->props =3D migration_properties; } =20 +static void migration_instance_finalize(Object *obj) +{ + MigrationState *ms =3D MIGRATION_OBJ(obj); + MigrationParameters *params =3D &ms->parameters; + + g_free(params->tls_hostname); + g_free(params->tls_creds); +} + static void migration_instance_init(Object *obj) { MigrationState *ms =3D MIGRATION_OBJ(obj); @@ -2282,6 +2291,7 @@ static const TypeInfo migration_type =3D { .class_size =3D sizeof(MigrationClass), .instance_size =3D sizeof(MigrationState), .instance_init =3D migration_instance_init, + .instance_finalize =3D migration_instance_finalize, }; =20 static void register_migration_types(void) --=20 2.14.0.rc0.1.g40ca67566