From nobody Sat May 4 00:05:38 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1501267997025572.7809232012464; Fri, 28 Jul 2017 11:53:17 -0700 (PDT) Received: from localhost ([::1]:49618 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dbANu-0005L4-NH for importer@patchew.org; Fri, 28 Jul 2017 14:53:14 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32912) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dbAMD-0004Tu-N2 for qemu-devel@nongnu.org; Fri, 28 Jul 2017 14:51:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dbAM8-00042K-Oa for qemu-devel@nongnu.org; Fri, 28 Jul 2017 14:51:29 -0400 Received: from mail-qt0-x242.google.com ([2607:f8b0:400d:c0d::242]:38052) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dbAM8-000426-KN for qemu-devel@nongnu.org; Fri, 28 Jul 2017 14:51:24 -0400 Received: by mail-qt0-x242.google.com with SMTP id p3so13530756qtg.5 for ; Fri, 28 Jul 2017 11:51:24 -0700 (PDT) Received: from bigtime.com (97-126-108-236.tukw.qwest.net. [97.126.108.236]) by smtp.gmail.com with ESMTPSA id f21sm533895qkh.89.2017.07.28.11.51.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 28 Jul 2017 11:51:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=LK6jCXZlW11PmWP2G3sEq1hN5ofU9z75iA45nh/Sjyk=; b=dWtWp20F90dbvY8+V8ezGBMQpKv1Y9DLJqQP5lm9WI7/R2xnBL6/QwLdXAfKBJxEGa HMKQl2RAEMEC4znxo6r5ffonbzoEDEAFotmoLlimMhdv9qEThtCRERfNfmG0+CHJz02M ItukhliEVLLslH+q1LNZA22+BjPglgfQZzRfTH1J+Rb9FtYiFdiEFz4drz/km2PkNk0p 3GBaggXd+FBr6z4i2LxwQgWLhiaGpbb75ZuznaZ77/I2Nee25BWQyqjI799zAN1T646b aEpHwmAP4zWFxaceKumJ80NXlBwMEdyFJ8N/owhDuF81tivMx4KDCc52WTIDAj5HTgoS TSGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=LK6jCXZlW11PmWP2G3sEq1hN5ofU9z75iA45nh/Sjyk=; b=mwmUkr4v9Z6870er7Q/zAYs5t0QUgd5Ag8U/dfvmIQUBFNsbDLmEajNsaqgAD5vf96 j6m65OkXU4RD0jpCKi+SEs1BMUKvuZZDeaiRxPU1xaxw/UfiInaRuJdNQDK5dUpVK/Lt l7LHc2mbmOqnCAQg0kaOA61sKrrS/jpOOILl/iTULdOPasW3loiyenLD0mMgS4Z+Nzc1 nuK9ZRnS+19aVPYgteL4QghT3GKR9Fx6TAIb38ONQ4J1joJyKI85CmpqROFcVWqAiw4A 2rYP4QH9MtJCiVIvXAoMisQDrAwhpSNf5iQ+fKHHPxRrrVaCUrNBWhIOzF0iV4H7Nz8n 0GWw== X-Gm-Message-State: AIVw112mbwG3MkNwKHl9JfQ45FFigvsx+g2wlAPdzGsbqrFW82RaWuki J4Q0PY0hF7ncMCW/m0c= X-Received: by 10.200.45.236 with SMTP id q41mr11914564qta.177.1501267883644; Fri, 28 Jul 2017 11:51:23 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Fri, 28 Jul 2017 11:50:49 -0700 Message-Id: <20170728185050.20395-2-rth@twiddle.net> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170728185050.20395-1-rth@twiddle.net> References: <20170728185050.20395-1-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::242 Subject: [Qemu-devel] [PATCH for-2.10 1/2] tcg/arm: Fix runtime overalignment test X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Patch 85aa80813dd changed the IF emitting the TST instruction, but failed to change the ?: converting CMP to CMPEQ, so the result of the TST is ignored. Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.inc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/arm/tcg-target.inc.c b/tcg/arm/tcg-target.inc.c index d1793ec77d..37efcf06af 100644 --- a/tcg/arm/tcg-target.inc.c +++ b/tcg/arm/tcg-target.inc.c @@ -1223,7 +1223,7 @@ static TCGReg tcg_out_tlb_read(TCGContext *s, TCGReg = addrlo, TCGReg addrhi, /* Load the tlb addend. */ tcg_out_ld32_12(s, COND_AL, TCG_REG_R2, TCG_REG_R2, add_off); =20 - tcg_out_dat_reg(s, (s_bits ? COND_EQ : COND_AL), ARITH_CMP, 0, + tcg_out_dat_reg(s, (a_bits ? COND_EQ : COND_AL), ARITH_CMP, 0, TCG_REG_R0, TCG_REG_TMP, SHIFT_IMM_LSL(TARGET_PAGE_BIT= S)); =20 if (TARGET_LONG_BITS =3D=3D 64) { --=20 2.13.3 From nobody Sat May 4 00:05:38 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1501267994516439.97241424307185; Fri, 28 Jul 2017 11:53:14 -0700 (PDT) Received: from localhost ([::1]:49617 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dbANs-0005Jq-JH for importer@patchew.org; Fri, 28 Jul 2017 14:53:12 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32908) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dbAMD-0004Ts-ML for qemu-devel@nongnu.org; Fri, 28 Jul 2017 14:51:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dbAM9-00042x-SD for qemu-devel@nongnu.org; Fri, 28 Jul 2017 14:51:29 -0400 Received: from mail-qt0-x244.google.com ([2607:f8b0:400d:c0d::244]:36131) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dbAM9-00042m-OG for qemu-devel@nongnu.org; Fri, 28 Jul 2017 14:51:25 -0400 Received: by mail-qt0-x244.google.com with SMTP id c15so8164025qta.3 for ; Fri, 28 Jul 2017 11:51:25 -0700 (PDT) Received: from bigtime.com (97-126-108-236.tukw.qwest.net. [97.126.108.236]) by smtp.gmail.com with ESMTPSA id f21sm533895qkh.89.2017.07.28.11.51.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 28 Jul 2017 11:51:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=8+4nVUJ82WVtC/6cFxkDXckTu3wthoSVRq1hy+DufCM=; b=Ne7jVKZrE+KjvN7vQlF1yoMwt4gslpKNNadVzD/+1RJbuFqjhCHK6oFrf2hDteLj8B tS3MEv2mmdPYRRgpVEO9FtKKLfqNoT2uDErjM6132Zcyj2PW2gd1QoIjWwTTPhWHqrdh XstTGu+ZILBOiC5FX4diVZyj+OUQgXPnSnbd9TVrAkyaiWQOh1x0PW7XCQ5IGnZMjEn/ GLLXtjes2LHnP4bzpMRjOJF4l7f99Hat0nBivT+H8NFedLfCzs9y2LV4xu6unFBNtdMx 6QO1yOJtgXmx9A4DU62k9vPB7lbjzI5Gnj0DYLCwvabcXdIxBUMjf4kDBzP6tOBKfX6f HeVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=8+4nVUJ82WVtC/6cFxkDXckTu3wthoSVRq1hy+DufCM=; b=VONks/atnxBiJ6QW+ZzIpFBFJ7E7kn9GbdQTd3SahbgfDlIOtpG0o3yw13tEe6dtX1 kGCtU3wQCViBFTE7E2f2Ee36SYY+g1XVogsroJ3JHvhGWRP4RJEvU9Zbpcf2urRpsqpA CkfS6t7aVFh6G+R1IY4XCInn4RgSk4mZ8GMB5KiRW+wg85pahhzOHiiOP1jBW8hkiK69 uaAPndJ5Ql9v2EiOynq9+jXs4hKP+iUoEeSQnts8CdZ7NjKlRfy9vZbZoxmb9ClbuZp8 1Fuo7b4QKfahToNpdq//G3/d4xT+qwnKCQG/A8Ch6enUht/kv5v/p0SORV/2c6TqRXik aWqw== X-Gm-Message-State: AIVw113Tl0ykeltzj2SPy+XA9LhFrFunpzfHy0sqhUnwETcnfAk+NVQ2 7jYUXBfoK7i7+pEa+k8= X-Received: by 10.200.39.206 with SMTP id x14mr12575498qtx.259.1501267884971; Fri, 28 Jul 2017 11:51:24 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Fri, 28 Jul 2017 11:50:50 -0700 Message-Id: <20170728185050.20395-3-rth@twiddle.net> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170728185050.20395-1-rth@twiddle.net> References: <20170728185050.20395-1-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::244 Subject: [Qemu-devel] [PATCH for-2.10 2/2] target/s390x: Fix CSST for 16-byte store X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Found by Coverity. Reported-by: Paolo Bonzini Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- target/s390x/mem_helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index cdc78aa3d4..c71dce4b1e 100644 --- a/target/s390x/mem_helper.c +++ b/target/s390x/mem_helper.c @@ -1580,6 +1580,7 @@ uint32_t HELPER(csst)(CPUS390XState *env, uint32_t r3= , uint64_t a1, uint64_t a2) cpu_stq_data_ra(env, a2 + 0, svh, ra); cpu_stq_data_ra(env, a2 + 8, svl, ra); } + break; default: g_assert_not_reached(); } --=20 2.13.3