build-sys: there is no qemu-ga.c

[Qemu-devel] [PATCH] build-sys: there is no qemu-ga.c

Marc-André Lureau posted 1 patch 6 years, 9 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170727154505.14838-1-marcandre.lureau@redhat.com

Test FreeBSD passed

Test checkpatch passed

Test s390x passed

Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[Qemu-devel] [PATCH] build-sys: there is no qemu-ga.c

Posted by Marc-André Lureau 6 years, 9 months ago

It got moved in qga/main.c from commit 2870dc3456c9c.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index ef721480eb..97a58a0f4e 100644
--- a/Makefile
+++ b/Makefile
@@ -443,7 +443,7 @@ $(qapi-modules) $(SRC_PATH)/scripts/qapi-introspect.py $(qapi-py)
 		"GEN","$@")
 
 QGALIB_GEN=$(addprefix qga/qapi-generated/, qga-qapi-types.h qga-qapi-visit.h qga-qmp-commands.h)
-$(qga-obj-y) qemu-ga.o: $(QGALIB_GEN)
+$(qga-obj-y): $(QGALIB_GEN)
 
 qemu-ga$(EXESUF): $(qga-obj-y) $(COMMON_LDADDS)
 	$(call LINK, $^)
-- 
2.14.0.rc0.1.g40ca67566

Re: [Qemu-devel] [PATCH] build-sys: there is no qemu-ga.c

Posted by Michael Roth 6 years, 9 months ago

Quoting Marc-André Lureau (2017-07-27 10:45:05)
> It got moved in qga/main.c from commit 2870dc3456c9c.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>

> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index ef721480eb..97a58a0f4e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -443,7 +443,7 @@ $(qapi-modules) $(SRC_PATH)/scripts/qapi-introspect.py $(qapi-py)
>                 "GEN","$@")
>  
>  QGALIB_GEN=$(addprefix qga/qapi-generated/, qga-qapi-types.h qga-qapi-visit.h qga-qmp-commands.h)
> -$(qga-obj-y) qemu-ga.o: $(QGALIB_GEN)
> +$(qga-obj-y): $(QGALIB_GEN)
>  
>  qemu-ga$(EXESUF): $(qga-obj-y) $(COMMON_LDADDS)
>         $(call LINK, $^)
> -- 
> 2.14.0.rc0.1.g40ca67566
> 
>

Re: [Qemu-devel] [PATCH] build-sys: there is no qemu-ga.c

Posted by Michael Tokarev 6 years, 8 months ago

27.07.2017 18:45, Marc-André Lureau wrote:
> It got moved in qga/main.c from commit 2870dc3456c9c.

Applied to -trivial, thanks!

/mjt