[Qemu-devel] [PATCH v3 00/14] qemu.py: Pylint/style fixes

Lukáš Doktor posted 14 patches 6 years, 8 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170726143543.2530-1-ldoktor@redhat.com
Test FreeBSD passed
Test s390x passed
There is a newer version of this series
[Qemu-devel] [PATCH v3 00/14] qemu.py: Pylint/style fixes
Posted by Lukáš Doktor 6 years, 8 months ago
Hello guys,

I'm reading the available python modules to exercise qemu and while reading them
I fixed some issues that caught my attention. It usually starts with a simple
pylint/docstring fixes and slowly graduates to more controversial ones so I'm
open to suggestion to remove some of them.

Kind regards,
Lukáš

Changes v1->v2
 - Squashed 2nd and 10th patches into 2nd one
 - Use repr() in MonitorResponseError's description
 - Improved commit message of the 6th patch
 - Two tweaks to docstrings changed in the 6th patch
 - Also updated qmp-shell to use new-style super calls (7th patch)
 - Fixed the accidental rename of qmp `cmd_id` (kept the id->cmd_id patch)
 - Changed the style of the style-fix in the 10th commit

Changes v2->v3
 - Don't use repr in the 5th patch in MonitorResponseError

Daniel P. Berrange (1):
  qcow: fix memory leaks related to encryption

Kevin Wolf (1):
  qemu-iotests: Fix reference output for 186

Lukáš Doktor (10):
  qemu.py: Pylint/style fixes
  qemu|qtest: Avoid dangerous arguments
  qemu.py: Use iteritems rather than keys()
  qemu.py: Simplify QMP key-conversion
  qemu.py: Use custom exceptions rather than Exception
  qmp.py: Couple of pylint/style fixes
  qmp.py: Use object-based class for QEMUMonitorProtocol
  qmp.py: Avoid "has_key" usage
  qmp.py: Avoid overriding a builtin object
  qtest.py: Few pylint/style fixes

Peter Maydell (1):
  Update version for v2.10.0-rc0 release

Vladimir Sementsov-Ogievskiy (1):
  qcow2-bitmap: fix bitmap_free


Re: [Qemu-devel] [PATCH v3 00/14] qemu.py: Pylint/style fixes
Posted by Lukáš Doktor 6 years, 8 months ago
Dne 26.7.2017 v 16:35 Lukáš Doktor napsal(a):
> Hello guys,
> 
> I'm reading the available python modules to exercise qemu and while reading them
> I fixed some issues that caught my attention. It usually starts with a simple
> pylint/docstring fixes and slowly graduates to more controversial ones so I'm
> open to suggestion to remove some of them.
> 
> Kind regards,
> Lukáš
> 
> Changes v1->v2
>  - Squashed 2nd and 10th patches into 2nd one
>  - Use repr() in MonitorResponseError's description
>  - Improved commit message of the 6th patch
>  - Two tweaks to docstrings changed in the 6th patch
>  - Also updated qmp-shell to use new-style super calls (7th patch)
>  - Fixed the accidental rename of qmp `cmd_id` (kept the id->cmd_id patch)
>  - Changed the style of the style-fix in the 10th commit
> 
> Changes v2->v3
>  - Don't use repr in the 5th patch in MonitorResponseError
> 
> Daniel P. Berrange (1):
>   qcow: fix memory leaks related to encryption
> 
> Kevin Wolf (1):
>   qemu-iotests: Fix reference output for 186
> 
> Lukáš Doktor (10):
>   qemu.py: Pylint/style fixes
>   qemu|qtest: Avoid dangerous arguments
>   qemu.py: Use iteritems rather than keys()
>   qemu.py: Simplify QMP key-conversion
>   qemu.py: Use custom exceptions rather than Exception
>   qmp.py: Couple of pylint/style fixes
>   qmp.py: Use object-based class for QEMUMonitorProtocol
>   qmp.py: Avoid "has_key" usage
>   qmp.py: Avoid overriding a builtin object
>   qtest.py: Few pylint/style fixes
> 
> Peter Maydell (1):
>   Update version for v2.10.0-rc0 release
> 
> Vladimir Sementsov-Ogievskiy (1):
>   qcow2-bitmap: fix bitmap_free
> 

Oups, I'm sorry I based it on a wrong master... I'll send v4 without those.

Lukáš