[Qemu-devel] [PATCH v5 0/6] arm: Make use of DEFINE_PROP_LINK

Fam Zheng posted 6 patches 6 years, 8 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170717023824.18796-1-famz@redhat.com
Test FreeBSD passed
Test checkpatch passed
Test docker passed
Test s390x passed
There is a newer version of this series
hw/arm/armv7m.c             | 16 ++++------------
hw/arm/xlnx-zynqmp.c        |  7 ++-----
hw/dma/xilinx_axidma.c      | 16 ++++------------
hw/intc/arm_gicv3_its_kvm.c | 19 +++++++------------
hw/net/xilinx_axienet.c     | 16 ++++------------
5 files changed, 21 insertions(+), 53 deletions(-)
[Qemu-devel] [PATCH v5 0/6] arm: Make use of DEFINE_PROP_LINK
Posted by Fam Zheng 6 years, 8 months ago
This is the arm part that was left out from:

https://lists.gnu.org/archive/html/qemu-devel/2017-07/msg04006.html

Make use of the new DEFINE_PROP_LINK, in favor of open coded the
object_property_add_link. The advantage of it is the property now get reflected
in the info qtree output, for a bit more introspectability.

Fam Zheng (6):
  armv7m: Convert bitband.source-mamory to DEFINE_PROP_LINK
  armv7m: Convert armv7m.memory to DEFINE_PROP_LINK
  gicv3: Convert to DEFINE_PROP_LINK
  xlnx_zynqmp: Convert to DEFINE_PROP_LINK
  xilinx_axienet: Convert to DEFINE_PROP_LINK
  xilinx_axidma: Convert to DEFINE_PROP_LINK

 hw/arm/armv7m.c             | 16 ++++------------
 hw/arm/xlnx-zynqmp.c        |  7 ++-----
 hw/dma/xilinx_axidma.c      | 16 ++++------------
 hw/intc/arm_gicv3_its_kvm.c | 19 +++++++------------
 hw/net/xilinx_axienet.c     | 16 ++++------------
 5 files changed, 21 insertions(+), 53 deletions(-)

-- 
2.9.4


Re: [Qemu-devel] [PATCH v5 0/6] arm: Make use of DEFINE_PROP_LINK
Posted by Fam Zheng 6 years, 6 months ago
Hi,

Ping for 2.11.

Peter, what do you think?

On Mon, 07/17 10:38, Fam Zheng wrote:
> This is the arm part that was left out from:
> 
> https://lists.gnu.org/archive/html/qemu-devel/2017-07/msg04006.html
> 
> Make use of the new DEFINE_PROP_LINK, in favor of open coded the
> object_property_add_link. The advantage of it is the property now get reflected
> in the info qtree output, for a bit more introspectability.
> 
> Fam Zheng (6):
>   armv7m: Convert bitband.source-mamory to DEFINE_PROP_LINK
>   armv7m: Convert armv7m.memory to DEFINE_PROP_LINK
>   gicv3: Convert to DEFINE_PROP_LINK
>   xlnx_zynqmp: Convert to DEFINE_PROP_LINK
>   xilinx_axienet: Convert to DEFINE_PROP_LINK
>   xilinx_axidma: Convert to DEFINE_PROP_LINK
> 
>  hw/arm/armv7m.c             | 16 ++++------------
>  hw/arm/xlnx-zynqmp.c        |  7 ++-----
>  hw/dma/xilinx_axidma.c      | 16 ++++------------
>  hw/intc/arm_gicv3_its_kvm.c | 19 +++++++------------
>  hw/net/xilinx_axienet.c     | 16 ++++------------
>  5 files changed, 21 insertions(+), 53 deletions(-)
> 
> -- 
> 2.9.4
> 
> 

Re: [Qemu-devel] [PATCH v5 0/6] arm: Make use of DEFINE_PROP_LINK
Posted by Peter Maydell 6 years, 6 months ago
On 5 September 2017 at 04:35, Fam Zheng <famz@redhat.com> wrote:
> Hi,
>
> Ping for 2.11.
>
> Peter, what do you think?
>
> On Mon, 07/17 10:38, Fam Zheng wrote:
>> This is the arm part that was left out from:
>>
>> https://lists.gnu.org/archive/html/qemu-devel/2017-07/msg04006.html
>>
>> Make use of the new DEFINE_PROP_LINK, in favor of open coded the
>> object_property_add_link. The advantage of it is the property now get reflected
>> in the info qtree output, for a bit more introspectability.
>>
>> Fam Zheng (6):
>>   armv7m: Convert bitband.source-mamory to DEFINE_PROP_LINK
>>   armv7m: Convert armv7m.memory to DEFINE_PROP_LINK
>>   gicv3: Convert to DEFINE_PROP_LINK
>>   xlnx_zynqmp: Convert to DEFINE_PROP_LINK
>>   xilinx_axienet: Convert to DEFINE_PROP_LINK
>>   xilinx_axidma: Convert to DEFINE_PROP_LINK

These look OK, but they've fallen out of the 'patches' cache.
There's a typo in the subject of the bitband one: should
be "memory", not "mamory". Can you fix that, add the reviewed-bys
and resend the series, please, and I'll put it in my queue?

thanks
-- PMM

Re: [Qemu-devel] [PATCH v5 0/6] arm: Make use of DEFINE_PROP_LINK
Posted by Fam Zheng 6 years, 6 months ago
On Tue, 09/05 11:43, Peter Maydell wrote:
> On 5 September 2017 at 04:35, Fam Zheng <famz@redhat.com> wrote:
> > Hi,
> >
> > Ping for 2.11.
> >
> > Peter, what do you think?
> >
> > On Mon, 07/17 10:38, Fam Zheng wrote:
> >> This is the arm part that was left out from:
> >>
> >> https://lists.gnu.org/archive/html/qemu-devel/2017-07/msg04006.html
> >>
> >> Make use of the new DEFINE_PROP_LINK, in favor of open coded the
> >> object_property_add_link. The advantage of it is the property now get reflected
> >> in the info qtree output, for a bit more introspectability.
> >>
> >> Fam Zheng (6):
> >>   armv7m: Convert bitband.source-mamory to DEFINE_PROP_LINK
> >>   armv7m: Convert armv7m.memory to DEFINE_PROP_LINK
> >>   gicv3: Convert to DEFINE_PROP_LINK
> >>   xlnx_zynqmp: Convert to DEFINE_PROP_LINK
> >>   xilinx_axienet: Convert to DEFINE_PROP_LINK
> >>   xilinx_axidma: Convert to DEFINE_PROP_LINK
> 
> These look OK, but they've fallen out of the 'patches' cache.
> There's a typo in the subject of the bitband one: should
> be "memory", not "mamory". Can you fix that, add the reviewed-bys
> and resend the series, please, and I'll put it in my queue?

Sure, sent v6.

Fam