slirp/ip6.h | 6 +++--- slirp/misc.c | 4 +++- slirp/sbuf.c | 2 +- slirp/socket.c | 52 +++++++++++++++++++++++++++++++++++----------------- 4 files changed, 42 insertions(+), 22 deletions(-)
warning: redirection vers https://people.debian.org/~sthibault/qemu.git/ The following changes since commit 4871b51b9241b10f4fd8e04bbb21577886795e25: vmgenid-test: use boot-sector infrastructure (2017-07-14 17:03:03 +0100) are available in the git repository at: http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault for you to fetch changes up to 75cb298d905030fca897ea1d80e409c7f7e3e5ea: slirp: Handle error returns from sosendoob() (2017-07-15 14:28:25 +0200) ---------------------------------------------------------------- slirp updates ---------------------------------------------------------------- Marc-André Lureau (1): slirp: use DIV_ROUND_UP Peter Maydell (3): slirp: fork_exec(): Don't close() a negative number in fork_exec() slirp: Handle error returns from slirp_send() in sosendoob() slirp: Handle error returns from sosendoob() slirp/ip6.h | 6 +++--- slirp/misc.c | 4 +++- slirp/sbuf.c | 2 +- slirp/socket.c | 52 +++++++++++++++++++++++++++++++++++----------------- 4 files changed, 42 insertions(+), 22 deletions(-)
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL 0/4] slirp updates Message-id: 20170715123057.8529-1-samuel.thibault@ens-lyon.org Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20170715123057.8529-1-samuel.thibault@ens-lyon.org -> patchew/20170715123057.8529-1-samuel.thibault@ens-lyon.org Switched to a new branch 'test' d550cce slirp: Handle error returns from sosendoob() 3ccee6a slirp: Handle error returns from slirp_send() in sosendoob() 17f0f61 slirp: fork_exec(): Don't close() a negative number in fork_exec() 861877a6 slirp: use DIV_ROUND_UP === OUTPUT BEGIN === Checking PATCH 1/4: slirp: use DIV_ROUND_UP... Checking PATCH 2/4: slirp: fork_exec(): Don't close() a negative number in fork_exec()... ERROR: code indent should never use tabs #27: FILE: slirp/misc.c:115: +^I^I^Iif (s >= 0) {$ ERROR: code indent should never use tabs #28: FILE: slirp/misc.c:116: +^I^I^I closesocket(s);$ ERROR: code indent should never use tabs #29: FILE: slirp/misc.c:117: +^I^I^I}$ total: 3 errors, 0 warnings, 10 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 3/4: slirp: Handle error returns from slirp_send() in sosendoob()... ERROR: code indent should never use tabs #35: FILE: slirp/socket.c:354: +^I^Iuint32_t urgc = so->so_urgc;$ ERROR: code indent should never use tabs #38: FILE: slirp/socket.c:356: +^I^Iif (len > urgc) {$ ERROR: code indent should never use tabs #39: FILE: slirp/socket.c:357: +^I^I^Ilen = urgc;$ ERROR: code indent should never use tabs #40: FILE: slirp/socket.c:358: +^I^I}$ ERROR: code indent should never use tabs #44: FILE: slirp/socket.c:360: +^I^Iurgc -= len;$ ERROR: code indent should never use tabs #45: FILE: slirp/socket.c:361: +^I^Iif (urgc) {$ ERROR: code indent should never use tabs #48: FILE: slirp/socket.c:363: +^I^I^Iif (n > urgc) {$ ERROR: code indent should never use tabs #49: FILE: slirp/socket.c:364: +^I^I^I^In = urgc;$ ERROR: code indent should never use tabs #50: FILE: slirp/socket.c:365: +^I^I^I}$ ERROR: code indent should never use tabs #56: FILE: slirp/socket.c:370: +^I}$ ERROR: code indent should never use tabs #61: FILE: slirp/socket.c:373: +^Iif (n != len) {$ ERROR: code indent should never use tabs #62: FILE: slirp/socket.c:374: +^I^IDEBUG_ERROR((dfd, "Didn't send all data urgently XXXXX\n"));$ ERROR: code indent should never use tabs #63: FILE: slirp/socket.c:375: +^I}$ ERROR: code indent should never use tabs #66: FILE: slirp/socket.c:377: +^Iif (n < 0) {$ ERROR: code indent should never use tabs #67: FILE: slirp/socket.c:378: +^I^Ireturn n;$ ERROR: code indent should never use tabs #69: FILE: slirp/socket.c:380: +^Iso->so_urgc -= n;$ ERROR: line over 90 characters #70: FILE: slirp/socket.c:381: + DEBUG_MISC((dfd, " ---2 sent %d bytes urgent data, %d urgent bytes left\n", n, so->so_urgc)); ERROR: code indent should never use tabs #70: FILE: slirp/socket.c:381: +^IDEBUG_MISC((dfd, " ---2 sent %d bytes urgent data, %d urgent bytes left\n", n, so->so_urgc));$ total: 18 errors, 0 warnings, 51 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 4/4: slirp: Handle error returns from sosendoob()... ERROR: code indent should never use tabs #27: FILE: slirp/sbuf.c:94: +^I^I(void)sosendoob(so);$ ERROR: code indent should never use tabs #40: FILE: slirp/socket.c:407: +^I^Iuint32_t expected = so->so_urgc;$ ERROR: code indent should never use tabs #41: FILE: slirp/socket.c:408: +^I^Iif (sosendoob(so) < expected) {$ ERROR: code indent should never use tabs #42: FILE: slirp/socket.c:409: +^I^I^I/* Treat a short write as a fatal error too,$ ERROR: code indent should never use tabs #43: FILE: slirp/socket.c:410: +^I^I^I * rather than continuing on and sending the urgent$ ERROR: code indent should never use tabs #44: FILE: slirp/socket.c:411: +^I^I^I * data as if it were non-urgent and leaving the$ ERROR: code indent should never use tabs #45: FILE: slirp/socket.c:412: +^I^I^I * so_urgc count wrong.$ ERROR: code indent should never use tabs #46: FILE: slirp/socket.c:413: +^I^I^I */$ ERROR: code indent should never use tabs #47: FILE: slirp/socket.c:414: +^I^I^Igoto err_disconnected;$ ERROR: code indent should never use tabs #48: FILE: slirp/socket.c:415: +^I^I}$ ERROR: code indent should never use tabs #61: FILE: slirp/socket.c:459: +^I^Igoto err_disconnected;$ WARNING: line over 80 characters #71: FILE: slirp/socket.c:488: + DEBUG_MISC((dfd, " --- sowrite disconnected, so->so_state = %x, errno = %d\n", ERROR: code indent should never use tabs #71: FILE: slirp/socket.c:488: +^IDEBUG_MISC((dfd, " --- sowrite disconnected, so->so_state = %x, errno = %d\n",$ ERROR: code indent should never use tabs #72: FILE: slirp/socket.c:489: +^I^I so->so_state, errno));$ ERROR: code indent should never use tabs #73: FILE: slirp/socket.c:490: +^Isofcantsendmore(so);$ ERROR: code indent should never use tabs #74: FILE: slirp/socket.c:491: +^Itcp_sockclosed(sototcpcb(so));$ ERROR: code indent should never use tabs #75: FILE: slirp/socket.c:492: +^Ireturn -1;$ total: 16 errors, 1 warnings, 49 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@freelists.org
On 15 July 2017 at 13:30, Samuel Thibault <samuel.thibault@ens-lyon.org> wrote: > warning: redirection vers https://people.debian.org/~sthibault/qemu.git/ > The following changes since commit 4871b51b9241b10f4fd8e04bbb21577886795e25: > > vmgenid-test: use boot-sector infrastructure (2017-07-14 17:03:03 +0100) > > are available in the git repository at: > > http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault > > for you to fetch changes up to 75cb298d905030fca897ea1d80e409c7f7e3e5ea: > > slirp: Handle error returns from sosendoob() (2017-07-15 14:28:25 +0200) > > ---------------------------------------------------------------- > slirp updates > > ---------------------------------------------------------------- > Marc-André Lureau (1): > slirp: use DIV_ROUND_UP > > Peter Maydell (3): > slirp: fork_exec(): Don't close() a negative number in fork_exec() > slirp: Handle error returns from slirp_send() in sosendoob() > slirp: Handle error returns from sosendoob() > > slirp/ip6.h | 6 +++--- > slirp/misc.c | 4 +++- > slirp/sbuf.c | 2 +- > slirp/socket.c | 52 +++++++++++++++++++++++++++++++++++----------------- > 4 files changed, 42 insertions(+), 22 deletions(-) Applied, thanks. -- PMM
© 2016 - 2024 Red Hat, Inc.