trace: update old trace events in docs

[Qemu-devel] [PATCH] trace: update old trace events in docs

Stefan Hajnoczi posted 1 patch 6 years, 9 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170714133111.27359-1-stefanha@redhat.com

Test FreeBSD passed

Test checkpatch passed

Test docker passed

Test s390x passed

docs/devel/tracing.txt | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH] trace: update old trace events in docs

Posted by Stefan Hajnoczi 6 years, 9 months ago

Commit c5f1ad429cdf26023cf331075a7d327708e3db6d ("block: Remove
bdrv_aio_readv/writev/flush()") removed
bdrv_aio_readv()/bdrv_aio_writev() so the example in the tracing
documentation is no longer valid.

Reported-by: Wang Dong <dongdwdw@linux.vnet.ibm.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 docs/devel/tracing.txt | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/docs/devel/tracing.txt b/docs/devel/tracing.txt
index 8c0029b..5768a0b 100644
--- a/docs/devel/tracing.txt
+++ b/docs/devel/tracing.txt
@@ -14,8 +14,7 @@ for debugging, profiling, and observing execution.
 
 2. Create a file with the events you want to trace:
 
-   echo bdrv_aio_readv   > /tmp/events
-   echo bdrv_aio_writev >> /tmp/events
+   echo memory_region_ops_read >/tmp/events
 
 3. Run the virtual machine to produce a trace file:
 
-- 
2.9.4

Re: [Qemu-devel] [PATCH] trace: update old trace events in docs

Posted by Eric Blake 6 years, 9 months ago

On 07/14/2017 08:31 AM, Stefan Hajnoczi wrote:
> Commit c5f1ad429cdf26023cf331075a7d327708e3db6d ("block: Remove
> bdrv_aio_readv/writev/flush()") removed
> bdrv_aio_readv()/bdrv_aio_writev() so the example in the tracing
> documentation is no longer valid.
> 
> Reported-by: Wang Dong <dongdwdw@linux.vnet.ibm.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  docs/devel/tracing.txt | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/docs/devel/tracing.txt b/docs/devel/tracing.txt
> index 8c0029b..5768a0b 100644
> --- a/docs/devel/tracing.txt
> +++ b/docs/devel/tracing.txt
> @@ -14,8 +14,7 @@ for debugging, profiling, and observing execution.
>  
>  2. Create a file with the events you want to trace:
>  
> -   echo bdrv_aio_readv   > /tmp/events
> -   echo bdrv_aio_writev >> /tmp/events
> +   echo memory_region_ops_read >/tmp/events
>  
>  3. Run the virtual machine to produce a trace file:
>  
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org