From nobody Thu May 2 16:50:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 14999827538731011.1372579598868; Thu, 13 Jul 2017 14:52:33 -0700 (PDT) Received: from localhost ([::1]:34137 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dVm2A-0008OF-J0 for importer@patchew.org; Thu, 13 Jul 2017 17:52:30 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43297) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dVm1Q-00085w-8m for qemu-devel@nongnu.org; Thu, 13 Jul 2017 17:51:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dVm1N-0000jx-6o for qemu-devel@nongnu.org; Thu, 13 Jul 2017 17:51:44 -0400 Received: from mail-lf0-x241.google.com ([2a00:1450:4010:c07::241]:35617) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dVm1M-0000jV-VW for qemu-devel@nongnu.org; Thu, 13 Jul 2017 17:51:41 -0400 Received: by mail-lf0-x241.google.com with SMTP id z78so6762908lff.2 for ; Thu, 13 Jul 2017 14:51:40 -0700 (PDT) Received: from neopili.qtec.com (cpe.xe-3-0-1-778.vbrnqe10.dk.customer.tdc.net. [80.197.57.18]) by smtp.gmail.com with ESMTPSA id t7sm1412106ljd.31.2017.07.13.14.51.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Jul 2017 14:51:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=c5tziBF1McdoZO6rJzmfaha4/vPG0fllFenRJbxF0bc=; b=Ar0JdNEihsVE0BM5nIztbowLhI9QWkjCXtg4pvUB1gjBJ4OKpvyCPPulWagaOXxR1L +xiuOvhTAY9IFopsPL63wEjyUlkqBsnU+JeRH+2RPJ5PGA1iS96Ebl8o7LwllwxD4Mxm z/Dnqu1hw+nO0+uaNmjZ+48csXAyEupDjBld61PzDaqWRbekJXoYQrbRp2QHFPC37AKj JTGco8nFEBWyTVfXDWgXspsrGsq02Tc6uf02MYwPZYTCuK0iJtW2p6M1eR1OGOKBBwpo 9r0+awn3Ak+QNGMTW/lBS+XzuDFH3VdjMIppoIKbhVdC3yrDWTScnnMMdEsuzKEtGlou wltw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=c5tziBF1McdoZO6rJzmfaha4/vPG0fllFenRJbxF0bc=; b=dzISOz7p7KrK+vwnsHCFa+/GPXQJCiMiLQwExOiiZhg+wGfa2ZtGVlVkNAFG+4d3d2 31hEIL4Q8e1ysnt5/XUrRv1yAp9B/9AToF1CNxNJVk4kQ1lSLV6x8wEhVsuWubCOJ4Ds JkJiRYKrb62giuf2WVbi0YsH5cWHFjD4sOQslFfx+6pLhYJMUHohqq0e/HJ207lgNA6o IEp5B/WBBAkgO05XYjgtQcjCsCSBEIly+dX9Q3QgOserRkN01QslkYbnT3Z/Qr6IxivO QySXC77OejFXUZR0XFaY6TiFkx7Kdij0VrWACBMCSmrUtF8uNgaam6ZIRRMLFe4Vixwg gPyQ== X-Gm-Message-State: AIVw111QSDyMNuuq8rWIXtWkRxJqPt9D0xzpAPgrqYsO+5Yy58tE1o8h eDTYRtEsleRtww== X-Received: by 10.25.33.203 with SMTP id h194mr1798294lfh.81.1499982699538; Thu, 13 Jul 2017 14:51:39 -0700 (PDT) From: Ricardo Ribalda Delgado To: Richard Henderson , qemu-devel@nongnu.org, ehabkost@redhat.com, pbonzini@redhat.com Date: Thu, 13 Jul 2017 23:51:37 +0200 Message-Id: <20170713215137.5307-1-ricardo.ribalda@gmail.com> X-Mailer: git-send-email 2.13.2 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::241 Subject: [Qemu-devel] [PATCH] target/i386: Fix ANDN (bmi) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ricardo Ribalda Delgado Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Operands on ANDN are swapped. Tested with the following function: long test_andn(long v1, long v2){ return (~v1 & v2); } Compiled with: gcc kk.c -mbmi -O3 -Wall 0000000000000910 : 910:c4 e2 c0 f2 c6 andn %rsi,%rdi,%rax 915:c3 retq 916:66 2e 0f 1f 84 00 00 nopw %cs:0x0(%rax,%rax,1) 91d:00 00 00 and gcc kk.c -march=3Dnative -O3 -Wall 0000000000000930 : 930: 48 f7 d7 not %rdi 933: 48 89 f8 mov %rdi,%rax 936: 48 21 f0 and %rsi,%rax 939: c3 retq 93a: 66 0f 1f 44 00 00 nopw 0x0(%rax,%rax,1) The test showed than -mbmi version behaved differently than the -march native version. Signed-off-by: Ricardo Ribalda Delgado --- target/i386/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/i386/translate.c b/target/i386/translate.c index 203623ef884c..1f39b497c19a 100644 --- a/target/i386/translate.c +++ b/target/i386/translate.c @@ -3774,7 +3774,7 @@ static void gen_sse(CPUX86State *env, DisasContext *s= , int b, } ot =3D mo_64_32(s->dflag); gen_ldst_modrm(env, s, modrm, ot, OR_TMP0, 0); - tcg_gen_andc_tl(cpu_T0, cpu_regs[s->vex_v], cpu_T0); + tcg_gen_andc_tl(cpu_T0, cpu_T0, cpu_regs[s->vex_v]); gen_op_mov_reg_v(ot, reg, cpu_T0); gen_op_update1_cc(); set_cc_op(s, CC_OP_LOGICB + ot); --=20 2.13.2