[Qemu-devel] [PATCH v6 0/4] block: Block driver callbacks fixes

Manos Pitsidianakis posted 4 patches 6 years, 8 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170713153028.31065-1-el13635@mail.ntua.gr
Test FreeBSD passed
Test checkpatch passed
Test docker passed
Test s390x passed
block.c                   | 35 +++++++++++++++++++----------------
block/blkdebug.c          | 20 ++------------------
block/commit.c            | 12 +-----------
block/io.c                | 26 ++++++++++++++++++++++++++
block/mirror.c            | 12 +-----------
block/raw-format.c        |  6 ------
include/block/block.h     |  1 -
include/block/block_int.h | 25 +++++++++++++++++++++++--
8 files changed, 72 insertions(+), 65 deletions(-)
[Qemu-devel] [PATCH v6 0/4] block: Block driver callbacks fixes
Posted by Manos Pitsidianakis 6 years, 8 months ago
This series makes implementing some of the bdrv_* callbacks easier for block
filters by passing requests to bs->file if bs->drv doesn't implement it instead
of failing, and adding default bdrv_co_get_block_status() implementations.

This is based against commit ced1484322 of 
https://github.com/XanClic/qemu.git block branch

v6:
  fix parameter order in bdrv_truncate() return call in 
      block: pass bdrv_* methods to bs->file by default in block filters

v5:
  rebase against ced1484322 of https://github.com/XanClic/qemu.git block to fix
  apply conflicts
  add suggested commit message in block: remove unused bdrv_media_changed
  add is_filter implication in commit message of block: remove bdrv_truncate
  callback in blkdebug

v4:
  forward only for block filters
  new patch: remove bdrv_media_changed
  dropped commit `block: Use defaults of bdrv_* callbacks in raw`, since raw is
  not a filter driver and is incompatible with the changes.

v3:
  minor changes by Eric Blake's suggestion
  new patch: remove bdrv_truncate method from blkdebug

v2:
  do not pass to bs->file if bs->drv is NULL
  move bs->file check outside of bdrv_inc_in_flight() area in bdrv_co_ioctl()
  new patch: remove duplicate code from block/raw-format.c

Manos Pitsidianakis (4):
  block: pass bdrv_* methods to bs->file by default in block filters
  block: remove unused bdrv_media_changed
  block: remove bdrv_truncate callback in blkdebug
  block: add default implementations for bdrv_co_get_block_status()

 block.c                   | 35 +++++++++++++++++++----------------
 block/blkdebug.c          | 20 ++------------------
 block/commit.c            | 12 +-----------
 block/io.c                | 26 ++++++++++++++++++++++++++
 block/mirror.c            | 12 +-----------
 block/raw-format.c        |  6 ------
 include/block/block.h     |  1 -
 include/block/block_int.h | 25 +++++++++++++++++++++++--
 8 files changed, 72 insertions(+), 65 deletions(-)

-- 
2.11.0


Re: [Qemu-devel] [PATCH v6 0/4] block: Block driver callbacks fixes
Posted by Kevin Wolf 6 years, 8 months ago
Am 13.07.2017 um 17:30 hat Manos Pitsidianakis geschrieben:
> This series makes implementing some of the bdrv_* callbacks easier for block
> filters by passing requests to bs->file if bs->drv doesn't implement it instead
> of failing, and adding default bdrv_co_get_block_status() implementations.
> 
> This is based against commit ced1484322 of 
> https://github.com/XanClic/qemu.git block branch

Thanks, applied to the block-next branch for 2.11.

Kevin