ppc/pnv: Remove unused XICSState reference

[Qemu-devel] [PATCH qemu] ppc/pnv: Remove unused XICSState reference

Posted by Alexey Kardashevskiy 6 years, 9 months ago

e6f7e110ee70 "ppc/xics: remove the XICSState classes" got rid of
XICSState, this is just an leftover.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
 include/hw/ppc/pnv_psi.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/include/hw/ppc/pnv_psi.h b/include/hw/ppc/pnv_psi.h
index 11d83e43f8..f6af5eae1f 100644
--- a/include/hw/ppc/pnv_psi.h
+++ b/include/hw/ppc/pnv_psi.h
@@ -28,8 +28,6 @@
 
 #define PSIHB_XSCOM_MAX         0x20
 
-typedef struct XICSState XICSState;
-
 typedef struct PnvPsi {
     SysBusDevice parent;
 
-- 
2.11.0

Re: [Qemu-devel] [Qemu-ppc] [PATCH qemu] ppc/pnv: Remove unused XICSState reference

Posted by Cédric Le Goater 6 years, 9 months ago

On 07/13/2017 08:21 AM, Alexey Kardashevskiy wrote:
> e6f7e110ee70 "ppc/xics: remove the XICSState classes" got rid of
> XICSState, this is just an leftover.
> 
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>

Indeed.

Reviewed-by: Cédric Le Goater <clg@kaod.org>

Thanks,

C.
> ---
>  include/hw/ppc/pnv_psi.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/include/hw/ppc/pnv_psi.h b/include/hw/ppc/pnv_psi.h
> index 11d83e43f8..f6af5eae1f 100644
> --- a/include/hw/ppc/pnv_psi.h
> +++ b/include/hw/ppc/pnv_psi.h
> @@ -28,8 +28,6 @@
>  
>  #define PSIHB_XSCOM_MAX         0x20
>  
> -typedef struct XICSState XICSState;
> -
>  typedef struct PnvPsi {
>      SysBusDevice parent;
>  
>

Re: [Qemu-devel] [PATCH qemu] ppc/pnv: Remove unused XICSState reference

Posted by David Gibson 6 years, 9 months ago

On Thu, Jul 13, 2017 at 04:21:28PM +1000, Alexey Kardashevskiy wrote:
> e6f7e110ee70 "ppc/xics: remove the XICSState classes" got rid of
> XICSState, this is just an leftover.
> 
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>

Applied to ppc-for-2.10, thanks.

> ---
>  include/hw/ppc/pnv_psi.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/include/hw/ppc/pnv_psi.h b/include/hw/ppc/pnv_psi.h
> index 11d83e43f8..f6af5eae1f 100644
> --- a/include/hw/ppc/pnv_psi.h
> +++ b/include/hw/ppc/pnv_psi.h
> @@ -28,8 +28,6 @@
>  
>  #define PSIHB_XSCOM_MAX         0x20
>  
> -typedef struct XICSState XICSState;
> -
>  typedef struct PnvPsi {
>      SysBusDevice parent;
>  

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson