[Qemu-devel] [PATCH v4 0/4] some gdbstub fixes for debug and vcont

Alex Bennée posted 4 patches 6 years, 9 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170712105216.747-1-alex.bennee@linaro.org
Test FreeBSD passed
Test checkpatch passed
Test docker passed
Test s390x passed
bsd-user/qemu.h        |   2 +
gdbstub.c              | 117 ++++++++++++++++++++++++-------------------------
include/exec/gdbstub.h |   9 ----
include/qom/cpu.h      |   2 -
linux-user/syscall.c   |   1 -
5 files changed, 59 insertions(+), 72 deletions(-)
[Qemu-devel] [PATCH v4 0/4] some gdbstub fixes for debug and vcont
Posted by Alex Bennée 6 years, 9 months ago
Hi Paolo,

I was going through my review queue and realised I had this hanging
around with an outstanding comment. Basically the only change is to
fix the bsd-user build by adding a field for the thread-id. It isn't
populated but it never was and it looks like the gdbstub for threaded
bsd-user programs has been broken forever.

Given the range of different ways of getting a thread-id and the fact
the bsd fork machinery looks like it needs updating anyway I'd left
this for a future BSD maintainer to fix up properly.

Are you happy to take this into your tree?

Alex Bennée (4):
  gdbstub: modernise DEBUG_GDB
  gdbstub: rename cpu_index -> cpu_gdb_index
  qom/cpu: remove host_tid field
  gdbstub: don't fail on vCont;C04:0;c packets

 bsd-user/qemu.h        |   2 +
 gdbstub.c              | 117 ++++++++++++++++++++++++-------------------------
 include/exec/gdbstub.h |   9 ----
 include/qom/cpu.h      |   2 -
 linux-user/syscall.c   |   1 -
 5 files changed, 59 insertions(+), 72 deletions(-)

-- 
2.13.0


Re: [Qemu-devel] [PATCH v4 0/4] some gdbstub fixes for debug and vcont
Posted by Philippe Mathieu-Daudé 6 years, 9 months ago
CC'ed Kamil Rytarowski (new NetBSD maintainer)

On 07/12/2017 07:52 AM, Alex Bennée wrote:
> Hi Paolo,
> 
> I was going through my review queue and realised I had this hanging
> around with an outstanding comment. Basically the only change is to
> fix the bsd-user build by adding a field for the thread-id. It isn't
> populated but it never was and it looks like the gdbstub for threaded
> bsd-user programs has been broken forever.
> 
> Given the range of different ways of getting a thread-id and the fact
> the bsd fork machinery looks like it needs updating anyway I'd left
> this for a future BSD maintainer to fix up properly.
> 
> Are you happy to take this into your tree?
> 
> Alex Bennée (4):
>    gdbstub: modernise DEBUG_GDB
>    gdbstub: rename cpu_index -> cpu_gdb_index
>    qom/cpu: remove host_tid field
>    gdbstub: don't fail on vCont;C04:0;c packets
> 
>   bsd-user/qemu.h        |   2 +
>   gdbstub.c              | 117 ++++++++++++++++++++++++-------------------------
>   include/exec/gdbstub.h |   9 ----
>   include/qom/cpu.h      |   2 -
>   linux-user/syscall.c   |   1 -
>   5 files changed, 59 insertions(+), 72 deletions(-)
> 

Re: [Qemu-devel] [PATCH v4 0/4] some gdbstub fixes for debug and vcont
Posted by Paolo Bonzini 6 years, 9 months ago
On 12/07/2017 12:52, Alex Bennée wrote:
> Hi Paolo,
> 
> I was going through my review queue and realised I had this hanging
> around with an outstanding comment. Basically the only change is to
> fix the bsd-user build by adding a field for the thread-id. It isn't
> populated but it never was and it looks like the gdbstub for threaded
> bsd-user programs has been broken forever.
> 
> Given the range of different ways of getting a thread-id and the fact
> the bsd fork machinery looks like it needs updating anyway I'd left
> this for a future BSD maintainer to fix up properly.
> 
> Are you happy to take this into your tree?

Yes, I will include it in my pull request.

Paolo