[v2] nbd refactoring part 2

[Qemu-devel] [PATCH v2 0/6] nbd refactoring part 2

Vladimir Sementsov-Ogievskiy posted 6 patches 6 years, 10 months ago

Diff against v3
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170621153424.16690-1-vsementsov@virtuozzo.com

Test FreeBSD passed

Test checkpatch passed

Test docker passed

Test s390x passed

There is a newer version of this series

Makefile.objs      |   1 +
nbd/client.c       |  87 +++++--------
nbd/common.c       |   4 +-
nbd/nbd-internal.h |  19 ---
nbd/server.c       | 368 +++++++++++++++++++++++++++++++----------------------
nbd/trace-events   |  68 ++++++++++
6 files changed, 320 insertions(+), 227 deletions(-)
create mode 100644 nbd/trace-events

Expand all Fold all

[Qemu-devel] [PATCH v2 0/6] nbd refactoring part 2

Posted by Vladimir Sementsov-Ogievskiy 6 years, 10 months ago

This is last part of "nbd errors and traces refactoring".

Patches 01-10 from "nbd errors and traces refactoring" are already merged.
Patches 11-13 from it are rejected - do not regret them.
So, these series is update of 14-19 patches from "nbd errors and traces
refactoring"

v2:
01: EPIPE not handled
    imporve comments
02: rebased on absence of old patch 13, errors are not saved into
    separate ret variable
    TRACE on fail of sending NBD_REP_ACK reply to NBD_OPT_ABORT
    instead of error propagating and EPIPE handling
03: fix error_prepend
04: just remove this TRACE
05: just trace nbd magic as 64bit number
06: improve commit message
    simplify trace_nbd_receive_negotiate_server_flags - do not trace
    separate flags
    add trace_nbd_opt_abort_reply_failed
    remove tail periods from traces


Vladimir Sementsov-Ogievskiy (6):
  nbd/server: nbd_negotiate: return 1 on NBD_OPT_ABORT
  nbd/server: use errp instead of LOG
  nbd/server: add errp to nbd_send_reply()
  nbd/common: nbd_tls_handshake: remove extra TRACE
  nbd/client: refactor TRACE of NBD_MAGIC
  nbd: use generic trace subsystem instead of TRACE macro

 Makefile.objs      |   1 +
 nbd/client.c       |  87 +++++--------
 nbd/common.c       |   4 +-
 nbd/nbd-internal.h |  19 ---
 nbd/server.c       | 368 +++++++++++++++++++++++++++++++----------------------
 nbd/trace-events   |  68 ++++++++++
 6 files changed, 320 insertions(+), 227 deletions(-)
 create mode 100644 nbd/trace-events

-- 
2.11.1