sdl2: add assert to make coverity happy

[Qemu-devel] [PATCH] sdl2: add assert to make coverity happy

Gerd Hoffmann posted 1 patch 6 years, 10 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170621122234.12751-1-kraxel@redhat.com

Test FreeBSD passed

Test checkpatch passed

Test docker passed

Test s390x passed

ui/sdl2.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[Qemu-devel] [PATCH] sdl2: add assert to make coverity happy

Posted by Gerd Hoffmann 6 years, 10 months ago

There is a loop a few lines up counting consoles and setting
sdl2_num_outputs accordingly, so con ptr can't be NULL there.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 ui/sdl2.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ui/sdl2.c b/ui/sdl2.c
index f76ee1081f..53dd447fd2 100644
--- a/ui/sdl2.c
+++ b/ui/sdl2.c
@@ -804,6 +804,7 @@ void sdl_display_init(DisplayState *ds, int full_screen, int no_frame)
     sdl2_console = g_new0(struct sdl2_console, sdl2_num_outputs);
     for (i = 0; i < sdl2_num_outputs; i++) {
         QemuConsole *con = qemu_console_lookup_by_index(i);
+        assert(con != NULL);
         if (!qemu_console_is_graphic(con)) {
             sdl2_console[i].hidden = true;
         }
-- 
2.9.3

Re: [Qemu-devel] [PATCH] sdl2: add assert to make coverity happy

Posted by Stefan Hajnoczi 6 years, 10 months ago

On Wed, Jun 21, 2017 at 02:22:34PM +0200, Gerd Hoffmann wrote:
> There is a loop a few lines up counting consoles and setting
> sdl2_num_outputs accordingly, so con ptr can't be NULL there.
> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  ui/sdl2.c | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>