[v1] Remove of loadvm handlers

[Qemu-devel] [PATCH 0/3] Remove of loadvm handlers

Juan Quintela posted 3 patches 6 years, 10 months ago

Diff against v2 v3
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170524085519.22856-1-quintela@redhat.com

Test checkpatch passed

Test docker passed

Test s390x passed

There is a newer version of this series

include/migration/migration.h |  5 ----
include/migration/vmstate.h   |  2 --
include/qemu/typedefs.h       |  1 -
migration/migration.c         |  2 --
migration/savevm.c            | 58 ++++++++++++-------------------------------
5 files changed, 16 insertions(+), 52 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH 0/3] Remove of loadvm handlers

Posted by Juan Quintela 6 years, 10 months ago

Hi

We just have a loadvm handlers that are a new list only used in a
single place.  Just move everything to use the savevm_handlers (yes,
it is a list, and we could have a better name).

Once there, vmstate_load() had three arguments but only needs two.  Fix that.

Please, review.

Juan Quintela (3):
  migration: Use savevm_handlers instead of loadvm copy
  migration: loadvm handlers are not used
  migration: Remove section_id parameter from vmstate_load

 include/migration/migration.h |  5 ----
 include/migration/vmstate.h   |  2 --
 include/qemu/typedefs.h       |  1 -
 migration/migration.c         |  2 --
 migration/savevm.c            | 58 ++++++++++++-------------------------------
 5 files changed, 16 insertions(+), 52 deletions(-)

-- 
2.9.3

Re: [Qemu-devel] [PATCH 0/3] Remove of loadvm handlers

Posted by Peter Xu 6 years, 10 months ago

On Wed, May 24, 2017 at 10:55:16AM +0200, Juan Quintela wrote:
> Hi
> 
> We just have a loadvm handlers that are a new list only used in a
> single place.  Just move everything to use the savevm_handlers (yes,
> it is a list, and we could have a better name).
> 
> Once there, vmstate_load() had three arguments but only needs two.  Fix that.
> 
> Please, review.
> 
> Juan Quintela (3):
>   migration: Use savevm_handlers instead of loadvm copy
>   migration: loadvm handlers are not used
>   migration: Remove section_id parameter from vmstate_load
> 
>  include/migration/migration.h |  5 ----
>  include/migration/vmstate.h   |  2 --
>  include/qemu/typedefs.h       |  1 -
>  migration/migration.c         |  2 --
>  migration/savevm.c            | 58 ++++++++++++-------------------------------
>  5 files changed, 16 insertions(+), 52 deletions(-)
> 
> -- 
> 2.9.3
> 

This series looks nice to me. :-)

Series:

Reviewed-by: Peter Xu <peterx@redhat.com>

Thanks,

-- 
Peter Xu