[Qemu-devel] [PATCH] docker: Add flex and bison to centos6 image

Fam Zheng posted 1 patch 6 years, 11 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170524005206.31916-1-famz@redhat.com
Test checkpatch passed
Test docker passed
Test s390x passed
tests/docker/dockerfiles/centos6.docker | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[Qemu-devel] [PATCH] docker: Add flex and bison to centos6 image
Posted by Fam Zheng 6 years, 11 months ago
Currently there are warnings about flex and bison being missing when
building in the centos6 image:

    make[1]: flex: Command not found
             BISON dtc-parser.tab.c
    make[1]: bison: Command not found

Add them.

Reported-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
---
 tests/docker/dockerfiles/centos6.docker | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/docker/dockerfiles/centos6.docker b/tests/docker/dockerfiles/centos6.docker
index 34e0d3b..17a4d24 100644
--- a/tests/docker/dockerfiles/centos6.docker
+++ b/tests/docker/dockerfiles/centos6.docker
@@ -1,7 +1,7 @@
 FROM centos:6
 RUN yum install -y epel-release
 ENV PACKAGES libfdt-devel ccache \
-    tar git make gcc g++ \
+    tar git make gcc g++ flex bison \
     zlib-devel glib2-devel SDL-devel pixman-devel \
     epel-release
 RUN yum install -y $PACKAGES
-- 
2.9.4


Re: [Qemu-devel] [PATCH] docker: Add flex and bison to centos6 image
Posted by Philippe Mathieu-Daudé 6 years, 11 months ago
On 05/23/2017 09:52 PM, Fam Zheng wrote:
> Currently there are warnings about flex and bison being missing when
> building in the centos6 image:
>
>     make[1]: flex: Command not found
>              BISON dtc-parser.tab.c
>     make[1]: bison: Command not found
>
> Add them.

I had the same issue with debian based images :/

>
> Reported-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Fam Zheng <famz@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
>  tests/docker/dockerfiles/centos6.docker | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/docker/dockerfiles/centos6.docker b/tests/docker/dockerfiles/centos6.docker
> index 34e0d3b..17a4d24 100644
> --- a/tests/docker/dockerfiles/centos6.docker
> +++ b/tests/docker/dockerfiles/centos6.docker
> @@ -1,7 +1,7 @@
>  FROM centos:6
>  RUN yum install -y epel-release
>  ENV PACKAGES libfdt-devel ccache \
> -    tar git make gcc g++ \
> +    tar git make gcc g++ flex bison \
>      zlib-devel glib2-devel SDL-devel pixman-devel \
>      epel-release
>  RUN yum install -y $PACKAGES
>

Re: [Qemu-devel] [PATCH] docker: Add flex and bison to centos6 image
Posted by Alex Bennée 6 years, 11 months ago
Fam Zheng <famz@redhat.com> writes:

> Currently there are warnings about flex and bison being missing when
> building in the centos6 image:
>
>     make[1]: flex: Command not found
>              BISON dtc-parser.tab.c
>     make[1]: bison: Command not found
>
> Add them.
>
> Reported-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Fam Zheng <famz@redhat.com>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

> ---
>  tests/docker/dockerfiles/centos6.docker | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/docker/dockerfiles/centos6.docker b/tests/docker/dockerfiles/centos6.docker
> index 34e0d3b..17a4d24 100644
> --- a/tests/docker/dockerfiles/centos6.docker
> +++ b/tests/docker/dockerfiles/centos6.docker
> @@ -1,7 +1,7 @@
>  FROM centos:6
>  RUN yum install -y epel-release
>  ENV PACKAGES libfdt-devel ccache \
> -    tar git make gcc g++ \
> +    tar git make gcc g++ flex bison \
>      zlib-devel glib2-devel SDL-devel pixman-devel \
>      epel-release
>  RUN yum install -y $PACKAGES


--
Alex Bennée