Hi, This patchset fixes some of issues I encountered when trying to use vvfat, and fixes bug #1599539: https://bugs.launchpad.net/qemu/+bug/1599539 Patch 1 fixes a crash when using 'qemu-img convert'. Patches 2 to 6 are code cleanup. No functionnal changes. Patches 7 to 13 fix problems detected by disk checking utilities in read-only mode. With these patches, vvfat creates valid FAT volumes and can be used with QEMU disk utilities. Read-write mode is still buggy after this patchset, but at least, I was not able to crash QEMU anymore. Note that patch 2 doesn't pass checkpatch.pl, as it changes indentation only. Hervé Changes v1->v2: - small changes following Kevin remarks (patches 3, 5, 6) - use g_utf8_* functions instead of ad-hock code (patches 8 and 9) - fix a bug with filenames starting with a dot (patch 9) Hervé Poussineau (13): vvfat: fix qemu-img map and qemu-img convert vvfat: replace tabs by 8 spaces vvfat: fix typos vvfat: rename useless enumeration values vvfat: introduce offset_to_bootsector, offset_to_fat and offset_to_root_dir vvfat: fix field names in FAT12/FAT16 and FAT32 boot sectors vvfat: always create . and .. entries at first and in that order vvfat: correctly create long names for non-ASCII filenames vvfat: correctly create base short names for non-ASCII filenames vvfat: correctly generate numeric-tail of short file names vvfat: limit number of entries in root directory in FAT12/FAT16 vvfat: handle KANJI lead byte 0xe5 vvfat: change OEM name to 'MSWIN4.1' block/vvfat.c | 2306 ++++++++++++++++++++++++++++++--------------------------- 1 file changed, 1198 insertions(+), 1108 deletions(-) -- 2.11.0
Am 22.05.2017 um 23:11 hat Hervé Poussineau geschrieben: > Hi, > > This patchset fixes some of issues I encountered when trying to use vvfat, and fixes > bug #1599539: https://bugs.launchpad.net/qemu/+bug/1599539 > > Patch 1 fixes a crash when using 'qemu-img convert'. > Patches 2 to 6 are code cleanup. No functionnal changes. > Patches 7 to 13 fix problems detected by disk checking utilities in read-only mode. > > With these patches, vvfat creates valid FAT volumes and can be used with QEMU disk utilities. > > Read-write mode is still buggy after this patchset, but at least, I was not > able to crash QEMU anymore. > > Note that patch 2 doesn't pass checkpatch.pl, as it changes indentation only. Thanks, fixed the build error in patch 9 (yet unused variables) and applied to the block branch. There were a few more minor comments for this series, but it has been on the list for long enough and I figured that they can be addressed on top. Kevin
Hi, Thanks to have taken this patch series. However, I already have in my repository the v3 patch series, whose changelog is: Changes v2->v3: - added patches 5, 12, 16 - fixed warning (unused variable) (patch 11) - added #defines for constants for deleted byte following Philippe remarks (patch 14) - added #define and explanations for OEM name following Philippe remarks (patch 15) Changes v1->v2: - small changes following Kevin remarks (patches 3, 5, 6) - use g_utf8_* functions instead of ad-hock code (patches 8 and 9) - fix a bug with filenames starting with a dot (patch 9) Hervé Poussineau (16): vvfat: fix qemu-img map and qemu-img convert vvfat: replace tabs by 8 spaces vvfat: fix typos vvfat: rename useless enumeration values vvfat: add constants for special values of name[0] vvfat: introduce offset_to_bootsector, offset_to_fat and offset_to_root_dir vvfat: fix field names in FAT12/FAT16 and FAT32 boot sectors vvfat: always create . and .. entries at first and in that order vvfat: correctly create long names for non-ASCII filenames vvfat: correctly create base short names for non-ASCII filenames vvfat: correctly generate numeric-tail of short file names vvfat: correctly parse non-ASCII short and long file names vvfat: limit number of entries in root directory in FAT12/FAT16 vvfat: handle KANJI lead byte 0xe5 vvfat: change OEM name to 'MSWIN4.1' vvfat: initialize memory after allocating it Should I rebase on top of your branch, or should I send the v3 as is? It fixes the last random errors I had in Win9x Scandisk (uninitialized memory). Regards, Hervé Le 03/07/2017 à 18:50, Kevin Wolf a écrit : > Am 22.05.2017 um 23:11 hat Hervé Poussineau geschrieben: >> Hi, >> >> This patchset fixes some of issues I encountered when trying to use vvfat, and fixes >> bug #1599539: https://bugs.launchpad.net/qemu/+bug/1599539 >> >> Patch 1 fixes a crash when using 'qemu-img convert'. >> Patches 2 to 6 are code cleanup. No functionnal changes. >> Patches 7 to 13 fix problems detected by disk checking utilities in read-only mode. >> >> With these patches, vvfat creates valid FAT volumes and can be used with QEMU disk utilities. >> >> Read-write mode is still buggy after this patchset, but at least, I was not >> able to crash QEMU anymore. >> >> Note that patch 2 doesn't pass checkpatch.pl, as it changes indentation only. > > Thanks, fixed the build error in patch 9 (yet unused variables) and > applied to the block branch. > > There were a few more minor comments for this series, but it has been on > the list for long enough and I figured that they can be addressed on > top. > > Kevin >
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20170522211205.14265-1-hpoussin@reactos.org Subject: [Qemu-devel] [PATCH v2 00/13] vvfat: misc fixes for read-only mode Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' a44e0b9 vvfat: change OEM name to 'MSWIN4.1' ff2c35b vvfat: handle KANJI lead byte 0xe5 6e11c6c vvfat: limit number of entries in root directory in FAT12/FAT16 e5687f8 vvfat: correctly generate numeric-tail of short file names 20780e0 vvfat: correctly create base short names for non-ASCII filenames 2d4bf63 vvfat: correctly create long names for non-ASCII filenames 48accbf vvfat: always create . and .. entries at first and in that order 3105081 vvfat: fix field names in FAT12/FAT16 and FAT32 boot sectors 6f108da vvfat: introduce offset_to_bootsector, offset_to_fat and offset_to_root_dir a4cbca8 vvfat: rename useless enumeration values 663af27 vvfat: fix typos 76286f8 vvfat: replace tabs by 8 spaces e4e4ff3 vvfat: fix qemu-img map and qemu-img convert === OUTPUT BEGIN === Checking PATCH 1/13: vvfat: fix qemu-img map and qemu-img convert... Checking PATCH 2/13: vvfat: replace tabs by 8 spaces... ERROR: braces {} are necessary for all arms of this statement #33: FILE: block/vvfat.c:106: + if (!array->pointer) [...] ERROR: spaces required around that '=' (ctx:VxV) #56: FILE: block/vvfat.c:127: + int increment=count*array->item_size; ^ ERROR: spaces required around that '*' (ctx:VxV) #56: FILE: block/vvfat.c:127: + int increment=count*array->item_size; ^ ERROR: spaces required around that '=' (ctx:VxV) #57: FILE: block/vvfat.c:128: + array->pointer=g_realloc(array->pointer,array->size+increment); ^ ERROR: space required after that ',' (ctx:VxV) #57: FILE: block/vvfat.c:128: + array->pointer=g_realloc(array->pointer,array->size+increment); ^ ERROR: spaces required around that '+' (ctx:VxV) #57: FILE: block/vvfat.c:128: + array->pointer=g_realloc(array->pointer,array->size+increment); ^ ERROR: space required before the open parenthesis '(' #58: FILE: block/vvfat.c:129: + if(!array->pointer) ERROR: braces {} are necessary for all arms of this statement #58: FILE: block/vvfat.c:129: + if(!array->pointer) [...] ERROR: spaces required around that '+=' (ctx:VxV) #61: FILE: block/vvfat.c:131: + array->size+=increment; ^ ERROR: spaces required around that '+' (ctx:VxV) #66: FILE: block/vvfat.c:134: + array->pointer+index*array->item_size, ^ ERROR: spaces required around that '*' (ctx:VxV) #66: FILE: block/vvfat.c:134: + array->pointer+index*array->item_size, ^ ERROR: spaces required around that '-' (ctx:VxV) #67: FILE: block/vvfat.c:135: + (array->next-index)*array->item_size); ^ ERROR: spaces required around that '*' (ctx:VxV) #67: FILE: block/vvfat.c:135: + (array->next-index)*array->item_size); ^ ERROR: spaces required around that '<' (ctx:VxV) #78: FILE: block/vvfat.c:150: + index_to<0 || index_to>=array->next || ^ ERROR: spaces required around that '>=' (ctx:VxV) #78: FILE: block/vvfat.c:150: + index_to<0 || index_to>=array->next || ^ ERROR: spaces required around that '<' (ctx:VxV) #79: FILE: block/vvfat.c:151: + index_from<0 || index_from>=array->next) ^ ERROR: spaces required around that '>=' (ctx:VxV) #79: FILE: block/vvfat.c:151: + index_from<0 || index_from>=array->next) ^ ERROR: spaces required around that '+' (ctx:VxV) #93: FILE: block/vvfat.c:164: + memmove(to+is*count,to,from-to); ^ ERROR: spaces required around that '*' (ctx:VxV) #93: FILE: block/vvfat.c:164: + memmove(to+is*count,to,from-to); ^ ERROR: space required after that ',' (ctx:VxV) #93: FILE: block/vvfat.c:164: + memmove(to+is*count,to,from-to); ^ ERROR: space required after that ',' (ctx:VxV) #93: FILE: block/vvfat.c:164: + memmove(to+is*count,to,from-to); ^ ERROR: spaces required around that '-' (ctx:VxV) #93: FILE: block/vvfat.c:164: + memmove(to+is*count,to,from-to); ^ ERROR: space required after that ',' (ctx:VxV) #96: FILE: block/vvfat.c:166: + memmove(from,from+is*count,to-from); ^ ERROR: spaces required around that '+' (ctx:VxV) #96: FILE: block/vvfat.c:166: + memmove(from,from+is*count,to-from); ^ ERROR: spaces required around that '*' (ctx:VxV) #96: FILE: block/vvfat.c:166: + memmove(from,from+is*count,to-from); ^ ERROR: space required after that ',' (ctx:VxV) #96: FILE: block/vvfat.c:166: + memmove(from,from+is*count,to-from); ^ ERROR: spaces required around that '-' (ctx:VxV) #96: FILE: block/vvfat.c:166: + memmove(from,from+is*count,to-from); ^ ERROR: space required after that ',' (ctx:VxV) #137: FILE: block/vvfat.c:229: + uint8_t major,minor; ^ ERROR: spaces required around that '*' (ctx:VxV) #191: FILE: block/vvfat.c:423: + dest[2*i+1]=0; ^ ERROR: spaces required around that '+' (ctx:VxV) #191: FILE: block/vvfat.c:423: + dest[2*i+1]=0; ^ ERROR: spaces required around that '=' (ctx:VxV) #191: FILE: block/vvfat.c:423: + dest[2*i+1]=0; ^ ERROR: spaces required around that '=' (ctx:VxV) #197: FILE: block/vvfat.c:428: + dest[i]=0xff; ^ ERROR: spaces required around that '=' (ctx:VxV) #210: FILE: block/vvfat.c:440: + entry=array_get_next(&(s->directory)); ^ ERROR: spaces required around that '=' (ctx:VxV) #211: FILE: block/vvfat.c:441: + entry->attributes=0xf; ^ ERROR: spaces required around that '=' (ctx:VxV) #212: FILE: block/vvfat.c:442: + entry->reserved[0]=0; ^ ERROR: spaces required around that '=' (ctx:VxV) #213: FILE: block/vvfat.c:443: + entry->begin=0; ^ ERROR: spaces required around that '=' (ctx:VxV) #214: FILE: block/vvfat.c:444: + entry->name[0]=(number_of_entries-i)|(i==0?0x40:0); ^ ERROR: spaces required around that '-' (ctx:VxV) #214: FILE: block/vvfat.c:444: + entry->name[0]=(number_of_entries-i)|(i==0?0x40:0); ^ ERROR: spaces required around that '|' (ctx:VxV) #214: FILE: block/vvfat.c:444: + entry->name[0]=(number_of_entries-i)|(i==0?0x40:0); ^ ERROR: spaces required around that '==' (ctx:VxV) #214: FILE: block/vvfat.c:444: + entry->name[0]=(number_of_entries-i)|(i==0?0x40:0); ^ ERROR: spaces required around that '?' (ctx:VxV) #214: FILE: block/vvfat.c:444: + entry->name[0]=(number_of_entries-i)|(i==0?0x40:0); ^ ERROR: spaces required around that ':' (ctx:VxV) #214: FILE: block/vvfat.c:444: + entry->name[0]=(number_of_entries-i)|(i==0?0x40:0); ^ ERROR: spaces required around that '=' (ctx:VxV) #223: FILE: block/vvfat.c:447: + int offset=(i%26); ^ ERROR: spaces required around that '%' (ctx:VxV) #223: FILE: block/vvfat.c:447: + int offset=(i%26); ^ ERROR: spaces required around that '<' (ctx:VxV) #224: FILE: block/vvfat.c:448: + if(offset<10) offset=1+offset; ^ ERROR: spaces required around that '=' (ctx:VxV) #224: FILE: block/vvfat.c:448: + if(offset<10) offset=1+offset; ^ ERROR: spaces required around that '+' (ctx:VxV) #224: FILE: block/vvfat.c:448: + if(offset<10) offset=1+offset; ^ ERROR: space required before the open parenthesis '(' #224: FILE: block/vvfat.c:448: + if(offset<10) offset=1+offset; ERROR: trailing statements should be on next line #224: FILE: block/vvfat.c:448: + if(offset<10) offset=1+offset; ERROR: braces {} are necessary for all arms of this statement #224: FILE: block/vvfat.c:448: + if(offset<10) offset=1+offset; [...] + else if(offset<22) offset=14+offset-10; [...] + else offset=28+offset-22; [...] ERROR: spaces required around that '<' (ctx:VxV) #225: FILE: block/vvfat.c:449: + else if(offset<22) offset=14+offset-10; ^ ERROR: spaces required around that '=' (ctx:VxV) #225: FILE: block/vvfat.c:449: + else if(offset<22) offset=14+offset-10; ^ ERROR: spaces required around that '+' (ctx:VxV) #225: FILE: block/vvfat.c:449: + else if(offset<22) offset=14+offset-10; ^ ERROR: spaces required around that '-' (ctx:VxV) #225: FILE: block/vvfat.c:449: + else if(offset<22) offset=14+offset-10; ^ ERROR: space required before the open parenthesis '(' #225: FILE: block/vvfat.c:449: + else if(offset<22) offset=14+offset-10; ERROR: trailing statements should be on next line #225: FILE: block/vvfat.c:449: + else if(offset<22) offset=14+offset-10; ERROR: braces {} are necessary for all arms of this statement #225: FILE: block/vvfat.c:449: + else if(offset<22) offset=14+offset-10; [...] + else offset=28+offset-22; [...] ERROR: spaces required around that '=' (ctx:VxV) #226: FILE: block/vvfat.c:450: + else offset=28+offset-22; ^ ERROR: spaces required around that '+' (ctx:VxV) #226: FILE: block/vvfat.c:450: + else offset=28+offset-22; ^ ERROR: spaces required around that '-' (ctx:VxV) #226: FILE: block/vvfat.c:450: + else offset=28+offset-22; ^ ERROR: trailing statements should be on next line #226: FILE: block/vvfat.c:450: + else offset=28+offset-22; ERROR: spaces required around that '=' (ctx:VxV) #227: FILE: block/vvfat.c:451: + entry=array_get(&(s->directory),s->directory.next-1-(i/26)); ^ ERROR: space required after that ',' (ctx:VxV) #227: FILE: block/vvfat.c:451: + entry=array_get(&(s->directory),s->directory.next-1-(i/26)); ^ ERROR: spaces required around that '-' (ctx:VxV) #227: FILE: block/vvfat.c:451: + entry=array_get(&(s->directory),s->directory.next-1-(i/26)); ^ ERROR: spaces required around that '-' (ctx:VxV) #227: FILE: block/vvfat.c:451: + entry=array_get(&(s->directory),s->directory.next-1-(i/26)); ^ ERROR: spaces required around that '/' (ctx:VxV) #227: FILE: block/vvfat.c:451: + entry=array_get(&(s->directory),s->directory.next-1-(i/26)); ^ ERROR: spaces required around that '=' (ctx:VxV) #228: FILE: block/vvfat.c:452: + entry->name[offset]=buffer[i]; ^ ERROR: spaces required around that '/' (ctx:VxV) #246: FILE: block/vvfat.c:531: + return cpu_to_le16((t->tm_sec/2)|(t->tm_min<<5)|(t->tm_hour<<11)); ^ ERROR: spaces required around that '|' (ctx:VxV) #246: FILE: block/vvfat.c:531: + return cpu_to_le16((t->tm_sec/2)|(t->tm_min<<5)|(t->tm_hour<<11)); ^ ERROR: spaces required around that '<<' (ctx:VxV) #246: FILE: block/vvfat.c:531: + return cpu_to_le16((t->tm_sec/2)|(t->tm_min<<5)|(t->tm_hour<<11)); ^ ERROR: spaces required around that '|' (ctx:VxV) #246: FILE: block/vvfat.c:531: + return cpu_to_le16((t->tm_sec/2)|(t->tm_min<<5)|(t->tm_hour<<11)); ^ ERROR: spaces required around that '<<' (ctx:VxV) #246: FILE: block/vvfat.c:531: + return cpu_to_le16((t->tm_sec/2)|(t->tm_min<<5)|(t->tm_hour<<11)); ^ ERROR: "foo* bar" should be "foo *bar" #255: FILE: block/vvfat.c:538: + uint32_t* entry=array_get(&(s->fat),cluster); ERROR: spaces required around that '=' (ctx:VxV) #255: FILE: block/vvfat.c:538: + uint32_t* entry=array_get(&(s->fat),cluster); ^ ERROR: space required after that ',' (ctx:VxV) #255: FILE: block/vvfat.c:538: + uint32_t* entry=array_get(&(s->fat),cluster); ^ ERROR: spaces required around that '=' (ctx:VxV) #256: FILE: block/vvfat.c:539: + *entry=cpu_to_le32(value); ^ ERROR: "foo* bar" should be "foo *bar" #260: FILE: block/vvfat.c:541: + uint16_t* entry=array_get(&(s->fat),cluster); ERROR: spaces required around that '=' (ctx:VxV) #260: FILE: block/vvfat.c:541: + uint16_t* entry=array_get(&(s->fat),cluster); ^ ERROR: space required after that ',' (ctx:VxV) #260: FILE: block/vvfat.c:541: + uint16_t* entry=array_get(&(s->fat),cluster); ^ ERROR: spaces required around that '=' (ctx:VxV) #261: FILE: block/vvfat.c:542: + *entry=cpu_to_le16(value&0xffff); ^ ERROR: spaces required around that '&' (ctx:VxV) #261: FILE: block/vvfat.c:542: + *entry=cpu_to_le16(value&0xffff); ^ ERROR: spaces required around that '*' (ctx:VxV) #265: FILE: block/vvfat.c:544: + int offset = (cluster*3/2); ^ ERROR: spaces required around that '/' (ctx:VxV) #265: FILE: block/vvfat.c:544: + int offset = (cluster*3/2); ^ ERROR: "foo* bar" should be "foo *bar" #266: FILE: block/vvfat.c:545: + unsigned char* p = array_get(&(s->fat), offset); ERROR: spaces required around that '&' (ctx:VxV) #278: FILE: block/vvfat.c:548: + p[0] = value&0xff; ^ ERROR: spaces required around that '&' (ctx:VxV) #279: FILE: block/vvfat.c:549: + p[1] = (p[1]&0xf0) | ((value>>8)&0xf); ^ ERROR: spaces required around that '>>' (ctx:VxV) #279: FILE: block/vvfat.c:549: + p[1] = (p[1]&0xf0) | ((value>>8)&0xf); ^ ERROR: spaces required around that '&' (ctx:VxV) #279: FILE: block/vvfat.c:549: + p[1] = (p[1]&0xf0) | ((value>>8)&0xf); ^ ERROR: spaces required around that '&' (ctx:VxV) #282: FILE: block/vvfat.c:552: + p[0] = (p[0]&0xf) | ((value&0xf)<<4); ^ ERROR: spaces required around that '&' (ctx:VxV) #282: FILE: block/vvfat.c:552: + p[0] = (p[0]&0xf) | ((value&0xf)<<4); ^ ERROR: spaces required around that '<<' (ctx:VxV) #282: FILE: block/vvfat.c:552: + p[0] = (p[0]&0xf) | ((value&0xf)<<4); ^ ERROR: spaces required around that '>>' (ctx:VxV) #283: FILE: block/vvfat.c:553: + p[1] = (value>>4); ^ ERROR: "foo* bar" should be "foo *bar" #294: FILE: block/vvfat.c:562: + uint32_t* entry=array_get(&(s->fat),cluster); ERROR: spaces required around that '=' (ctx:VxV) #294: FILE: block/vvfat.c:562: + uint32_t* entry=array_get(&(s->fat),cluster); ^ ERROR: space required after that ',' (ctx:VxV) #294: FILE: block/vvfat.c:562: + uint32_t* entry=array_get(&(s->fat),cluster); ^ ERROR: "foo* bar" should be "foo *bar" #299: FILE: block/vvfat.c:565: + uint16_t* entry=array_get(&(s->fat),cluster); ERROR: spaces required around that '=' (ctx:VxV) #299: FILE: block/vvfat.c:565: + uint16_t* entry=array_get(&(s->fat),cluster); ^ ERROR: space required after that ',' (ctx:VxV) #299: FILE: block/vvfat.c:565: + uint16_t* entry=array_get(&(s->fat),cluster); ^ ERROR: "(foo*)" should be "(foo *)" #304: FILE: block/vvfat.c:568: + const uint8_t* x=(uint8_t*)(s->fat.pointer)+cluster*3/2; ERROR: spaces required around that '=' (ctx:VxV) #304: FILE: block/vvfat.c:568: + const uint8_t* x=(uint8_t*)(s->fat.pointer)+cluster*3/2; ^ ERROR: spaces required around that '+' (ctx:VxV) #304: FILE: block/vvfat.c:568: + const uint8_t* x=(uint8_t*)(s->fat.pointer)+cluster*3/2; ^ ERROR: spaces required around that '*' (ctx:VxV) #304: FILE: block/vvfat.c:568: + const uint8_t* x=(uint8_t*)(s->fat.pointer)+cluster*3/2; ^ ERROR: spaces required around that '/' (ctx:VxV) #304: FILE: block/vvfat.c:568: + const uint8_t* x=(uint8_t*)(s->fat.pointer)+cluster*3/2; ^ ERROR: spaces required around that '|' (ctx:VxV) #305: FILE: block/vvfat.c:569: + return ((x[0]|(x[1]<<8))>>(cluster&1?4:0))&0x0fff; ^ ERROR: spaces required around that '<<' (ctx:VxV) #305: FILE: block/vvfat.c:569: + return ((x[0]|(x[1]<<8))>>(cluster&1?4:0))&0x0fff; ^ ERROR: spaces required around that '>>' (ctx:VxV) #305: FILE: block/vvfat.c:569: + return ((x[0]|(x[1]<<8))>>(cluster&1?4:0))&0x0fff; ^ ERROR: spaces required around that '&' (ctx:VxV) #305: FILE: block/vvfat.c:569: + return ((x[0]|(x[1]<<8))>>(cluster&1?4:0))&0x0fff; ^ ERROR: spaces required around that '?' (ctx:VxV) #305: FILE: block/vvfat.c:569: + return ((x[0]|(x[1]<<8))>>(cluster&1?4:0))&0x0fff; ^ ERROR: spaces required around that ':' (ctx:VxV) #305: FILE: block/vvfat.c:569: + return ((x[0]|(x[1]<<8))>>(cluster&1?4:0))&0x0fff; ^ ERROR: spaces required around that '&' (ctx:VxV) #305: FILE: block/vvfat.c:569: + return ((x[0]|(x[1]<<8))>>(cluster&1?4:0))&0x0fff; ^ ERROR: space required after that ',' (ctx:VxV) #323: FILE: block/vvfat.c:583: + array_init(&(s->fat),1); ^ ERROR: space required after that ',' (ctx:VxV) #330: FILE: block/vvfat.c:587: + array_init(&(s->fat),(s->fat_type==32?4:2)); ^ ERROR: spaces required around that '==' (ctx:VxV) #330: FILE: block/vvfat.c:587: + array_init(&(s->fat),(s->fat_type==32?4:2)); ^ ERROR: spaces required around that '?' (ctx:VxV) #330: FILE: block/vvfat.c:587: + array_init(&(s->fat),(s->fat_type==32?4:2)); ^ ERROR: spaces required around that ':' (ctx:VxV) #330: FILE: block/vvfat.c:587: + array_init(&(s->fat),(s->fat_type==32?4:2)); ^ ERROR: switch and case should be at the same indent #336: FILE: block/vvfat.c:593: switch(s->fat_type) { + case 12: s->max_fat_value=0xfff; break; + case 16: s->max_fat_value=0xffff; break; + case 32: s->max_fat_value=0x0fffffff; break; + default: s->max_fat_value=0; /* error... */ ERROR: spaces required around that '=' (ctx:VxV) #341: FILE: block/vvfat.c:594: + case 12: s->max_fat_value=0xfff; break; ^ ERROR: trailing statements should be on next line #341: FILE: block/vvfat.c:594: + case 12: s->max_fat_value=0xfff; break; ERROR: spaces required around that '=' (ctx:VxV) #342: FILE: block/vvfat.c:595: + case 16: s->max_fat_value=0xffff; break; ^ ERROR: trailing statements should be on next line #342: FILE: block/vvfat.c:595: + case 16: s->max_fat_value=0xffff; break; ERROR: spaces required around that '=' (ctx:VxV) #343: FILE: block/vvfat.c:596: + case 32: s->max_fat_value=0x0fffffff; break; ^ ERROR: trailing statements should be on next line #343: FILE: block/vvfat.c:596: + case 32: s->max_fat_value=0x0fffffff; break; ERROR: spaces required around that '=' (ctx:VxV) #344: FILE: block/vvfat.c:597: + default: s->max_fat_value=0; /* error... */ ^ ERROR: trailing statements should be on next line #344: FILE: block/vvfat.c:597: + default: s->max_fat_value=0; /* error... */ ERROR: "foo* bar" should be "foo *bar" #353: FILE: block/vvfat.c:605: + unsigned int directory_start, const char* filename, int is_dot) ERROR: spaces required around that '=' (ctx:VxV) #361: FILE: block/vvfat.c:612: + entry=array_get_next(&(s->directory)); ^ ERROR: space required after that ',' (ctx:VxV) #365: FILE: block/vvfat.c:614: + memcpy(entry->name,filename,strlen(filename)); ^ ERROR: space required after that ',' (ctx:VxV) #365: FILE: block/vvfat.c:614: + memcpy(entry->name,filename,strlen(filename)); ^ ERROR: spaces required around that '==' (ctx:VxV) #390: FILE: block/vvfat.c:639: + if(i==10 || i==7) for(;i>0 && entry->name[i]==' ';i--); ^ ERROR: spaces required around that '==' (ctx:VxV) #390: FILE: block/vvfat.c:639: + if(i==10 || i==7) for(;i>0 && entry->name[i]==' ';i--); ^ ERROR: space required after that ';' (ctx:BxV) #390: FILE: block/vvfat.c:639: + if(i==10 || i==7) for(;i>0 && entry->name[i]==' ';i--); ^ ERROR: spaces required around that '>' (ctx:VxV) #390: FILE: block/vvfat.c:639: + if(i==10 || i==7) for(;i>0 && entry->name[i]==' ';i--); ^ ERROR: spaces required around that '==' (ctx:VxV) #390: FILE: block/vvfat.c:639: + if(i==10 || i==7) for(;i>0 && entry->name[i]==' ';i--); ^ ERROR: space required after that ';' (ctx:VxV) #390: FILE: block/vvfat.c:639: + if(i==10 || i==7) for(;i>0 && entry->name[i]==' ';i--); ^ ERROR: space required before the open parenthesis '(' #390: FILE: block/vvfat.c:639: + if(i==10 || i==7) for(;i>0 && entry->name[i]==' ';i--); ERROR: trailing statements should be on next line #390: FILE: block/vvfat.c:639: + if(i==10 || i==7) for(;i>0 && entry->name[i]==' ';i--); ERROR: braces {} are necessary for all arms of this statement #390: FILE: block/vvfat.c:639: + if(i==10 || i==7) for(;i>0 && entry->name[i]==' ';i--); [...] ERROR: spaces required around that '<=' (ctx:VxV) #391: FILE: block/vvfat.c:640: + if(entry->name[i]<=' ' || entry->name[i]>0x7f ^ ERROR: spaces required around that '>' (ctx:VxV) #391: FILE: block/vvfat.c:640: + if(entry->name[i]<=' ' || entry->name[i]>0x7f ^ ERROR: space required before the open parenthesis '(' #391: FILE: block/vvfat.c:640: + if(entry->name[i]<=' ' || entry->name[i]>0x7f ERROR: braces {} are necessary for all arms of this statement #391: FILE: block/vvfat.c:640: + if(entry->name[i]<=' ' || entry->name[i]>0x7f [...] else if(entry->name[i]>='a' && entry->name[i]<='z') [...] ERROR: space required after that ',' (ctx:VxV) #392: FILE: block/vvfat.c:641: + || strchr(".*?<>|\":/\\[];,+='",entry->name[i])) ^ ERROR: spaces required around that '=' (ctx:VxV) #393: FILE: block/vvfat.c:642: + entry->name[i]='_'; ^ ERROR: "foo* bar" should be "foo *bar" #425: FILE: block/vvfat.c:649: + direntry_t* entry1=array_get(&(s->directory),directory_start); ERROR: spaces required around that '=' (ctx:VxV) #425: FILE: block/vvfat.c:649: + direntry_t* entry1=array_get(&(s->directory),directory_start); ^ ERROR: space required after that ',' (ctx:VxV) #425: FILE: block/vvfat.c:649: + direntry_t* entry1=array_get(&(s->directory),directory_start); ^ ERROR: space required after that ';' (ctx:BxV) #428: FILE: block/vvfat.c:652: + for(;entry1<entry;entry1++) ^ ERROR: spaces required around that '<' (ctx:VxV) #428: FILE: block/vvfat.c:652: + for(;entry1<entry;entry1++) ^ ERROR: space required after that ';' (ctx:VxV) #428: FILE: block/vvfat.c:652: + for(;entry1<entry;entry1++) ^ ERROR: space required before the open parenthesis '(' #428: FILE: block/vvfat.c:652: + for(;entry1<entry;entry1++) ERROR: space required after that ',' (ctx:VxV) #429: FILE: block/vvfat.c:653: + if(!is_long_name(entry1) && !memcmp(entry1->name,entry->name,11)) ^ ERROR: space required after that ',' (ctx:VxV) #429: FILE: block/vvfat.c:653: + if(!is_long_name(entry1) && !memcmp(entry1->name,entry->name,11)) ^ ERROR: space required before the open parenthesis '(' #429: FILE: block/vvfat.c:653: + if(!is_long_name(entry1) && !memcmp(entry1->name,entry->name,11)) ERROR: braces {} are necessary for all arms of this statement #429: FILE: block/vvfat.c:653: + if(!is_long_name(entry1) && !memcmp(entry1->name,entry->name,11)) [...] ERROR: spaces required around that '==' (ctx:VxV) #431: FILE: block/vvfat.c:655: + if(entry1==entry) /* no dupe found */ ^ ERROR: space required before the open parenthesis '(' #431: FILE: block/vvfat.c:655: + if(entry1==entry) /* no dupe found */ ERROR: braces {} are necessary for all arms of this statement #431: FILE: block/vvfat.c:655: + if(entry1==entry) /* no dupe found */ [...] ERROR: spaces required around that '==' (ctx:VxV) #435: FILE: block/vvfat.c:659: + if(entry->name[7]==' ') { ^ ERROR: space required before the open parenthesis '(' #435: FILE: block/vvfat.c:659: + if(entry->name[7]==' ') { ERROR: spaces required around that '=' (ctx:VxV) #437: FILE: block/vvfat.c:661: + for(j=6;j>0 && entry->name[j]==' ';j--) ^ ERROR: space required after that ';' (ctx:VxV) #437: FILE: block/vvfat.c:661: + for(j=6;j>0 && entry->name[j]==' ';j--) ^ ERROR: spaces required around that '>' (ctx:VxV) #437: FILE: block/vvfat.c:661: + for(j=6;j>0 && entry->name[j]==' ';j--) ^ ERROR: spaces required around that '==' (ctx:VxV) #437: FILE: block/vvfat.c:661: + for(j=6;j>0 && entry->name[j]==' ';j--) ^ ERROR: space required after that ';' (ctx:VxV) #437: FILE: block/vvfat.c:661: + for(j=6;j>0 && entry->name[j]==' ';j--) ^ ERROR: space required before the open parenthesis '(' #437: FILE: block/vvfat.c:661: + for(j=6;j>0 && entry->name[j]==' ';j--) ERROR: braces {} are necessary even for single statement blocks #437: FILE: block/vvfat.c:661: + for(j=6;j>0 && entry->name[j]==' ';j--) + entry->name[j]='~'; ERROR: spaces required around that '=' (ctx:VxV) #438: FILE: block/vvfat.c:662: + entry->name[j]='~'; ^ ERROR: spaces required around that '=' (ctx:VxV) #442: FILE: block/vvfat.c:666: + for(j=7;j>0 && entry->name[j]=='9';j--) ^ ERROR: space required after that ';' (ctx:VxV) #442: FILE: block/vvfat.c:666: + for(j=7;j>0 && entry->name[j]=='9';j--) ^ ERROR: spaces required around that '>' (ctx:VxV) #442: FILE: block/vvfat.c:666: + for(j=7;j>0 && entry->name[j]=='9';j--) ^ ERROR: spaces required around that '==' (ctx:VxV) #442: FILE: block/vvfat.c:666: + for(j=7;j>0 && entry->name[j]=='9';j--) ^ ERROR: space required after that ';' (ctx:VxV) #442: FILE: block/vvfat.c:666: + for(j=7;j>0 && entry->name[j]=='9';j--) ^ ERROR: space required before the open parenthesis '(' #442: FILE: block/vvfat.c:666: + for(j=7;j>0 && entry->name[j]=='9';j--) ERROR: braces {} are necessary even for single statement blocks #442: FILE: block/vvfat.c:666: + for(j=7;j>0 && entry->name[j]=='9';j--) + entry->name[j]='0'; ERROR: spaces required around that '=' (ctx:VxV) #443: FILE: block/vvfat.c:667: + entry->name[j]='0'; ^ ERROR: spaces required around that '>' (ctx:VxV) #444: FILE: block/vvfat.c:668: + if(j>0) { ^ ERROR: space required before the open parenthesis '(' #444: FILE: block/vvfat.c:668: + if(j>0) { ERROR: spaces required around that '<' (ctx:VxV) #445: FILE: block/vvfat.c:669: + if(entry->name[j]<'0' || entry->name[j]>'9') ^ ERROR: spaces required around that '>' (ctx:VxV) #445: FILE: block/vvfat.c:669: + if(entry->name[j]<'0' || entry->name[j]>'9') ^ ERROR: space required before the open parenthesis '(' #445: FILE: block/vvfat.c:669: + if(entry->name[j]<'0' || entry->name[j]>'9') ERROR: braces {} are necessary for all arms of this statement #445: FILE: block/vvfat.c:669: + if(entry->name[j]<'0' || entry->name[j]>'9') [...] + else [...] ERROR: spaces required around that '=' (ctx:VxV) #446: FILE: block/vvfat.c:670: + entry->name[j]='0'; ^ ERROR: spaces required around that '=' (ctx:VxV) #463: FILE: block/vvfat.c:681: + entry_long=array_get(&(s->directory),long_index); ^ ERROR: space required after that ',' (ctx:VxV) #463: FILE: block/vvfat.c:681: + entry_long=array_get(&(s->directory),long_index); ^ ERROR: spaces required around that '<' (ctx:VxV) #464: FILE: block/vvfat.c:682: + while(entry_long<entry && is_long_name(entry_long)) { ^ ERROR: space required before the open parenthesis '(' #464: FILE: block/vvfat.c:682: + while(entry_long<entry && is_long_name(entry_long)) { ERROR: spaces required around that '=' (ctx:VxV) #465: FILE: block/vvfat.c:683: + entry_long->reserved[1]=chksum; ^ ERROR: spaces required around that '=' (ctx:VxV) #488: FILE: block/vvfat.c:721: + unsigned int length=strlen(dirname)+2+strlen(entry->d_name); ^ ERROR: spaces required around that '+' (ctx:VxV) #488: FILE: block/vvfat.c:721: + unsigned int length=strlen(dirname)+2+strlen(entry->d_name); ^ ERROR: spaces required around that '+' (ctx:VxV) #488: FILE: block/vvfat.c:721: + unsigned int length=strlen(dirname)+2+strlen(entry->d_name); ^ ERROR: "foo* bar" should be "foo *bar" #491: FILE: block/vvfat.c:723: + direntry_t* direntry; ERROR: spaces required around that '=' (ctx:VxO) #495: FILE: block/vvfat.c:725: + int is_dot=!strcmp(entry->d_name,"."); ^ ERROR: space required before that '!' (ctx:OxV) #495: FILE: block/vvfat.c:725: + int is_dot=!strcmp(entry->d_name,"."); ^ ERROR: space required after that ',' (ctx:VxV) #495: FILE: block/vvfat.c:725: + int is_dot=!strcmp(entry->d_name,"."); ^ ERROR: spaces required around that '=' (ctx:VxO) #496: FILE: block/vvfat.c:726: + int is_dotdot=!strcmp(entry->d_name,".."); ^ ERROR: space required before that '!' (ctx:OxV) #496: FILE: block/vvfat.c:726: + int is_dotdot=!strcmp(entry->d_name,".."); ^ ERROR: space required after that ',' (ctx:VxV) #496: FILE: block/vvfat.c:726: + int is_dotdot=!strcmp(entry->d_name,".."); ^ ERROR: space required before the open parenthesis '(' #500: FILE: block/vvfat.c:728: + if(first_cluster == 0 && (is_dotdot || is_dot)) ERROR: braces {} are necessary for all arms of this statement #500: FILE: block/vvfat.c:728: + if(first_cluster == 0 && (is_dotdot || is_dot)) [...] ERROR: space required after that ',' (ctx:VxV) #506: FILE: block/vvfat.c:732: + snprintf(buffer,length,"%s/%s",dirname,entry->d_name); ^ ERROR: space required after that ',' (ctx:VxV) #506: FILE: block/vvfat.c:732: + snprintf(buffer,length,"%s/%s",dirname,entry->d_name); ^ ERROR: space required after that ',' (ctx:VxV) #506: FILE: block/vvfat.c:732: + snprintf(buffer,length,"%s/%s",dirname,entry->d_name); ^ ERROR: space required after that ',' (ctx:VxV) #506: FILE: block/vvfat.c:732: + snprintf(buffer,length,"%s/%s",dirname,entry->d_name); ^ ERROR: space required after that ',' (ctx:VxO) #509: FILE: block/vvfat.c:734: + if(stat(buffer,&st)<0) { ^ ERROR: space required before that '&' (ctx:OxV) #509: FILE: block/vvfat.c:734: + if(stat(buffer,&st)<0) { ^ ERROR: spaces required around that '<' (ctx:VxV) #509: FILE: block/vvfat.c:734: + if(stat(buffer,&st)<0) { ^ ERROR: space required before the open parenthesis '(' #509: FILE: block/vvfat.c:734: + if(stat(buffer,&st)<0) { ERROR: spaces required around that '=' (ctx:VxV) #534: FILE: block/vvfat.c:740: + direntry=create_short_and_long_name(s, i, entry->d_name, ^ ERROR: spaces required around that '=' (ctx:VxV) #536: FILE: block/vvfat.c:742: + direntry->attributes=(S_ISDIR(st.st_mode)?0x10:0x20); ^ ERROR: spaces required around that '?' (ctx:VxV) #536: FILE: block/vvfat.c:742: + direntry->attributes=(S_ISDIR(st.st_mode)?0x10:0x20); ^ ERROR: spaces required around that ':' (ctx:VxV) #536: FILE: block/vvfat.c:742: + direntry->attributes=(S_ISDIR(st.st_mode)?0x10:0x20); ^ ERROR: spaces required around that '=' (ctx:VxV) #537: FILE: block/vvfat.c:743: + direntry->reserved[0]=direntry->reserved[1]=0; ^ ERROR: spaces required around that '=' (ctx:VxV) #537: FILE: block/vvfat.c:743: + direntry->reserved[0]=direntry->reserved[1]=0; ^ ERROR: spaces required around that '=' (ctx:VxV) #538: FILE: block/vvfat.c:744: + direntry->ctime=fat_datetime(st.st_ctime,1); ^ ERROR: space required after that ',' (ctx:VxV) #538: FILE: block/vvfat.c:744: + direntry->ctime=fat_datetime(st.st_ctime,1); ^ ERROR: spaces required around that '=' (ctx:VxV) #539: FILE: block/vvfat.c:745: + direntry->cdate=fat_datetime(st.st_ctime,0); ^ ERROR: space required after that ',' (ctx:VxV) #539: FILE: block/vvfat.c:745: + direntry->cdate=fat_datetime(st.st_ctime,0); ^ ERROR: spaces required around that '=' (ctx:VxV) #540: FILE: block/vvfat.c:746: + direntry->adate=fat_datetime(st.st_atime,0); ^ ERROR: space required after that ',' (ctx:VxV) #540: FILE: block/vvfat.c:746: + direntry->adate=fat_datetime(st.st_atime,0); ^ ERROR: spaces required around that '=' (ctx:VxV) #541: FILE: block/vvfat.c:747: + direntry->begin_hi=0; ^ ERROR: spaces required around that '=' (ctx:VxV) #542: FILE: block/vvfat.c:748: + direntry->mtime=fat_datetime(st.st_mtime,1); ^ ERROR: space required after that ',' (ctx:VxV) #542: FILE: block/vvfat.c:748: + direntry->mtime=fat_datetime(st.st_mtime,1); ^ ERROR: spaces required around that '=' (ctx:VxV) #543: FILE: block/vvfat.c:749: + direntry->mdate=fat_datetime(st.st_mtime,0); ^ ERROR: space required after that ',' (ctx:VxV) #543: FILE: block/vvfat.c:749: + direntry->mdate=fat_datetime(st.st_mtime,0); ^ ERROR: space required before the open parenthesis '(' #544: FILE: block/vvfat.c:750: + if(is_dotdot) ERROR: braces {} are necessary for all arms of this statement #544: FILE: block/vvfat.c:750: + if(is_dotdot) [...] + else if(is_dot) [...] + else [...] ERROR: space required before the open parenthesis '(' #546: FILE: block/vvfat.c:752: + else if(is_dot) ERROR: braces {} are necessary for all arms of this statement #546: FILE: block/vvfat.c:752: + else if(is_dot) [...] + else [...] ERROR: spaces required around that '=' (ctx:VxV) #549: FILE: block/vvfat.c:755: + direntry->begin=0; /* do that later */ ^ ERROR: spaces required around that '=' (ctx:VxV) #582: FILE: block/vvfat.c:762: + direntry->size=cpu_to_le32(S_ISDIR(st.st_mode)?0:st.st_size); ^ ERROR: spaces required around that '?' (ctx:VxV) #582: FILE: block/vvfat.c:762: + direntry->size=cpu_to_le32(S_ISDIR(st.st_mode)?0:st.st_size); ^ ERROR: spaces required around that ':' (ctx:VxV) #582: FILE: block/vvfat.c:762: + direntry->size=cpu_to_le32(S_ISDIR(st.st_mode)?0:st.st_size); ^ ERROR: space required before the open parenthesis '(' #585: FILE: block/vvfat.c:765: + if(!is_dot && !is_dotdot && (S_ISDIR(st.st_mode) || st.st_size)) { ERROR: spaces required around that '=' (ctx:VxV) #587: FILE: block/vvfat.c:767: + s->current_mapping->begin=0; ^ ERROR: spaces required around that '=' (ctx:VxV) #588: FILE: block/vvfat.c:768: + s->current_mapping->end=st.st_size; ^ ERROR: spaces required around that '=' (ctx:VxV) #593: FILE: block/vvfat.c:773: + s->current_mapping->dir_index=s->directory.next-1; ^ ERROR: spaces required around that '-' (ctx:VxV) #593: FILE: block/vvfat.c:773: + s->current_mapping->dir_index=s->directory.next-1; ^ ERROR: spaces required around that '=' (ctx:VxV) #603: FILE: block/vvfat.c:783: + s->current_mapping->path=buffer; ^ ERROR: "foo* bar" should be "foo *bar" #615: FILE: block/vvfat.c:794: + direntry_t* direntry=array_get_next(&(s->directory)); ERROR: spaces required around that '=' (ctx:VxV) #615: FILE: block/vvfat.c:794: + direntry_t* direntry=array_get_next(&(s->directory)); ^ ERROR: space required after that ',' (ctx:VxV) #616: FILE: block/vvfat.c:795: + memset(direntry,0,sizeof(direntry_t)); ^ ERROR: space required after that ',' (ctx:VxV) #616: FILE: block/vvfat.c:795: + memset(direntry,0,sizeof(direntry_t)); ^ ERROR: "foo* bar" should be "foo *bar" #650: FILE: block/vvfat.c:860: + direntry_t* entry=array_get_next(&(s->directory)); ERROR: spaces required around that '=' (ctx:VxV) #650: FILE: block/vvfat.c:860: + direntry_t* entry=array_get_next(&(s->directory)); ^ ERROR: spaces required around that '=' (ctx:VxV) #651: FILE: block/vvfat.c:861: + entry->attributes=0x28; /* archive | volume label */ ^ ERROR: space required before the open parenthesis '(' #681: FILE: block/vvfat.c:893: + if(read_directory(s, i)) { ERROR: spaces required around that '=' (ctx:VxV) #714: FILE: block/vvfat.c:901: + mapping->mode=MODE_NORMAL; ^ ERROR: "foo* bar" should be "foo *bar" #717: FILE: block/vvfat.c:904: + direntry_t* direntry = array_get(&(s->directory), ERROR: spaces required around that '-' (ctx:VxV) #720: FILE: block/vvfat.c:907: + mapping->end = cluster + 1 + (mapping->end-1)/s->cluster_size; ^ ERROR: spaces required around that '/' (ctx:VxV) #720: FILE: block/vvfat.c:907: + mapping->end = cluster + 1 + (mapping->end-1)/s->cluster_size; ^ ERROR: space required before the open parenthesis '(' #733: FILE: block/vvfat.c:920: + if(cluster > s->cluster_count) { ERROR: space required before the open parenthesis '(' #751: FILE: block/vvfat.c:930: + for(j = mapping->begin; j < mapping->end - 1; j++) ERROR: braces {} are necessary even for single statement blocks #751: FILE: block/vvfat.c:930: + for(j = mapping->begin; j < mapping->end - 1; j++) + fat_set(s, j, j+1); ERROR: spaces required around that '+' (ctx:VxV) #752: FILE: block/vvfat.c:931: + fat_set(s, j, j+1); ^ ERROR: "foo* bar" should be "foo *bar" #808: FILE: block/vvfat.c:1249: + mapping_t* mapping; ERROR: spaces required around that '=' (ctx:VxV) #809: FILE: block/vvfat.c:1250: + index3=(index1+index2)/2; ^ ERROR: spaces required around that '+' (ctx:VxV) #809: FILE: block/vvfat.c:1250: + index3=(index1+index2)/2; ^ ERROR: spaces required around that '/' (ctx:VxV) #809: FILE: block/vvfat.c:1250: + index3=(index1+index2)/2; ^ ERROR: spaces required around that '=' (ctx:VxV) #810: FILE: block/vvfat.c:1251: + mapping=array_get(&(s->mapping),index3); ^ ERROR: space required after that ',' (ctx:VxV) #810: FILE: block/vvfat.c:1251: + mapping=array_get(&(s->mapping),index3); ^ ERROR: spaces required around that '>=' (ctx:VxV) #812: FILE: block/vvfat.c:1253: + if(mapping->begin>=cluster_num) { ^ ERROR: space required before the open parenthesis '(' #812: FILE: block/vvfat.c:1253: + if(mapping->begin>=cluster_num) { ERROR: spaces required around that '!=' (ctx:VxV) #813: FILE: block/vvfat.c:1254: + assert(index2!=index3 || index2==0); ^ ERROR: spaces required around that '==' (ctx:VxV) #813: FILE: block/vvfat.c:1254: + assert(index2!=index3 || index2==0); ^ ERROR: spaces required around that '==' (ctx:VxV) #814: FILE: block/vvfat.c:1255: + if(index2==index3) ^ ERROR: space required before the open parenthesis '(' #814: FILE: block/vvfat.c:1255: + if(index2==index3) ERROR: braces {} are necessary for all arms of this statement #814: FILE: block/vvfat.c:1255: + if(index2==index3) [...] ERROR: spaces required around that '=' (ctx:VxV) #816: FILE: block/vvfat.c:1257: + index2=index3; ^ ERROR: spaces required around that '==' (ctx:VxV) #818: FILE: block/vvfat.c:1259: + if(index1==index3) ^ ERROR: space required before the open parenthesis '(' #818: FILE: block/vvfat.c:1259: + if(index1==index3) ERROR: braces {} are necessary for all arms of this statement #818: FILE: block/vvfat.c:1259: + if(index1==index3) [...] ERROR: spaces required around that '<=' (ctx:VxV) #819: FILE: block/vvfat.c:1260: + return mapping->end<=cluster_num ? index2 : index1; ^ ERROR: spaces required around that '=' (ctx:VxV) #820: FILE: block/vvfat.c:1261: + index1=index3; ^ ERROR: spaces required around that '<=' (ctx:VxV) #822: FILE: block/vvfat.c:1263: + assert(index1<=index2); ^ ERROR: spaces required around that '=' (ctx:VxV) #823: FILE: block/vvfat.c:1264: + DLOG(mapping=array_get(&(s->mapping),index1); ^ ERROR: space required after that ',' (ctx:VxV) #823: FILE: block/vvfat.c:1264: + DLOG(mapping=array_get(&(s->mapping),index1); ^ ERROR: spaces required around that '<=' (ctx:VxV) #824: FILE: block/vvfat.c:1265: + assert(mapping->begin<=cluster_num); ^ ERROR: space required after that ',' (ctx:VxV) #826: FILE: block/vvfat.c:1267: + ((mapping = array_get(&(s->mapping),index2)) && ^ ERROR: spaces required around that '>' (ctx:VxV) #827: FILE: block/vvfat.c:1268: + mapping->end>cluster_num))); ^ ERROR: space required after that ',' (ctx:VxV) #846: FILE: block/vvfat.c:1290: + strcmp(s->current_mapping->path,mapping->path)) { ^ ERROR: spaces required around that '<' (ctx:VxV) #849: FILE: block/vvfat.c:1293: + if(fd<0) ^ ERROR: space required before the open parenthesis '(' #849: FILE: block/vvfat.c:1293: + if(fd<0) ERROR: braces {} are necessary for all arms of this statement #849: FILE: block/vvfat.c:1293: + if(fd<0) [...] ERROR: spaces required around that '=' (ctx:VxV) #875: FILE: block/vvfat.c:1305: + int result=0; ^ ERROR: line over 90 characters #877: FILE: block/vvfat.c:1307: + assert(!s->current_mapping || s->current_fd || (s->current_mapping->mode & MODE_DIRECTORY)); ERROR: space required before the open parenthesis '(' #878: FILE: block/vvfat.c:1308: + if(!s->current_mapping ERROR: braces {} are necessary for all arms of this statement #878: FILE: block/vvfat.c:1308: + if(!s->current_mapping [...] - } else if (s->current_mapping->mode & MODE_DIRECTORY) [...] ERROR: spaces required around that '>' (ctx:VxV) #879: FILE: block/vvfat.c:1309: + || s->current_mapping->begin>cluster_num ^ ERROR: spaces required around that '<=' (ctx:VxV) #880: FILE: block/vvfat.c:1310: + || s->current_mapping->end<=cluster_num) { ^ ERROR: "foo* bar" should be "foo *bar" #882: FILE: block/vvfat.c:1312: + mapping_t* mapping=find_mapping_for_cluster(s,cluster_num); ERROR: spaces required around that '=' (ctx:VxV) #882: FILE: block/vvfat.c:1312: + mapping_t* mapping=find_mapping_for_cluster(s,cluster_num); ^ ERROR: space required after that ',' (ctx:VxV) #882: FILE: block/vvfat.c:1312: + mapping_t* mapping=find_mapping_for_cluster(s,cluster_num); ^ WARNING: line over 80 characters #884: FILE: block/vvfat.c:1314: + assert(!mapping || (cluster_num>=mapping->begin && cluster_num<mapping->end)); ERROR: spaces required around that '>=' (ctx:VxV) #884: FILE: block/vvfat.c:1314: + assert(!mapping || (cluster_num>=mapping->begin && cluster_num<mapping->end)); ^ ERROR: spaces required around that '<' (ctx:VxV) #884: FILE: block/vvfat.c:1314: + assert(!mapping || (cluster_num>=mapping->begin && cluster_num<mapping->end)); ^ WARNING: line over 80 characters #916: FILE: block/vvfat.c:1320: + offset = s->cluster_size*(cluster_num-s->current_mapping->begin); ERROR: spaces required around that '*' (ctx:VxV) #916: FILE: block/vvfat.c:1320: + offset = s->cluster_size*(cluster_num-s->current_mapping->begin); ^ ERROR: spaces required around that '-' (ctx:VxV) #916: FILE: block/vvfat.c:1320: + offset = s->cluster_size*(cluster_num-s->current_mapping->begin); ^ ERROR: "(foo*)" should be "(foo *)" #917: FILE: block/vvfat.c:1321: + s->cluster = (unsigned char*)s->directory.pointer+offset ERROR: spaces required around that '+' (ctx:VxV) #917: FILE: block/vvfat.c:1321: + s->cluster = (unsigned char*)s->directory.pointer+offset ^ ERROR: spaces required around that '*' (ctx:VxV) #918: FILE: block/vvfat.c:1322: + + 0x20*s->current_mapping->info.dir.first_dir_index; ^ ERROR: line over 90 characters #919: FILE: block/vvfat.c:1323: + assert(((s->cluster-(unsigned char*)s->directory.pointer)%s->cluster_size)==0); ERROR: "(foo*)" should be "(foo *)" #919: FILE: block/vvfat.c:1323: + assert(((s->cluster-(unsigned char*)s->directory.pointer)%s->cluster_size)==0); ERROR: spaces required around that '-' (ctx:VxV) #919: FILE: block/vvfat.c:1323: + assert(((s->cluster-(unsigned char*)s->directory.pointer)%s->cluster_size)==0); ^ ERROR: spaces required around that '%' (ctx:VxV) #919: FILE: block/vvfat.c:1323: + assert(((s->cluster-(unsigned char*)s->directory.pointer)%s->cluster_size)==0); ^ ERROR: spaces required around that '==' (ctx:VxV) #919: FILE: block/vvfat.c:1323: + assert(((s->cluster-(unsigned char*)s->directory.pointer)%s->cluster_size)==0); ^ ERROR: line over 90 characters #920: FILE: block/vvfat.c:1324: + assert((char*)s->cluster+s->cluster_size <= s->directory.pointer+s->directory.next*s->directory.item_size); ERROR: "(foo*)" should be "(foo *)" #920: FILE: block/vvfat.c:1324: + assert((char*)s->cluster+s->cluster_size <= s->directory.pointer+s->directory.next*s->directory.item_size); ERROR: spaces required around that '+' (ctx:VxV) #920: FILE: block/vvfat.c:1324: + assert((char*)s->cluster+s->cluster_size <= s->directory.pointer+s->directory.next*s->directory.item_size); ^ ERROR: spaces required around that '+' (ctx:VxV) #920: FILE: block/vvfat.c:1324: + assert((char*)s->cluster+s->cluster_size <= s->directory.pointer+s->directory.next*s->directory.item_size); ^ ERROR: spaces required around that '*' (ctx:VxV) #920: FILE: block/vvfat.c:1324: + assert((char*)s->cluster+s->cluster_size <= s->directory.pointer+s->directory.next*s->directory.item_size); ^ ERROR: space required after that ',' (ctx:VxV) #925: FILE: block/vvfat.c:1329: + if(open_file(s,mapping)) ^ ERROR: space required before the open parenthesis '(' #925: FILE: block/vvfat.c:1329: + if(open_file(s,mapping)) ERROR: braces {} are necessary for all arms of this statement #925: FILE: block/vvfat.c:1329: + if(open_file(s,mapping)) [...] ERROR: braces {} are necessary for all arms of this statement #927: FILE: block/vvfat.c:1331: + } else if (s->current_mapping->mode & MODE_DIRECTORY) [...] ERROR: line over 90 characters #932: FILE: block/vvfat.c:1336: + offset=s->cluster_size*(cluster_num-s->current_mapping->begin)+s->current_mapping->info.file.offset; ERROR: spaces required around that '=' (ctx:VxV) #932: FILE: block/vvfat.c:1336: + offset=s->cluster_size*(cluster_num-s->current_mapping->begin)+s->current_mapping->info.file.offset; ^ ERROR: spaces required around that '*' (ctx:VxV) #932: FILE: block/vvfat.c:1336: + offset=s->cluster_size*(cluster_num-s->current_mapping->begin)+s->current_mapping->info.file.offset; ^ ERROR: spaces required around that '-' (ctx:VxV) #932: FILE: block/vvfat.c:1336: + offset=s->cluster_size*(cluster_num-s->current_mapping->begin)+s->current_mapping->info.file.offset; ^ ERROR: spaces required around that '+' (ctx:VxV) #932: FILE: block/vvfat.c:1336: + offset=s->cluster_size*(cluster_num-s->current_mapping->begin)+s->current_mapping->info.file.offset; ^ ERROR: spaces required around that '!=' (ctx:VxV) #933: FILE: block/vvfat.c:1337: + if(lseek(s->current_fd, offset, SEEK_SET)!=offset) ^ ERROR: space required before the open parenthesis '(' #933: FILE: block/vvfat.c:1337: + if(lseek(s->current_fd, offset, SEEK_SET)!=offset) ERROR: braces {} are necessary for all arms of this statement #933: FILE: block/vvfat.c:1337: + if(lseek(s->current_fd, offset, SEEK_SET)!=offset) [...] ERROR: spaces required around that '=' (ctx:VxV) #935: FILE: block/vvfat.c:1339: + s->cluster=s->cluster_buffer; ^ ERROR: spaces required around that '=' (ctx:VxV) #936: FILE: block/vvfat.c:1340: + result=read(s->current_fd,s->cluster,s->cluster_size); ^ ERROR: space required after that ',' (ctx:VxV) #936: FILE: block/vvfat.c:1340: + result=read(s->current_fd,s->cluster,s->cluster_size); ^ ERROR: space required after that ',' (ctx:VxV) #936: FILE: block/vvfat.c:1340: + result=read(s->current_fd,s->cluster,s->cluster_size); ^ ERROR: spaces required around that '<' (ctx:VxV) #937: FILE: block/vvfat.c:1341: + if(result<0) { ^ ERROR: space required before the open parenthesis '(' #937: FILE: block/vvfat.c:1341: + if(result<0) { ERROR: "(foo*)" should be "(foo *)" #955: FILE: block/vvfat.c:1360: + unsigned char* c=(unsigned char*)direntry; ERROR: spaces required around that '=' (ctx:VxV) #955: FILE: block/vvfat.c:1360: + unsigned char* c=(unsigned char*)direntry; ^ ERROR: suspect code indent for conditional statements (8, 0) #957: FILE: block/vvfat.c:1362: + for(i=1;i<11 && c[i] && c[i]!=0xff;i+=2) #define ADD_CHAR(c) {buffer[j] = (c); if (buffer[j] < ' ') buffer[j] = 0xb0; j++;} ERROR: spaces required around that '=' (ctx:VxV) #957: FILE: block/vvfat.c:1362: + for(i=1;i<11 && c[i] && c[i]!=0xff;i+=2) ^ ERROR: space required after that ';' (ctx:VxV) #957: FILE: block/vvfat.c:1362: + for(i=1;i<11 && c[i] && c[i]!=0xff;i+=2) ^ ERROR: spaces required around that '<' (ctx:VxV) #957: FILE: block/vvfat.c:1362: + for(i=1;i<11 && c[i] && c[i]!=0xff;i+=2) ^ ERROR: spaces required around that '!=' (ctx:VxV) #957: FILE: block/vvfat.c:1362: + for(i=1;i<11 && c[i] && c[i]!=0xff;i+=2) ^ ERROR: space required after that ';' (ctx:VxV) #957: FILE: block/vvfat.c:1362: + for(i=1;i<11 && c[i] && c[i]!=0xff;i+=2) ^ ERROR: spaces required around that '+=' (ctx:VxV) #957: FILE: block/vvfat.c:1362: + for(i=1;i<11 && c[i] && c[i]!=0xff;i+=2) ^ ERROR: space required before the open parenthesis '(' #957: FILE: block/vvfat.c:1362: + for(i=1;i<11 && c[i] && c[i]!=0xff;i+=2) ERROR: spaces required around that '=' (ctx:VxV) #967: FILE: block/vvfat.c:1365: + for(i=14;i<26 && c[i] && c[i]!=0xff;i+=2) ^ ERROR: space required after that ';' (ctx:VxV) #967: FILE: block/vvfat.c:1365: + for(i=14;i<26 && c[i] && c[i]!=0xff;i+=2) ^ ERROR: spaces required around that '<' (ctx:VxV) #967: FILE: block/vvfat.c:1365: + for(i=14;i<26 && c[i] && c[i]!=0xff;i+=2) ^ ERROR: spaces required around that '!=' (ctx:VxV) #967: FILE: block/vvfat.c:1365: + for(i=14;i<26 && c[i] && c[i]!=0xff;i+=2) ^ ERROR: space required after that ';' (ctx:VxV) #967: FILE: block/vvfat.c:1365: + for(i=14;i<26 && c[i] && c[i]!=0xff;i+=2) ^ ERROR: spaces required around that '+=' (ctx:VxV) #967: FILE: block/vvfat.c:1365: + for(i=14;i<26 && c[i] && c[i]!=0xff;i+=2) ^ ERROR: space required before the open parenthesis '(' #967: FILE: block/vvfat.c:1365: + for(i=14;i<26 && c[i] && c[i]!=0xff;i+=2) ERROR: braces {} are necessary even for single statement blocks #967: FILE: block/vvfat.c:1365: + for(i=14;i<26 && c[i] && c[i]!=0xff;i+=2) + ADD_CHAR(c[i]); ERROR: spaces required around that '=' (ctx:VxV) #969: FILE: block/vvfat.c:1367: + for(i=28;i<32 && c[i] && c[i]!=0xff;i+=2) ^ ERROR: space required after that ';' (ctx:VxV) #969: FILE: block/vvfat.c:1367: + for(i=28;i<32 && c[i] && c[i]!=0xff;i+=2) ^ ERROR: spaces required around that '<' (ctx:VxV) #969: FILE: block/vvfat.c:1367: + for(i=28;i<32 && c[i] && c[i]!=0xff;i+=2) ^ ERROR: spaces required around that '!=' (ctx:VxV) #969: FILE: block/vvfat.c:1367: + for(i=28;i<32 && c[i] && c[i]!=0xff;i+=2) ^ ERROR: space required after that ';' (ctx:VxV) #969: FILE: block/vvfat.c:1367: + for(i=28;i<32 && c[i] && c[i]!=0xff;i+=2) ^ ERROR: spaces required around that '+=' (ctx:VxV) #969: FILE: block/vvfat.c:1367: + for(i=28;i<32 && c[i] && c[i]!=0xff;i+=2) ^ ERROR: space required before the open parenthesis '(' #969: FILE: block/vvfat.c:1367: + for(i=28;i<32 && c[i] && c[i]!=0xff;i+=2) ERROR: braces {} are necessary even for single statement blocks #969: FILE: block/vvfat.c:1367: + for(i=28;i<32 && c[i] && c[i]!=0xff;i+=2) + ADD_CHAR(c[i]); ERROR: spaces required around that '=' (ctx:VxV) #983: FILE: block/vvfat.c:1373: + for(i=0;i<11;i++) ^ ERROR: space required after that ';' (ctx:VxV) #983: FILE: block/vvfat.c:1373: + for(i=0;i<11;i++) ^ ERROR: spaces required around that '<' (ctx:VxV) #983: FILE: block/vvfat.c:1373: + for(i=0;i<11;i++) ^ ERROR: space required after that ';' (ctx:VxV) #983: FILE: block/vvfat.c:1373: + for(i=0;i<11;i++) ^ ERROR: space required before the open parenthesis '(' #983: FILE: block/vvfat.c:1373: + for(i=0;i<11;i++) ERROR: braces {} are necessary even for single statement blocks #983: FILE: block/vvfat.c:1373: + for(i=0;i<11;i++) + ADD_CHAR(direntry->name[i]); ERROR: space required after that ',' (ctx:VxV) #986: FILE: block/vvfat.c:1376: + fprintf(stderr,"%s attributes=0x%02x begin=%d size=%d\n", ^ ERROR: space required after that ',' (ctx:VxV) #989: FILE: block/vvfat.c:1379: + begin_of_direntry(direntry),le32_to_cpu(direntry->size)); ^ ERROR: line over 90 characters #998: FILE: block/vvfat.c:1391: + fprintf(stderr, "parent_mapping_index = %d, first_dir_index = %d\n", mapping->info.dir.parent_mapping_index, mapping->info.dir.first_dir_index); ERROR: suspect code indent for conditional statements (8, 11) #1013: FILE: block/vvfat.c:1404: + if (sector_num >= bs->total_sectors) + return -1; ERROR: spaces required around that '<' (ctx:VxV) #1044: FILE: block/vvfat.c:1426: + if(sector_num<s->faked_sectors) { ^ ERROR: space required before the open parenthesis '(' #1044: FILE: block/vvfat.c:1426: + if(sector_num<s->faked_sectors) { ERROR: spaces required around that '<' (ctx:VxV) #1045: FILE: block/vvfat.c:1427: + if(sector_num<s->first_sectors_number) ^ ERROR: space required before the open parenthesis '(' #1045: FILE: block/vvfat.c:1427: + if(sector_num<s->first_sectors_number) ERROR: braces {} are necessary for all arms of this statement #1045: FILE: block/vvfat.c:1427: + if(sector_num<s->first_sectors_number) [...] + else if(sector_num-s->first_sectors_number<s->sectors_per_fat) [...] + else if(sector_num-s->first_sectors_number-s->sectors_per_fat<s->sectors_per_fat) [...] ERROR: spaces required around that '+' (ctx:VxV) #1046: FILE: block/vvfat.c:1428: + memcpy(buf+i*0x200,&(s->first_sectors[sector_num*0x200]),0x200); ^ ERROR: spaces required around that '*' (ctx:VxV) #1046: FILE: block/vvfat.c:1428: + memcpy(buf+i*0x200,&(s->first_sectors[sector_num*0x200]),0x200); ^ ERROR: space required after that ',' (ctx:VxO) #1046: FILE: block/vvfat.c:1428: + memcpy(buf+i*0x200,&(s->first_sectors[sector_num*0x200]),0x200); ^ ERROR: space required before that '&' (ctx:OxV) #1046: FILE: block/vvfat.c:1428: + memcpy(buf+i*0x200,&(s->first_sectors[sector_num*0x200]),0x200); ^ ERROR: spaces required around that '*' (ctx:VxV) #1046: FILE: block/vvfat.c:1428: + memcpy(buf+i*0x200,&(s->first_sectors[sector_num*0x200]),0x200); ^ ERROR: space required after that ',' (ctx:VxV) #1046: FILE: block/vvfat.c:1428: + memcpy(buf+i*0x200,&(s->first_sectors[sector_num*0x200]),0x200); ^ ERROR: spaces required around that '-' (ctx:VxV) #1047: FILE: block/vvfat.c:1429: + else if(sector_num-s->first_sectors_number<s->sectors_per_fat) ^ ERROR: spaces required around that '<' (ctx:VxV) #1047: FILE: block/vvfat.c:1429: + else if(sector_num-s->first_sectors_number<s->sectors_per_fat) ^ ERROR: space required before the open parenthesis '(' #1047: FILE: block/vvfat.c:1429: + else if(sector_num-s->first_sectors_number<s->sectors_per_fat) ERROR: braces {} are necessary for all arms of this statement #1047: FILE: block/vvfat.c:1429: + else if(sector_num-s->first_sectors_number<s->sectors_per_fat) [...] + else if(sector_num-s->first_sectors_number-s->sectors_per_fat<s->sectors_per_fat) [...] ERROR: line over 90 characters #1048: FILE: block/vvfat.c:1430: + memcpy(buf+i*0x200,&(s->fat.pointer[(sector_num-s->first_sectors_number)*0x200]),0x200); ERROR: spaces required around that '+' (ctx:VxV) #1048: FILE: block/vvfat.c:1430: + memcpy(buf+i*0x200,&(s->fat.pointer[(sector_num-s->first_sectors_number)*0x200]),0x200); ^ ERROR: spaces required around that '*' (ctx:VxV) #1048: FILE: block/vvfat.c:1430: + memcpy(buf+i*0x200,&(s->fat.pointer[(sector_num-s->first_sectors_number)*0x200]),0x200); ^ ERROR: space required after that ',' (ctx:VxO) #1048: FILE: block/vvfat.c:1430: + memcpy(buf+i*0x200,&(s->fat.pointer[(sector_num-s->first_sectors_number)*0x200]),0x200); ^ ERROR: space required before that '&' (ctx:OxV) #1048: FILE: block/vvfat.c:1430: + memcpy(buf+i*0x200,&(s->fat.pointer[(sector_num-s->first_sectors_number)*0x200]),0x200); ^ ERROR: spaces required around that '-' (ctx:VxV) #1048: FILE: block/vvfat.c:1430: + memcpy(buf+i*0x200,&(s->fat.pointer[(sector_num-s->first_sectors_number)*0x200]),0x200); ^ ERROR: spaces required around that '*' (ctx:VxV) #1048: FILE: block/vvfat.c:1430: + memcpy(buf+i*0x200,&(s->fat.pointer[(sector_num-s->first_sectors_number)*0x200]),0x200); ^ ERROR: space required after that ',' (ctx:VxV) #1048: FILE: block/vvfat.c:1430: + memcpy(buf+i*0x200,&(s->fat.pointer[(sector_num-s->first_sectors_number)*0x200]),0x200); ^ ERROR: line over 90 characters #1049: FILE: block/vvfat.c:1431: + else if(sector_num-s->first_sectors_number-s->sectors_per_fat<s->sectors_per_fat) ERROR: spaces required around that '-' (ctx:VxV) #1049: FILE: block/vvfat.c:1431: + else if(sector_num-s->first_sectors_number-s->sectors_per_fat<s->sectors_per_fat) ^ ERROR: spaces required around that '-' (ctx:VxV) #1049: FILE: block/vvfat.c:1431: + else if(sector_num-s->first_sectors_number-s->sectors_per_fat<s->sectors_per_fat) ^ ERROR: spaces required around that '<' (ctx:VxV) #1049: FILE: block/vvfat.c:1431: + else if(sector_num-s->first_sectors_number-s->sectors_per_fat<s->sectors_per_fat) ^ ERROR: space required before the open parenthesis '(' #1049: FILE: block/vvfat.c:1431: + else if(sector_num-s->first_sectors_number-s->sectors_per_fat<s->sectors_per_fat) ERROR: braces {} are necessary for all arms of this statement #1049: FILE: block/vvfat.c:1431: + else if(sector_num-s->first_sectors_number-s->sectors_per_fat<s->sectors_per_fat) [...] ERROR: line over 90 characters #1050: FILE: block/vvfat.c:1432: + memcpy(buf+i*0x200,&(s->fat.pointer[(sector_num-s->first_sectors_number-s->sectors_per_fat)*0x200]),0x200); ERROR: spaces required around that '+' (ctx:VxV) #1050: FILE: block/vvfat.c:1432: + memcpy(buf+i*0x200,&(s->fat.pointer[(sector_num-s->first_sectors_number-s->sectors_per_fat)*0x200]),0x200); ^ ERROR: spaces required around that '*' (ctx:VxV) #1050: FILE: block/vvfat.c:1432: + memcpy(buf+i*0x200,&(s->fat.pointer[(sector_num-s->first_sectors_number-s->sectors_per_fat)*0x200]),0x200); ^ ERROR: space required after that ',' (ctx:VxO) #1050: FILE: block/vvfat.c:1432: + memcpy(buf+i*0x200,&(s->fat.pointer[(sector_num-s->first_sectors_number-s->sectors_per_fat)*0x200]),0x200); ^ ERROR: space required before that '&' (ctx:OxV) #1050: FILE: block/vvfat.c:1432: + memcpy(buf+i*0x200,&(s->fat.pointer[(sector_num-s->first_sectors_number-s->sectors_per_fat)*0x200]),0x200); ^ ERROR: spaces required around that '-' (ctx:VxV) #1050: FILE: block/vvfat.c:1432: + memcpy(buf+i*0x200,&(s->fat.pointer[(sector_num-s->first_sectors_number-s->sectors_per_fat)*0x200]),0x200); ^ ERROR: spaces required around that '-' (ctx:VxV) #1050: FILE: block/vvfat.c:1432: + memcpy(buf+i*0x200,&(s->fat.pointer[(sector_num-s->first_sectors_number-s->sectors_per_fat)*0x200]),0x200); ^ ERROR: spaces required around that '*' (ctx:VxV) #1050: FILE: block/vvfat.c:1432: + memcpy(buf+i*0x200,&(s->fat.pointer[(sector_num-s->first_sectors_number-s->sectors_per_fat)*0x200]),0x200); ^ ERROR: space required after that ',' (ctx:VxV) #1050: FILE: block/vvfat.c:1432: + memcpy(buf+i*0x200,&(s->fat.pointer[(sector_num-s->first_sectors_number-s->sectors_per_fat)*0x200]),0x200); ^ ERROR: spaces required around that '=' (ctx:VxV) #1052: FILE: block/vvfat.c:1434: + uint32_t sector=sector_num-s->faked_sectors, ^ ERROR: spaces required around that '-' (ctx:VxV) #1052: FILE: block/vvfat.c:1434: + uint32_t sector=sector_num-s->faked_sectors, ^ ERROR: spaces required around that '=' (ctx:VxV) #1053: FILE: block/vvfat.c:1435: + sector_offset_in_cluster=(sector%s->sectors_per_cluster), ^ ERROR: spaces required around that '%' (ctx:VxV) #1053: FILE: block/vvfat.c:1435: + sector_offset_in_cluster=(sector%s->sectors_per_cluster), ^ ERROR: spaces required around that '=' (ctx:VxV) #1054: FILE: block/vvfat.c:1436: + cluster_num=sector/s->sectors_per_cluster; ^ ERROR: spaces required around that '/' (ctx:VxV) #1054: FILE: block/vvfat.c:1436: + cluster_num=sector/s->sectors_per_cluster; ^ WARNING: line over 80 characters #1055: FILE: block/vvfat.c:1437: + if(cluster_num > s->cluster_count || read_cluster(s, cluster_num) != 0) { ERROR: space required before the open parenthesis '(' #1055: FILE: block/vvfat.c:1437: + if(cluster_num > s->cluster_count || read_cluster(s, cluster_num) != 0) { ERROR: spaces required around that '+' (ctx:VxV) #1057: FILE: block/vvfat.c:1439: + memset(buf+i*0x200,0,0x200); ^ ERROR: spaces required around that '*' (ctx:VxV) #1057: FILE: block/vvfat.c:1439: + memset(buf+i*0x200,0,0x200); ^ ERROR: space required after that ',' (ctx:VxV) #1057: FILE: block/vvfat.c:1439: + memset(buf+i*0x200,0,0x200); ^ ERROR: space required after that ',' (ctx:VxV) #1057: FILE: block/vvfat.c:1439: + memset(buf+i*0x200,0,0x200); ^ ERROR: spaces required around that '+' (ctx:VxV) #1060: FILE: block/vvfat.c:1442: + memcpy(buf+i*0x200,s->cluster+sector_offset_in_cluster*0x200,0x200); ^ ERROR: spaces required around that '*' (ctx:VxV) #1060: FILE: block/vvfat.c:1442: + memcpy(buf+i*0x200,s->cluster+sector_offset_in_cluster*0x200,0x200); ^ ERROR: space required after that ',' (ctx:VxV) #1060: FILE: block/vvfat.c:1442: + memcpy(buf+i*0x200,s->cluster+sector_offset_in_cluster*0x200,0x200); ^ ERROR: spaces required around that '+' (ctx:VxV) #1060: FILE: block/vvfat.c:1442: + memcpy(buf+i*0x200,s->cluster+sector_offset_in_cluster*0x200,0x200); ^ ERROR: spaces required around that '*' (ctx:VxV) #1060: FILE: block/vvfat.c:1442: + memcpy(buf+i*0x200,s->cluster+sector_offset_in_cluster*0x200,0x200); ^ ERROR: space required after that ',' (ctx:VxV) #1060: FILE: block/vvfat.c:1442: + memcpy(buf+i*0x200,s->cluster+sector_offset_in_cluster*0x200,0x200); ^ ERROR: "foo* bar" should be "foo *bar" #1093: FILE: block/vvfat.c:1517: + commit_t* commit = array_get(&(s->commits), i); ERROR: braces {} are necessary for all arms of this statement #1095: FILE: block/vvfat.c:1519: + if (commit->action != ACTION_WRITEOUT) { [...] - } else [...] ERROR: braces {} are necessary even for single statement blocks #1100: FILE: block/vvfat.c:1522: + } else + assert(commit->path == NULL); ERROR: "foo* bar" should be "foo *bar" #1108: FILE: block/vvfat.c:1529: + uint32_t cluster, char* new_path) ERROR: "foo* bar" should be "foo *bar" #1126: FILE: block/vvfat.c:1548: + char* path, uint32_t first_cluster) ERROR: "foo* bar" should be "foo *bar" #1135: FILE: block/vvfat.c:1583: + const direntry_t* direntry) ERROR: braces {} are necessary for all arms of this statement #1169: FILE: block/vvfat.c:1605: + if (j == 11) [...] + else if (j == 26) [...] ERROR: braces {} are necessary for all arms of this statement #1171: FILE: block/vvfat.c:1607: + else if (j == 26) [...] ERROR: spaces required around that '+' (ctx:VxV) #1180: FILE: block/vvfat.c:1610: + if (pointer[j+1] == 0) ^ ERROR: braces {} are necessary for all arms of this statement #1180: FILE: block/vvfat.c:1610: + if (pointer[j+1] == 0) [...] + else if (pointer[j+1] != 0xff || (pointer[0] & 0x40) == 0) [...] + else [...] ERROR: spaces required around that '+' (ctx:VxV) #1182: FILE: block/vvfat.c:1612: + else if (pointer[j+1] != 0xff || (pointer[0] & 0x40) == 0) ^ ERROR: braces {} are necessary for all arms of this statement #1182: FILE: block/vvfat.c:1612: + else if (pointer[j+1] != 0xff || (pointer[0] & 0x40) == 0) [...] + else [...] ERROR: "(foo*)" should be "(foo *)" #1190: FILE: block/vvfat.c:1619: + lfn->len = offset + strlen((char*)lfn->name + offset); ERROR: "foo* bar" should be "foo *bar" #1198: FILE: block/vvfat.c:1626: + long_file_name* lfn, direntry_t* direntry) ERROR: braces {} are necessary for all arms of this statement #1214: FILE: block/vvfat.c:1635: + if (direntry->name[i] <= ' ' || direntry->name[i] > 0x7f) [...] + else if (s->downcase_short_names) [...] + else [...] ERROR: braces {} are necessary for all arms of this statement #1216: FILE: block/vvfat.c:1637: + else if (s->downcase_short_names) [...] + else [...] ERROR: space required after that ';' (ctx:BxV) #1230: FILE: block/vvfat.c:1648: + for (;j >= 0; j--) { ^ ERROR: "foo* bar" should be "foo *bar" #1282: FILE: block/vvfat.c:1744: + direntry_t* direntry, const char* path) ERROR: "foo* bar" should be "foo *bar" #1304: FILE: block/vvfat.c:1786: + const char* basename; ERROR: braces {} are necessary for all arms of this statement #1325: FILE: block/vvfat.c:1796: + if (strcmp(basename, basename2)) [...] ERROR: braces {} are necessary for all arms of this statement #1327: FILE: block/vvfat.c:1798: + } else if (is_file(direntry)) [...] ERROR: suspect code indent for conditional statements (16, 16) #1347: FILE: block/vvfat.c:1810: + if (mapping == NULL || [...] + mapping = find_mapping_for_cluster(s, cluster_num); ERROR: braces {} are necessary for all arms of this statement #1347: FILE: block/vvfat.c:1810: + if (mapping == NULL || [...] ERROR: "foo* bar" should be "foo *bar" #1372: FILE: block/vvfat.c:1826: + const char* basename = get_basename(mapping->path); ERROR: braces {} are necessary for all arms of this statement #1378: FILE: block/vvfat.c:1828: + if (strcmp(basename, basename2)) [...] WARNING: line over 80 characters #1380: FILE: block/vvfat.c:1830: + first_mapping_index = array_index(&(s->mapping), mapping); ERROR: braces {} are necessary for all arms of this statement #1445: FILE: block/vvfat.c:1878: + if (s->used_clusters[cluster_num] & USED_ANY) [...] ERROR: braces {} are necessary for all arms of this statement #1456: FILE: block/vvfat.c:1884: + if (fat_eof(s, cluster_num)) [...] + else if (cluster_num < 2 || cluster_num > s->max_fat_value - 16) [...] ERROR: braces {} are necessary for all arms of this statement #1458: FILE: block/vvfat.c:1886: + else if (cluster_num < 2 || cluster_num > s->max_fat_value - 16) [...] ERROR: "foo* bar" should be "foo *bar" #1471: FILE: block/vvfat.c:1899: + int cluster_num, const char* path) ERROR: "foo* bar" should be "foo *bar" #1481: FILE: block/vvfat.c:1916: + const char* basename = get_basename(mapping->path); ERROR: "foo* bar" should be "foo *bar" #1482: FILE: block/vvfat.c:1917: + const char* basename2 = get_basename(path); ERROR: braces {} are necessary for all arms of this statement #1494: FILE: block/vvfat.c:1924: + if (strcmp(basename, basename2)) [...] WARNING: line over 80 characters #1515: FILE: block/vvfat.c:1938: + fprintf(stderr, "cluster %d used more than once\n", (int)cluster_num); ERROR: braces {} are necessary for all arms of this statement #1573: FILE: block/vvfat.c:1957: + if (is_volume_label(direntries + i) || is_dot(direntries + i) || [...] ERROR: braces {} are necessary for all arms of this statement #1582: FILE: block/vvfat.c:1966: + if (subret == 0 || is_free(direntries + i)) [...] ERROR: spaces required around that '+' (ctx:VxV) #1585: FILE: block/vvfat.c:1969: + if (fat_chksum(direntries+i) != lfn.checksum) { ^ ERROR: "(foo*)" should be "(foo *)" #1591: FILE: block/vvfat.c:1975: + if (subret > 0 || !strcmp((char*)lfn.name, ".") ERROR: braces {} are necessary for all arms of this statement #1591: FILE: block/vvfat.c:1975: + if (subret > 0 || !strcmp((char*)lfn.name, ".") [...] ERROR: "(foo*)" should be "(foo *)" #1592: FILE: block/vvfat.c:1976: + || !strcmp((char*)lfn.name, "..")) ERROR: braces {} are necessary for all arms of this statement #1619: FILE: block/vvfat.c:1988: + if (is_directory(direntries + i)) { [...] + } else if (is_file(direntries + i)) { [...] - } else [...] ERROR: line over 90 characters #1621: FILE: block/vvfat.c:1990: + DLOG(fprintf(stderr, "invalid begin for directory: %s\n", path2); print_direntry(direntries + i)); ERROR: line over 90 characters #1627: FILE: block/vvfat.c:1996: + DLOG(fprintf(stderr, "problem in directory %s:\n", path2); print_direntry(direntries + i)); WARNING: line over 80 characters #1632: FILE: block/vvfat.c:2001: + cluster_count = get_cluster_count_for_direntry(s, direntries + i, path2); ERROR: braces {} are necessary even for single statement blocks #1642: FILE: block/vvfat.c:2007: + } else abort(); /* cluster_count = 0; */ ERROR: "foo* bar" should be "foo *bar" #1691: FILE: block/vvfat.c:2061: + mapping_t* mapping = array_get(&(s->mapping), i); ERROR: braces {} are necessary for all arms of this statement #1692: FILE: block/vvfat.c:2062: + if (mapping->first_mapping_index < 0) [...] ERROR: space required before the open parenthesis '(' #1714: FILE: block/vvfat.c:2075: + if(!s->used_clusters[i]) { ERROR: line over 90 characters #1715: FILE: block/vvfat.c:2076: + DLOG(fprintf(stderr, "FAT was modified (%d), but cluster is not used?\n", i)); ERROR: "foo* bar" should be "foo *bar" #1748: FILE: block/vvfat.c:2101: + mapping_t* mapping = array_get(&(s->mapping), i); ERROR: braces {} are necessary for all arms of this statement #1753: FILE: block/vvfat.c:2104: + if (mapping->name >= offset) \ [...] ERROR: spaces required around that '+' (ctx:WxV) #1791: FILE: block/vvfat.c:2137: + adjust_mapping_indices(s, index, +1); ^ ERROR: "foo* bar" should be "foo *bar" #1827: FILE: block/vvfat.c:2182: + mapping_t* mapping = array_get(&(s->mapping), i); ERROR: braces {} are necessary for all arms of this statement #1828: FILE: block/vvfat.c:2183: + if (mapping->dir_index >= offset) [...] ERROR: trailing statements should be on next line #1934: FILE: block/vvfat.c:2239: + for (c = cluster, c1 = modified_fat_get(s, c); c + 1 == c1; + c = c1, c1 = modified_fat_get(s, c1)); ERROR: trailing statements should be on next line #1941: FILE: block/vvfat.c:2246: + for (i = 1; i < max_i && mapping[i].begin < c; i++); ERROR: braces {} are necessary even for single statement blocks #1941: FILE: block/vvfat.c:2246: + for (i = 1; i < max_i && mapping[i].begin < c; i++); ERROR: braces {} are necessary even for single statement blocks #1942: FILE: block/vvfat.c:2247: + while (--i > 0) + remove_mapping(s, index + 1); ERROR: "foo* bar" should be "foo *bar" #1951: FILE: block/vvfat.c:2256: + mapping_t* next_mapping = i >= s->mapping.next ? NULL : ERROR: spaces required around that '+' (ctx:VxV) #1957: FILE: block/vvfat.c:2262: + next_mapping = insert_mapping(s, c1, c1+1); ^ ERROR: braces {} are necessary for all arms of this statement #1959: FILE: block/vvfat.c:2264: + if (c1 < c) [...] ERROR: braces {} are necessary for all arms of this statement #1972: FILE: block/vvfat.c:2277: + if (mapping->mode & MODE_DIRECTORY) { [...] + } else [...] ERROR: braces {} are necessary for all arms of this statement #2027: FILE: block/vvfat.c:2336: + if (insert_direntries(s, [...] ERROR: "foo* bar" should be "foo *bar" #2046: FILE: block/vvfat.c:2347: + void* direntry = array_get(&(s->directory), current_dir_index); ERROR: braces {} are necessary for all arms of this statement #2049: FILE: block/vvfat.c:2350: + if (ret) [...] ERROR: braces {} are necessary for all arms of this statement #2082: FILE: block/vvfat.c:2372: + if (ret) [...] ERROR: spaces required around that '>=' (ctx:WxV) #2135: FILE: block/vvfat.c:2424: + (size > offset && c >=2 && !fat_eof(s, c))); ^ ERROR: "(foo*)" should be "(foo *)" #2140: FILE: block/vvfat.c:2427: + (uint8_t*)cluster, (rest_size + 0x1ff) / 0x200); ERROR: "foo* bar" should be "foo *bar" #2171: FILE: block/vvfat.c:2463: + mapping_t* mapping = array_get(&(s->mapping), i); ERROR: "foo* bar" should be "foo *bar" #2177: FILE: block/vvfat.c:2469: + direntry_t* direntry = array_get(&(s->directory), mapping->dir_index); ERROR: line over 90 characters #2178: FILE: block/vvfat.c:2470: + assert(mapping->begin == begin_of_direntry(direntry) || mapping->first_mapping_index >= 0); ERROR: line over 90 characters #2180: FILE: block/vvfat.c:2472: + assert(mapping->info.dir.first_dir_index + 0x10 * s->sectors_per_cluster * (mapping->end - mapping->begin) <= s->directory.next); ERROR: line over 90 characters #2181: FILE: block/vvfat.c:2473: + assert((mapping->info.dir.first_dir_index % (0x10 * s->sectors_per_cluster)) == 0); ERROR: "foo* bar" should be "foo *bar" #2227: FILE: block/vvfat.c:2485: + direntry_t* direntry = array_get(&(s->directory), i); WARNING: line over 80 characters #2230: FILE: block/vvfat.c:2488: + mapping_t* mapping = find_mapping_for_cluster(s, begin_of_direntry(direntry)); ERROR: "foo* bar" should be "foo *bar" #2230: FILE: block/vvfat.c:2488: + mapping_t* mapping = find_mapping_for_cluster(s, begin_of_direntry(direntry)); WARNING: line over 80 characters #2233: FILE: block/vvfat.c:2491: + assert(mapping->begin == begin_of_direntry(direntry) || is_dot(direntry)); ERROR: "foo* bar" should be "foo *bar" #2241: FILE: block/vvfat.c:2499: + mapping_t* mapping = array_get(&(s->mapping), j); ERROR: braces {} are necessary for all arms of this statement #2242: FILE: block/vvfat.c:2500: + if (mapping->mode & MODE_DELETED) [...] ERROR: line over 90 characters #2245: FILE: block/vvfat.c:2503: + if (mapping->info.dir.first_dir_index <= i && mapping->info.dir.first_dir_index + 0x10 * s->sectors_per_cluster > i) { ERROR: braces {} are necessary for all arms of this statement #2247: FILE: block/vvfat.c:2505: + if (mapping->first_mapping_index == -1) [...] + else [...] WARNING: line over 80 characters #2250: FILE: block/vvfat.c:2508: + assert(first_mapping == mapping->first_mapping_index); ERROR: braces {} are necessary for all arms of this statement #2251: FILE: block/vvfat.c:2509: + if (mapping->info.dir.parent_mapping_index < 0) [...] + else { [...] ERROR: line over 90 characters #2254: FILE: block/vvfat.c:2512: + mapping_t* parent = array_get(&(s->mapping), mapping->info.dir.parent_mapping_index); ERROR: "foo* bar" should be "foo *bar" #2254: FILE: block/vvfat.c:2512: + mapping_t* parent = array_get(&(s->mapping), mapping->info.dir.parent_mapping_index); ERROR: line over 90 characters #2256: FILE: block/vvfat.c:2514: + assert(parent->info.dir.first_dir_index < mapping->info.dir.first_dir_index); ERROR: braces {} are necessary for all arms of this statement #2261: FILE: block/vvfat.c:2519: + if (count == 0) [...] ERROR: "foo* bar" should be "foo *bar" #2273: FILE: block/vvfat.c:2533: + commit_t* commit = array_get(&(s->commits), i); ERROR: line over 90 characters #2274: FILE: block/vvfat.c:2534: + fprintf(stderr, "%d, %s (%d, %d)\n", i, commit->path ? commit->path : "(null)", commit->param.rename.cluster, commit->action); ERROR: "foo* bar" should be "foo *bar" #2311: FILE: block/vvfat.c:2539: + commit_t* commit = array_get(&(s->commits), i); ERROR: "foo* bar" should be "foo *bar" #2313: FILE: block/vvfat.c:2541: + mapping_t* mapping = find_mapping_for_cluster(s, ERROR: "foo* bar" should be "foo *bar" #2315: FILE: block/vvfat.c:2543: + char* old_path = mapping->path; ERROR: braces {} are necessary for all arms of this statement #2319: FILE: block/vvfat.c:2547: + if (rename(old_path, mapping->path)) [...] ERROR: "foo* bar" should be "foo *bar" #2326: FILE: block/vvfat.c:2554: + direntry_t* direntry = array_get(&(s->directory), ERROR: "foo* bar" should be "foo *bar" #2334: FILE: block/vvfat.c:2562: + direntry_t* d = direntry + i; ERROR: "foo* bar" should be "foo *bar" #2337: FILE: block/vvfat.c:2565: + mapping_t* m = find_mapping_for_cluster(s, ERROR: "foo* bar" should be "foo *bar" #2340: FILE: block/vvfat.c:2568: + char* new_path = g_malloc(l + diff + 1); ERROR: space required before the open parenthesis '(' #2358: FILE: block/vvfat.c:2579: + } while((i % (0x10 * s->sectors_per_cluster)) != 0); ERROR: "foo* bar" should be "foo *bar" #2372: FILE: block/vvfat.c:2588: + mapping_t* mapping; ERROR: braces {} are necessary for all arms of this statement #2414: FILE: block/vvfat.c:2601: + if (mapping == NULL) [...] ERROR: "foo* bar" should be "foo *bar" #2429: FILE: block/vvfat.c:2616: + mapping_t* m = array_get(&(s->mapping), j); ERROR: braces {} are necessary for all arms of this statement #2430: FILE: block/vvfat.c:2617: + if (m->first_mapping_index < 0 && m != mapping && [...] ERROR: "foo* bar" should be "foo *bar" #2453: FILE: block/vvfat.c:2644: + commit_t* commit = array_get(&(s->commits), i); ERROR: space required before the open parenthesis '(' #2454: FILE: block/vvfat.c:2645: + switch(commit->action) { ERROR: "foo* bar" should be "foo *bar" #2469: FILE: block/vvfat.c:2653: + direntry_t* entry = array_get(&(s->directory), ERROR: "foo* bar" should be "foo *bar" #2472: FILE: block/vvfat.c:2656: + mapping_t* mapping = find_mapping_for_cluster(s, begin); ERROR: braces {} are necessary for all arms of this statement #2528: FILE: block/vvfat.c:2663: + if (commit_one_file(s, commit->param.writeout.dir_index, [...] ERROR: "foo* bar" should be "foo *bar" #2536: FILE: block/vvfat.c:2671: + mapping_t* mapping = find_mapping_for_cluster(s, begin); ERROR: "foo* bar" should be "foo *bar" #2537: FILE: block/vvfat.c:2672: + direntry_t* entry; ERROR: braces {} are necessary for all arms of this statement #2543: FILE: block/vvfat.c:2678: + if (is_file(entry) && begin_of_direntry(entry) == begin) [...] ERROR: spaces required around that '+' (ctx:VxV) #2558: FILE: block/vvfat.c:2693: + mapping = insert_mapping(s, begin, begin+1); ^ ERROR: braces {} are necessary for all arms of this statement #2567: FILE: block/vvfat.c:2702: + if (commit_one_file(s, i, 0)) [...] ERROR: "foo* bar" should be "foo *bar" #2638: FILE: block/vvfat.c:2727: + mapping_t* mapping = array_get(&(s->mapping), i); ERROR: "foo* bar" should be "foo *bar" #2640: FILE: block/vvfat.c:2729: + direntry_t* entry = array_get(&(s->directory), ERROR: braces {} are necessary for all arms of this statement #2650: FILE: block/vvfat.c:2739: + if (errno == ENOTEMPTY) { [...] + } else [...] ERROR: "foo* bar" should be "foo *bar" #2658: FILE: block/vvfat.c:2747: + mapping_t* m = array_get(&(s->mapping), j); ERROR: braces {} are necessary for all arms of this statement #2659: FILE: block/vvfat.c:2748: + if (m->mode & MODE_DIRECTORY && [...] ERROR: braces {} are necessary for all arms of this statement #2673: FILE: block/vvfat.c:2762: + if (unlink(mapping->path)) [...] ERROR: line over 90 characters #2677: FILE: block/vvfat.c:2766: + DLOG(fprintf(stderr, "DELETE (%d)\n", i); print_mapping(mapping); print_direntry(entry)); ERROR: "foo* bar" should be "foo *bar" #2798: FILE: block/vvfat.c:2870: + mapping_t* mapping = find_mapping_for_cluster(s, i); ERROR: braces {} are necessary for all arms of this statement #2799: FILE: block/vvfat.c:2871: + if (mapping) { [...] + } else [...] ERROR: "foo* bar" should be "foo *bar" #2810: FILE: block/vvfat.c:2882: + const direntry_t* direntries; ERROR: braces {} are necessary for all arms of this statement #2815: FILE: block/vvfat.c:2887: + if (begin < sector_num) [...] ERROR: braces {} are necessary for all arms of this statement #2817: FILE: block/vvfat.c:2889: + if (end > sector_num + nb_sectors) [...] ERROR: "(foo*)" should be "(foo *)" #2821: FILE: block/vvfat.c:2893: + direntries = (direntry_t*)(buf + 0x200 * (begin - sector_num)); ERROR: spaces required around that '+' (ctx:VxV) #2830: FILE: block/vvfat.c:2902: + else if (is_short_name(direntries+k) && ^ ERROR: line over 90 characters #2835: FILE: block/vvfat.c:2907: + fprintf(stderr, "Warning: tried to write to write-protected file\n"); ERROR: braces {} are necessary for all arms of this statement #2862: FILE: block/vvfat.c:2930: + if (i >= 0) [...] total: 540 errors, 9 warnings, 2803 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 3/13: vvfat: fix typos... Checking PATCH 4/13: vvfat: rename useless enumeration values... Checking PATCH 5/13: vvfat: introduce offset_to_bootsector, offset_to_fat and offset_to_root_dir... Checking PATCH 6/13: vvfat: fix field names in FAT12/FAT16 and FAT32 boot sectors... Checking PATCH 7/13: vvfat: always create . and .. entries at first and in that order... Checking PATCH 8/13: vvfat: correctly create long names for non-ASCII filenames... Checking PATCH 9/13: vvfat: correctly create base short names for non-ASCII filenames... Checking PATCH 10/13: vvfat: correctly generate numeric-tail of short file names... Checking PATCH 11/13: vvfat: limit number of entries in root directory in FAT12/FAT16... Checking PATCH 12/13: vvfat: handle KANJI lead byte 0xe5... Checking PATCH 13/13: vvfat: change OEM name to 'MSWIN4.1'... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@freelists.org
© 2016 - 2024 Red Hat, Inc.