[v2] block: fix 'savevm' hang with -object iothread

[Qemu-devel] [PATCH v2 0/4] block: fix 'savevm' hang with -object iothread

Stefan Hajnoczi posted 4 patches 6 years, 11 months ago

Diff against v1 v3
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170519103247.4405-1-stefanha@redhat.com

Test checkpatch passed

Test docker passed

Test s390x passed

There is a newer version of this series

block/io.c         | 21 +++++++++++++--------
migration/savevm.c | 21 +++++++++++++++++++--
2 files changed, 32 insertions(+), 10 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH v2 0/4] block: fix 'savevm' hang with -object iothread

Posted by Stefan Hajnoczi 6 years, 11 months ago

v2:
 * New patch to use bdrv_drain_all_begin/end() in savevm/loadvm [Kevin]
   (All other patches unchanged)

The 'savevm' command hangs when -object iothread is used.  See patches for
details, but basically the vmstate read/write code didn't conform to the latest
block layer locking rules.

Stefan Hajnoczi (4):
  block: count bdrv_co_rw_vmstate() requests
  block: use BDRV_POLL_WHILE() in bdrv_rw_vmstate()
  migration: avoid recursive AioContext locking in save_vmstate()
  migration: use bdrv_drain_all_begin/end() instead bdrv_drain_all()

 block/io.c         | 21 +++++++++++++--------
 migration/savevm.c | 21 +++++++++++++++++++--
 2 files changed, 32 insertions(+), 10 deletions(-)

-- 
2.9.3