From nobody Fri May 3 00:37:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1494560267273611.0507329891333; Thu, 11 May 2017 20:37:47 -0700 (PDT) Received: from localhost ([::1]:51155 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d91Oj-0007oe-IF for importer@patchew.org; Thu, 11 May 2017 23:37:45 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47208) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d91ND-0006U2-0A for qemu-devel@nongnu.org; Thu, 11 May 2017 23:36:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d91NB-0003bN-Tp for qemu-devel@nongnu.org; Thu, 11 May 2017 23:36:11 -0400 Received: from mail-qk0-x243.google.com ([2607:f8b0:400d:c09::243]:35783) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d91NB-0003bE-Pl for qemu-devel@nongnu.org; Thu, 11 May 2017 23:36:09 -0400 Received: by mail-qk0-x243.google.com with SMTP id k74so6323280qke.2 for ; Thu, 11 May 2017 20:36:09 -0700 (PDT) Received: from localhost.localdomain ([138.117.48.226]) by smtp.gmail.com with ESMTPSA id m188sm1443267qkc.5.2017.05.11.20.36.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 May 2017 20:36:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HiaPev6/xKPbNKgmODGn0D/jCcJnrxxJojbY1WdUb9g=; b=sCc0hLbYnify9l1DB6GXtiBZ8lYAThY4rYOIWyTurQLHd41xov3asL3MgqdEbsx3Yk uomrii/9cjsNnJBtvwqlOQM+54JszVBb7b8K8i/yIWP/9xEv64Eh73MNevvNkn5+6OEs 2MtcAZgXwgPkNTgiAWGZmZqZmFGY447SsXHUN2GFrMDkQEK8NdWYuf1Pm75kSAt8Z567 DJRYmq5EKPmGTmmE770Or3KniGElz53iTdVHrK+v4hbcms87PFw26o208OPuwWiUAnp8 SUfq3lznlm1DmQ6vLypUJwg/UWQkSo5B6YmU2AW/zoyLhSxQea4UHS9qsvrUNNins74w Kjdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=HiaPev6/xKPbNKgmODGn0D/jCcJnrxxJojbY1WdUb9g=; b=GQad1kQBta5IV85ZsMynh68M5Seq5li91nCJF0daLc2FGQ+Fj3DhNMYdZVSrZvQc+q K/rwMMQE2HM6HdwnZPCVHxaujaG3F/d/HD/Ir9jUQ7K+w6oY9qBRDqqIiXvnYfKX6Ehk Yx+295mFYaRyJ4m3DnweZ7CedMeOB1EAQvWOVyMd2SsqoT4li0xjHhzKWs4779WtJ27d Cb0XR5b1cFx1gvQavN1t0eOhFRooXF8J4icr79JeAIDMQVHwnLNXE3grenmJb0Qd4P1Q BQwOgf2ZZzGVaPxfSL3u8VXERxnxKw/+w7LY7fEtacPMZ7P2RwkNrB1okQf/OTmhomHw lFlg== X-Gm-Message-State: AODbwcDCIokEPCQZvDPIZ9KVSvIDKsG3eQ7pVTl8+cbOALItvFtA4UAj Q7fliGCz4X3C8w== X-Received: by 10.55.134.2 with SMTP id i2mr1662567qkd.43.1494560169208; Thu, 11 May 2017 20:36:09 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Aurelien Jarno , Richard Henderson , Nikunj A Dadhania , Eric Blake , Markus Armbruster , Laurent Vivier , Michael Tokarev , Eduardo Habkost , Paolo Bonzini Date: Fri, 12 May 2017 00:35:39 -0300 Message-Id: <20170512033543.6789-2-f4bug@amsat.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170512033543.6789-1-f4bug@amsat.org> References: <20170512033543.6789-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::243 Subject: [Qemu-devel] [RFC PATCH v3 1/5] coccinelle: add a script to optimize tcg op using tcg_gen_extract() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Julia Lawall , Nicolas Palix , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Markus Elfring Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 If you have coccinelle installed you can apply this script using: $ spatch \ --macro-file scripts/cocci-macro-file.h \ --dir target --in-place You can also use directly Peter Senna Tschudin docker image (easier): $ docker run -v `pwd`:`pwd` -w `pwd` petersenna/coccinelle \ --sp-file scripts/coccinelle/tcg_gen_extract.cocci \ --macro-file scripts/cocci-macro-file.h \ --dir target --in-place Then verified that no manual touchups are required. The following thread was helpful while writing this script: https://github.com/coccinelle/coccinelle/issues/86 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- scripts/coccinelle/tcg_gen_extract.cocci | 71 ++++++++++++++++++++++++++++= ++++ 1 file changed, 71 insertions(+) create mode 100644 scripts/coccinelle/tcg_gen_extract.cocci diff --git a/scripts/coccinelle/tcg_gen_extract.cocci b/scripts/coccinelle/= tcg_gen_extract.cocci new file mode 100644 index 0000000000..4823073005 --- /dev/null +++ b/scripts/coccinelle/tcg_gen_extract.cocci @@ -0,0 +1,71 @@ +// optimize TCG using extract op +// +// Copyright: (C) 2017 Philippe Mathieu-Daud=C3=A9. GPLv2+. +// Confidence: High +// Options: --macro-file scripts/cocci-macro-file.h +// +// Nikunj A Dadhania optimization: +// http://lists.nongnu.org/archive/html/qemu-devel/2017-02/msg05211.html +// Aurelien Jarno optimization: +// http://lists.nongnu.org/archive/html/qemu-devel/2017-05/msg01466.html +// Coccinelle helpful issue: +// https://github.com/coccinelle/coccinelle/issues/86 + +@match@ // match shri*+andi* pattern, calls script verify_len +identifier ret, arg; +constant ofs, len; +identifier shr_fn =3D~ "^tcg_gen_shri_"; +identifier and_fn =3D~ "^tcg_gen_andi_"; +position shr_p; +position and_p; +@@ +( +shr_fn@shr_p(ret, arg, ofs); +and_fn@and_p(ret, ret, len); +) + +@script:python verify_len@ +ret_s << match.ret; +len_s << match.len; +shr_s << match.shr_fn; +and_s << match.and_fn; +shr_p << match.shr_p; +extract_fn; +@@ +print "candidate at %s:%s" % (shr_p[0].file, shr_p[0].line) +len_fn=3Dlen("tcg_gen_shri_") +shr_sz=3Dshr_s[len_fn:] +and_sz=3Dand_s[len_fn:] +# TODO: op_size shr Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1494560387918218.98064925879487; Thu, 11 May 2017 20:39:47 -0700 (PDT) Received: from localhost ([::1]:51163 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d91Qg-0000s2-Oj for importer@patchew.org; Thu, 11 May 2017 23:39:46 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47256) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d91NJ-0006YZ-1B for qemu-devel@nongnu.org; Thu, 11 May 2017 23:36:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d91NF-0003dD-0p for qemu-devel@nongnu.org; Thu, 11 May 2017 23:36:16 -0400 Received: from mail-qt0-x241.google.com ([2607:f8b0:400d:c0d::241]:35437) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d91NE-0003cp-TK; Thu, 11 May 2017 23:36:12 -0400 Received: by mail-qt0-x241.google.com with SMTP id r58so5366380qtb.2; Thu, 11 May 2017 20:36:12 -0700 (PDT) Received: from localhost.localdomain ([138.117.48.226]) by smtp.gmail.com with ESMTPSA id m188sm1443267qkc.5.2017.05.11.20.36.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 May 2017 20:36:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nhTGRxVfoJ7Ah/YLU6COAHFDl7Y4Ci8qhe51bjgzQXc=; b=saq/o/O9iOxF4meuv42d7hLJHLuPQuyhgUdSNspUlyDYoXb80FUKFZ8sPpsEAcFvMS Dnt1/ThvckOroxFmrkxHML+cuZ5Yyb2uy0DX3dg7VKUUOyT8+kqp3YGr6lcLHN8hZwRW Wc9VvVCbRVad2PoSNia0sVY6WnewB8dJkvfeZE/QrcZf300IUitCSUv2nm2Fc6+XpIQg dlwAKI7irrzAsNRMwKfEpCBKN5rcvZt+emjDOLMMUwqKNuX2sOXArw1YPrxrB6waIRIe GeN1D/m/Tzp+ERL85K9uZ5PUN5WYLG1etZucqJdG2Kfv34VxcEeB/C7az1m8kEel4rhe t1pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=nhTGRxVfoJ7Ah/YLU6COAHFDl7Y4Ci8qhe51bjgzQXc=; b=h5SZbx+r++4hXUXCmVbcH9YUlamM/UiMYJqtld5riOf6GI8rS5Xfa0nNPirEexSvWX n0gHtLWmJGShK84kfSePsxCmrdEYip4BxGZuaJ96smsX5yZ6/M8c7vUqCBI0ye7l4pDo 8As6uVmRdxfwjayqo6xNWe9Jv5MnF44JhjKu/oBW0scWA4tDyJtGEDsanqyvHkaaSmks NqDk+livS1oJ7EZQGYaq7iIERNZ2ZnIADg2nYG6gh9/KoEfHI1eP5im9iVWCDVunOGox tnOFZLpszKNek/5m+TkNq48hroPjUaE5Xw8Y/ZkS22r5xqvCmzb84R/s4fFfyguKivgV prvw== X-Gm-Message-State: AODbwcB4phSmvdva3zl0F0356oIg/qE527MOCtQl7Z0BFwkzmHTAOfVH XfYzcp5Ys1JyPg== X-Received: by 10.237.53.149 with SMTP id c21mr1831176qte.191.1494560172376; Thu, 11 May 2017 20:36:12 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Peter Maydell , Aurelien Jarno , Richard Henderson , qemu-arm@nongnu.org Date: Fri, 12 May 2017 00:35:40 -0300 Message-Id: <20170512033543.6789-3-f4bug@amsat.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170512033543.6789-1-f4bug@amsat.org> References: <20170512033543.6789-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::241 Subject: [Qemu-devel] [PATCH v3 2/5] target/arm: optimize rev16() using extract op X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Patch created mechanically using Coccinelle script via: $ spatch --macro-file scripts/cocci-macro-file.h --in-place \ --sp-file scripts/coccinelle/tcg_gen_extract.cocci --dir target Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/arm/translate-a64.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 24de30d92c..7ea130107e 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -4038,14 +4038,12 @@ static void handle_rev16(DisasContext *s, unsigned = int sf, tcg_gen_andi_i64(tcg_tmp, tcg_rn, 0xffff); tcg_gen_bswap16_i64(tcg_rd, tcg_tmp); =20 - tcg_gen_shri_i64(tcg_tmp, tcg_rn, 16); - tcg_gen_andi_i64(tcg_tmp, tcg_tmp, 0xffff); + tcg_gen_extract_i64(tcg_tmp, tcg_rn, 16, 0xffff); tcg_gen_bswap16_i64(tcg_tmp, tcg_tmp); tcg_gen_deposit_i64(tcg_rd, tcg_rd, tcg_tmp, 16, 16); =20 if (sf) { - tcg_gen_shri_i64(tcg_tmp, tcg_rn, 32); - tcg_gen_andi_i64(tcg_tmp, tcg_tmp, 0xffff); + tcg_gen_extract_i64(tcg_tmp, tcg_rn, 32, 0xffff); tcg_gen_bswap16_i64(tcg_tmp, tcg_tmp); tcg_gen_deposit_i64(tcg_rd, tcg_rd, tcg_tmp, 32, 16); =20 --=20 2.11.0 From nobody Fri May 3 00:37:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1494560478303307.6670751252766; Thu, 11 May 2017 20:41:18 -0700 (PDT) Received: from localhost ([::1]:51172 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d91S9-0001vf-4F for importer@patchew.org; Thu, 11 May 2017 23:41:17 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47272) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d91NK-0006ZO-4v for qemu-devel@nongnu.org; Thu, 11 May 2017 23:36:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d91NJ-0003eV-9I for qemu-devel@nongnu.org; Thu, 11 May 2017 23:36:18 -0400 Received: from mail-qt0-x244.google.com ([2607:f8b0:400d:c0d::244]:33214) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d91NJ-0003eN-30 for qemu-devel@nongnu.org; Thu, 11 May 2017 23:36:17 -0400 Received: by mail-qt0-x244.google.com with SMTP id a46so5374112qte.0 for ; Thu, 11 May 2017 20:36:16 -0700 (PDT) Received: from localhost.localdomain ([138.117.48.226]) by smtp.gmail.com with ESMTPSA id m188sm1443267qkc.5.2017.05.11.20.36.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 May 2017 20:36:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=U4h7F7PCvb/T+pCJbDsZWpNqNpff+PIWnBdVVeaKirc=; b=PzlA2VEZlFP3J2JsKhv1iHGFlYaRANinXZmOHk2JorY27xRfJIOd/4yB5UYNokH7+/ nq7Na+Z9nefhDOtAEAvgL4IiPKqQLPMfY+XyRKrwn87diLlgljZTAyH/Vn5EYqzfcrYG ag2KOfwVD8OqQd8f0JWG8r5UR0ONe/7KnhIf84tbkpLtUIMobCMcEv3Qe5CCAfw7JKuS /vYL4V5wAUt0k5cGMpwUx9H+i2JerYiJmDVwtLjmfs0uUyib9Nip3hqTrnNWQfi4Jz/4 o64Nlg6yvNBl3eYBPXp2flf5SD3yiTGlthZMtKIbnu+iySO9dC6y25uedZ9rOukFBtcw o9Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=U4h7F7PCvb/T+pCJbDsZWpNqNpff+PIWnBdVVeaKirc=; b=Ph7HVxv+cETMz3zlZjrWehOAwXWc6l8xE2LOh4AEX7Zm3DD82cAgfA3m13KChyoHu1 twnPO6ykLW3dlWAb4ulfkqvIVJlfBD6cxb/wjWn3JmEuVceQoyo4TszHtfnouAbu8SP+ 6L7+Bb4ItWDEwi7DJQwsLD9j8h8EPI3zp7J9uwlvjeDSHOtpfTyAlHoTaLHC7ZAqiCfK Hcme4Rtmpzvvx8vxV7xpxhqyeMCXxB4lbXu4j/ub++qI1ZdNLZPryE7ejsGITbxDW7oC UYi9nuzYsZ403HQ+B6eXEjTM7R27JwxfzISNRsR6j7CJxBxetb12S+wUEGLux/2Fxg2g 1wlw== X-Gm-Message-State: AODbwcCZxTdYqYDB371DbKWVDU1PDHHElExVKWgTeWxPfxRWBXZCkqH7 JbMhWbDiJXDeVg== X-Received: by 10.200.49.46 with SMTP id g43mr1697067qtb.229.1494560176655; Thu, 11 May 2017 20:36:16 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Aurelien Jarno , Richard Henderson , Laurent Vivier Date: Fri, 12 May 2017 00:35:41 -0300 Message-Id: <20170512033543.6789-4-f4bug@amsat.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170512033543.6789-1-f4bug@amsat.org> References: <20170512033543.6789-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::244 Subject: [Qemu-devel] [PATCH v3 3/5] target/m68k: optimize bcd_flags() using extract op X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Patch created mechanically using Coccinelle script via: $ spatch --macro-file scripts/cocci-macro-file.h --in-place \ --sp-file scripts/coccinelle/tcg_gen_extract.cocci --dir target Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Laurent Vivier --- target/m68k/translate.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index 9f60fbc0db..babb9e2c5b 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translate.c @@ -1463,8 +1463,7 @@ static void bcd_flags(TCGv val) tcg_gen_andi_i32(QREG_CC_C, val, 0x0ff); tcg_gen_or_i32(QREG_CC_Z, QREG_CC_Z, QREG_CC_C); =20 - tcg_gen_shri_i32(QREG_CC_C, val, 8); - tcg_gen_andi_i32(QREG_CC_C, QREG_CC_C, 1); + tcg_gen_extract_i32(QREG_CC_C, val, 8, 1); =20 tcg_gen_mov_i32(QREG_CC_X, QREG_CC_C); } --=20 2.11.0 From nobody Fri May 3 00:37:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 149456028885983.70212716609535; Thu, 11 May 2017 20:38:08 -0700 (PDT) Received: from localhost ([::1]:51156 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d91P5-000854-9O for importer@patchew.org; Thu, 11 May 2017 23:38:07 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d91NO-0006cQ-3Z for qemu-devel@nongnu.org; Thu, 11 May 2017 23:36:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d91NN-0003fJ-0t for qemu-devel@nongnu.org; Thu, 11 May 2017 23:36:22 -0400 Received: from mail-qt0-x243.google.com ([2607:f8b0:400d:c0d::243]:33217) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d91NM-0003fF-Sh; Thu, 11 May 2017 23:36:20 -0400 Received: by mail-qt0-x243.google.com with SMTP id a46so5374220qte.0; Thu, 11 May 2017 20:36:20 -0700 (PDT) Received: from localhost.localdomain ([138.117.48.226]) by smtp.gmail.com with ESMTPSA id m188sm1443267qkc.5.2017.05.11.20.36.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 May 2017 20:36:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SY4zKpJNSzQpDbuzAA2C+kru0KKRMTzAmj3ldILvbjI=; b=lVKRKww4NLN5NCs1V9ac4VQa25dGJUyI6Vl9z9qGoj9VgxRSJqX3ifMsDEoH7CXJjA Sse0/B2C8WYQ8EygvDG2Fa3nOQIqt3lZ3y84U/KC0cl9hkEAU3rne+eqGRuUOQ87IqqM 4VWNYDbpPkvdgBcqWR2wFTqKhyWGQQjh07iNU1uqejCa77eXVyXEV7bJnXomgmJwqsAl hxZ4Ss/B472Yvd/0FRTnfC+eA1RkmjgiCKZib4qqEgGsc1XzCCgvde9GAAnm7rCAafMr dGBBWxYxoYmAdPjZyM5JgwEotG/CGpvLRAdYqAsh6mJFdBkUv+InLkBXfW36jDcDmagN 0c/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=SY4zKpJNSzQpDbuzAA2C+kru0KKRMTzAmj3ldILvbjI=; b=ob8elMeH6cnMvXw0r6tSYImDSqrqhiIflpiVEXKH1PnMsHPEdpT21LIq7x0t/nG6Yb YpymHwDb6JgzAj0gX2/PDLAWymmahTPt0SprFTvlltgtbYqHkdHv7cCC1vdoUz6L7ejx zac8q78NQDcyHYBXWCbIYygCT/4phx0MlIukDlXsn8hXZNAAW0/iqux7QWeE1LKB1RiO NhDWpNjNkRyVKlAnt6wIhA7bbPs0ZkRFNmnk9X4SBfWcFUGV5wg2RrhTpulIU56MnOuf H7cuDxBNEs9W/cnKhE0tLzivSNJA3XXThEyaAI3g921MdLaW4OFiOlUj4dBHAYJq87Ul uvgQ== X-Gm-Message-State: AODbwcCjA+yK9pm9sIOp3osEMQ2k4BxUYtIXGV1d3nAIBynjC+3w4KSs KQBn+G3AMD5p4Q== X-Received: by 10.237.34.154 with SMTP id p26mr1702821qtc.47.1494560180344; Thu, 11 May 2017 20:36:20 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Aurelien Jarno , Richard Henderson , David Gibson , Alexander Graf , qemu-ppc@nongnu.org Date: Fri, 12 May 2017 00:35:42 -0300 Message-Id: <20170512033543.6789-5-f4bug@amsat.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170512033543.6789-1-f4bug@amsat.org> References: <20170512033543.6789-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::243 Subject: [Qemu-devel] [PATCH v3 4/5] target/ppc: using various functions using extract op X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Patch created mechanically using Coccinelle script via: $ spatch --macro-file scripts/cocci-macro-file.h --in-place \ --sp-file scripts/coccinelle/tcg_gen_extract.cocci --dir target Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- David I did not add your Reviewed-by as suggested by Laurent Vivier after Nikunj A Dadhania review. target/ppc/translate.c | 9 +++------ target/ppc/translate/vsx-impl.inc.c | 15 +++++---------- 2 files changed, 8 insertions(+), 16 deletions(-) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index f40b5a1abf..64ab412bf3 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -868,8 +868,7 @@ static inline void gen_op_arith_add(DisasContext *ctx, = TCGv ret, TCGv arg1, } tcg_gen_xor_tl(cpu_ca, t0, t1); /* bits changed w/ carr= y */ tcg_temp_free(t1); - tcg_gen_shri_tl(cpu_ca, cpu_ca, 32); /* extract bit 32 */ - tcg_gen_andi_tl(cpu_ca, cpu_ca, 1); + tcg_gen_extract_tl(cpu_ca, cpu_ca, 32, 1); if (is_isa300(ctx)) { tcg_gen_mov_tl(cpu_ca32, cpu_ca); } @@ -1399,8 +1398,7 @@ static inline void gen_op_arith_subf(DisasContext *ct= x, TCGv ret, TCGv arg1, tcg_temp_free(inv1); tcg_gen_xor_tl(cpu_ca, t0, t1); /* bits changes w/ car= ry */ tcg_temp_free(t1); - tcg_gen_shri_tl(cpu_ca, cpu_ca, 32); /* extract bit 32 */ - tcg_gen_andi_tl(cpu_ca, cpu_ca, 1); + tcg_gen_extract_tl(cpu_ca, cpu_ca, 32, 1); if (is_isa300(ctx)) { tcg_gen_mov_tl(cpu_ca32, cpu_ca); } @@ -5383,8 +5381,7 @@ static void gen_mfsri(DisasContext *ctx) CHK_SV; t0 =3D tcg_temp_new(); gen_addr_reg_index(ctx, t0); - tcg_gen_shri_tl(t0, t0, 28); - tcg_gen_andi_tl(t0, t0, 0xF); + tcg_gen_extract_tl(t0, t0, 28, 0xF); gen_helper_load_sr(cpu_gpr[rd], cpu_env, t0); tcg_temp_free(t0); if (ra !=3D 0 && ra !=3D rd) diff --git a/target/ppc/translate/vsx-impl.inc.c b/target/ppc/translate/vsx= -impl.inc.c index 7f12908029..9faffd2ddc 100644 --- a/target/ppc/translate/vsx-impl.inc.c +++ b/target/ppc/translate/vsx-impl.inc.c @@ -1262,8 +1262,7 @@ static void gen_xsxexpqp(DisasContext *ctx) gen_exception(ctx, POWERPC_EXCP_VSXU); return; } - tcg_gen_shri_i64(xth, xbh, 48); - tcg_gen_andi_i64(xth, xth, 0x7FFF); + tcg_gen_extract_i64(xth, xbh, 48, 0x7FFF); tcg_gen_movi_i64(xtl, 0); } =20 @@ -1448,10 +1447,8 @@ static void gen_xvxexpdp(DisasContext *ctx) gen_exception(ctx, POWERPC_EXCP_VSXU); return; } - tcg_gen_shri_i64(xth, xbh, 52); - tcg_gen_andi_i64(xth, xth, 0x7FF); - tcg_gen_shri_i64(xtl, xbl, 52); - tcg_gen_andi_i64(xtl, xtl, 0x7FF); + tcg_gen_extract_i64(xth, xbh, 52, 0x7FF); + tcg_gen_extract_i64(xtl, xbl, 52, 0x7FF); } =20 GEN_VSX_HELPER_2(xvxsigsp, 0x00, 0x04, 0, PPC2_ISA300) @@ -1474,16 +1471,14 @@ static void gen_xvxsigdp(DisasContext *ctx) zr =3D tcg_const_i64(0); nan =3D tcg_const_i64(2047); =20 - tcg_gen_shri_i64(exp, xbh, 52); - tcg_gen_andi_i64(exp, exp, 0x7FF); + tcg_gen_extract_i64(exp, xbh, 52, 0x7FF); tcg_gen_movi_i64(t0, 0x0010000000000000); tcg_gen_movcond_i64(TCG_COND_EQ, t0, exp, zr, zr, t0); tcg_gen_movcond_i64(TCG_COND_EQ, t0, exp, nan, zr, t0); tcg_gen_andi_i64(xth, xbh, 0x000FFFFFFFFFFFFF); tcg_gen_or_i64(xth, xth, t0); =20 - tcg_gen_shri_i64(exp, xbl, 52); - tcg_gen_andi_i64(exp, exp, 0x7FF); + tcg_gen_extract_i64(exp, xbl, 52, 0x7FF); tcg_gen_movi_i64(t0, 0x0010000000000000); tcg_gen_movcond_i64(TCG_COND_EQ, t0, exp, zr, zr, t0); tcg_gen_movcond_i64(TCG_COND_EQ, t0, exp, nan, zr, t0); --=20 2.11.0 From nobody Fri May 3 00:37:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1494560414825596.7438252914203; Thu, 11 May 2017 20:40:14 -0700 (PDT) Received: from localhost ([::1]:51164 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d91R7-00019x-Ke for importer@patchew.org; Thu, 11 May 2017 23:40:13 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47333) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d91NS-0006gU-58 for qemu-devel@nongnu.org; Thu, 11 May 2017 23:36:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d91NQ-0003hf-5p for qemu-devel@nongnu.org; Thu, 11 May 2017 23:36:26 -0400 Received: from mail-qk0-x243.google.com ([2607:f8b0:400d:c09::243]:33462) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d91NQ-0003hT-1L for qemu-devel@nongnu.org; Thu, 11 May 2017 23:36:24 -0400 Received: by mail-qk0-x243.google.com with SMTP id o85so6330612qkh.0 for ; Thu, 11 May 2017 20:36:23 -0700 (PDT) Received: from localhost.localdomain ([138.117.48.226]) by smtp.gmail.com with ESMTPSA id m188sm1443267qkc.5.2017.05.11.20.36.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 May 2017 20:36:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YccxYdu2W7FWBmuefVB5gxyKeN2EbK6SwfC1dzr+Ur4=; b=cO1EywM5nUUxVjdD59kIU15qZWm0+X7MlRQZ9IAszPxkJqnIxGFGeVFhPsJcr2Ex9o Ed7DpygnBMn13gZMlmI9D/G5oOiTHTV5zeyUJGpGoj6/Nu/BcftL8i2JaQAIGunc0nYZ KkywZgZNqz/cZFMpsZqVjtrIgwu1VIs+kaF0dFzjeWZcK+W8q/350YTi/Gss3xKnwHvS o5QcEKlwO64Oft2lYDMQOvEkq5AkeMqaiX1nLCzyXzlc78cvJ0nwHprhFwqNajvnG3dd UIOrzim/KEv0qI4NilBmTRfib34CI2UF3GNcmIng7qEqhBQV3FOQ0dNCwFukTKl1sJSc RF2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=YccxYdu2W7FWBmuefVB5gxyKeN2EbK6SwfC1dzr+Ur4=; b=BBxkCfMJDdWvekBEWqUTq/h3OUOB3io9h+iPpz13UZiGIYQXzTxi7sDaY9a8UQblyS T/uzbQsiKFemPqIDCdr6U0TDPpm0reUkPxnA3O314EUr94WFHdFiGCy+qJfpkx5B4kv0 ucHnzXLsSeGDBjhgnMmjFID0YDrI6ahRwjcRRRTAZquLAS9O5ZJcfNQT0vBZqyZJzd34 Uq0NctB4RF/fDsxTL9udBG65ifJA30jUwMdQ2VQsMGsms5hOGyuPwV+rdj0gRg5cw4AQ PtxHAdM/fZUDcZ93sY9Bfs6D3Vxogqh54nrPLvfoh2zlfsg3wJsmPo0tigy+6WBZMpCs PZ6w== X-Gm-Message-State: AODbwcCUzQGjt/DhMduMgtvVSsuvmbO5NYvSVxsz/qHpTznGLkvsWjzz Hc9FlGt3FhwHgw== X-Received: by 10.233.220.71 with SMTP id q68mr1571153qkf.199.1494560183576; Thu, 11 May 2017 20:36:23 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Aurelien Jarno , Richard Henderson , Mark Cave-Ayland , Artyom Tarasenko Date: Fri, 12 May 2017 00:35:43 -0300 Message-Id: <20170512033543.6789-6-f4bug@amsat.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170512033543.6789-1-f4bug@amsat.org> References: <20170512033543.6789-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::243 Subject: [Qemu-devel] [PATCH v3 5/5] target/sparc: optimize various functions using extract op X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Patch created mechanically using Coccinelle script via: $ spatch --macro-file scripts/cocci-macro-file.h --in-place \ --sp-file scripts/coccinelle/tcg_gen_extract.cocci --dir target Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/sparc/translate.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/target/sparc/translate.c b/target/sparc/translate.c index aa6734d54e..a92b5c425c 100644 --- a/target/sparc/translate.c +++ b/target/sparc/translate.c @@ -380,29 +380,25 @@ static inline void gen_goto_tb(DisasContext *s, int t= b_num, static inline void gen_mov_reg_N(TCGv reg, TCGv_i32 src) { tcg_gen_extu_i32_tl(reg, src); - tcg_gen_shri_tl(reg, reg, PSR_NEG_SHIFT); - tcg_gen_andi_tl(reg, reg, 0x1); + tcg_gen_extract_tl(reg, reg, PSR_NEG_SHIFT, 0x1); } =20 static inline void gen_mov_reg_Z(TCGv reg, TCGv_i32 src) { tcg_gen_extu_i32_tl(reg, src); - tcg_gen_shri_tl(reg, reg, PSR_ZERO_SHIFT); - tcg_gen_andi_tl(reg, reg, 0x1); + tcg_gen_extract_tl(reg, reg, PSR_ZERO_SHIFT, 0x1); } =20 static inline void gen_mov_reg_V(TCGv reg, TCGv_i32 src) { tcg_gen_extu_i32_tl(reg, src); - tcg_gen_shri_tl(reg, reg, PSR_OVF_SHIFT); - tcg_gen_andi_tl(reg, reg, 0x1); + tcg_gen_extract_tl(reg, reg, PSR_OVF_SHIFT, 0x1); } =20 static inline void gen_mov_reg_C(TCGv reg, TCGv_i32 src) { tcg_gen_extu_i32_tl(reg, src); - tcg_gen_shri_tl(reg, reg, PSR_CARRY_SHIFT); - tcg_gen_andi_tl(reg, reg, 0x1); + tcg_gen_extract_tl(reg, reg, PSR_CARRY_SHIFT, 0x1); } =20 static inline void gen_op_add_cc(TCGv dst, TCGv src1, TCGv src2) @@ -638,8 +634,7 @@ static inline void gen_op_mulscc(TCGv dst, TCGv src1, T= CGv src2) // env->y =3D (b2 << 31) | (env->y >> 1); tcg_gen_andi_tl(r_temp, cpu_cc_src, 0x1); tcg_gen_shli_tl(r_temp, r_temp, 31); - tcg_gen_shri_tl(t0, cpu_y, 1); - tcg_gen_andi_tl(t0, t0, 0x7fffffff); + tcg_gen_extract_tl(t0, cpu_y, 1, 0x7fffffff); tcg_gen_or_tl(t0, t0, r_temp); tcg_gen_andi_tl(cpu_y, t0, 0xffffffff); =20 --=20 2.11.0