On 2017/5/12 0:32, Juan Quintela wrote:
> Hi
>
> Changes from v1:
>
> - make migrate_block_set_* take a boolean
> - disable block migration in colo to maintain semantics.
>
> Please review, Juan.
>
> [v1]
> Upon a time there were MigrationParms (only used for block migration)
> and then MigrationParams used for everything else. This series:
>
> - create migration capabilities for block parameters
> - make the migrate command line parameters to use capabilities
> - remove MigrationParams completely
>
> Please, review.
>
Looks good to me, this makes codes more grace.
Reviewed-by:zhanghailiang <zhang.zhanghailiang@huawei.com>
> *** BLURB HERE ***
>
> Juan Quintela (3):
> migration: Create block capabilities for shared and enable
> migration: Remove use of old MigrationParams
> migration: Remove old MigrationParams
>
> include/migration/block.h | 3 +++
> include/migration/migration.h | 14 +++++-------
> include/migration/vmstate.h | 1 -
> include/qemu/typedefs.h | 1 -
> include/sysemu/sysemu.h | 3 +--
> migration/block.c | 17 ++------------
> migration/colo.c | 7 +++---
> migration/migration.c | 52 ++++++++++++++++++++++++++++++++++++-------
> migration/savevm.c | 18 +++------------
> qapi-schema.json | 7 +++++-
> 10 files changed, 68 insertions(+), 55 deletions(-)
>