From nobody Sun May 5 23:34:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1494446874885563.1049583039927; Wed, 10 May 2017 13:07:54 -0700 (PDT) Received: from localhost ([::1]:44586 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8Xtn-00010g-4s for importer@patchew.org; Wed, 10 May 2017 16:07:51 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32979) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8Xs5-00086o-ME for qemu-devel@nongnu.org; Wed, 10 May 2017 16:06:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8Xs4-0006OW-IC for qemu-devel@nongnu.org; Wed, 10 May 2017 16:06:05 -0400 Received: from mail-qt0-x243.google.com ([2607:f8b0:400d:c0d::243]:33264) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d8Xs3-0006OP-TT for qemu-devel@nongnu.org; Wed, 10 May 2017 16:06:04 -0400 Received: by mail-qt0-x243.google.com with SMTP id a46so278095qte.0 for ; Wed, 10 May 2017 13:06:03 -0700 (PDT) Received: from localhost.localdomain ([138.117.48.226]) by smtp.gmail.com with ESMTPSA id s190sm377398qkh.57.2017.05.10.13.06.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 May 2017 13:06:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iFAmC2RGnKKNew1dXsXJU6GcVS13gfJ/TMlDfV9zxOY=; b=lHrXJwV3/4E6qSFgjSYw8zuAgK8YFBVSz1ZPt5u2fVTDQyfRDvxoKyXmFt5jWqv5wR f4fRNlcta79hatwVKa9lTz8B5UBEgsahLXq0wJo92FPXUyaZfTTLdl7cu3o9H9rPtYMr hs5u6E2f4zXrC1g0XbJF23aY0QaNkeozLUjcp4eDDJaq+zAFpsXT+F/QRK1z7KbfyZny Yvo7So/tqqL7Apl/2UxnNDCgt0lJpUringhgPElIVSc7O9Lk/KbJVrpyJJ8GvIDdBGlY W4+tD1fcHbaotdHQyhGSYsTG0XtpApjUcHoTY1gpHlYCXK0mtaZEVG0jsF3AD+Jj0VdP UYEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=iFAmC2RGnKKNew1dXsXJU6GcVS13gfJ/TMlDfV9zxOY=; b=K+x8eCd2+gZaE9M8xlygNu7DWDTn3uiXVlqCOCaLBDm133BOKhpeY25iWZ9lihuRko lPVDBErzWw9SUARtsSCXv0S5iSSGoYlQR9a6HWUCKycWuvS708u1OUiZ09zt5Gt1IT1U 3m6iVNxSvPDoL+hSaWvVjf+6BmADFOisWitiL4v9M4pX1jfgZB8fm5dDpTM1kGZJBie3 6KXMTBaL9Z2352lLqvIRUnlv+RbiRp/7zg+3UHl34Txwgu4A2T8KKk0G894jw/Ak2+pB /Ingm2MkM73SWtQ7YENn+xyzmO5DjEoVQouLY2+aWeuxK3zrdfT4kWXXhVCShLuUvoMc eOLg== X-Gm-Message-State: AODbwcCDt2sTT0drQyTDKB+Wx++N4gHkVpa+XmZZJetSGG7sjJZhWVpQ ajO+bMKHrISh0w== X-Received: by 10.237.60.23 with SMTP id t23mr312547qte.206.1494446763384; Wed, 10 May 2017 13:06:03 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Aurelien Jarno , Richard Henderson , Nikunj A Dadhania , Eric Blake , Markus Armbruster , Laurent Vivier , Michael Tokarev , Eduardo Habkost , Paolo Bonzini Date: Wed, 10 May 2017 17:05:28 -0300 Message-Id: <20170510200535.13268-2-f4bug@amsat.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170510200535.13268-1-f4bug@amsat.org> References: <20170510200535.13268-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::243 Subject: [Qemu-devel] [PATCH 1/8] coccinelle: add a script to optimize tcg op using tcg_gen_extract() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- scripts/coccinelle/tcg_gen_extract.cocci | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) create mode 100644 scripts/coccinelle/tcg_gen_extract.cocci diff --git a/scripts/coccinelle/tcg_gen_extract.cocci b/scripts/coccinelle/= tcg_gen_extract.cocci new file mode 100644 index 0000000000..4080f97cc7 --- /dev/null +++ b/scripts/coccinelle/tcg_gen_extract.cocci @@ -0,0 +1,26 @@ +// optimize TCG using extract op +// +// Copyright: (C) 2017 Philippe Mathieu-Daud=C3=A9. GPLv2. +// Confidence: High +// Options: --macro-file scripts/cocci-macro-file.h +@@ +identifier ret, arg; +constant ofs, len; +@@ +( +// from Nikunj A Dadhania comment: +// http://lists.nongnu.org/archive/html/qemu-devel/2017-02/msg05211.html +-tcg_gen_shri_tl(ret, arg, ofs); +-tcg_gen_andi_tl(ret, ret, len); ++tcg_gen_extract_tl(ret, arg, ofs, len); +| +// from Aurelien Jarno comment: +// http://lists.nongnu.org/archive/html/qemu-devel/2017-05/msg01466.html +-tcg_gen_shri_i32(ret, arg, ofs); +-tcg_gen_andi_i32(ret, ret, len); ++tcg_gen_extract_i32(ret, arg, ofs, len); +| +-tcg_gen_shri_i64(ret, arg, ofs); +-tcg_gen_andi_i64(ret, ret, len); ++tcg_gen_extract_i64(ret, arg, ofs, len); +) --=20 2.11.0 From nobody Sun May 5 23:34:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 149444700665027.915530617857712; Wed, 10 May 2017 13:10:06 -0700 (PDT) Received: from localhost ([::1]:44597 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8Xvw-0002tU-96 for importer@patchew.org; Wed, 10 May 2017 16:10:04 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33032) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8XsC-0008Av-QR for qemu-devel@nongnu.org; Wed, 10 May 2017 16:06:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8Xs9-0006Po-AR for qemu-devel@nongnu.org; Wed, 10 May 2017 16:06:12 -0400 Received: from mail-qk0-x243.google.com ([2607:f8b0:400d:c09::243]:34983) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d8Xs9-0006PW-4r; Wed, 10 May 2017 16:06:09 -0400 Received: by mail-qk0-x243.google.com with SMTP id k74so950453qke.2; Wed, 10 May 2017 13:06:09 -0700 (PDT) Received: from localhost.localdomain ([138.117.48.226]) by smtp.gmail.com with ESMTPSA id s190sm377398qkh.57.2017.05.10.13.06.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 May 2017 13:06:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vIpk8wTZc1TnEmv0ib9+0baze68y08wSH3kzhbSNOFs=; b=nWvCPiI0k/LYyKeNlbgN8t9aLVWXkrvFuuBZ6JDqlZ3D5qMExoQnCyFpA05pyAc4Zm 3GZUDtq86zgjYEQB1U2swibi1BP6Mf/bu8NwVjBge64MsOz0kls1psoZs4vBWiC4dFih EklBPwp4BF6hgzLejHg01T5RjZg75xWnONeGAPW9Jpmri/BKaoLlzVYrPpwz5fMJj9Ku ixUt8NL3oDJoZPrJ46IIorpOdCgaVSEbQneHKh/1Y/jle+mdJvwL51YGr3qpK8njluq/ Q3ge302v5IPWy4LpHwQ73bui5+0b84qkw+q5VetiWEh/kHmys8KZw3ENkP6wDHMUDWY2 mOfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=vIpk8wTZc1TnEmv0ib9+0baze68y08wSH3kzhbSNOFs=; b=kmbuumYWPkDljx9eXtIldqzBsMkIf4WpPC8/ndTavKCp+qVk2g0QIN/0POAqFn9tjv aHevjLOmZ3oZigUgcdRxtirEpAE14A3avbfNNmu8BXSozq9uowUg8wUtvXT2vFAU522N 9b3d26ntY3vxGBNRB9mQG2RR02hk8v8k5BGLQuioB4zDhAuOFW2obCo3Qw37K7YoiLui RD7weYalft5356JInNJob/FC4be2RkHgmEBfZzsOjoT+fasrQa0kRe1TsnW4XBpF1h/x GDlQyTJ1+rtjKYGwFKoVGmV28TfFgocVhzuyOTThG8A1jvPSX6ibWJSsTaEBKxPfXIJ3 +PYQ== X-Gm-Message-State: AODbwcAYBKp5wA3enzGH/QaT3NhNDGM+iJTiXbiq5vMwIywd7o4doejz VlZSNPZZ7ajsRw== X-Received: by 10.55.40.158 with SMTP id o30mr7619764qko.210.1494446768564; Wed, 10 May 2017 13:06:08 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Peter Maydell , Aurelien Jarno , Richard Henderson , qemu-arm@nongnu.org Date: Wed, 10 May 2017 17:05:29 -0300 Message-Id: <20170510200535.13268-3-f4bug@amsat.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170510200535.13268-1-f4bug@amsat.org> References: <20170510200535.13268-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::243 Subject: [Qemu-devel] [PATCH 2/8] target/arm: optimize smul_dual() and neon_trn_u8() using extract op X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Applied using Coccinelle script. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/arm/translate.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 0b5a0bca06..3230efe1be 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -339,8 +339,7 @@ static void gen_smul_dual(TCGv_i32 a, TCGv_i32 b) static void gen_rev16(TCGv_i32 var) { TCGv_i32 tmp =3D tcg_temp_new_i32(); - tcg_gen_shri_i32(tmp, var, 8); - tcg_gen_andi_i32(tmp, tmp, 0x00ff00ff); + tcg_gen_extract_i32(tmp, var, 8, 0x00ff00ff); tcg_gen_shli_i32(var, var, 8); tcg_gen_andi_i32(var, var, 0xff00ff00); tcg_gen_or_i32(var, var, tmp); @@ -4700,8 +4699,7 @@ static void gen_neon_trn_u8(TCGv_i32 t0, TCGv_i32 t1) tcg_gen_andi_i32(tmp, t1, 0x00ff00ff); tcg_gen_or_i32(rd, rd, tmp); =20 - tcg_gen_shri_i32(t1, t1, 8); - tcg_gen_andi_i32(t1, t1, 0x00ff00ff); + tcg_gen_extract_i32(t1, t1, 8, 0x00ff00ff); tcg_gen_andi_i32(tmp, t0, 0xff00ff00); tcg_gen_or_i32(t1, t1, tmp); tcg_gen_mov_i32(t0, rd); --=20 2.11.0 From nobody Sun May 5 23:34:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1494446886507430.07259835050627; Wed, 10 May 2017 13:08:06 -0700 (PDT) Received: from localhost ([::1]:44587 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8Xu0-0001Bb-4Q for importer@patchew.org; Wed, 10 May 2017 16:08:04 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33033) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8XsC-0008Aw-Qc for qemu-devel@nongnu.org; Wed, 10 May 2017 16:06:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8XsB-0006Sh-Mw for qemu-devel@nongnu.org; Wed, 10 May 2017 16:06:12 -0400 Received: from mail-qt0-x243.google.com ([2607:f8b0:400d:c0d::243]:36784) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d8XsB-0006SN-Gi; Wed, 10 May 2017 16:06:11 -0400 Received: by mail-qt0-x243.google.com with SMTP id j13so264863qta.3; Wed, 10 May 2017 13:06:11 -0700 (PDT) Received: from localhost.localdomain ([138.117.48.226]) by smtp.gmail.com with ESMTPSA id s190sm377398qkh.57.2017.05.10.13.06.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 May 2017 13:06:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CUtuhwotTcUgfxDileQ4JAC48wEk/mlZ5pDz05j4+8k=; b=pGATNv47uqxnzp531GYbfYMMr8ohYIc7++5BNz4OSZwvMcunbqxFvsnashbgGEpivw vuayFUbmftwhTOEA6X+/snQMkdjvJcpljWUYbk+bqBl6/cqPiEpfGxmnXZPt1s9s6YRk LDXfL4cSqkKoMqADSE6aj+PmcI2GzvbA8u3i4YU3SZxS7Z2ALSup9L04pgc8U6iMAXNO 44wNwy7XZlSoay4pKPpPyjAtSkl53HKj4ZFV9LyERz3CAkEyRdFNZVi9ckR3O2Xa4FOR nOdh4WskYzBQYG00Zmnas+0xfQTWwEIaUiihF973dDYdwyFXSSsIddQXm5phbXxwx+Wj amLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=CUtuhwotTcUgfxDileQ4JAC48wEk/mlZ5pDz05j4+8k=; b=kfIk+uz3/x7mXDVxv876qUgbtyb6lw5bcEb3Iav5zf3gfwvzZa4ddzMvZKySMKcd2P q7ykKkoHrk7bm0BNtQmxT9eDSOAnzCS/PHdhRreqx53qS7pJ9USa0CImdtbzc8LknlKY IGWpWpvMAyx0qaGMaaFCPAkzIHH9XibdA7EpTs9bP2m3Md9ffEKVWdW56kq9VIPSKGIf 0CoX9Y2AQMj0oeB50NgGcF4PRthwVEOBpV8DFF2YM8WQ8PKxbrKW4V3TZXjhRhaPlvTu RaXdXEr1M381iDMzCtrQQpSwcp/ipf88Ug7tytq+KN/7Z+NcSooOvNIKr+cAveGj+Gcq GYtw== X-Gm-Message-State: AODbwcDEIa6KZrAKiF0pYOYDrZICsFuQqRq40e+OvzA/e7JZx9JrwnTj LiaZUTtMBIuw8Q== X-Received: by 10.200.43.217 with SMTP id n25mr307105qtn.190.1494446771064; Wed, 10 May 2017 13:06:11 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Peter Maydell , Aurelien Jarno , Richard Henderson , qemu-arm@nongnu.org Date: Wed, 10 May 2017 17:05:30 -0300 Message-Id: <20170510200535.13268-4-f4bug@amsat.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170510200535.13268-1-f4bug@amsat.org> References: <20170510200535.13268-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::243 Subject: [Qemu-devel] [PATCH 3/8] target/arm: optimize rev16() using extract op X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Applied using Coccinelle script. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/arm/translate-a64.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 24de30d92c..7ea130107e 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -4038,14 +4038,12 @@ static void handle_rev16(DisasContext *s, unsigned = int sf, tcg_gen_andi_i64(tcg_tmp, tcg_rn, 0xffff); tcg_gen_bswap16_i64(tcg_rd, tcg_tmp); =20 - tcg_gen_shri_i64(tcg_tmp, tcg_rn, 16); - tcg_gen_andi_i64(tcg_tmp, tcg_tmp, 0xffff); + tcg_gen_extract_i64(tcg_tmp, tcg_rn, 16, 0xffff); tcg_gen_bswap16_i64(tcg_tmp, tcg_tmp); tcg_gen_deposit_i64(tcg_rd, tcg_rd, tcg_tmp, 16, 16); =20 if (sf) { - tcg_gen_shri_i64(tcg_tmp, tcg_rn, 32); - tcg_gen_andi_i64(tcg_tmp, tcg_tmp, 0xffff); + tcg_gen_extract_i64(tcg_tmp, tcg_rn, 32, 0xffff); tcg_gen_bswap16_i64(tcg_tmp, tcg_tmp); tcg_gen_deposit_i64(tcg_rd, tcg_rd, tcg_tmp, 32, 16); =20 --=20 2.11.0 From nobody Sun May 5 23:34:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1494447013981693.6229021980533; Wed, 10 May 2017 13:10:13 -0700 (PDT) Received: from localhost ([::1]:44598 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8Xw4-00032K-Nm for importer@patchew.org; Wed, 10 May 2017 16:10:12 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33073) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8XsE-0008CL-QB for qemu-devel@nongnu.org; Wed, 10 May 2017 16:06:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8XsD-0006U3-Va for qemu-devel@nongnu.org; Wed, 10 May 2017 16:06:14 -0400 Received: from mail-qt0-x242.google.com ([2607:f8b0:400d:c0d::242]:36786) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d8XsD-0006TT-RW for qemu-devel@nongnu.org; Wed, 10 May 2017 16:06:13 -0400 Received: by mail-qt0-x242.google.com with SMTP id j13so264999qta.3 for ; Wed, 10 May 2017 13:06:13 -0700 (PDT) Received: from localhost.localdomain ([138.117.48.226]) by smtp.gmail.com with ESMTPSA id s190sm377398qkh.57.2017.05.10.13.06.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 May 2017 13:06:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZhlKdEbzYhAiZi2kqPup6McMWtCXkC1Um+s1U9rQ8vA=; b=jl/5w2wqQUBYmwda6wf3i9QpffFgq9DVR9f3ltyiHBK07b5fIE3kAtJh0zkJNLWoqC PpXbMMngj7+shKNhr+M0Jnlp1ZVuODv0U7GpUsBBmt7YYv2MxwSMy4wQjTenqkMZBH4S ANJbX7kL8ywsAAg9dSwBazOT/O23N/QQVH7Jtxin7/9uEDkDYKXSaje3pXb1yIdnSIMb 6zPTJsHcTAHv9pJvDxN+yIH2emG2M/aTqh4vgjkJx93yvOGuf/vd3VL+cqRxrTg9wM22 nDY+4EYeCb3KLAJL2dxLYTNPUovreZm8+Tm9XedKEm64bKDfB4dqASSt+Phb98aomBtw kr6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=ZhlKdEbzYhAiZi2kqPup6McMWtCXkC1Um+s1U9rQ8vA=; b=oyhMvc3Z+pns5zTogBGczuLbrejRrvJxfRStRIIXf1U25iL9LQhq4ve7fOfUBUYpC9 M908dUdvaCMu5mbmEOjlKyN7Hj1dHP62x9EnldlJbh0sQdHjtYytGVAzus293RwjKF+4 WsZWxNAvgozhBW4P6OUqvcvToa/1HCVHiZ/OVnG38N5sBjpOBKVkK1ah9/AaptWlf5ok UZSgshNMbRGCFyPcVcUlWkfi3GOSEeRA9Fb4d01Npla51gXP/OnNIDgVXiBTAhTiKIzn Go3+LH53aaNo2t7sl+H9xHI1d78MhTGBO7WrX0GR8htOiHvOhNYBkg0nYjP0R2A7dIhR pKag== X-Gm-Message-State: AODbwcDSobUr7j/Xn08nDPKJSG0vrdXbwawl9BWGRW/FRQ5S9FJhWakS Oa7zA+Dwxwma4Q== X-Received: by 10.237.34.58 with SMTP id n55mr285905qtc.117.1494446773375; Wed, 10 May 2017 13:06:13 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Aurelien Jarno , Richard Henderson , "Edgar E. Iglesias" Date: Wed, 10 May 2017 17:05:31 -0300 Message-Id: <20170510200535.13268-5-f4bug@amsat.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170510200535.13268-1-f4bug@amsat.org> References: <20170510200535.13268-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::242 Subject: [Qemu-devel] [PATCH 4/8] target/cris: optimize gen_swapb() using extract op X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Applied using Coccinelle script. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/cris/translate.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/cris/translate.c b/target/cris/translate.c index 0ee05ca02d..c03403ac62 100644 --- a/target/cris/translate.c +++ b/target/cris/translate.c @@ -442,8 +442,7 @@ static inline void t_gen_swapb(TCGv d, TCGv s) tcg_gen_mov_tl(org_s, s); tcg_gen_shli_tl(t, org_s, 8); tcg_gen_andi_tl(d, t, 0xff00ff00); - tcg_gen_shri_tl(t, org_s, 8); - tcg_gen_andi_tl(t, t, 0x00ff00ff); + tcg_gen_extract_tl(t, org_s, 8, 0x00ff00ff); tcg_gen_or_tl(d, d, t); tcg_temp_free(t); tcg_temp_free(org_s); --=20 2.11.0 From nobody Sun May 5 23:34:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1494447108498999.8141853741206; Wed, 10 May 2017 13:11:48 -0700 (PDT) Received: from localhost ([::1]:44609 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8Xxb-0004Al-7j for importer@patchew.org; Wed, 10 May 2017 16:11:47 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33101) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8XsG-0008Eb-W2 for qemu-devel@nongnu.org; Wed, 10 May 2017 16:06:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8XsG-0006Uq-B2 for qemu-devel@nongnu.org; Wed, 10 May 2017 16:06:17 -0400 Received: from mail-qt0-x243.google.com ([2607:f8b0:400d:c0d::243]:36792) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d8XsG-0006Ue-6p for qemu-devel@nongnu.org; Wed, 10 May 2017 16:06:16 -0400 Received: by mail-qt0-x243.google.com with SMTP id j13so265238qta.3 for ; Wed, 10 May 2017 13:06:16 -0700 (PDT) Received: from localhost.localdomain ([138.117.48.226]) by smtp.gmail.com with ESMTPSA id s190sm377398qkh.57.2017.05.10.13.06.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 May 2017 13:06:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tJ/A4M+g3dfQb2/rhY5gbdFk8TGWjwEnjYrWQT3gzc4=; b=eWVJs8p67hLvVvsSfYXObJHUvukJXg3RyOen7FoI9n5bF8W6WDBXHvd9yVZMudJdRT +e89kcygIfZFVv8yWlA9VgdedvFdILwPyog8o+BZ2aHR4r9FCTpZtk+G9q3jYaEJ2bHU L/042KIe8Z0HHWA+180xUTIldxMmcUokI3/MHINcbdD5uKpJ7nzdtgtg9Bo8YyTZuEsV chiA2E5f3F7KOi/skwP+CgiuUZQz/AAZNLt/kIs73b1kAxxTLoeTzeWjo4EP4mZbl1Ar rxBuPGv5rdFvFPjvt8oCxvCqjdV9asUdbmRnxUwclpTZpLuhQkN9QY8xhXRl+fx4lN1G /CSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=tJ/A4M+g3dfQb2/rhY5gbdFk8TGWjwEnjYrWQT3gzc4=; b=D3sVQTmemO1G9NLmSn/itu9BQ9q41oZRN85SLu8CxLGrFZ6Xi2nECfmx8LkWKyMLeU VU1wEnHucTyChvEYakROOW2EAvJKLftZ/xCMG5cFCjTiwgDihzd6FJQXw75/rPWS6Lzb oFtMhfPfqv5FS6MdACQT6ULsqRF4ECRlFXYKNaxfc5OWQeqkCFsDpxq3c66cQ+dtkWqP hYOMs3PeKxAiyWt/DzUMEhYaDn8PI9DWpLPOlufCOxkw+USNnXpdEOciaLVeIwrmC5Aj iUcZOxIEH1g+JlYg7vLnf1OkdPBsGyTNo2vEHTbv/fgs1IOKmWZdjSgeKqQHLcNr+97B XL2A== X-Gm-Message-State: AODbwcBEZ8HL61VX7WS1UNp0XfvZmbsz6ZWQeI/zzpXz66dkVnSKBQFZ ZeTZZ8SLC3B6HBChbWSr1g== X-Received: by 10.200.56.56 with SMTP id q53mr318935qtb.36.1494446775549; Wed, 10 May 2017 13:06:15 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Aurelien Jarno , Richard Henderson , Laurent Vivier Date: Wed, 10 May 2017 17:05:32 -0300 Message-Id: <20170510200535.13268-6-f4bug@amsat.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170510200535.13268-1-f4bug@amsat.org> References: <20170510200535.13268-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::243 Subject: [Qemu-devel] [PATCH 5/8] target/m68k: optimize bcd_flags() using extract op X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Applied using Coccinelle script. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Laurent Vivier --- target/m68k/translate.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index 9f60fbc0db..babb9e2c5b 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translate.c @@ -1463,8 +1463,7 @@ static void bcd_flags(TCGv val) tcg_gen_andi_i32(QREG_CC_C, val, 0x0ff); tcg_gen_or_i32(QREG_CC_Z, QREG_CC_Z, QREG_CC_C); =20 - tcg_gen_shri_i32(QREG_CC_C, val, 8); - tcg_gen_andi_i32(QREG_CC_C, QREG_CC_C, 1); + tcg_gen_extract_i32(QREG_CC_C, val, 8, 1); =20 tcg_gen_mov_i32(QREG_CC_X, QREG_CC_C); } --=20 2.11.0 From nobody Sun May 5 23:34:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1494447108207854.2051064071301; Wed, 10 May 2017 13:11:48 -0700 (PDT) Received: from localhost ([::1]:44608 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8Xxa-0004AX-O6 for importer@patchew.org; Wed, 10 May 2017 16:11:46 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33124) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8XsL-0008Ic-FD for qemu-devel@nongnu.org; Wed, 10 May 2017 16:06:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8XsI-0006W2-8M for qemu-devel@nongnu.org; Wed, 10 May 2017 16:06:21 -0400 Received: from mail-qt0-x244.google.com ([2607:f8b0:400d:c0d::244]:35794) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d8XsI-0006Vr-4H for qemu-devel@nongnu.org; Wed, 10 May 2017 16:06:18 -0400 Received: by mail-qt0-x244.google.com with SMTP id r58so271160qtb.2 for ; Wed, 10 May 2017 13:06:18 -0700 (PDT) Received: from localhost.localdomain ([138.117.48.226]) by smtp.gmail.com with ESMTPSA id s190sm377398qkh.57.2017.05.10.13.06.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 May 2017 13:06:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4cetlFfxvnoF3a93mvYF4nJD6Cnt6x6Jtg4fH3YplO4=; b=BENAgRYfThqX6NLxB7JcFf2M+ndkrJxGRlTsVwQ2AiwcOboR0EjB8cudSD23GfbzQp b3Yic+KzKqRtPD/0UhhcVGKktk23/lChiGdaFeLBSq2et2Wx9QNbF6cICQjAkwDN70wD 5Nuk9i8qcekUq4H0wo4ZAp9lSKcEM+gXAOH8NNiif02sAbiJP600/u1sec9NCSQhJ2g2 vDoa1PANv6AYkI0LIsiA7hTAPT45Tb6PVr5EvcsDPvogh7Yd2ZT3O2LoUv9E1O+td2Mp XeAOP+Wguw15WLDi7KOVITsIBQ7nG/uwc0R/hFnPhuLXPvf5EMKwWgu87NP2ryfYWx/a SAGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=4cetlFfxvnoF3a93mvYF4nJD6Cnt6x6Jtg4fH3YplO4=; b=flVqLYAhXniJGJoderj29eX/gMN5EMzInIhwivJz2qI17CRowwI3f2AJH+4YhVDMhH zFR1FM8BUNRWk3IXgECQy54QlBf3n4fA6XyGc7+q5C+mqj+vthy136Blott4l27cUEcC kYq6zysqb+POJRi+hb4NllsRfDrOVfy2x0kq+IkWHOGIEYqgkRsNSHjaZ1tS16hszolj BN3hgazonG3d2GTB5rcSK38zaBHD9PrsqKWNhdNsmYblO7lVNdcyQyvs12Zd8dajTlMN p8K71MTAoSAAuJvMI2XVgGNm3fcw11BuDdzpOc3Mnty/WGDGW+7cZXqP5ZIGy8uCvxRS q/Dw== X-Gm-Message-State: AODbwcDe4wJUyCgLCep2Hrr7Q2t3SUTuvRtMVDVwH9vHOBLp64gg8IDA LQMH+hHkPvndIA== X-Received: by 10.200.57.37 with SMTP id s34mr274257qtb.141.1494446777575; Wed, 10 May 2017 13:06:17 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Aurelien Jarno , Richard Henderson , Yongbok Kim Date: Wed, 10 May 2017 17:05:33 -0300 Message-Id: <20170510200535.13268-7-f4bug@amsat.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170510200535.13268-1-f4bug@amsat.org> References: <20170510200535.13268-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::244 Subject: [Qemu-devel] [PATCH 6/8] target/mips: optimize bshfl() using extract op X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Applied using Coccinelle script. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/mips/translate.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index 3022f349cb..96177da9ae 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -4573,8 +4573,7 @@ static void gen_bshfl (DisasContext *ctx, uint32_t op= 2, int rt, int rd) { TCGv t1 =3D tcg_temp_new(); =20 - tcg_gen_shri_tl(t1, t0, 8); - tcg_gen_andi_tl(t1, t1, 0x00FF00FF); + tcg_gen_extract_tl(t1, t0, 8, 0x00FF00FF); tcg_gen_shli_tl(t0, t0, 8); tcg_gen_andi_tl(t0, t0, ~0x00FF00FF); tcg_gen_or_tl(t0, t0, t1); @@ -4593,8 +4592,7 @@ static void gen_bshfl (DisasContext *ctx, uint32_t op= 2, int rt, int rd) { TCGv t1 =3D tcg_temp_new(); =20 - tcg_gen_shri_tl(t1, t0, 8); - tcg_gen_andi_tl(t1, t1, 0x00FF00FF00FF00FFULL); + tcg_gen_extract_tl(t1, t0, 8, 0x00FF00FF00FF00FFULL); tcg_gen_shli_tl(t0, t0, 8); tcg_gen_andi_tl(t0, t0, ~0x00FF00FF00FF00FFULL); tcg_gen_or_tl(cpu_gpr[rd], t0, t1); @@ -4605,8 +4603,7 @@ static void gen_bshfl (DisasContext *ctx, uint32_t op= 2, int rt, int rd) { TCGv t1 =3D tcg_temp_new(); =20 - tcg_gen_shri_tl(t1, t0, 16); - tcg_gen_andi_tl(t1, t1, 0x0000FFFF0000FFFFULL); + tcg_gen_extract_tl(t1, t0, 16, 0x0000FFFF0000FFFFULL); tcg_gen_shli_tl(t0, t0, 16); tcg_gen_andi_tl(t0, t0, ~0x0000FFFF0000FFFFULL); tcg_gen_or_tl(t0, t0, t1); --=20 2.11.0 From nobody Sun May 5 23:34:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1494446896283923.3407153729029; Wed, 10 May 2017 13:08:16 -0700 (PDT) Received: from localhost ([::1]:44588 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8Xu9-0001Kg-LA for importer@patchew.org; Wed, 10 May 2017 16:08:13 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33142) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8XsM-0008Iw-58 for qemu-devel@nongnu.org; Wed, 10 May 2017 16:06:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8XsL-0006XO-5E for qemu-devel@nongnu.org; Wed, 10 May 2017 16:06:22 -0400 Received: from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]:36738) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d8XsL-0006X3-0a; Wed, 10 May 2017 16:06:21 -0400 Received: by mail-qk0-x244.google.com with SMTP id y128so946315qka.3; Wed, 10 May 2017 13:06:20 -0700 (PDT) Received: from localhost.localdomain ([138.117.48.226]) by smtp.gmail.com with ESMTPSA id s190sm377398qkh.57.2017.05.10.13.06.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 May 2017 13:06:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MRGtuARN+YANv2ESqDGJaDWo89L1CTLQkC9GmaN6Jto=; b=CB1nHGB3JDaT0sspgRswtoVKJwAWqYTeiKMr5HOe1exQstPGveeSnmHnk8xnIZZTaq RpR5BYFZMWLFVBjULlGUJ1OmRVPPDbrFaa9KeRaBt0GQDYMlpLs+9kSVKTsIgIgHQ7ev AFm+wgKaztCVbdLosyjk8LSxmQ2Dr/35dLgNA/+RQokFsAzTxw1WMfC8q6iHJPTsFnMl 9AmZ127rkA29SPMkl5+0QrK1P1J6MBoTZt8pDBlHzGPZFXpGA+Fi+5jL2m6gi17k8Pzo zzDsXv9xKJ9Y4r5S0yQw7PutyACyyOdhV+UoUA5sIu+42qndLCFRkFHPrZDhqjywGDsz uhVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=MRGtuARN+YANv2ESqDGJaDWo89L1CTLQkC9GmaN6Jto=; b=lWeYIFdtIP0qdWQd8+WZLRO5XKSfkwBpOTJFl0wmQIyDwH081z3c2H+zzbRJBQLwp3 RJbc3F+Ez6hHUXqKWp4agnq31J5lVP5ZKE+1Dr8hkBMIWnHyqHhSj2UHtdT2mnby1MGp JtqvLi4apMQOasa1c4X+8j/+sNsy8NnKqgAAfBXUardpc3R+zobK0c61sNTHk/ku5su2 R+7NLl4AxaVLLJxwjRaVpkkohrbBQhx62PypQ0WIp+JA4hTUPm21gYSks09hfJUd7C5z 7mWDYw001dSKr3ar659O2LnmY9ScIf1oD/EJLcFwiETGnHZ2Y5yTaPNcKp0FyREKFo9p 7WDA== X-Gm-Message-State: AODbwcBMEk/V4zXbH6Ixo/UrzJ4UqkuVu//ngqralvCaBltd1d72B/yi v3Ym4phWVT5yNw== X-Received: by 10.55.26.215 with SMTP id l84mr7020982qkh.307.1494446780462; Wed, 10 May 2017 13:06:20 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Aurelien Jarno , Richard Henderson , David Gibson , Alexander Graf , qemu-ppc@nongnu.org Date: Wed, 10 May 2017 17:05:34 -0300 Message-Id: <20170510200535.13268-8-f4bug@amsat.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170510200535.13268-1-f4bug@amsat.org> References: <20170510200535.13268-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::244 Subject: [Qemu-devel] [PATCH 7/8] target/ppc: optimize various functions using extract op X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Applied using Coccinelle script. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: David Gibson --- target/ppc/translate.c | 9 +++------ target/ppc/translate/vsx-impl.inc.c | 21 +++++++-------------- 2 files changed, 10 insertions(+), 20 deletions(-) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index f40b5a1abf..64ab412bf3 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -868,8 +868,7 @@ static inline void gen_op_arith_add(DisasContext *ctx, = TCGv ret, TCGv arg1, } tcg_gen_xor_tl(cpu_ca, t0, t1); /* bits changed w/ carr= y */ tcg_temp_free(t1); - tcg_gen_shri_tl(cpu_ca, cpu_ca, 32); /* extract bit 32 */ - tcg_gen_andi_tl(cpu_ca, cpu_ca, 1); + tcg_gen_extract_tl(cpu_ca, cpu_ca, 32, 1); if (is_isa300(ctx)) { tcg_gen_mov_tl(cpu_ca32, cpu_ca); } @@ -1399,8 +1398,7 @@ static inline void gen_op_arith_subf(DisasContext *ct= x, TCGv ret, TCGv arg1, tcg_temp_free(inv1); tcg_gen_xor_tl(cpu_ca, t0, t1); /* bits changes w/ car= ry */ tcg_temp_free(t1); - tcg_gen_shri_tl(cpu_ca, cpu_ca, 32); /* extract bit 32 */ - tcg_gen_andi_tl(cpu_ca, cpu_ca, 1); + tcg_gen_extract_tl(cpu_ca, cpu_ca, 32, 1); if (is_isa300(ctx)) { tcg_gen_mov_tl(cpu_ca32, cpu_ca); } @@ -5383,8 +5381,7 @@ static void gen_mfsri(DisasContext *ctx) CHK_SV; t0 =3D tcg_temp_new(); gen_addr_reg_index(ctx, t0); - tcg_gen_shri_tl(t0, t0, 28); - tcg_gen_andi_tl(t0, t0, 0xF); + tcg_gen_extract_tl(t0, t0, 28, 0xF); gen_helper_load_sr(cpu_gpr[rd], cpu_env, t0); tcg_temp_free(t0); if (ra !=3D 0 && ra !=3D rd) diff --git a/target/ppc/translate/vsx-impl.inc.c b/target/ppc/translate/vsx= -impl.inc.c index 7f12908029..354a6b113a 100644 --- a/target/ppc/translate/vsx-impl.inc.c +++ b/target/ppc/translate/vsx-impl.inc.c @@ -1262,8 +1262,7 @@ static void gen_xsxexpqp(DisasContext *ctx) gen_exception(ctx, POWERPC_EXCP_VSXU); return; } - tcg_gen_shri_i64(xth, xbh, 48); - tcg_gen_andi_i64(xth, xth, 0x7FFF); + tcg_gen_extract_i64(xth, xbh, 48, 0x7FFF); tcg_gen_movi_i64(xtl, 0); } =20 @@ -1431,10 +1430,8 @@ static void gen_xvxexpsp(DisasContext *ctx) gen_exception(ctx, POWERPC_EXCP_VSXU); return; } - tcg_gen_shri_i64(xth, xbh, 23); - tcg_gen_andi_i64(xth, xth, 0xFF000000FF); - tcg_gen_shri_i64(xtl, xbl, 23); - tcg_gen_andi_i64(xtl, xtl, 0xFF000000FF); + tcg_gen_extract_i64(xth, xbh, 23, 0xFF000000FF); + tcg_gen_extract_i64(xtl, xbl, 23, 0xFF000000FF); } =20 static void gen_xvxexpdp(DisasContext *ctx) @@ -1448,10 +1445,8 @@ static void gen_xvxexpdp(DisasContext *ctx) gen_exception(ctx, POWERPC_EXCP_VSXU); return; } - tcg_gen_shri_i64(xth, xbh, 52); - tcg_gen_andi_i64(xth, xth, 0x7FF); - tcg_gen_shri_i64(xtl, xbl, 52); - tcg_gen_andi_i64(xtl, xtl, 0x7FF); + tcg_gen_extract_i64(xth, xbh, 52, 0x7FF); + tcg_gen_extract_i64(xtl, xbl, 52, 0x7FF); } =20 GEN_VSX_HELPER_2(xvxsigsp, 0x00, 0x04, 0, PPC2_ISA300) @@ -1474,16 +1469,14 @@ static void gen_xvxsigdp(DisasContext *ctx) zr =3D tcg_const_i64(0); nan =3D tcg_const_i64(2047); =20 - tcg_gen_shri_i64(exp, xbh, 52); - tcg_gen_andi_i64(exp, exp, 0x7FF); + tcg_gen_extract_i64(exp, xbh, 52, 0x7FF); tcg_gen_movi_i64(t0, 0x0010000000000000); tcg_gen_movcond_i64(TCG_COND_EQ, t0, exp, zr, zr, t0); tcg_gen_movcond_i64(TCG_COND_EQ, t0, exp, nan, zr, t0); tcg_gen_andi_i64(xth, xbh, 0x000FFFFFFFFFFFFF); tcg_gen_or_i64(xth, xth, t0); =20 - tcg_gen_shri_i64(exp, xbl, 52); - tcg_gen_andi_i64(exp, exp, 0x7FF); + tcg_gen_extract_i64(exp, xbl, 52, 0x7FF); tcg_gen_movi_i64(t0, 0x0010000000000000); tcg_gen_movcond_i64(TCG_COND_EQ, t0, exp, zr, zr, t0); tcg_gen_movcond_i64(TCG_COND_EQ, t0, exp, nan, zr, t0); --=20 2.11.0 From nobody Sun May 5 23:34:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1494447217099459.1311729315195; Wed, 10 May 2017 13:13:37 -0700 (PDT) Received: from localhost ([::1]:44614 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8XzL-0005hj-4B for importer@patchew.org; Wed, 10 May 2017 16:13:35 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33161) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8XsO-0008Jx-MR for qemu-devel@nongnu.org; Wed, 10 May 2017 16:06:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8XsN-0006YT-P3 for qemu-devel@nongnu.org; Wed, 10 May 2017 16:06:24 -0400 Received: from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]:35012) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d8XsN-0006Y6-KW for qemu-devel@nongnu.org; Wed, 10 May 2017 16:06:23 -0400 Received: by mail-qk0-x244.google.com with SMTP id k74so951534qke.2 for ; Wed, 10 May 2017 13:06:23 -0700 (PDT) Received: from localhost.localdomain ([138.117.48.226]) by smtp.gmail.com with ESMTPSA id s190sm377398qkh.57.2017.05.10.13.06.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 May 2017 13:06:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Qu+hEmxyALWiBdTqAfzdXLoGgM85KLXvjmbo8U+978c=; b=TvXPEGxS8fXpP7+S6rDPTvo/LN5IfBRngLdoQyG/96G4S2jRLzo5h11HmGURHTvwqa UsnvioMt+SysBKzkeWPe2MWxh+NwaCLOtTNJoZjYUYwvGyQRQ33tSK/5l6tTyYg5hkgt 07rFFlISxlxGhwoyQWRUnru/aqD/YS6XMVwez9zyC2+sBI8wz0YvD/0CfnsYNEBWfJLt uS6GmPgKos0M/3GZqwuN/O7jACQ1Xy9WWg5d/Nh9xrgSyNapldgL+6oHEGJHoc8h0kjM YZYzmdrJ6XVEIOFfKZY5JLIvDKrxAtx9JPckbOOH9vU5eIhpJCi8kml/CPeC6856yTbD Nx1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=Qu+hEmxyALWiBdTqAfzdXLoGgM85KLXvjmbo8U+978c=; b=XuacSWfGiqZxeznGs+doODa1yVgCGccK/8LVwe25cJVRDgG4LhIJ3mEH460m299awg zAJXLuX0AmPLtiZNI3kxUY9MMXJBDwzp4igd4jwukqIGzfM9TeBdnVz93Cs8qqVSFqgq XgZnuc8gwAkWZqaZevMQP7ArXEF8SWLIdwu7Snlw2gA5g1z+d+GXwUEhCdg6w7nMfsSf qNTkZ+J3kvMtzoV8NWuZ1UpqJYlmEXPstC8HYHRqd7n3RCp3QUxaCaq0NFliWP+CCIFy HzjK98p3FOZprBtjlciPPebcithLCO8hkx8FyPPrDg/2XPB7frx5hqbTiACRpCn+LKbK XzZQ== X-Gm-Message-State: AODbwcDVFpoLSXSnrMcaknjtRURXJzBUSYQlgJMbC0anHBRrhq1SI5Q7 aI2uSa28GPR2LA== X-Received: by 10.55.40.158 with SMTP id o30mr7621142qko.210.1494446783216; Wed, 10 May 2017 13:06:23 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Aurelien Jarno , Richard Henderson , Mark Cave-Ayland , Artyom Tarasenko Date: Wed, 10 May 2017 17:05:35 -0300 Message-Id: <20170510200535.13268-9-f4bug@amsat.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170510200535.13268-1-f4bug@amsat.org> References: <20170510200535.13268-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::244 Subject: [Qemu-devel] [PATCH 8/8] target/sparc: optimize various functions using extract op X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Applied using Coccinelle script. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/sparc/translate.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/target/sparc/translate.c b/target/sparc/translate.c index aa6734d54e..a92b5c425c 100644 --- a/target/sparc/translate.c +++ b/target/sparc/translate.c @@ -380,29 +380,25 @@ static inline void gen_goto_tb(DisasContext *s, int t= b_num, static inline void gen_mov_reg_N(TCGv reg, TCGv_i32 src) { tcg_gen_extu_i32_tl(reg, src); - tcg_gen_shri_tl(reg, reg, PSR_NEG_SHIFT); - tcg_gen_andi_tl(reg, reg, 0x1); + tcg_gen_extract_tl(reg, reg, PSR_NEG_SHIFT, 0x1); } =20 static inline void gen_mov_reg_Z(TCGv reg, TCGv_i32 src) { tcg_gen_extu_i32_tl(reg, src); - tcg_gen_shri_tl(reg, reg, PSR_ZERO_SHIFT); - tcg_gen_andi_tl(reg, reg, 0x1); + tcg_gen_extract_tl(reg, reg, PSR_ZERO_SHIFT, 0x1); } =20 static inline void gen_mov_reg_V(TCGv reg, TCGv_i32 src) { tcg_gen_extu_i32_tl(reg, src); - tcg_gen_shri_tl(reg, reg, PSR_OVF_SHIFT); - tcg_gen_andi_tl(reg, reg, 0x1); + tcg_gen_extract_tl(reg, reg, PSR_OVF_SHIFT, 0x1); } =20 static inline void gen_mov_reg_C(TCGv reg, TCGv_i32 src) { tcg_gen_extu_i32_tl(reg, src); - tcg_gen_shri_tl(reg, reg, PSR_CARRY_SHIFT); - tcg_gen_andi_tl(reg, reg, 0x1); + tcg_gen_extract_tl(reg, reg, PSR_CARRY_SHIFT, 0x1); } =20 static inline void gen_op_add_cc(TCGv dst, TCGv src1, TCGv src2) @@ -638,8 +634,7 @@ static inline void gen_op_mulscc(TCGv dst, TCGv src1, T= CGv src2) // env->y =3D (b2 << 31) | (env->y >> 1); tcg_gen_andi_tl(r_temp, cpu_cc_src, 0x1); tcg_gen_shli_tl(r_temp, r_temp, 31); - tcg_gen_shri_tl(t0, cpu_y, 1); - tcg_gen_andi_tl(t0, t0, 0x7fffffff); + tcg_gen_extract_tl(t0, cpu_y, 1, 0x7fffffff); tcg_gen_or_tl(t0, t0, r_temp); tcg_gen_andi_tl(cpu_y, t0, 0xffffffff); =20 --=20 2.11.0