[Qemu-devel] [PATCH 0/9] hw/display: make display updates thread safe, part 1

Gerd Hoffmann posted 9 patches 6 years, 11 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170421091632.30900-1-kraxel@redhat.com
Test checkpatch passed
Test docker passed
Test s390x passed
include/exec/memory.h        | 47 +++++++++++++++++++++++++++
include/exec/ram_addr.h      |  7 +++++
include/qemu/bitmap.h        |  2 ++
include/qemu/typedefs.h      |  1 +
exec.c                       | 75 ++++++++++++++++++++++++++++++++++++++++++++
hw/display/exynos4210_fimd.c | 11 ++++---
hw/display/framebuffer.c     | 11 +++----
hw/display/g364fb.c          | 28 +++--------------
hw/display/sm501.c           | 23 ++++----------
hw/display/vga.c             | 50 ++++++++++++++++-------------
hw/display/vmware_vga.c      | 21 ++-----------
memory.c                     | 17 ++++++++++
util/bitmap.c                | 11 +++++++
13 files changed, 213 insertions(+), 91 deletions(-)
[Qemu-devel] [PATCH 0/9] hw/display: make display updates thread safe, part 1
Posted by Gerd Hoffmann 6 years, 11 months ago
  Hi,

Ok, 2.10 is open, lets start tackling the display update race
conditions.  This series adds the helper functions used to receive
a dirty bitmap snapshot, which is used by the display adapters then.
Also a bunch of display adapters are converted to use those helpers.

Changes from previous version:  Fixed one vga patch.  Left out are the
sparc adapters for now (Mark Cave-Ayland is busy cleaning them up and
fixing them).  Also left out the patch dropping the temporary
workaround, that obviously has to wait until all display adapters are
switched over.

please review,
  Gerd

Gerd Hoffmann (9):
  bitmap: add bitmap_copy_and_clear_atomic
  memory: add support getting and using a dirty bitmap copy.
  vga: add vga_scanline_invalidated helper
  vga: make display updates thread safe.
  framebuffer: make display updates thread safe
  exynos: make display updates thread safe
  g364fb: make display updates thread safe
  vmsvga: fix vmsvga_update_display
  sm501: make display updates thread safe

 include/exec/memory.h        | 47 +++++++++++++++++++++++++++
 include/exec/ram_addr.h      |  7 +++++
 include/qemu/bitmap.h        |  2 ++
 include/qemu/typedefs.h      |  1 +
 exec.c                       | 75 ++++++++++++++++++++++++++++++++++++++++++++
 hw/display/exynos4210_fimd.c | 11 ++++---
 hw/display/framebuffer.c     | 11 +++----
 hw/display/g364fb.c          | 28 +++--------------
 hw/display/sm501.c           | 23 ++++----------
 hw/display/vga.c             | 50 ++++++++++++++++-------------
 hw/display/vmware_vga.c      | 21 ++-----------
 memory.c                     | 17 ++++++++++
 util/bitmap.c                | 11 +++++++
 13 files changed, 213 insertions(+), 91 deletions(-)

-- 
2.9.3


Re: [Qemu-devel] [PATCH 0/9] hw/display: make display updates thread safe, part 1
Posted by Mark Cave-Ayland 6 years, 11 months ago
On 21/04/17 10:16, Gerd Hoffmann wrote:

>   Hi,
> 
> Ok, 2.10 is open, lets start tackling the display update race
> conditions.  This series adds the helper functions used to receive
> a dirty bitmap snapshot, which is used by the display adapters then.
> Also a bunch of display adapters are converted to use those helpers.
> 
> Changes from previous version:  Fixed one vga patch.  Left out are the
> sparc adapters for now (Mark Cave-Ayland is busy cleaning them up and
> fixing them).  Also left out the patch dropping the temporary
> workaround, that obviously has to wait until all display adapters are
> switched over.

FWIW I'm going to send a pull request for the SPARC adapter cleanups
later today as I'll be AFK for the next week and don't want to hold you up.

I've also rebased my TCX/CG3 "make display updates thread-safe" patches
onto my v2 cleanup patchset and pushed to result to
https://github.com/mcayland/qemu/tree/vga-fixes-sparc so that in my
absence you can cherry-pick the cg3/tcx conversion patches into your
series while I'm away.


ATB,

Mark.