qga-win: Fix Event Viewer errors caused by qemu-ga

[Qemu-devel] [PATCH v2] qga-win: Fix Event Viewer errors caused by qemu-ga

Posted by Sameeh Jubran 7 years ago

When the command "guest-fsfreeze-freeze" is executed it causes
the VSS service to log the error below in the Event Viewer. This
error is caused by an issue in the function "CommitSnapshots" in
provider.cpp:

* When VSS_TIMEOUT_MSEC expires the funtion returns E_ABORT. This causes
the error #12293.

|event id|                           error                               |
* 12293  : Volume Shadow Copy Service error: Error calling a routine on a
           Shadow Copy Provider {00000000-0000-0000-0000-000000000000}.
           Routine details CommitSnapshots [hr = 0x80004004, Operation
           aborted.

Signed-off-by: Sameeh Jubran <sameeh@daynix.com>
---
 qga/vss-win32/provider.cpp | 1 -
 1 file changed, 1 deletion(-)

diff --git a/qga/vss-win32/provider.cpp b/qga/vss-win32/provider.cpp
index ef94669..72d8b0e 100644
--- a/qga/vss-win32/provider.cpp
+++ b/qga/vss-win32/provider.cpp
@@ -377,7 +377,6 @@ STDMETHODIMP CQGAVssProvider::CommitSnapshots(VSS_ID SnapshotSetId)
     if (WaitForSingleObject(hEventThaw, VSS_TIMEOUT_MSEC) != WAIT_OBJECT_0) {
         /* Send event to qemu-ga to notify the provider is timed out */
         SetEvent(hEventTimeout);
-        hr = E_ABORT;
     }
 
     CloseHandle(hEventThaw);
-- 
2.9.3

Re: [Qemu-devel] [PATCH v2] qga-win: Fix Event Viewer errors caused by qemu-ga

Posted by Michael Roth 7 years ago

Quoting Sameeh Jubran (2017-04-05 07:01:06)
> When the command "guest-fsfreeze-freeze" is executed it causes
> the VSS service to log the error below in the Event Viewer. This
> error is caused by an issue in the function "CommitSnapshots" in
> provider.cpp:
> 
> * When VSS_TIMEOUT_MSEC expires the funtion returns E_ABORT. This causes
> the error #12293.
> 
> |event id|                           error                               |
> * 12293  : Volume Shadow Copy Service error: Error calling a routine on a
>            Shadow Copy Provider {00000000-0000-0000-0000-000000000000}.
>            Routine details CommitSnapshots [hr = 0x80004004, Operation
>            aborted.
> 
> Signed-off-by: Sameeh Jubran <sameeh@daynix.com>

Thanks, applied to qga tree:                                                                              

  https://github.com/mdroth/qemu/commits/qga

> ---
>  qga/vss-win32/provider.cpp | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/qga/vss-win32/provider.cpp b/qga/vss-win32/provider.cpp
> index ef94669..72d8b0e 100644
> --- a/qga/vss-win32/provider.cpp
> +++ b/qga/vss-win32/provider.cpp
> @@ -377,7 +377,6 @@ STDMETHODIMP CQGAVssProvider::CommitSnapshots(VSS_ID SnapshotSetId)
>      if (WaitForSingleObject(hEventThaw, VSS_TIMEOUT_MSEC) != WAIT_OBJECT_0) {
>          /* Send event to qemu-ga to notify the provider is timed out */
>          SetEvent(hEventTimeout);
> -        hr = E_ABORT;
>      }
> 
>      CloseHandle(hEventThaw);
> -- 
> 2.9.3
>