From nobody Thu May 2 04:30:40 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1491380027606378.0715105754442; Wed, 5 Apr 2017 01:13:47 -0700 (PDT) Received: from localhost ([::1]:39245 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cvg4X-0003hd-F5 for importer@patchew.org; Wed, 05 Apr 2017 04:13:45 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46710) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cvg3Q-0003Aa-2q for qemu-devel@nongnu.org; Wed, 05 Apr 2017 04:12:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cvg3M-0006vU-TL for qemu-devel@nongnu.org; Wed, 05 Apr 2017 04:12:36 -0400 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:33506) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cvg3M-0006ug-Mt for qemu-devel@nongnu.org; Wed, 05 Apr 2017 04:12:32 -0400 Received: by mail-wm0-x243.google.com with SMTP id o81so1297250wmb.0 for ; Wed, 05 Apr 2017 01:12:32 -0700 (PDT) Received: from donizetti.lan (94-39-149-222.adsl-ull.clienti.tiscali.it. [94.39.149.222]) by smtp.gmail.com with ESMTPSA id u189sm11483864wmg.18.2017.04.05.01.12.29 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Apr 2017 01:12:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id; bh=foGp3BOWd2FN/qY2wRamZWrSoQ7sqi8a6LStt/Q25Bw=; b=PG2rmAZOPpbEHlxomcKcJpWBRSDzF4kLj0Ug9kh4oQ8WfnEy2FhN/my5vUBc6I5eTL K9PVMJOUX+UW2rXDXKc4MMZLy/rMMo4Pryj9kKunDjW86/f/E5qgofPhy3RK4C1oUvfg q6HTR4m+8/KBknNH3O9Kdt5GY3Jp+3g7+RSETaFTzDhdGmpzzAIOgnLi/Tf9se+wg/jj 3NVtseAgLYmMPJEscCeuD1RzzSZxPubfwrD1OGNy4vhRaqWGqKjqUFfF8qRAvJBhecoi J0Mz6DYAnHW2R0JQzASlM1OwyuHMw6INWqZWiBPr+WzaU5lIN5YmiX3BGKHKqUjOyHff UZMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id; bh=foGp3BOWd2FN/qY2wRamZWrSoQ7sqi8a6LStt/Q25Bw=; b=rYv5JCHvTl2g0WVqNhPCooIRQm92TctKDlGHu+ZEAo+gjU//2zr/UEkVzD9mPOVFPv /9F+lAe8wUpNCAVSxFdqnPRwj2U4+a/0YwG258Y/tekFJHdspD/EXffO428hr7yn2FbT fy8wCj59MRZl9ehk5/WDeHW+iku0cWvYrAE7J5nRPbj3q2UPP5NDMDlz6sh09ODW33y8 z0YrkbHkk/XigCR3aYT3B75ySuXGeNoV11sxshZTLvEOmqUxY+/kWXg0VlIXbatUL2Kh Q3TiGeo7GLM+TZdGVLUXKZsy7j6oMymJJp7T1O/ce+HoeHdDSS1EDgnJPJb9vUnO9DFc l8vg== X-Gm-Message-State: AFeK/H3cZOXtWqxH4DqNU9ShDIbSC5LB7fQOmuygdvDRPn8eOThyaT3y gr89EikeBVGizZsZomQ= X-Received: by 10.28.30.197 with SMTP id e188mr16786647wme.99.1491379951114; Wed, 05 Apr 2017 01:12:31 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Wed, 5 Apr 2017 10:12:09 +0200 Message-Id: <20170405081209.26814-1-pbonzini@redhat.com> X-Mailer: git-send-email 2.9.3 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::243 Subject: [Qemu-devel] [PATCH for-2.9] tco: do not generate an NMI X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This behavior is not indicated in the datasheet and can confuse the OS. Signed-off-by: Paolo Bonzini Reviewed-by: Laszlo Ersek --- hw/acpi/tco.c | 2 -- hw/isa/lpc_ich9.c | 5 ----- include/hw/i386/ich9.h | 1 - 3 files changed, 8 deletions(-) diff --git a/hw/acpi/tco.c b/hw/acpi/tco.c index b4adac8..05b9d7b 100644 --- a/hw/acpi/tco.c +++ b/hw/acpi/tco.c @@ -75,8 +75,6 @@ static void tco_timer_expired(void *opaque) =20 if (pm->smi_en & ICH9_PMIO_SMI_EN_TCO_EN) { ich9_generate_smi(); - } else { - ich9_generate_nmi(); } tr->tco.rld =3D tr->tco.tmr; tco_timer_reload(tr); diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c index 59930dd..a0866c3 100644 --- a/hw/isa/lpc_ich9.c +++ b/hw/isa/lpc_ich9.c @@ -312,11 +312,6 @@ void ich9_generate_smi(void) cpu_interrupt(first_cpu, CPU_INTERRUPT_SMI); } =20 -void ich9_generate_nmi(void) -{ - cpu_interrupt(first_cpu, CPU_INTERRUPT_NMI); -} - static int ich9_lpc_sci_irq(ICH9LPCState *lpc) { switch (lpc->d.config[ICH9_LPC_ACPI_CTRL] & diff --git a/include/hw/i386/ich9.h b/include/hw/i386/ich9.h index 18dcca7..673d13d 100644 --- a/include/hw/i386/ich9.h +++ b/include/hw/i386/ich9.h @@ -21,7 +21,6 @@ void ich9_lpc_pm_init(PCIDevice *pci_lpc, bool smm_enable= d); I2CBus *ich9_smb_init(PCIBus *bus, int devfn, uint32_t smb_io_base); =20 void ich9_generate_smi(void); -void ich9_generate_nmi(void); =20 #define ICH9_CC_SIZE (16 * 1024) /* 16KB. Chipset configuration registers = */ =20 --=20 2.9.3