From nobody Sun May 5 03:35:12 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1491205054192382.6797382621795; Mon, 3 Apr 2017 00:37:34 -0700 (PDT) Received: from localhost ([::1]:57911 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cuwYO-0000uT-Qk for importer@patchew.org; Mon, 03 Apr 2017 03:37:32 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37880) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cuwXh-0000YQ-Gg for qemu-devel@nongnu.org; Mon, 03 Apr 2017 03:36:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cuwXe-0004Ss-Aq for qemu-devel@nongnu.org; Mon, 03 Apr 2017 03:36:49 -0400 Received: from mail-pg0-x241.google.com ([2607:f8b0:400e:c05::241]:33112) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cuwXe-0004Pm-3G for qemu-devel@nongnu.org; Mon, 03 Apr 2017 03:36:46 -0400 Received: by mail-pg0-x241.google.com with SMTP id 79so28061891pgf.0 for ; Mon, 03 Apr 2017 00:36:44 -0700 (PDT) Received: from localhost.localdomain.com ([117.224.108.74]) by smtp.gmail.com with ESMTPSA id f81sm23867943pfe.61.2017.04.03.00.36.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Apr 2017 00:36:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=jKEP06foiR3KamyqVTpsqSIM3Ph2DtREFMC0QbeaXsE=; b=mjPptpHaN7ee1isvCDRox97POrIZIeNWKV4R0sWMUZuvSw7kJaf5t6vBx19tAat9aP sy35bKn9s6crF6wfO8KPUyjmuItpPsDRxuJbrwuXAigjJFnyzkDeiV8lsUQfmMYDQO4o B6wnplCksUP6bvW6eW/Z7g/1hbTF30R1LDdm1KZbZSZbsDuJDdkzePpX5NZcAgtclS+s aGNhQ133pQgxFWFKEwEbTFVn3q+G+E/svfeGbV/hRklewdwki+SH7pZEYFG63obIG8D3 hhcE6Qc0GiMCEAM5KWH3cEIxev+5Ifd5OjDr/+aikA8MKxUphOnLXs1WNi3qMgA69G65 F+ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=jKEP06foiR3KamyqVTpsqSIM3Ph2DtREFMC0QbeaXsE=; b=Qvt4UbpzcX5A2vf5TLlfDeY/DGzNAjPXFWEkVxOe6r9yzDgpaQWyIPslNrqOMVGBLl bK0rb1MKjZqc9JJKdKweFbct1Q1A1lVVvHKmnIde0JG6LWBTwFBYUVwh6lIIL8i/HxIV pavZ+7W6rTQ9tW+CBlKwmmQc0Z9si/HEkemNiYeElQC7y8JkXlELGagUQbxnIB+9jpXU JSv8P2o4y0xhBRxVbG69q01brfnDCpyaVLk2xNKKBKaVciOOEvKl12aYATE8S+i+d9xn O350McHTxUY0QeeHEudeIIBFj7iapo0YD2Pvfmr46x8zAR15Vf1TDGhlin4ZP1QzCTEh sUTA== X-Gm-Message-State: AFeK/H3Ig68htlh/lQADUxUCZNwlBvi7xXBCuxXihygDDX6kYR8g1NoM9e2lenvzDOg9Lg== X-Received: by 10.84.212.8 with SMTP id d8mr19904552pli.152.1491205003583; Mon, 03 Apr 2017 00:36:43 -0700 (PDT) From: Suramya Shah To: qemu-devel@nongnu.org Date: Mon, 3 Apr 2017 13:05:50 +0530 Message-Id: <20170403073550.29162-1-shah.suramya@gmail.com> X-Mailer: git-send-email 2.9.3 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c05::241 Subject: [Qemu-devel] [PATCH] hw/net: convert "dma" property type from ptr to link X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Suramya Shah Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The lance device needs pointer to ISA DMA device to operate. But according = to qdev-properties.h, properties of pointer type should be avoided. A link type property is a good substitution. Signed-off-by: Suramya Shah --- hw/net/lance.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/net/lance.c b/hw/net/lance.c index 573d724..3996b9c 100644 --- a/hw/net/lance.c +++ b/hw/net/lance.c @@ -44,6 +44,7 @@ #include "pcnet.h" #include "trace.h" #include "sysemu/sysemu.h" +#include "qapi/error.h" =20 #define TYPE_LANCE "lance" #define SYSBUS_PCNET(obj) \ @@ -145,10 +146,14 @@ static void lance_instance_init(Object *obj) device_add_bootindex_property(obj, &s->conf.bootindex, "bootindex", "/ethernet-phy@0", DEVICE(obj), NULL); + + object_property_add_link(obj, "dma", TYPE_LANCE, + (Object **)&d->state.dma_opaque, + qdev_prop_allow_set_link_before_realize, + 0, &error_abort); } =20 static Property lance_properties[] =3D { - DEFINE_PROP_PTR("dma", SysBusPCNetState, state.dma_opaque), DEFINE_NIC_PROPERTIES(SysBusPCNetState, state.conf), DEFINE_PROP_END_OF_LIST(), }; @@ -164,7 +169,6 @@ static void lance_class_init(ObjectClass *klass, void *= data) dc->reset =3D lance_reset; dc->vmsd =3D &vmstate_lance; dc->props =3D lance_properties; - /* Reason: pointer property "dma" */ dc->cannot_instantiate_with_device_add_yet =3D true; } =20 --=20 2.9.3